aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google
Commit message (Collapse)AuthorAge
* Include memleaks plugin support for experimental_ios_testGravatar Chris Parsons2015-10-21
| | | | | -- MOS_MIGRATED_REVID=105876178
* Improve documentation for resolve_commandGravatar Francois-Rene Rideau2015-10-21
| | | | | -- MOS_MIGRATED_REVID=105875176
* Check invalid empty dict attributesGravatar Francois-Rene Rideau2015-10-21
| | | | | | | | In checkAttrValNonEmpty, also check dict values for emptiness when the attribute was declared non-empty. -- MOS_MIGRATED_REVID=105871620
* Add support for Windows zip permissionsGravatar Kristina Chodorow2015-10-20
| | | | | | | | | Fixes #518. RELNOTES: Add support for Windows-created zip files with non-posix permissions. -- MOS_MIGRATED_REVID=105865785
* Unify Skylark and BUILD listsGravatar Francois-Rene Rideau2015-10-20
| | | | | | | | Use SkylarkList everywhere rather than either List or GlobList. Keep a GlobList underneath a MutableList, where applicable. -- MOS_MIGRATED_REVID=105864035
* Add netrc support to GitCloneFunction.Gravatar Erik Gilling2015-10-20
| | | | | | | -- Change-Id: Ib82d20394b85433d7b0aae4a71f07ec1af068fa0 Reviewed-on: https://bazel-review.googlesource.com/#/c/2140/ MOS_MIGRATED_REVID=105856861
* Add %crosstool_top% metasyntax for builtin cxx include directories.Gravatar Googler2015-10-20
| | | | | | | | | | | | Instead of two metasyntactic variables and one random bit of magic which changes relative paths to be children of crosstool, we now have three consistent pieces of metasyntax; except that since we can't actually remove the old syntax, we have either way for the time being. RELNOTES[NEW]: accept %crosstool_top% in cxx_builtin_include_directory -- MOS_MIGRATED_REVID=105854779
* Make 'blaze query --output=build' 25 times faster.Gravatar Laurent Le Brun2015-10-20
| | | | | -- MOS_MIGRATED_REVID=105854596
* Improve error diagnostics for Skylark aspects.Gravatar Dmitry Lomov2015-10-20
| | | | | -- MOS_MIGRATED_REVID=105851371
* Implement aspect(...) Skylark function.Gravatar Dmitry Lomov2015-10-20
| | | | | -- MOS_MIGRATED_REVID=105844221
* Move most of BlazeRuntime.beforeCommand() to CommandEnvironment.Gravatar Ulf Adams2015-10-20
| | | | | -- MOS_MIGRATED_REVID=105841866
* Move the outputService field to the CommandEnvironment.Gravatar Ulf Adams2015-10-20
| | | | | -- MOS_MIGRATED_REVID=105841398
* Move commandStartTime from BlazeRuntime to CommandEnvironment.Gravatar Ulf Adams2015-10-20
| | | | | -- MOS_MIGRATED_REVID=105840775
* Move workingDirectory to CommandEnvironment.Gravatar Ulf Adams2015-10-20
| | | | | | | Preparation for running multiple commands in parallel. -- MOS_MIGRATED_REVID=105840167
* Reduce memory churn when expanding many nested sets: Use compact hashset for ↵Gravatar Eric Fellheimer2015-10-20
| | | | | | | | | hte uniqueifer and size them smaller when we're under the memoization threshold. A heap dump (with retained garbage) showed many of these sets sitting around, most at under 60% fill ratio. -- MOS_MIGRATED_REVID=105818028
* Rollback of commit ac7195025b073948785db8c6975a53fc305c5087.Gravatar Peter Schmitt2015-10-20
| | | | | | | | | | | | | *** Reason for rollback *** Uses tests that don't run on Bazel *** Original change description *** Implement aspect(...) Skylark function. -- MOS_MIGRATED_REVID=105808850
* Make the incompatibility between dynamic configurationsGravatar Greg Estren2015-10-20
| | | | | | | | | and --nodistinct_host_configuration explicit. This particularly helps triaging the Bazel tests when --experimental_dynamic_configs is on. -- MOS_MIGRATED_REVID=105801590
* Allow relative CxxBuiltinDirectories not just under crosstool or sysroot.Gravatar Googler2015-10-20
| | | | | | | | | | cxx_builtin_include directories which start with "%workspace%/" are taken to be relative to the build workspace, and not relative to crosstool-top. RELNOTES[NEW]: cpxx_builtin_include_directory specifications allow more flexibility. -- MOS_MIGRATED_REVID=105789270
* Also forward the exported_plugins of the rules in the deps of anGravatar Alex Humesky2015-10-20
| | | | | | | | | | | android_library rule when the android_library is being used as a forwarding rule (i.e., has no sources). RELNOTES: When used as a forwarding rule (i.e., has no sources), android_library will also forward any exported_plugins in its dependencies. -- MOS_MIGRATED_REVID=105787789
* Don't log SchedulerExceptions.Gravatar Nathan Harmata2015-10-20
| | | | | | | RELNOTES: None -- MOS_MIGRATED_REVID=105787681
* Use a sorted set for the test suite expansion key to prevent non-determinism.Gravatar Ulf Adams2015-10-20
| | | | | | | | | | | | | | | | | While a normal set is theoretically sufficient, it can cause hard-to-reproduce problems. In particular, the iteration order of the expansion result depends on the iteration order of the requested targets. If there are multiple requests for the same set of targets, but with different orders, the results would depend on which request was made first. If a downstream function also inadvertantly depends on the iteration order, it can be hard to debug why it ended up with a different order than it requested. Alternatively, we could sort the result before returning it. We generally expect the key set to be smaller than the result set, so this should be ever so slightly more efficient. -- MOS_MIGRATED_REVID=105765514
* Automated [] rollback of [].Gravatar Eric Fellheimer2015-10-20
| | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks many android targets in the depot. *** Original change description *** Trying again with checking for the presence of the "resources" attribute. Change the resource dependency handling to separate between the transitive and direct resources from libraries. This slightly increases the complexity of resource propagation. The initial algorithm was to simply merge all transitive ResourceContainers together with any new ResourceContainer and propagate them via the AndroidResourcesProvider. The new algorithm is encapsulated inside a new ResourceDependencies class which... *** ROLLBACK_OF=105631635 -- MOS_MIGRATED_REVID=105752015
* Quick workaround for #473 that reenables hdrs_check in Bazel to unblock the ↵Gravatar Philipp Wollermann2015-10-19
| | | | | | | | | | | | | | | release. Note the following peculiarities of the current situation: - Sandboxed execution still silently falls back to non-sandboxed execution due to LocalGccStrategy explicitly requesting local execution. - However, builds are still correct due to local execution using hdrs_check. - hdrs_check, even though it was intended to default to "strict" in Bazel from the start, is still set to "loose" by default, so you might accidentally be using non-declared header files in your cc_* targets. In this case, your builds will break when the default becomes hdrs_check=strict and sandboxing becomes available. It is recommended that you check whether your builds are affected, by specifying --hdrs_check=strict manually and fixing your BUILD files to explicitly list all used includes in the srcs / hdrs attributes of your cc_* targets. These remaining issues will be fixed in an upcoming change. This change also adds regression tests for the issue. -- MOS_MIGRATED_REVID=105747212
* Fix two uses of generics that are causing errors in Eclipse for me.Gravatar Ulf Adams2015-10-19
| | | | | -- MOS_MIGRATED_REVID=105742091
* Implement the test suite expansion after target pattern evaluation.Gravatar Ulf Adams2015-10-19
| | | | | | | | This is still not hooked up, but it's now passing all the relevant tests that apply directly to the LoadingPhaseRunner; there are still a couple of TODOs. -- MOS_MIGRATED_REVID=105739507
* Make bazel not require a tools/defaults/BUILD file.Gravatar Lukacs Berki2015-10-19
| | | | | -- MOS_MIGRATED_REVID=105734972
* Avoid some Skyframe restarts.Gravatar Nathan Harmata2015-10-19
| | | | | -- MOS_MIGRATED_REVID=105648425
* Trying again with checking for the presence of the "resources" attribute.Gravatar Googler2015-10-19
| | | | | | | | | | | | | | | Change the resource dependency handling to separate between the transitive and direct resources from libraries. This slightly increases the complexity of resource propagation. The initial algorithm was to simply merge all transitive ResourceContainers together with any new ResourceContainer and propagate them via the AndroidResourcesProvider. The new algorithm is encapsulated inside a new ResourceDependencies class which works as follows: 1. Collect resources from the deps into transitive and direct NestedSets 2. If a rule provides a ResourceContainer, merge the transitive and direct into a new transitive set 3. Export the provider This results having a rule without resources "forward" the merged sets of transitive and direct resources to the next rule. -- MOS_MIGRATED_REVID=105631635
* Change the way sources are gathered for ASwB aspect.Gravatar Googler2015-10-19
| | | | | | | | | | | | | | | This fixes android_resources being dropped on the ground because the source jar isn't included. Previously, the java compilation args were used. This includes a bunch of implicit and generated source, like idl sources. The source jars include output from resource processing the rule itself, so it wasn't possible to start including that. What we want are all explicit sources only. This CL does that. -- MOS_MIGRATED_REVID=105624870
* Expose link flags to SkylarkGravatar Googler2015-10-19
| | | | | -- MOS_MIGRATED_REVID=105624527
* Brief audit of singleton SkyValuesGravatar Michajlo Matijkiw2015-10-19
| | | | | | | Minimize indirection wrt singletons, turns out we had one that was completely unused. -- MOS_MIGRATED_REVID=105621494
* Add text output format to Android IDE aspect.Gravatar Googler2015-10-19
| | | | | | | For debugging. Simply serializes the proto to a text file. -- MOS_MIGRATED_REVID=105621279
* []Rollback of commit 65425810207c9fd6892abfaa95da65e25db5e515.Gravatar Googler2015-10-16
| | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks []. *** Original change description *** Change the resource dependency handling to separate between the transitive and direct resources from libraries. This slightly increases the complexity of resource propagation. The initial algorithm was to simply merge all transitive ResourceContainers together with any new ResourceContainer and propagate them via the AndroidResourcesProvider. The new algorithm is encapsulated inside a new ResourceDependencies class which works as follows: 1. Collect resources from the deps into transitive and... *** -- MOS_MIGRATED_REVID=105598448
* Implement aspect(...) Skylark function.Gravatar Dmitry Lomov2015-10-16
| | | | | -- MOS_MIGRATED_REVID=105596479
* Fix reporting of error messages for EnvironmentalExecExceptionGravatar Googler2015-10-16
| | | | | | | | | | | | | Most (all?) messages for this exception are complete description of the failure (e.g. "failed to do X", "could not do X"). With the previous wording the user got something like: ERROR: [...] Writing file for rule '[...]' failedfailed to create file '[...]' Now: ERROR: [...] Writing file for rule '[...]' failed (failed to create file '[...]') -- MOS_MIGRATED_REVID=105591532
* Minor improvements to set documentation.Gravatar Laurent Le Brun2015-10-16
| | | | | -- MOS_MIGRATED_REVID=105591091
* Fixed wrong error message when using class definitions in Skylark / BUILD files.Gravatar Florian Weikert2015-10-16
| | | | | -- MOS_MIGRATED_REVID=105585492
* When loading a Skylark list or tuple, preserve the type in the BUILD file.Gravatar Laurent Le Brun2015-10-16
| | | | | -- MOS_MIGRATED_REVID=105552023
* Move to using "well-known" SkyFunctionNames in tests exercising graphGravatar Michajlo Matijkiw2015-10-16
| | | | | -- MOS_MIGRATED_REVID=105539869
* Stop filtering when returning root causes -- the filter is always true, ↵Gravatar Janak Ramakrishnan2015-10-16
| | | | | | | | | since root causes are associated with top-level targets and labels, and the filter is for all top-level targets and labels. I noticed this when a huge --noanalyze build spent most of its time in filtering here. The passed-in "collection" was a list, which meant that we could have sped it up by using a set, but why not just get rid of it all. -- MOS_MIGRATED_REVID=105536485
* Cache BUILD file AST parsing results instead of preprocessing results (the ↵Gravatar Nathan Harmata2015-10-16
| | | | | | | | | former uses the latter). This way we parse BUILD files exactly once. This is part of a series of changes with the net result being that we open, read, and parse each BUILD file exactly once. -- MOS_MIGRATED_REVID=105528075
* Change the resource dependency handling to separate between the transitive ↵Gravatar Googler2015-10-16
| | | | | | | | | | | | | | | and direct resources from libraries. This slightly increases the complexity of resource propagation. The initial algorithm was to simply merge all transitive ResourceContainers together with any new ResourceContainer and propagate them via the AndroidResourcesProvider. The new algorithm is encapsulated inside a new ResourceDependencies class which works as follows: 1. Collect resources from the deps into transitive and direct NestedSets 2. If a rule provides a ResourceContainer, merge the transitive and direct into a new transitive set 3. Export the provider This results having a rule without resources "forward" the merged sets of transitive and direct resources to the next rule. -- MOS_MIGRATED_REVID=105515074
* RELNOTES: Allow dots in package names.Gravatar Han-Wen Nienhuys2015-10-16
| | | | | -- MOS_MIGRATED_REVID=105512492
* Roll back [] that makes Bazel not require a tools/defaults/BUILD file ↵Gravatar Lukacs Berki2015-10-16
| | | | | | | because it breaks some internal tests. -- MOS_MIGRATED_REVID=105511798
* Separate BUILD file for options and docgen.Gravatar Han-Wen Nienhuys2015-10-16
| | | | | -- MOS_MIGRATED_REVID=105511114
* New feature: Bazel prints a warning for unknown --config flag values.Gravatar Laszlo Csomor2015-10-15
| | | | | -- MOS_MIGRATED_REVID=105499267
* Skylark: Add lstrip and rstrip functions.Gravatar Laurent Le Brun2015-10-15
| | | | | -- MOS_MIGRATED_REVID=105498175
* Make recursive package wildcards work in remote repositories.Gravatar Lukacs Berki2015-10-15
| | | | | | | Ideally, PrepareDepsOfPatternFunction and maybe even RecursivePkgFunction would also be changed to take a PackageIdentifier instead of RootedPath because the less places we store the set of roots, the better, but I've done enough refactoring in the past weeks to not be thrilled by the idea of doing more. -- MOS_MIGRATED_REVID=105486561
* Introduce --override_workspace_root blaze flag to hand-set workspace_root ↵Gravatar Googler2015-10-15
| | | | | | | | | and mainGroup in xcodeproj. RELNOTES: Adds --override_workspace_root blaze flag to hand-set workspace_root and mainGroup in xcodeproj. -- MOS_MIGRATED_REVID=105484952
* Remove command_helper, use resolve_command insteadGravatar Francois-Rene Rideau2015-10-15
| | | | | | | Eliminate side-effect in command_line_srcs and hide the internal class. -- MOS_MIGRATED_REVID=105480701