| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Bazel client will pass the
--host_jvm_args=-Dbazel.windows_unix_root=<path>
flag to the server (computed from $BAZEL_SH), and
the server will no longer shell out to cygpath to
compute this value.
Fixes https://github.com/bazelbuild/bazel/issues/2983
Change-Id: Iacc2e2eb70eacafdf7bbcad68d375ba9eadc6ee1
PiperOrigin-RevId: 158830675
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also add an interface to allow injecting that logic into LocalSpawnRunner; this
is in preparation for rewriting StandaloneSpawnStrategy to use
LocalSpawnRunner.
At the same time, this reduces the dependencies from exec / standalone to
rules.apple, which is a prerequisite for micro-Bazel.
There's a small semantic change hidden here - we now only set the new
XCodeLocalEnvProvider if we're actually running on Darwin, so we no longer
fail execution on non-Darwin platforms if XCODE_VERSION_OVERRIDE or
APPLE_SDK_VERSION_OVERRIDE is set. As a result, I moved the corresponding test
from StandaloneSpawnStrategyTest to the new XCodeLocalEnvProviderTest.
While I'm at it, also open source DottedVersionTest and CacheManagerTest.
PiperOrigin-RevId: 158829077
|
|
|
|
|
|
|
|
|
|
|
| |
Also add tests for the CAS path converter. I've also changed the code to
explicitly inject the RemoteOptions into the CasPathConverter - note that
the class is now static, so it no longer has access to the fields in the
RemoteModule class.
This change will need to be cherry-picked into 0.5.2.
PiperOrigin-RevId: 158816408
|
|
|
|
|
|
|
| |
Added public visibility to some constructors/accessors, and made child LValue nodes explicitly constructed by the caller rather than hidden inside constructors. This makes it easier to treat nodes as uniform dumb values. Also added some helpers.
RELNOTES: None
PiperOrigin-RevId: 158761415
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rolling forward with the generated resources directory being created for tests without resources.
*** Original change description ***
Automated g4 rollback of commit d028d7854d3e95d97143945a1ec32944e5e4594b.
*** Reason for rollback ***
Breaks 1000+ targets in the depot: []
*** Original change description ***
Generate pre-reconciled ids R classes for dependency libraries with resources
in the transitive closure of robolectric tests.
RELNOTES: None
PiperOrigin-RevId: 158756991
|
|
|
|
|
|
|
|
| |
of labels.
Also fix an indent error in BuildTool.
PiperOrigin-RevId: 158747039
|
|
|
|
|
|
| |
RELNOTES: none
TESTED=presubmit
PiperOrigin-RevId: 158734467
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks the classroom_ios TAP project [1] in the presence of --experimental_objc_crosstool=all, which was added to the global .blazerc last week.
[1] []
*** Original change description ***
Change ProtobufSupport to use CrosstoolCompilationSupport if experimental_objc_crosstool=all
PiperOrigin-RevId: 158727100
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 158721043
|
|
|
|
|
|
|
|
|
|
| |
So far only link actions were initialized in CppLinkActionConfigs. This cl
changes this class to also initialize CppCompile actions. This is needed for
our ongoing work removing hard-coded flags from Bazel and moving them into
Crosstool.
RELNOTES: None.
PiperOrigin-RevId: 158715986
|
|
|
|
|
|
|
|
|
| |
Call sites were creating a ValidationEnvironment object with no other purpose
than calling validateAst(). Simplify the code so that callers don't have to
worry about it.
RELNOTES: None.
PiperOrigin-RevId: 158705853
|
|
|
|
|
| |
RELNOTES: NONE.
PiperOrigin-RevId: 158703123
|
|
|
|
|
|
|
| |
The call sites in QueryEnvironment implementations were not needed because QueryEnvironments are always made afresh.
RELNOTES: None.
PiperOrigin-RevId: 158698881
|
|
|
|
|
| |
RELNOTES: none.
PiperOrigin-RevId: 158694769
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes https://github.com/bazelbuild/bazel/issues/1586
Fixes https://github.com/bazelbuild/bazel/issues/2326
This change also undoes https://github.com/bazelbuild/bazel/commit/956810b6ee24289e457a4b8d0a84ff56eb32c264 -- since
Bazel now closes its stdout/stderr before
cleaning, jvm.out is also closed so we don't need
to open it with deletion sharing.
RELNOTES: Windows: bazel clean --expunge works
Change-Id: I692f2e86a5983cb472a142a093611fd1c694cd3b
PiperOrigin-RevId: 158682987
|
|
|
|
| |
PiperOrigin-RevId: 158584197
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The experimental UI uses a thread to regularly update itself to reflect time-based
changes. As that that thread has to call synchronized methods any waiting for it to
finish has to happen outside any synchronized block. Unfortunately, 9e0308e0f7 accidentally
moved the stopUpdateThread() in buildComplete() into the synchronized block, thus giving
an opportunity for deadlocks. Move it out again.
Also, as the accounting for pending transports now happens in synchronized methods in
the state tracker, the buildEventTransportClosed() method does not have to be synchronized
any more---thus eliminating the second deadlock opportunity.
Change-Id: Icacb2ee70f4bedde1c1aac2bcfefc6fabf42fdd3
PiperOrigin-RevId: 158537844
|
|
|
|
|
|
| |
HIDDEN.
PiperOrigin-RevId: 158524495
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was originally included in runtime due to external dependencies, and
a desire to keep the options parser a general options library. These
dependencies have been or will be removed, and there are plenty of other
general flag libraries.
InvocationPolicy is fundamentally acting on the properties of this
specific OptionsParser and needs proper access to it for the proper
solution to a number of existing bugs, which means having access to
things that should be package private.
PiperOrigin-RevId: 158523111
|
|
|
|
|
| |
Change-Id: I8e445d3f3b06846a2f1d8db25c98aa5cd124f72b
PiperOrigin-RevId: 158516752
|
|
|
|
|
|
|
| |
Fixes #2904.
RELNOTES: None.
PiperOrigin-RevId: 158516169
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also use DigestUtils for performance, which has a static cache of the digests.
This isn't ideal, but necessary for now to avoid computing the digests multiple
times. We'll need to clean this up afterwards by including the digests in the
posted events, and making them available to the PathConverter. I have some
changes towards that (as well as some submitted already), but it requires
quite some refactoring.
RELNOTES: Bazel posts links to the CAS to the BEP if remote caching / execution is enabled
PiperOrigin-RevId: 158513165
|
|
|
|
|
|
| |
We don't want people to get used to this.
PiperOrigin-RevId: 158508816
|
|
|
|
| |
PiperOrigin-RevId: 158503746
|
|
|
|
|
|
|
|
|
| |
--experimental_extra_action_top_level_only_with_aspects command line option.
It was introduced in November 2016 as an escape hatch, and has not been used in the last two months so it's safe to remove.
RELNOTES: None.
PiperOrigin-RevId: 158502426
|
|
|
|
|
|
|
|
| |
The base names are not necessarily unique enough to identify which
artifact is being talked about.
Change-Id: Ic8ff78c8f26f98e0e9a2d558d03f4cf9ae9111c8
PiperOrigin-RevId: 158499210
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 158498863
|
|
|
|
|
|
|
|
|
| |
https://docs.google.com/document/d/1AaGk7fOPByEvpAbqeXIyE8HX_A3_axxNnvroblTZ_6s/edit
Also refactored away the various *Interface* files, no need since unit testing can be done with mocking the appropriate gRPC Impl classes directly (see tests). This also fixes the RemoteSpawnRunner, which should use different objects for remote caching and remote execution, the same way RemoteSpawnStrategy does.
RELNOTES: n/a
PiperOrigin-RevId: 158473700
|
|
|
|
| |
PiperOrigin-RevId: 158473075
|
|
|
|
|
|
|
| |
This change moves the BES code from blaze to bazel.
RELNOTES: None.
PiperOrigin-RevId: 158445754
|
|
|
|
| |
PiperOrigin-RevId: 158428641
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Automated g4 rollback of commit 23004957a56d304106d5dbf0d6ea52ec10713b39).
*** Reason for rollback ***
The problems that forced commit 23004957a56d304106d5dbf0d6ea52ec10713b39 were fixed in commit e6392cd380fce14d719890c78d5eb2657e8a6cfc.
*** Original change description ***
Automated g4 rollback of commit e7ab452ac940e645046221dee9b63a670f8a276c.
*** Reason for rollback ***
Some of the work supporting this is being rolled back due to uncaught crash bugs.
*** Original change description ***
Enable dynamic configurations for all builds.
PiperOrigin-RevId: 158420321
|
|
|
|
|
|
|
|
| |
Instead of passing a client env into the test strategies, use the same
mechansim as --action_env, by depending on the right set of Skyframe nodes that
correspond to client env entries.
PiperOrigin-RevId: 158401670
|
|
|
|
|
| |
RELNOTES: ctx.expand_make_variables is deprecated.
PiperOrigin-RevId: 158396106
|
|
|
|
|
|
|
| |
This creates a new class BlazeWorkspaceTest, and removes the initCommand method
from BlazeRuntime.
PiperOrigin-RevId: 158396032
|
|
|
|
|
|
| |
Closes #3030.
PiperOrigin-RevId: 158387165
|
|
|
|
|
|
|
|
|
| |
- Only manually check the timeout if the process wrapper is not used
- Set the timeout correctly; the process API uses milliseconds
- flush the error output stream after writing
- return SIGALRM as exit code for timeout cases
PiperOrigin-RevId: 158374246
|
|
|
|
|
|
|
|
| |
to store Java compilation artifacts. Round-tripping through
JavaCompilationArgs loses dependency information that upstream
compilations use to optimize compile time classpaths.
PiperOrigin-RevId: 158360995
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support disabling javac fallback for actions without a direct
classpath, and only use the 'JavacTurbine' mnemonic for spawns
that require javac-turbine due to annotation processing to make
it easier to collect metrics on that.
Finally, remove --java_header_compilation_direct_classpath now
that it has been productionized and enabled by default.
PiperOrigin-RevId: 158359858
|
|
|
|
|
|
|
| |
Fixes #3122.
RELNOTES: bazel query --output package now displays packages from external repository with the format "@reponame//package". Packages in the main repository continue to have the format "package".
PiperOrigin-RevId: 158327492
|
|
|
|
|
|
|
| |
configurable. Add a test for the current behavior of treating an unreadable BUILD file as a package loading error.
RELNOTES: None
PiperOrigin-RevId: 158314187
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
py_test cannot find it's data file at runtime. The reason is it's
running in a wrong directory.
The test directory is set to runfiles directory by test-setup.sh, but on
Windows, python binary unzip itself to another temp directory which
test-setup.sh doesn't know.
So let the python stub template switch to the correct runfiles directory
if RUN_UNDER_RUNFILES = 1
Fixed https://github.com/bazelbuild/bazel/issues/3134
Change-Id: If5dbee811330372d86484ebd871ea55d84bc29a8
PiperOrigin-RevId: 158299041
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't flush when buffer is a prefix of SHOW_INCLUDES_PREFIX or
sourceFileName
eg. Since we are looking for a line starting with "Note: including file:",
when buffer equals "Note: i", when should not flush the buffer,
but wait until the whole line is read or we are sure they won't match.
Also, we need to reset the buffer after write to out.
Added test for ShowIncludesFilter.java
Change-Id: I58ebd0bfd5a3e2c9973c8bd910e2e5b85a545c21
PiperOrigin-RevId: 158297616
|
|
|
|
|
|
|
|
|
| |
This requirement was added to PatchTransition in commit e6392cd380fce14d719890c78d5eb2657e8a6cfc.
This also adds tests for ConfigFeatureFlagTransitionFactory's other
behaviors.
RELNOTES: None.
PiperOrigin-RevId: 158294134
|
|
|
|
|
|
| |
RELNOTES: ios_device and ios_test are deprecated. Please use the new testing
rules in https://github.com/bazelbuild/rules_apple instead.
PiperOrigin-RevId: 158290414
|
|
|
|
|
|
|
| |
indicative of the probable cause of the error.
RELNOTES: None.
PiperOrigin-RevId: 158286091
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 158279811
|
|
|
|
|
|
|
|
|
|
| |
if statements.
RELNOTES:
In .bzl files, top-level `if` statements are deprecated and will be forbidden
in the future. Move them in a function body instead (or use a conditional
expression instead: `x if condition else y`).
PiperOrigin-RevId: 158276986
|
|
|
|
|
|
|
| |
options.
Change-Id: If623f2416f8bff7c74ddf99d5c957a075de6494f
PiperOrigin-RevId: 158275892
|
| |
|