| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
--
MOS_MIGRATED_REVID=136152771
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The only visible difference for users is that a few more functions are
available in BUILD files. That's fine, this difference was not even
documented.
RELNOTES:
A few functions are added to BUILD files for consistency (hash, dir,
hasattr, getattr) with .bzl files, although they are not very useful.
--
MOS_MIGRATED_REVID=136151633
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In genrules, cmd strings of the form "$(location :label) ..."
are used with the assumption that the executable named by the
label will be called. This holds true as long as $(location :label)
expands to a string that is recognizable as a path, i.e., as long
as :label does not refer to a file in the top-level directory. In the
latter case, however, that string will be the plain file name and the
shell will search for that name in the search path. This will fail, if
'.' is not in the search path; even worse, if a file with that name
is in the search path before '.', then that one will be called which
is not what the user intended to do. Fix this unintended behavior by
expanding $(location :label) to a string that unambiguously is a path.
--
Change-Id: If8681039a8befae6234fbe0cbe3a0f75eedba7aa
Reviewed-on: https://bazel-review.googlesource.com/#/c/6691
MOS_MIGRATED_REVID=136151500
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Android split transition removes the --cpu (as intended), but then the
resulting split configurations are identical across the --cpu values set by
--experimental_multi_cpu, which triggers a sanity check in BuildConfiguration.
For now, I'm disabling the sanity check in this case, although that's not
ideal. The rewrite to dynamic configurations fixes this, as it is then fine
to end up at an identical configuration.
Fixes #1400.
--
Change-Id: I466edaf3e1e1d9e9cc353e3937e6675f75c870fc
Reviewed-on: https://bazel-review.googlesource.com/#/c/6618/
MOS_MIGRATED_REVID=136146249
|
|
|
|
|
|
|
| |
There doesn't seem to be any reason to keep them separate.
--
MOS_MIGRATED_REVID=136145734
|
|
|
|
|
|
|
| |
Instead, deduplicate when the helper is actually added to a GroupedList.
--
MOS_MIGRATED_REVID=136145321
|
|
|
|
|
|
|
| |
This includes applying desugaring for mobile-install's stub apk.
--
MOS_MIGRATED_REVID=136111631
|
|
|
|
|
|
|
| |
rule.
--
MOS_MIGRATED_REVID=136099460
|
|
|
|
|
|
|
|
|
|
|
| |
This supports genrules that output srcjars that
are then inputs to java_libraries.
Also add support to produce a source jar with
the contents of the gen jar.
--
MOS_MIGRATED_REVID=136099457
|
|
|
|
|
|
|
| |
Also moves AAR-specific tools from tools/zip into tools/android and renames embedded_jar_extractor to aar_embedded_jars_extractor because in a future change it will extract classes.jar and libs/*.jar.
--
MOS_MIGRATED_REVID=136099324
|
|
|
|
|
|
|
| |
PopulateTreeArtifactAction is going away.
--
MOS_MIGRATED_REVID=136093999
|
|
|
|
|
|
|
| |
annotation processing support.
--
MOS_MIGRATED_REVID=136084697
|
|
|
|
|
|
|
|
|
| |
Fixes #1469.
--
Change-Id: I3ffc18208ba346e03658ebeb4d2bb5938113a476
Reviewed-on: https://bazel-review.googlesource.com/6615
MOS_MIGRATED_REVID=136073702
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Causes our integration tests on Darwin to time out
*** Original change description ***
Make --watchfs a common command option.
Adding an options parameter to DiffAwareness#getCurrentView seems like the
simplest way to achieve that.
Alternatives considered:
1. Making the diff awareness modules stateful. However, I did not want to do so
as I've also been working on improving the module API to reduce state, or at
least to have a proper lifecycle management for any necessary state.
2. Making the watchFs flag a constructor parameter. However, that would also
invalidate any implement...
***
--
MOS_MIGRATED_REVID=136070807
|
|
|
|
|
|
|
|
|
|
|
| |
-Make FileType and ExternalFileAction public.
-Have producers use ExternalFileAction, rather than a boolean, to specify the desired behavior.
And a big change in semantics (doesn't affect Bazel):
-Replace ExternalFileAction.ERROR_OUT with ExternalFileAction.ASSUME_NON_EXISTENT_AND_IMMUTABLE, which does what it sounds like. This new action, like the old ERROR_OUT, is _not_ used in Bazel.
--
MOS_MIGRATED_REVID=136063159
|
|
|
|
|
|
|
| |
We don't actually need a map.
--
MOS_MIGRATED_REVID=136040005
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding an options parameter to DiffAwareness#getCurrentView seems like the
simplest way to achieve that.
Alternatives considered:
1. Making the diff awareness modules stateful. However, I did not want to do so
as I've also been working on improving the module API to reduce state, or at
least to have a proper lifecycle management for any necessary state.
2. Making the watchFs flag a constructor parameter. However, that would also
invalidate any implementations that don't use the flag (of which we have
several).
3. Only passing in a single boolean flag instead of an options class provider;
however, this is a more principled, futureproof API, which allows other
modules / awareness implementations to use their own options.
RELNOTES: --watchfs is now a command option; the startup option of the same
name is deprecated. I.e., use bazel build --watchfs, not blaze --watchfs
build.
--
MOS_MIGRATED_REVID=136026835
|
|
|
|
|
|
|
|
|
|
| |
Use StringLiteral instead of String+Location. This improves consistency.
getRawImports() now returns StringLiterals, which makes possible to show
location in error messages.
--
MOS_MIGRATED_REVID=136019586
|
|
|
|
|
|
|
| |
RELNOTES: Darwin sandboxing is default.
--
MOS_MIGRATED_REVID=136013826
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=136011723
|
|
|
|
|
|
|
|
|
| |
symlinks.
This bug caused rare NotASymlinkException exceptions when using sandboxed workers.
--
MOS_MIGRATED_REVID=136010526
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=135956016
|
|
|
|
|
|
|
| |
which cross into a sub-repository. Part of #1592.
--
MOS_MIGRATED_REVID=135931868
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks android_integration_test, see https://github.com/bazelbuild/bazel/issues/1927
*** Original change description ***
Generate aar_import and java_import rules for local maven repositories in <sdk>/extras for sdk in android_sdk_repository.
Addresses https://github.com/bazelbuild/bazel/issues/1745.
--
MOS_MIGRATED_REVID=135926334
|
|
|
|
|
|
|
|
| |
It was a temporary workaround due to client Skylark code that was sensitive to
type(). That code has been fixed.
--
MOS_MIGRATED_REVID=135920620
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Make darwin sandboxing default again.
*** Original change description ***
Fix #1849: Sandboxing on OS X should be turned off by default for 0.3.2.
This restructures the way we set the default Spawn strategy so that each BlazeModule supplying a SpawnActionContext has an ActionContextConsumer that sets its own SpawnActionContext as the default, with the BazelRulesModule being put as the last module loaded in BazelMain, so that it can override that decision - it only does, if the user explicitly specifies a --spawn_strategy flag. IMHO this is a much saner approach than...
***
ROLLBACK_OF=134770427
RELNOTES: Darwin sandboxing is default.
--
MOS_MIGRATED_REVID=135905657
|
|
|
|
|
|
|
| |
we should collect coverage, not only when the rule says so.
--
MOS_MIGRATED_REVID=135896208
|
|
|
|
|
|
|
|
|
|
|
| |
packages/targets in parallel with subdirectories.
The previous implementation was vulnerable to incomplete traversal in case of cycles: if a subdirectory had a cycle, the targets in the package would never be requested. Requesting the package first would create a different problem, where the subdirectories would never be requested if the package depended on a cycle.
Also stop uniquifying Skylark import cycles when inlining. While uniquification is nice, this was leading to us emitting an error during queries that we weren't actually emitting when not inlining. Putting the cycle into the exception error message should be enough information, and since we emit an error per exception anyway, the number of events will still be lower (although each event might be more verbose).
--
MOS_MIGRATED_REVID=135846847
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Fixed depended-on broken CL
*** Original change description ***
Automated [] rollback of commit f341bc4f6e918b6a41c1536c111bbf24f14f967b.
*** Reason for rollback ***
Depends on c/135226123 which depends on commit 9c25afe750a937b2152c21a93effc8b9ba82c27b, which needs to be rolled
back.
*** Original change description ***
Add ctx.get_actions(), for inspecting the actions created by the current rule.
This returns an ActionsProvider. In the case where the rule does not emit any
more actions afterwards, the provider is equivalent to the one that gets passed
on to the rule's dependencies.
This may be u...
***
ROLLBACK_OF=135781162
--
MOS_MIGRATED_REVID=135833495
|
|
|
|
|
|
|
|
|
|
|
| |
This is at this point mostly an exercise in refactoring, as this initial
implementation of apple_dynamic_library mirrors apple_binary exactly,
except for the output extension and the -dynamiclib linker arg. There
will be additional followup to deal with significant differences
between these two rules.
--
MOS_MIGRATED_REVID=135822476
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Fixed underlying broken CL that was depended on
*** Original change description ***
Automated [] rollback of commit e025939e71b179ae0f6bd09ef3af474f49b853a2.
*** Reason for rollback ***
Depends on commit 9c25afe750a937b2152c21a93effc8b9ba82c27b, which needs to be rolled back.
*** Original change description ***
Add API for individual actions
This exposes action inputs, outputs, argv, content, and substitutions (if applicable).
--
MOS_MIGRATED_REVID=135821603
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=135816762
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=135816105
|
|
|
|
|
|
|
|
|
| |
classes
This is needed to let subclasses of @SkylarkModules have the same type() string as their superclass, without requiring a second annotation for the subclass.
--
MOS_MIGRATED_REVID=135814343
|
|
|
|
|
|
|
| |
input pruning.
--
MOS_MIGRATED_REVID=135807490
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=135805730
|
|
|
|
|
|
|
|
|
| |
This cl moves the conditional building of interface libraries from LinkCommandLine to action configs and features. It provides link_dynamic_library.sh to keep blaze backwards compatible. The script and related code can be deleted once all crosstools are updated.
RELNOTES: No.
--
MOS_MIGRATED_REVID=135799041
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Seems to break some parts of aspects.
*** Original change description ***
Make EvalUtils.getDataTypeNameFromClass() look for @SkylarkModules in parent classes
This is needed to let subclasses of @SkylarkModules have the same type() string as their superclass, without requiring a second annotation for the subclass (which would lead to redundant documentation being generated).
--
MOS_MIGRATED_REVID=135786137
|
|
|
|
|
|
|
|
| |
- Load prelude_bazel as a .bzl file (to simplify code paths)
- Remove a function in BuildFileAST that was used only in tests
--
MOS_MIGRATED_REVID=135785708
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=135784854
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Depends on commit 9c25afe750a937b2152c21a93effc8b9ba82c27b, which needs to be rolled back.
*** Original change description ***
Add API for individual actions
This exposes action inputs, outputs, argv, content, and substitutions (if applicable).
--
MOS_MIGRATED_REVID=135783964
|
|
|
|
|
|
|
| |
The previous solution added too many unneeded runfiles, which caused problems with our workers.
--
MOS_MIGRATED_REVID=135782773
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Depends on c/135226123 which depends on commit 9c25afe750a937b2152c21a93effc8b9ba82c27b, which needs to be rolled
back.
*** Original change description ***
Add ctx.get_actions(), for inspecting the actions created by the current rule.
This returns an ActionsProvider. In the case where the rule does not emit any
more actions afterwards, the provider is equivalent to the one that gets passed
on to the rule's dependencies.
This may be useful for unit testing analysis-time helper functions that take
in ctx and have the side-effect of creating actions. In this use case, the
testing rule should be marked _skylark_testable=True, and its implementation
f...
***
--
MOS_MIGRATED_REVID=135781162
|
|
|
|
|
|
|
|
|
|
|
| |
We have added support for Linux s390x platform in Bazel.
Closes #1891.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/1891
MOS_MIGRATED_REVID=135777047
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=135768834
|
|
|
|
|
|
|
| |
to load must have failed because of an exception, which is false in the case of cycles;
--
MOS_MIGRATED_REVID=135742248
|
|
|
|
|
|
|
| |
loaded by a single package. This also fixes a bug in which Skylark code expecting reference equality for an object imported multiple ways were not getting it.
--
MOS_MIGRATED_REVID=135738789
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=135724830
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=135689610
|
|
|
|
|
|
|
| |
into batches. This way nodes corresponding to targets in the same package are likely to be in the same batch.
--
MOS_MIGRATED_REVID=135684088
|