aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google
Commit message (Collapse)AuthorAge
* Also report the spawn from the remote strategyGravatar Ulf Adams2017-03-10
| | | | | | | | | | It's silly that we require every spawn strategy to do this individually, and the new spawn scheduler will fix this. However, it's useful to add this for debugging. -- PiperOrigin-RevId: 149743992 MOS_MIGRATED_REVID=149743992
* Add the appropriate cxx_builtin_include_directory entries for clang to the ↵Gravatar Adam Michael2017-03-10
| | | | | | | | | | | | | | | | | | | | Android NDK crosstool created by android_ndk_repository. Also, stop setting -isystem for the builtin include directories in the clang toolchains. Previously, we were incorrectly setting cxx_builtin_include_directory for clang toolchains to the gcc include directories. We were also setting -isystem on these directories, so when an Android build attempted to include an NDK header (like arm_neon.h), clang got gcc's version of that header. A followup change will stop setting -isystem for gcc. Fixes https://github.com/bazelbuild/bazel/issues/2601. Note that I intentionally did not attempt to fix the bug for NDK10. NDK10 is very old, defaults to GCC and contains two separate clang/LLVMs. As such, it would be more complicated to get right and test properly. Also adds an integration test that attempts to compile an NDK header with clang. This change does not entirely fix Tensorflow's Android sample app build with NDK13 (the motivation for https://github.com/bazelbuild/bazel/issues/2601), however I believe that the remaining fixes are on Tensorflow's side. E.g. setting -Wno-c++11-narrowing in copts. -- PiperOrigin-RevId: 149719100 MOS_MIGRATED_REVID=149719100
* Adds linkmaps to the AppleDebugOutputsProvider for them to be consumed by ↵Gravatar Sergio Campama2017-03-10
| | | | | | | | dependents. -- PiperOrigin-RevId: 149702529 MOS_MIGRATED_REVID=149702529
* Document the descriptor set output of proto_library.Gravatar Carmi Grushko2017-03-10
| | | | | | -- PiperOrigin-RevId: 149659956 MOS_MIGRATED_REVID=149659956
* Add documentation for java_common.Gravatar Irina Iancu2017-03-10
| | | | | | -- PiperOrigin-RevId: 149657329 MOS_MIGRATED_REVID=149657329
* Abstract from DownloadProgressEvent to generic FetchProgress Gravatar Klaus Aehlig2017-03-10
| | | | | | | | | | | In this way, we can easily add other fetch-like events to be reported in a similar way as plain downloads. -- Change-Id: I518df5ba27b6593eca98d30407b582f509a52aeb Reviewed-on: https://cr.bazel.build/9313 PiperOrigin-RevId: 149655918 MOS_MIGRATED_REVID=149655918
* Global cleanup change.Gravatar Googler2017-03-09
| | | | | | -- PiperOrigin-RevId: 149652245 MOS_MIGRATED_REVID=149652245
* Prevent users from using the WorkerTestStrategy unless they're running with ↵Gravatar Kush Chakraborty2017-03-09
| | | | | | | | the ExperimentalTestRunner. -- PiperOrigin-RevId: 149636903 MOS_MIGRATED_REVID=149636903
* Make InMemoryFileSystem case-insensitive on Windows. Gravatar Dmitry Lomov2017-03-09
| | | | | | | | | | This fixes PackagePathLocatorTest. -- Change-Id: I3d14a80993f6b256acfc732adf2d97b1d2dcb804 Reviewed-on: https://cr.bazel.build/9310 PiperOrigin-RevId: 149634730 MOS_MIGRATED_REVID=149634730
* Description redacted.Gravatar Nathan Harmata2017-03-09
| | | | | | -- PiperOrigin-RevId: 149585165 MOS_MIGRATED_REVID=149585165
* Merging remote_cache and remote_worker into a single binary. Gravatar Ola Rozenfeld2017-03-09
| | | | | | | | | | | | | | | It can still be used as only a cache server, or only a worker with a wrapper of Hazelcast, so no functionality is lost, but it is now simpler to use in local testing / prototyping. Changed README files appropriately. TESTED=locally -- Change-Id: I3fdff9d434ce8cae5a6a700df0cb9f5bc364b60c Reviewed-on: https://cr.bazel.build/9253 PiperOrigin-RevId: 149569790 MOS_MIGRATED_REVID=149569790
* Set -> ImmutableSet in Platform.javaGravatar Cal Peyser2017-03-09
| | | | | | -- PiperOrigin-RevId: 149567942 MOS_MIGRATED_REVID=149567942
* Closing missing quote in htmlGravatar Laurent Le Brun2017-03-09
| | | | | | -- PiperOrigin-RevId: 149560999 MOS_MIGRATED_REVID=149560999
* Add support for 'macos' platform_type in apple binary. This type is only ↵Gravatar Cal Peyser2017-03-09
| | | | | | | | supported for crosstool builds - there is no support in LegacyCompilationSupport. -- PiperOrigin-RevId: 149558653 MOS_MIGRATED_REVID=149558653
* BEP: provide timing information for tests Gravatar Klaus Aehlig2017-03-09
| | | | | | | | | | For tests, also provide information on the time the test took. -- Change-Id: I8e71391e4dd97627d6293159a0cbb0d922683af7 Reviewed-on: https://cr.bazel.build/9214 PiperOrigin-RevId: 149547633 MOS_MIGRATED_REVID=149547633
* Bring back the persistent test runner functionality, on ExperimentalTestRunner.Gravatar Kush Chakraborty2017-03-09
| | | | | | | | This is essentially a rollforward of commit 7d0561b6ca92d72bd8767d4dca50e5437976812c, and changes triggering the perisitent runner using an environment variable instead of argument as suggested in commit 7d0561b6ca92d72bd8767d4dca50e5437976812c -- PiperOrigin-RevId: 149540564 MOS_MIGRATED_REVID=149540564
* Create ExperimentalTestRunner which is just the same as BazelTestRunner, but ↵Gravatar Kush Chakraborty2017-03-09
| | | | | | | | | | a testbed of upcoming changes, without breaking existing test targets. To use the alternate test runner a java test should add the tag "experimental_testrunner" and depend on "@bazel_tools//tools/jdk:ExperimentalTestRunner_deploy.jar" (instead of @bazel_tools//tools/jdk:TestRunner_deploy.jar) -- PiperOrigin-RevId: 149536298 MOS_MIGRATED_REVID=149536298
* Make Bazel build with MSVC-default-toolchain Bazel Gravatar Yun Peng2017-03-08
| | | | | | | | | | | | | After this change, a msys bazel can be built with a MSVC-default Bazel by adding --cpu=x64_windows_msys --host=x64_windows_msys See https://github.com/bazelbuild/bazel/issues/2627 -- Change-Id: Iaa82bf4dd911c5740b98d3b2739dfccca6203f79 Reviewed-on: https://cr.bazel.build/9293 PiperOrigin-RevId: 149532274 MOS_MIGRATED_REVID=149532274
* Make sure that the external version of skylark-overview.html is being ↵Gravatar Florian Weikert2017-03-08
| | | | | | | | displayed properly. -- PiperOrigin-RevId: 149528271 MOS_MIGRATED_REVID=149528271
* Introduce strip_debug_symbols feature to crosstoolGravatar Marcel Hlopko2017-03-08
| | | | | | | | | This cl removes hard coded -Wl,-S flag from Blaze and moves it to the crosstool. -- PiperOrigin-RevId: 149525225 MOS_MIGRATED_REVID=149525225
* Do not create symlink pointing at itself with ↵Gravatar Marcel Hlopko2017-03-08
| | | | | | | | | | | | | | | strip_include_prefix/include_prefix This cl fixes a bug when strip_include_prefix and include_prefix are used in such a way that the resulting virtual header is be accessible from the same path as the original header and bazel would attempt to create symlink pointing at itself. Fixes #2635 -- PiperOrigin-RevId: 149524480 MOS_MIGRATED_REVID=149524480
* Add a source_jars variable to OutputJar.Gravatar Irina Iancu2017-03-08
| | | | | | | | | | | Having a correlation between an output jar and a source jar is not enough. There may be situations when an output jar is generated from more source jars, not just one. We need this flexibility especially in Skylark for the java sandwich, when the user can compile multiple source jars. -- PiperOrigin-RevId: 149510534 MOS_MIGRATED_REVID=149510534
* Apply the apple crosstool transition to j2objc_library.Gravatar Cal Peyser2017-03-08
| | | | | | -- PiperOrigin-RevId: 149460936 MOS_MIGRATED_REVID=149460936
* Apple-specific environment variables are derived from the CROSSTOOL insteadGravatar Cal Peyser2017-03-08
| | | | | | | | | of hardcoded in AppleCcToolchain. Also, apply environment variables to objc archives. -- PiperOrigin-RevId: 149439637 MOS_MIGRATED_REVID=149439637
* Support composed dependency transitions with dynamic configs.Gravatar Greg Estren2017-03-08
| | | | | | -- PiperOrigin-RevId: 149439502 MOS_MIGRATED_REVID=149439502
* Env.vars: server won't ignore the client envGravatar Dmitry Lomov2017-03-08
| | | | | | | | | | | | | | | | | | Make the --ignore_client_env flag a no-op. The client will pass --client_env flags to the server even in --batch mode. This simplifies the code as well as ensuring that the server always uses the up-do-date client environment. We'll gradually get rid of all System.getenv calls in the server, because the server should always respect the client env. Roll forward of 149403129 with fixes. -- PiperOrigin-RevId: 149435060 MOS_MIGRATED_REVID=149435060
* Fix bug with streaming bounded deps/allrdeps/rdeps.Gravatar Nathan Harmata2017-03-08
| | | | | | -- PiperOrigin-RevId: 149431500 MOS_MIGRATED_REVID=149431500
* Don't update the action locality for actions with a null ownerGravatar Ulf Adams2017-03-07
| | | | | | -- PiperOrigin-RevId: 149418372 MOS_MIGRATED_REVID=149418372
* Rollback of commit 94d8f4e9c8c8757aa7ab7c1a7c3e9afb34039127.Gravatar Klaus Aehlig2017-03-07
| | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** broke //src/test/shell/bazel:bazel_bootstrap_distfile_test *** Original change description *** Env.vars: server won't ignore the client env Make the --ignore_client_env flag a no-op. The client will pass --client_env flags to the server even in --batch mode. This simplifies the code as well as ensuring that the server always uses the up-do-date client environment. We'll gradually get rid of all System.getenv calls in the server, because the server should always respect the client env. -- PiperOrigin-RevId: 149416602 MOS_MIGRATED_REVID=149416602
* Env.vars: server won't ignore the client envGravatar Laszlo Csomor2017-03-07
| | | | | | | | | | | | | | | | Make the --ignore_client_env flag a no-op. The client will pass --client_env flags to the server even in --batch mode. This simplifies the code as well as ensuring that the server always uses the up-do-date client environment. We'll gradually get rid of all System.getenv calls in the server, because the server should always respect the client env. -- PiperOrigin-RevId: 149403129 MOS_MIGRATED_REVID=149403129
* StandaloneTestStrategy sets the full list of outputs on the test spawnGravatar Ulf Adams2017-03-07
| | | | | | | | | | | | | | | | | | | All spawn strategies already treat all normal outputs as optional. Bazel checks at the action level whether all action outputs are created, but does not check at the spawn level. Spawn.getOptionalOutputs is therefore unnecessary, and removed in this change. The only place where this was set was in StandaloneTestStrategy, which now specifies the full set of outputs, which is now computed by TestRunnerAction. The internal test strategy implementations are also updated in this change. While I'm at it, also remove the use of BaseSpawn and use SimpleSpawn instead. This may go some way towards fixing #1413 and #942. -- PiperOrigin-RevId: 149397100 MOS_MIGRATED_REVID=149397100
* Fix NPE in Android{S,N}dkRepositoryFunction.Gravatar Adam Michael2017-03-07
| | | | | | | | | | | | | | | If neither the path attribute or the $ANDROID_HOME/$ANDROID_NDK_HOME environment variable is set, we should report a helpful error message. A previous change switched the lookup for the environment variable from the client environment map to the skyframe environment map. However in the skyframe action environment map, environment variables that are requested but not set in the environment have null values. Followup to change needed for #2621. -- PiperOrigin-RevId: 149369076 MOS_MIGRATED_REVID=149369076
* Correctly returns null if an environment variables is missing Gravatar Damien Martin-Guillerez2017-03-07
| | | | | | | | | | | | | | | | The hard part is to test this one as we haven't even been able to reproduce. Maybe we should just fuzz Skyframe function for null values. Fixes #2621. To cherry-pick for 0.4.5 (#2472) -- Change-Id: Ida489fb8dbd659b42a8d2bebff58d49ffeaf72c3 Reviewed-on: https://cr.bazel.build/9213 PiperOrigin-RevId: 149316508 MOS_MIGRATED_REVID=149316508
* Fix typo in comment.Gravatar Lukacs Berki2017-03-07
| | | | | | -- PiperOrigin-RevId: 149305466 MOS_MIGRATED_REVID=149305466
* Flag to import external repositories in python import path Gravatar Damien Martin-Guillerez2017-03-06
| | | | | | | | | | | | | | | This flag will be used to turn off the feature until we get support for --incompatible flag. This flag is going to go away very fast, do not rely on it too much. To be cherry-picked for 0.4.5 (#2472) -- Change-Id: I2d3c79ae0c2c53089677573cffd40fa07e03c7e1 Reviewed-on: https://cr.bazel.build/9210 PiperOrigin-RevId: 149291628 MOS_MIGRATED_REVID=149291628
* Add support for --flagfile=flagfile.txt args in addition to the usual ↵Gravatar Philipp Wollermann2017-03-06
| | | | | | | | | | @flagfile.txt style. Let the worker strategy correctly handle multiple flagfiles, instead of just assuming that the last argument will be the one and only @flagfile. -- PiperOrigin-RevId: 149291230 MOS_MIGRATED_REVID=149291230
* Skylark Documentation: Add a one-page overview of all Skylark modules and ↵Gravatar Florian Weikert2017-03-06
| | | | | | | | globals. -- PiperOrigin-RevId: 149286951 MOS_MIGRATED_REVID=149286951
* provider.transitive_runtime_jars returns a SkylarkNestedSet instead of a ↵Gravatar Irina Iancu2017-03-06
| | | | | | | | SkylarkList. -- PiperOrigin-RevId: 149286753 MOS_MIGRATED_REVID=149286753
* Drop CppLinkActionContextGravatar Ulf Adams2017-03-06
| | | | | | | | | | Merge the functionality into CppLinkAction, which now simply creates and runs a Spawn. Set PWD to /proc/self/cwd for Linux, and set execution info if the action needs to run on MacOS. -- PiperOrigin-RevId: 149285420 MOS_MIGRATED_REVID=149285420
* Convey the value of the --host_javabase startup option to the server.Gravatar Lukacs Berki2017-03-06
| | | | | | -- PiperOrigin-RevId: 149282686 MOS_MIGRATED_REVID=149282686
* Rewrite TestStrategy.getArgsGravatar Ulf Adams2017-03-06
| | | | | | | | | | | | | | | | | | | | | | This changes command-line computation for tests: - run the coverage collector before the run_under command - no shell escaping: if all tools just call "$@", then this should work Note that we still wrap the command in a sub-shell to support shell built-ins and PATH lookup if the command does not contain a slash character '/'. A side effect of this change is that the --run_under command now executes in the test's runfiles directory, rather than in the exec root, if coverage is enabled at the same time. Inside Google, it's very rare for --run_under to be used in combination with coverage, and it seems likely to be rare externally as well, so I don't think it warrants covering it in the release notes. Also set TEST_BINARY to the root-relative path of the test executable for all tests (in TestRunnerAction.java). -- PiperOrigin-RevId: 149275688 MOS_MIGRATED_REVID=149275688
* Add flavour name for java proto compilation.Gravatar Irina Iancu2017-03-06
| | | | | | -- PiperOrigin-RevId: 149274808 MOS_MIGRATED_REVID=149274808
* BEP: Make TestSummary provide the overall status Gravatar Klaus Aehlig2017-03-06
| | | | | | | | | | | | | | | | | Bazel does an involved computation of the overall outcome of a test, taking into considerations multiple attempts to detect flaky tests. To allow a consumer of the BEP to have the same view of the outcome of the test as bazel does, report the overall status of a test in the TestSummary event. Note: as proto-to-proto dependencies are not yet available, we have to provide the status by duplicating the status enum. -- Change-Id: I413ce7b72c54ff3cbfe0733219ba0881ad5d064e Reviewed-on: https://cr.bazel.build/9129 PiperOrigin-RevId: 149268441 MOS_MIGRATED_REVID=149268441
* Allow declared providers in attribute and aspect defintions.Gravatar Dmitry Lomov2017-03-06
| | | | | | -- PiperOrigin-RevId: 149169656 MOS_MIGRATED_REVID=149169656
* Support declared providers in AdvertisedProviderSet.Gravatar Dmitry Lomov2017-03-06
| | | | | | -- PiperOrigin-RevId: 149165836 MOS_MIGRATED_REVID=149165836
* Tighten invariants around dirtiness checking. We should never need to create ↵Gravatar Janak Ramakrishnan2017-03-06
| | | | | | | | a child that's being checked by a parent (that was a legacy of when we delegated to enqueueChild), and such a child that is being checked should always be dirty or done, never fresh. -- PiperOrigin-RevId: 149136909 MOS_MIGRATED_REVID=149136909
* Pass the bootclasspath as a top-level JavaBuilder flagGravatar Liam Miller-Cushon2017-03-06
| | | | | | | | | instead of hiding inside javacopts, and then processing javacopts to extract in JavaBuilder. -- PiperOrigin-RevId: 149127902 MOS_MIGRATED_REVID=149127902
* Remove duplicate class.Gravatar Chloe Calvarin2017-03-06
| | | | | | | | | | ParsedOptionEntry and OptionValueDescription were redundant and error-prone, since converting from one to the other involved adding a name that could easily be unrelated to the option value described. -- PiperOrigin-RevId: 149111525 MOS_MIGRATED_REVID=149111525
* Remove all the action resource estimation codeGravatar Ulf Adams2017-03-06
| | | | | | -- PiperOrigin-RevId: 149110466 MOS_MIGRATED_REVID=149110466
* Allow ' ', '(', ')' and '$' in labels Gravatar Damien Martin-Guillerez2017-03-06
| | | | | | | | | | | | | | | | | | | | | | | This just add the special characters in labels and fixes the associated tests, left is the hard part to test adding those characters everywhere. This is experimental and several characters will break at several location especial in the runfiles manifest file. Follow-ups: Resolve quoting then test, test more and add even more tests. Issue found during development: Parentheses are not accepted in exclude pattern in globs Building a binary includes build-runfiles that relies on the runfiles manifest format so the added test would fails with a java_binary instead of a library. -- Change-Id: I9c87273a90318b931c61bdb86f1066962819960a Reviewed-on: https://cr.bazel.build/9055 PiperOrigin-RevId: 149108027 MOS_MIGRATED_REVID=149108027