| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
| |
This interface makes it clearer in the type system exactly how items that go into a CustomCommandLine are turned into strings.
It is a preparatory change to allow command line fingerprints to be more cheaply calculated, but it is valuable in itself from a code quality standpoint.
PiperOrigin-RevId: 183274022
|
|
|
|
|
|
|
|
| |
includes output directory, which is wiped for every symlink action. Instead,
put .includes files in genfiles.
TESTED=manually using repro instructions in b/64534488#comment15
PiperOrigin-RevId: 183268700
|
|
|
|
|
|
| |
of the final steps of the migration process into Skylark. If you were using ios_test, please take a look at ios_unit_test provided by the github.com/bazelbuild/rules_apple project.
PiperOrigin-RevId: 183251623
|
|
|
|
| |
PiperOrigin-RevId: 183248133
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 183246711
|
|
|
|
|
|
| |
ConfiguredTargetAndTarget.getTarget().
PiperOrigin-RevId: 183241259
|
|
|
|
|
|
|
| |
This option has no effect, so don't give documentation readers false hope.
Change-Id: Ibbc0d2f62375fd146fedaa113a39027bd7d65d6c
PiperOrigin-RevId: 183240947
|
|
|
|
|
|
|
| |
emulators to show up.
RELNOTES: None.
PiperOrigin-RevId: 183188581
|
|
|
|
|
|
| |
Allows ObjectCodec to be registered as a Kryo Serializer.
PiperOrigin-RevId: 183149177
|
|
|
|
|
|
|
|
| |
TestConfigFragment.
Thanks to shahan@ for the TestConfigFragment code.
PiperOrigin-RevId: 183127152
|
|
|
|
|
|
| |
from package.
PiperOrigin-RevId: 183121812
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Made obsolete by https://github.com/bazelbuild/bazel/commit/e734c479956df7a675c61f531d769609d3af3e5d
*** Original change description ***
Blaze now passes an extra flag to JavaBuilder, --testonly, to
mark compilations of test code.
We plan to use this for Error Prone checks that need to distinguish
between test and production code, such as enforcing
@VisibleForTesting.
PiperOrigin-RevId: 183121768
|
|
|
|
|
|
|
|
| |
https://github.com/bazelbuild/bazel/commit/3863b536bcab8de2000f342c85c31c7ea91cccbe, we don't want to have to serialize/deserialize a BuildConfiguration in a SkyKey.
Cutting the edge to the aspect configuration will come in a follow-up.
PiperOrigin-RevId: 183117915
|
|
|
|
|
|
| |
start-lib/end-lib should not be passed to ar. Fix how the libraries to link are passed to ar by not using the generic feature "libraries_to_link"
PiperOrigin-RevId: 183107904
|
|
|
|
|
|
|
|
| |
BuildConfiguration: BuildConfigurations are too heavy to be in SkyKeys.
This adds an extra dependency for BuildInfoCollectionValues, but there are not many in the graph, and the dep request is now batched, which is better than before.
PiperOrigin-RevId: 183106788
|
|
|
|
| |
PiperOrigin-RevId: 183102476
|
| |
|
|
|
|
|
|
|
|
| |
BuildConfiguration.Fragment>> set of Fragment classes that is part of the BuildConfigurationValue.Key. This class allows us to compute a fingerprint of the wrapped ImmutableSortedSet, making equality comparisons fast. The number of additional wrapper objects is the number of distinct sets of fragment classes, so 1. (In fact, we don't even need to compute a fingerprint, since reference equality does the job for us here, but we do it just to be conservative.)
This CL has a performance benefit for Bazel currently, but has a bigger performance benefit in the following changes, where there are more BuildConfigurationValue.Key objects to compare.
PiperOrigin-RevId: 183090122
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
android_instrumentation_test.args dictionary into the DeviceBroker in the stub template. Also remove extra %test_label% assignment
This allows users to pass arguments in the form of:
```
args = [
"--enable_display=false",
...
]
```
GITHUB: #903
RELNOTES: None.
PiperOrigin-RevId: 183089901
|
|
|
|
|
|
| |
types instead of sorting.
PiperOrigin-RevId: 183083445
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 183069509
|
|
|
|
|
|
|
|
| |
and fixes codec in
RunUnderConverter.
PiperOrigin-RevId: 183003383
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 182986489
|
|
|
|
|
|
|
|
| |
ImmutableSortedSet wherever possible, and use a known explicit ImmutableSortedSet in the case of two sets being equal. This is mainly a cosmetic cleanup for the sequel changes.
Also rename test-only methods in SkyframeExecutor to indicate that, and do a drive-by clean-up of a test that reported hard crashes confusingly because it wrapped RuntimeExceptions.
PiperOrigin-RevId: 182984572
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Merged object files are needed when we use -flto-unit. It's created
during the LTO indexing step and needs to be passed to the final link.
LLVM already can create merged object files we just need to pass
"-Wl,-plugin-opt,obj-path=" into LLVM gold plugin.
"-flto-unit" emits IR to support LTO unit features needed for CFI (Control
Flow Integrity).
RELNOTES: Add support for merged object files needed for -flto-unit.
PiperOrigin-RevId: 182964781
|
|
|
|
|
|
|
|
| |
android_instrumentation_test's runfiles.
GITHUB: #903
RELNOTES: None.
PiperOrigin-RevId: 182940009
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 182937363
|
|
|
|
|
|
|
| |
JavaRuntimeInfo.
Change-Id: Ic338dc9b3e5efa2fee92dba722a46cab743db40c
PiperOrigin-RevId: 182919931
|
|
|
|
|
|
|
| |
access.
Change-Id: I6041c51823fa52d6ae55dfe06afd1754ce05ab98
PiperOrigin-RevId: 182904580
|
|
|
|
|
|
|
|
| |
Fixes #3234.
Rollforward of commit dafe71390340224e06eab0ac7afcebb2f5219f5a with a bugfix
PiperOrigin-RevId: 182903117
|
|
|
|
|
|
|
|
|
|
|
| |
JavaRuleOutputJarsProvider.
Added tests for checking JavaRuleOutputJarsProvider state.
Moved all test cases related to JavaInfo to new file JavaInfoSkylarkApiTest.java
Created RuleBuilder inside JavaInfoSkylarkApiTest to reduce duplication of code.
RELNOTES:none
PiperOrigin-RevId: 182901118
|
|
|
|
|
|
| |
java.util.function.Predicate and move some code that was only called by TestFilter inside it.
PiperOrigin-RevId: 182884550
|
| |
|
|
|
|
|
|
| |
have already been changed to ConfiguredTargetAndTarget so there's fewer classes than I thought there would be.
PiperOrigin-RevId: 182839243
|
|
|
|
| |
PiperOrigin-RevId: 182837838
|
|
|
|
|
|
|
|
|
| |
Bazel help output will now use the new categories by default, including for the generated html documentation at https://bazel.build/versions/master/docs/command-line-reference.html
Issue #3758 - this switches to the new categories, but the grouping is still by command, which leads to duplicate options
RELNOTES: None
PiperOrigin-RevId: 182815006
|
|
|
|
|
|
|
| |
Fixes #4170.
Change-Id: I308ee17eb769dcc6a94b90b1dd6cc2ccbe14e968
PiperOrigin-RevId: 182807196
|
|
|
|
|
|
|
| |
The idea is that rule sets should record what builtin providers (types, not instances) they use, as opposed to having a static registry the way we do for @SkylarkSignature builtins. (It'd be nice for the latter to not be static one day.)
RELNOTES: None
PiperOrigin-RevId: 182802492
|
|
|
|
| |
PiperOrigin-RevId: 182796843
|
|
|
|
|
|
|
| |
Part of #4442.
Change-Id: I49d6d851787727739f50348df2e2ef48392af479
PiperOrigin-RevId: 182795733
|
|
|
|
|
|
|
| |
This will serve as an alternative to --batch, leaving behind a server without state from the previous build.
RELNOTES: Introduces --[no]keep_state_after_build
PiperOrigin-RevId: 182778500
|
|
|
|
|
|
|
|
|
|
| |
Currently, we insist on all archives we download being compressed. But
technically, there is no reason compression is needed; handling plain
tar archives is no more complicated. So add that option as well; at the
very least, it makes testing more easy.
Change-Id: I1fddc95d5c80d195eb900ab74bf6403484f61da7
PiperOrigin-RevId: 182777193
|
|
|
|
|
|
|
|
| |
Regress on #3360.
We have reports of Bazel outputting warnings for generated files, which I have been able to reproduce. Apparently, Bazel gets stuck with an old FileContentsProxy for generated files, and is unable to recover.
PiperOrigin-RevId: 182772324
|
|
|
|
| |
PiperOrigin-RevId: 182767783
|
|
|
|
|
|
|
| |
Part of #4442.
Change-Id: I6debbf7cfdf560d2113e736176702c2cd889c0d2
PiperOrigin-RevId: 182763864
|
|
|
|
|
|
| |
owner and fix up BuildConfigurationValue.Key. ConfiguredTargetKey is going to need some modifications to AutoCodec: probably the long-awaited static "create" method.
PiperOrigin-RevId: 182630181
|
|
|
|
|
|
|
|
|
|
|
| |
Just shuffling code in the build() method to simplify future review.
1. Reuse result of getRootRelativePath()
2. Delay linkerInputs generation
3. allowLtoIndexing ? thinltoParamFile : null -> thinltoParamFile
it must be null if indexing is not allowed
RELNOTES: None
PiperOrigin-RevId: 182626938
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 182579590
|
|
|
|
|
|
| |
into processRequest method in BuildTool. This is an extension of CL/181816980 and prevents pollution of BuildRequest.
PiperOrigin-RevId: 182576704
|
|
|
|
| |
PiperOrigin-RevId: 182568806
|