| Commit message (Collapse) | Author | Age |
|
|
|
|
|
| |
--
PiperOrigin-RevId: 149110466
MOS_MIGRATED_REVID=149110466
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This just add the special characters in labels and fixes the
associated tests, left is the hard part to test adding
those characters everywhere.
This is experimental and several characters will break at several
location especial in the runfiles manifest file.
Follow-ups: Resolve quoting then test, test more and add even more tests.
Issue found during development:
Parentheses are not accepted in exclude pattern in globs
Building a binary includes build-runfiles that relies on the runfiles
manifest format so the added test would fails with a java_binary
instead of a library.
--
Change-Id: I9c87273a90318b931c61bdb86f1066962819960a
Reviewed-on: https://cr.bazel.build/9055
PiperOrigin-RevId: 149108027
MOS_MIGRATED_REVID=149108027
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
PathFragment's `equals`, `hashCode`, `compareTo`,
`startsWith`, `endsWith`, and `relativeTo` are now
aware of case-insensitivity when running on
Windows.
This approach is better than
https://bazel-review.googlesource.com/c/9124/
because it preserves path casing, which is
important when computing action output paths.
This change contains two additional bugfixes:
- `compareTo` now takes `driveLetter` into account
- the `InMemoryFileSystem` in `PathWindowsTest` is
not case-insensitive
Fixes https://github.com/bazelbuild/bazel/issues/2613
--
Change-Id: I1a4250a373fff03fa02a6d8360457450b47a42a8
Reviewed-on: https://cr.bazel.build/9126
PiperOrigin-RevId: 149106930
MOS_MIGRATED_REVID=149106930
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was fixing the Android tests and I noticed that the bazel_workspace_status_test was failing. It was like when you have a thread coming out of a sweater and you start pulling and pretty soon you have no sweater. Long story short, my "Android tests fix" cl ended up needing ~1k more lines changed (on top of the existing enormous CL).
So, I'm creating some smaller CLs with the changes that I can extract from the mega CL. Again.
Prep for #1681.
--
PiperOrigin-RevId: 149106039
MOS_MIGRATED_REVID=149106039
|
|
|
|
|
|
|
|
|
| |
They were only used by a test that can just as well use the tokenized
version of the javacOpts.
--
PiperOrigin-RevId: 149102073
MOS_MIGRATED_REVID=149102073
|
|
|
|
|
|
|
|
| |
Fixes #2016
--
PiperOrigin-RevId: 149102037
MOS_MIGRATED_REVID=149102037
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 149089903
MOS_MIGRATED_REVID=149089903
|
|
|
|
|
|
|
|
| |
implementation that uses crosstool for compilation.
--
PiperOrigin-RevId: 149083774
MOS_MIGRATED_REVID=149083774
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 149067322
MOS_MIGRATED_REVID=149067322
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 149061874
MOS_MIGRATED_REVID=149061874
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks nightly, see [].
*** Original change description ***
Inject aidl_lib only to android_library targets that have idl_srcs
--
PiperOrigin-RevId: 149059892
MOS_MIGRATED_REVID=149059892
|
|
|
|
|
|
|
|
| |
the full list of rdep mods that are being performed on this entry, not just the current one that failed.
--
PiperOrigin-RevId: 149055655
MOS_MIGRATED_REVID=149055655
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 149026338
MOS_MIGRATED_REVID=149026338
|
|
|
|
|
|
|
|
| |
RELNOTES: Per-architecture dSYM binaries are now propagated by apple_binary's AppleDebugOutputsProvider.
--
PiperOrigin-RevId: 149019153
MOS_MIGRATED_REVID=149019153
|
|
|
|
|
|
|
|
|
|
|
| |
In this way, the experimental UI will report about the progress of
downloads. Fixes #2563. Fixes #1260.
--
Change-Id: I034e0f2bc8df0a1f46b28298d3d1fccc8daaaded
Reviewed-on: https://cr.bazel.build/9115
PiperOrigin-RevId: 149013682
MOS_MIGRATED_REVID=149013682
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move all local resource acquisition to where local execution actually happens.
Don't attempt to acquire resources per action, but only for individual spawns.
This significantly simplifies the code.
The downside is that we don't account for action-level work anymore. In
general, actions should not perform any process execution themselves, but
always delegate such work to a SpawnStrategy implementation.
This change makes sure that every Spawn has local resources set in a way that
is consistent with the previous state.
However, there are two actions - Fileset and FileWrite -, which are not spawns,
and so we now don't limit their concurrent execution anymore. For Fileset, all
work is done in a custom Fileset-specific thread pool, so this shouldn't be a
problem. I'm not sure about FileWriteAction.
--
PiperOrigin-RevId: 149012600
MOS_MIGRATED_REVID=149012600
|
|
|
|
|
|
|
|
| |
execution. Usually it is enabled, and will be triggered whenever a remote_cache is specified, but a remote_worker is not; however, this flag allows to specifically disable it for the cases where remote_worker is defined, but something went wrong and we were forced to execute locally. This is useful to save time when the remote API does not actually support setting the remote action result.
--
PiperOrigin-RevId: 149007755
MOS_MIGRATED_REVID=149007755
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 149004753
MOS_MIGRATED_REVID=149004753
|
|
|
|
|
|
|
|
| |
Fixes #2597
--
PiperOrigin-RevId: 148999160
MOS_MIGRATED_REVID=148999160
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Instead of having a single class for both, split them into
{Skylark,Native}ClassObjectConstructors
2) Allow NativeClassObjectConstructors to customize their instantiation
logic.
3) Prepare ClassObjectConstructor.Key to be serializable.
--
PiperOrigin-RevId: 148997553
MOS_MIGRATED_REVID=148997553
|
|
|
|
|
|
|
|
| |
In particular, display the type that was passed as argument.
--
PiperOrigin-RevId: 148995695
MOS_MIGRATED_REVID=148995695
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 148987080
MOS_MIGRATED_REVID=148987080
|
|
|
|
|
|
|
|
|
|
| |
Part of ongoing work on #2219.
--
Change-Id: Ie4e842a5d8218e47f41a954c2b955ab24237aa65
Reviewed-on: https://cr.bazel.build/9116
PiperOrigin-RevId: 148976893
MOS_MIGRATED_REVID=148976893
|
|
|
|
|
| |
PiperOrigin-RevId: 148938713
MOS_MIGRATED_REVID=148938713
|
|
|
|
|
|
|
|
| |
This requires passing linkopts through CrosstoolCompilationSupport into the 'legacy_link_flags' feature, as is done in c++.
--
PiperOrigin-RevId: 148911500
MOS_MIGRATED_REVID=148911500
|
|
|
|
|
|
|
|
|
|
|
|
| |
prevent thread starvation
This change gets rid of the additional thread needed for task scheduling during
BFS visitation, which eliminates the possibility of thread starvation while a
single thread pool is used for multiple concurrent evaluations.
--
PiperOrigin-RevId: 148911346
MOS_MIGRATED_REVID=148911346
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the experimental UI, to be able to report appropriately about ongoing
downloads, we need to track their state, as updated by the DownloadProgressEvents.
Do so. Also report on ongoing downloads in the progress bar.
--
Change-Id: I668e963cd6da85ec598b23724066d366d465271f
Reviewed-on: https://cr.bazel.build/9114
PiperOrigin-RevId: 148899297
MOS_MIGRATED_REVID=148899297
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Roll-forward of commit 01120026dc313ee7ad9ea95069a29252eb19173b with fix.
*** Original change description ***
Automated [] rollback of commit 01120026dc313ee7ad9ea95069a29252eb19173b.
--
PiperOrigin-RevId: 148897534
MOS_MIGRATED_REVID=148897534
|
|
|
|
|
|
|
|
|
|
|
| |
If expanding a pattern fails, report this on the build event protocol;
also include details of what happened.
--
Change-Id: I2bc9caf7c085911b80551d7892cc34f5e9961c7b
Reviewed-on: https://cr.bazel.build/8795
PiperOrigin-RevId: 148894326
MOS_MIGRATED_REVID=148894326
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 148888469
MOS_MIGRATED_REVID=148888469
|
|
|
|
|
|
|
|
|
|
|
| |
provide a provider.
Previously we always executed the function, but didn't add the aspect to
the deps.
--
PiperOrigin-RevId: 148887089
MOS_MIGRATED_REVID=148887089
|
|
|
|
|
|
|
|
|
| |
This simplifies implementation of attr.* functions and helps make
declared provider implementation simpler.
--
PiperOrigin-RevId: 148867326
MOS_MIGRATED_REVID=148867326
|
|
|
|
|
|
|
|
|
|
| |
TestStrategy sometimes computed the runfiles directory separately from
the existing code in Runfiles. Now we always use the passed through value.
AFAICT, the two code paths were identical.
--
PiperOrigin-RevId: 148866489
MOS_MIGRATED_REVID=148866489
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 148844518
MOS_MIGRATED_REVID=148844518
|
|
|
|
|
|
|
|
| |
out if DexArchiveAspect misses .jar files
--
PiperOrigin-RevId: 148835665
MOS_MIGRATED_REVID=148835665
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 148827329
MOS_MIGRATED_REVID=148827329
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 148816635
MOS_MIGRATED_REVID=148816635
|
|
|
|
|
|
|
|
| |
RELNOTES: Convert --use_action_cache to a regular option
--
PiperOrigin-RevId: 148804881
MOS_MIGRATED_REVID=148804881
|
|
|
|
|
|
|
|
|
|
|
|
| |
The build event protocol now emits a BuildFinished event at the end of a build. The event is a child of the BuildStarted event.
The code changes were larger than expected, due to some refactoring in BuildEventStreamer. This was necessary as the BuildCompleteEvent now implements the BuildEvent interface and Guava's EventBus always invokes the most specialized subscriber method. Thus, the buildEvent(BuildEvent) and buildCompleted(BuildCompletedEvent) methods had to be merged.
--
Change-Id: Id0c2bd7220dc8ce03128b7126587e212ee8ce836
Reviewed-on: https://cr.bazel.build/9053
PiperOrigin-RevId: 148788582
MOS_MIGRATED_REVID=148788582
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
--
PiperOrigin-RevId: 148781019
MOS_MIGRATED_REVID=148781019
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ProgressInputStream provides unstructured information about progress
of downloading files in the form of Progress events. Add a new event
type, to be posted over the event bus, providing structured information
about the download progress.
--
Change-Id: Idbbaa4325ade356e65ef7ef1a40e66730216b6fe
Reviewed-on: https://cr.bazel.build/9113
PiperOrigin-RevId: 148772585
MOS_MIGRATED_REVID=148772585
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In Skyframe Evaluation, events reporting about progress are meant to be seen
immediately by the environment. More over, they are not to be replayed when
taking this SkyFunction out of cache. So change the custom implementation of the
StoredEventHandler in the SkyFunctionEnvironment to forward appropriately.
--
Change-Id: I30baf0088595ef684f16270f11668e980e65aa41
Reviewed-on: https://cr.bazel.build/9112
PiperOrigin-RevId: 148766400
MOS_MIGRATED_REVID=148766400
|
|
|
|
|
|
|
|
|
|
|
|
| |
platform-related constraints and values.
Part of ongoing work on #2219.
--
Change-Id: Ice370ee26469f4992faf72c0c95a1a3e51a9f9e7
Reviewed-on: https://cr.bazel.build/9091
PiperOrigin-RevId: 148758190
MOS_MIGRATED_REVID=148758190
|
|
|
|
|
|
|
|
|
|
|
|
| |
directory.
Fixes #2580.
--
Change-Id: I6e1271a9c1442819e956f7fcdcb5da535ed027db
Reviewed-on: https://cr.bazel.build/9110
PiperOrigin-RevId: 148751072
MOS_MIGRATED_REVID=148751072
|
|
|
|
|
|
|
|
|
|
|
|
| |
updateInputs() and inputsKnown() non-overridable and removing setInputs().
This comes at the cost of adding a flag to every action instance that's not used for non-input-discovering actions, but I think that's a deal. Simpler APIs are good, mmmmkay?
Also fixed a few pre-existing issues in TestAction and ObjcCompileAction.
--
PiperOrigin-RevId: 148749734
MOS_MIGRATED_REVID=148749734
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 148749485
MOS_MIGRATED_REVID=148749485
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 148697913
MOS_MIGRATED_REVID=148697913
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
backend for SkyQueryEnvironment's implementation in order to achieve parallelism.
Advantages:
-New design has no flaws that the old design had.
-Code is structured so that deadlocks due to thread starvation are impossible (yup!).
Disadvantages:
-The meat of this change needs to all be in a single CL because every single QueryFunction and QueryExpression needs to be rewritten in the async style.
Still TODO:
-Fully embrace the async model in all QueryFunctions (e.g. 'rdeps', 'allpaths').
-Use concurrency in BlazeQueryEnvironment to achieve parallel evaluation for (non SkyQuery) 'blaze query' and genquery.
--
PiperOrigin-RevId: 148690279
MOS_MIGRATED_REVID=148690279
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A target's tags and output files are reported as part of
the TargetComplete event of the build event protocol (BEP).
The output files are grouped by their corresponding output
group. If an output file belongs to more than one output group
it appears once in each output group.
--
Change-Id: Ia37db68709850d8550e478dcc30064dc7366bd1b
Reviewed-on: https://cr.bazel.build/8955
PiperOrigin-RevId: 148667599
MOS_MIGRATED_REVID=148667599
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a test based on our Python rules that makes sure that this actually
fixes the issue. Thanks to @duggelz for the suggestion. It seems like
our Python rules are the only place that actually provides an
EmptyFilesSupplier to Runfiles, so there's probably no simpler way to
test this behavior in an integration test.
Fix #1458. Fix #2394.
--
PiperOrigin-RevId: 148656193
MOS_MIGRATED_REVID=148656193
|