| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
|
| |
performed in order to expose it in build summary output.
--
PiperOrigin-RevId: 145457357
MOS_MIGRATED_REVID=145457357
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
After discussing with thomaswk@, we've decided not to put these in the android_sdk.
*** Original change description ***
Add attributes to android_sdk rule so that they will be available for open sourcing android_device.
--
PiperOrigin-RevId: 145444443
MOS_MIGRATED_REVID=145444443
|
|
|
|
|
|
|
|
| |
sourcing android_device.
--
PiperOrigin-RevId: 145429610
MOS_MIGRATED_REVID=145429610
|
|
|
|
|
|
|
|
| |
transition at the top level for the expanded set of apple rule classes
--
PiperOrigin-RevId: 145421255
MOS_MIGRATED_REVID=145421255
|
|
|
|
|
|
|
|
|
| |
Remove (output != null) check which is always true and cleanup dependent
conditionals.
--
PiperOrigin-RevId: 145409269
MOS_MIGRATED_REVID=145409269
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is part of unifying the test strategies; here, I'm working towards
sharing the test environment setup.
This change moves code from previously closed source code into the open
source parts. The internal change is not visible, making this look like an
addition rather than a move..
The next change hooks this up to Bazel. I did this in order to reduce the
size of the change to make it easier to debug, review, and so that it's
smaller in case we have to roll it back. Unfortunately, that requires
duplicating some of the code in StandaloneTestStrategy until the next change
lands.
--
PiperOrigin-RevId: 145387109
MOS_MIGRATED_REVID=145387109
|
|
|
|
|
|
|
|
| |
brings it in line with the behavior in objc_library.
--
PiperOrigin-RevId: 145330154
MOS_MIGRATED_REVID=145330154
|
|
|
|
|
|
|
|
|
| |
This is required for compatibility with existing runtimes specified
as filegroups.
--
PiperOrigin-RevId: 145314598
MOS_MIGRATED_REVID=145314598
|
|
|
|
|
|
|
|
| |
finding actions based on intermediate artifacts.
--
PiperOrigin-RevId: 145303065
MOS_MIGRATED_REVID=145303065
|
|
|
|
|
|
|
|
| |
One's unused, the other is ok as protected.
--
PiperOrigin-RevId: 145291062
MOS_MIGRATED_REVID=145291062
|
|
|
|
|
|
|
|
|
|
| |
that provider to retrieve the executable binary to act as the bundle_loader.
Also passes the bundle loader's ObjcProvider and ObjcProtoProviders to the dylib deduping mechanism to avoid dual linking of symbols into the tests.
--
PiperOrigin-RevId: 145284598
MOS_MIGRATED_REVID=145284598
|
|
|
|
|
|
|
|
| |
(as oposed to proto_library targets) would result in a crash.
--
PiperOrigin-RevId: 145283582
MOS_MIGRATED_REVID=145283582
|
|
|
|
|
|
|
|
|
|
| |
the scope.
This seems to only have been a problem when the error was in an unselect path, as the query would have failed earlier otherwise.
--
PiperOrigin-RevId: 145282112
MOS_MIGRATED_REVID=145282112
|
|
|
|
|
|
|
|
| |
Also refactoring JavaProvider to use the Builder pattern, given that it is going to encapsulate a fair number of other providers.
--
PiperOrigin-RevId: 145280532
MOS_MIGRATED_REVID=145280532
|
|
|
|
|
|
|
|
|
|
| |
This cl relieves us from hard-coding -l and -l: flags in Bazel. To be able to
express the behavior in CROSSTOOL, we need to know what type of library are we
dealing with.
--
PiperOrigin-RevId: 145271426
MOS_MIGRATED_REVID=145271426
|
|
|
|
|
|
|
|
|
|
|
|
| |
Because the event handler's inner handlers are removed after each query
command, caching the handler caused a subset of subsequent commands'
errors (those reported through the resolver's handler) to go unlogged.
Also fix a bug with cycle detection in DelegatingWalkableGraph.
--
PiperOrigin-RevId: 145124271
MOS_MIGRATED_REVID=145124271
|
|
|
|
|
|
|
|
| |
Also some apple binary test cleanup along the way.
--
PiperOrigin-RevId: 145123804
MOS_MIGRATED_REVID=145123804
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 145122327
MOS_MIGRATED_REVID=145122327
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 145119990
MOS_MIGRATED_REVID=145119990
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 145091484
MOS_MIGRATED_REVID=145091484
|
|
|
|
|
|
|
|
| |
with the internal GenRule implementation.
--
PiperOrigin-RevId: 145087704
MOS_MIGRATED_REVID=145087704
|
|
|
|
|
|
|
|
|
| |
The code has been untouched and unused for over a year (it's very likely
broken) and we have other priorities for now.
--
PiperOrigin-RevId: 145087310
MOS_MIGRATED_REVID=145087310
|
|
|
|
|
|
|
|
| |
ExecutionInfoProvider.
--
PiperOrigin-RevId: 145084927
MOS_MIGRATED_REVID=145084927
|
|
|
|
|
|
|
|
|
| |
This functionality is never used, have never been exposed to Skylark
and is a continuous pain to maintain and test.
--
PiperOrigin-RevId: 145079832
MOS_MIGRATED_REVID=145079832
|
|
|
|
|
|
|
|
|
|
| |
Specifying both options can cause OOM on OSX.
--
Change-Id: I52daf194a8840f9e63f1d537f13152e53f8436a7
Reviewed-on: https://cr.bazel.build/8220
PiperOrigin-RevId: 145079331
MOS_MIGRATED_REVID=145079331
|
|
|
|
|
|
|
|
|
|
| |
This seems like an obvious cleanup, and I also want to move most of the
test-specific environment setup to TestRunnerAction, which is simpler after
this change.
--
PiperOrigin-RevId: 145076829
MOS_MIGRATED_REVID=145076829
|
|
|
|
|
|
|
|
|
|
|
| |
For example, on FreeBSD, ${PREFIX}/bin/python is a symlink
to the correct python version.
--
Change-Id: Iae79caae8d98530a6d8656b1915a8d5de9c132ea
Reviewed-on: https://cr.bazel.build/8396
PiperOrigin-RevId: 145068920
MOS_MIGRATED_REVID=145068920
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Unwrapping JavaCompilationArgsProvider from JavaProvider when collecting compile time dependencies artifacts (in addition to JavaCompilationArgsProvider), so that java_library could depend on Skylark rules that return java_common.provider. (this makes java sandwich complete \o/)
* Added a new param (source_files) to java_common.compile to allow compilation of source files in addition to source jars.
* Added a new sourceFiles field to JavaLibraryHelper in order to pass them to JavaCompilationHelper.
* Added a new method (java_common.default_javac_opts) for default Java compilation.
* Added a test for a basic java sandwich.
--
PiperOrigin-RevId: 145064700
MOS_MIGRATED_REVID=145064700
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is not intended to be a user-visible semantic change, aside from error messages.
This is to help avoid unintentional flattening of depsets, and to narrow down the number of call sites where this can occur, to help us print warning/deprecation messages.
EvalUtils#toIterable will now return an ImmutableList in place of SkylarkNestedSet. This should be ok since the caller shouldn't be relying on the result being a Skylark-safe type. Code that takes Iterable because it accepts either a list or set, can instead be changed to take Object and use EvalUtils#toIterableStrict for validation.
Note that NestedSet still implements Iterable, so native code can still easily and accidentally flatten sets.
--
PiperOrigin-RevId: 145044023
MOS_MIGRATED_REVID=145044023
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 145030082
MOS_MIGRATED_REVID=145030082
|
|
|
|
|
|
|
|
| |
the AppleCrosstoolTransition.
--
PiperOrigin-RevId: 145006581
MOS_MIGRATED_REVID=145006581
|
|
|
|
|
|
|
|
|
|
| |
The old names are deprecated but still supported for now. A flag for enforcing the deprecation will come in a later change.
RELNOTES[INC]: The traversal orders for depsets have been renamed. The old names are deprecated and will be removed in the future. New names: "stable" -> "default", "compile" -> "postorder", "link" -> "topological", "naive_link" -> "preorder".
--
PiperOrigin-RevId: 145004718
MOS_MIGRATED_REVID=145004718
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144992642
MOS_MIGRATED_REVID=144992642
|
|
|
|
|
|
|
|
|
|
|
| |
As pointed out in the new review comments on commit df726eae7b6ef11df3b962d720df36f63d5cd3a3, the
SpawnAction members did not need to be changed from private to
protected, they just needed to be accessed via accessor methods
in the derived LTOBackendAction class.
--
PiperOrigin-RevId: 144989490
MOS_MIGRATED_REVID=144989490
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144983864
MOS_MIGRATED_REVID=144983864
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144965845
MOS_MIGRATED_REVID=144965845
|
|
|
|
|
|
|
|
|
|
|
| |
This digest make sure that we produce a different RepositoryDirectoryValue
for different marker data, thus invalidating the node.
--
Change-Id: Ibc6286c76de7a8d07ece2bb8125bfb75095f7784
Reviewed-on: https://cr.bazel.build/8136
PiperOrigin-RevId: 144948233
MOS_MIGRATED_REVID=144948233
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144890965
MOS_MIGRATED_REVID=144890965
|
|
|
|
|
|
|
|
|
| |
This matters when the same rule (or other exportable) is bound to multiple
variables, since the identifier of the first variable will become its name.
--
PiperOrigin-RevId: 144881310
MOS_MIGRATED_REVID=144881310
|
|
|
|
|
|
|
|
| |
* This allows xcrunwrapper to set the correct SDKROOT when building darwin targets.
--
PiperOrigin-RevId: 144874291
MOS_MIGRATED_REVID=144874291
|
|
|
|
|
|
|
|
|
|
| |
--experimental_objc_library and --experimental_objc_use_crosstool_for_binary.
This flag will allow testing of the complete (compilation and linking) rollout
of the objc crosstool.
--
PiperOrigin-RevId: 144864301
MOS_MIGRATED_REVID=144864301
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the code below was first written, the default value for @Option cpu was null. This value was then overwritten with whatever target_cpu got loaded from the CROSSTOOL, which became the basis for all code queries of the value "cpu".
This behavior was deprecated some months ago after the default @Option cpu was changed to auto-read from the host machine. So the CROSSTOOL "override" no longer ever happens.
Also made the relevant test more hermetic.
--
PiperOrigin-RevId: 144850329
MOS_MIGRATED_REVID=144850329
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144849686
MOS_MIGRATED_REVID=144849686
|
|
|
|
|
|
|
|
|
|
|
| |
Bazel-created files (like log files of test runs) are internally reported
as Paths. However, this is not always the most useful representation of the
location of that artifact for a consumer of build events. Therefore, support
a mapping of paths to more useful URIs.
--
PiperOrigin-RevId: 144843525
MOS_MIGRATED_REVID=144843525
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144841772
MOS_MIGRATED_REVID=144841772
|
|
|
|
|
| |
PiperOrigin-RevId: 144839489
MOS_MIGRATED_REVID=144839489
|
|
|
|
|
|
|
|
| |
strict_proto_deps, then strictness is enforced.
--
PiperOrigin-RevId: 144836042
MOS_MIGRATED_REVID=144836042
|
|
|
|
|
|
|
|
|
|
| |
This interface is part of the module API, and this makes more sense than the
previous per-file API, IMO, and is more future proof, even if there's no
immediate benefit to the change.
--
PiperOrigin-RevId: 144827566
MOS_MIGRATED_REVID=144827566
|
|
|
|
|
|
|
|
|
|
| |
config1.equals(c2).
This fixes an obscure bug between dynamic configurations, host configuration caching, and Skyframe skyKey interning that makes Bazel crash under certain sequences of builds. See changes for details.
--
PiperOrigin-RevId: 144766296
MOS_MIGRATED_REVID=144766296
|
|
|
|
|
|
|
|
| |
ObjcProvider subtrees
--
PiperOrigin-RevId: 144747299
MOS_MIGRATED_REVID=144747299
|