aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools
Commit message (Collapse)AuthorAge
...
* Skylark debugger: fix thread paused state and location not being properly ↵Gravatar brendandouglas2018-06-08
| | | | | | set in ThreadPausedEvents. PiperOrigin-RevId: 199847385
* Add status details to the protosGravatar ulfjack2018-06-08
| | | | | | | | Both for the build event stream proto, which contains the TestResult event, and to the test status proto which is used for caching. The new field may be populated in the future. PiperOrigin-RevId: 199846232
* Automated rollback of commit 6c87715b8ac6b32e636ba307440e2b7362b10a48.Gravatar cpeyser2018-06-08
| | | | | RELNOTES:none PiperOrigin-RevId: 199840978
* Make Artifact#equals take the owner into account for derived artifacts.Gravatar janakr2018-06-08
| | | | | | | | Derived artifacts' owners are important because they are used to determine the artifact's generating action. Source artifacts' owners are not used in this way, so I left them alone. This allows us to get rid of most uses of ArtifactSkyKey. We may be able to delete it entirely in a follow-up. PiperOrigin-RevId: 199836436
* ActionFS correctly tracks symlink sources.Gravatar shahan2018-06-08
| | | | PiperOrigin-RevId: 199820207
* Use unsafe String operations when writing parameter files.Gravatar tomlu2018-06-08
| | | | | | | | | When a LATIN-1 parameter file is requested, we can take advantage of the fact that JDK9 strings are (usually) stored as LATIN-1. For UTF-8, we can still optimize for the common case where a LATIN-1 string contains only ASCII characters, as these are bit-identical between UTF-8 and LATIN-1. This would still be expected to be the vast majority of parameter file contents. RELNOTES: None PiperOrigin-RevId: 199816430
* Support basic test functionality in ActionFS.Gravatar felly2018-06-08
| | | | | | | | | ActionFS now allows output files to be created that do not correspond to known Artifacts. Note that tests exercise a greater gamut of filesystem functionality (deleting files, deleting directory trees, moving files, etc.) RELNOTES: None PiperOrigin-RevId: 199809069
* Flip default value of --experimental_shortened_obj_file_path to true (Second ↵Gravatar pcloudy2018-06-08
| | | | | | | | | | try) This is a roll forward of https://github.com/bazelbuild/bazel/commit/3ab52e63079f1e43cb2c973425f615836a334082. The issue caused the objc rule breakage was fixed by https://github.com/bazelbuild/bazel/commit/5176300577b53a15128b3cb6a17d7883c5b7090e. RELNOTES: Flip default value of --experimental_shortened_obj_file_path to true, Bazel now generates short object file path by default. PiperOrigin-RevId: 199806300
* Prepare to remove java_toolchain.encodingGravatar cushon2018-06-08
| | | | | | | | UTF-8 is the only supported encoding for Java sources. See #2926. PiperOrigin-RevId: 199803902
* Deletes default implemetation of MetadataProvider.getInputGravatar shahan2018-06-08
| | | | | | Small misc cleanups. PiperOrigin-RevId: 199797948
* Cleanup BuildEventStreamOptionsGravatar ulfjack2018-06-08
| | | | PiperOrigin-RevId: 199795284
* Expose cc_common.create_link_build_variablesGravatar hlopko2018-06-08
| | | | | | | | | | | This cl enabled skylark rules to create build variables used for C++ link actions (in a limited form, e.g. build variables for thinlto are not exposed etc). Working towards #4571. RELNOTES: None PiperOrigin-RevId: 199792130
* Add a `sync` commandGravatar Klaus Aehlig2018-06-08
| | | | | | | | | | | | | Add a command that ensures that all skylark workspace rules get called. In follow-up changes the semantics of the sync command will be extended to call all those rules unconditionally. This, together with recoding of the return values of the repository rules, as currently provided by --experimental_repository_resolved_file provides the framework for resolving underspecified rules, e.g., rules following head of an external repository. Change-Id: I11061ec138a9ba7a7b61a431eeb1b8667dfabb95 PiperOrigin-RevId: 199792026
* Print an additional link at the end of the build pointing where the Build ↵Gravatar lpino2018-06-08
| | | | | | Event Protocol is being streamed. PiperOrigin-RevId: 199790757
* BlazeOptionHandler: only check in the parent directory, if there is oneGravatar Klaus Aehlig2018-06-08
| | | | | | | | | | | When checking for a file called DO_NOT_BUILD_HERE in the parent direcotry of the workspace path, first verify that there is such a parent directory. This avoids a null pointer exception if the WORKSPACE file is in the top-level directory. Fixes #5349 Change-Id: I81289a27a3f7fb0f4b5a112343de1b454fb5b8c5 PiperOrigin-RevId: 199790735
* Remove include_java_contracts_deps option.Gravatar dbabkin2018-06-08
| | | | | RELNOTES:none PiperOrigin-RevId: 199787025
* Filter middleman artifacts from NamedArtifactGroupGravatar ulfjack2018-06-08
| | | | PiperOrigin-RevId: 199786555
* Update documentation about dict iteration orderGravatar laurentlb2018-06-08
| | | | | | | | | | | The information was redundant. https://github.com/bazelbuild/bazel/commit/d605a62eb9908fe44c89a2ed10f88f633c4dcb3e modified only one place, which created a contradiction. We can just remove the outdated one. #5352 RELNOTES: None. PiperOrigin-RevId: 199780557
* C++: Refactors PyWrapCc to make it easier to migrate to SkylarkGravatar plf2018-06-08
| | | | | | | | Rolling forward https://github.com/bazelbuild/bazel/commit/6afc2eb67675e928bc8fa10c5d1745223186b6e0. This CL was only rolled back to make it easier to rollback https://github.com/bazelbuild/bazel/commit/d0982b905d93e219a0caccdcf5d6ae1e219387c2. RELNOTES:none PiperOrigin-RevId: 199779304
* Remove the legacy loading phase runnerGravatar ulfjack2018-06-08
| | | | PiperOrigin-RevId: 199775400
* Automated rollback of commit ccaccb2b277a82f7264567563a02ab133a0f6e6f.Gravatar jmmv2018-06-07
| | | | | | | | | | | | | | | *** Reason for rollback *** Suspected root cause behind tons of Blaze nightly failures. One example: [] *** Original change description *** Let blaze obfuscate manual main_dex_list according to proguard map. PiperOrigin-RevId: 199737371
* Deletes ActionInputFileCache.Gravatar shahan2018-06-07
| | | | PiperOrigin-RevId: 199732415
* Automated rollback of commit d0982b905d93e219a0caccdcf5d6ae1e219387c2.Gravatar janakr2018-06-07
| | | | | | | | | | | | | | | *** Reason for rollback *** See linked bug. *** Original change description *** C++: Delete PyCcLinkParamsProvider. No longer needed. RELNOTES:none PiperOrigin-RevId: 199710626
* Automated rollback of commit f137cea0ac74334013e7b064e59d1624cf032ac4.Gravatar janakr2018-06-07
| | | | | | | | | | | | | *** Reason for rollback *** See linked bug. *** Original change description *** C++: Refactors PyWrapCc to make it easier to migrate to Skylark RELNOTES:none PiperOrigin-RevId: 199702630
* Add an initial skylark debug server implementation.Gravatar Googler2018-06-07
| | | | | | | | | | | | Not intending this to be a complete implementation yet. Among the things still to do: - officially add support for debugging aspects, rules, etc., with corresponding tests. - handle breakpoints at return statements (an edge case which bypasses Eval). PiperOrigin-RevId: 199692670
* Automated rollback of commit 4c72a82ada742bd369185cd07c57f96c497ce440.Gravatar jmmv2018-06-07
| | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks, at least, //ads/aswan/tools:format_mr_results. *** Original change description *** Remove python3/ prefix to generated .pyc files. That makes: (a) merging PY2 and PY3 .runfiles impossible (which is incorrect anyway) and (b) generated .py source files incompatible with 2to3 (src_version=PY2) - that's OK as we deprecate 2to3. RELNOTES: n/a PiperOrigin-RevId: 199661399
* Simplify TestAttempt interfaceGravatar ulfjack2018-06-07
| | | | | | | By always requiring a TestResultData instace, we simplify the callers, which already have to do all the work anyway. PiperOrigin-RevId: 199639965
* Move --distdir out of experimental statusGravatar Klaus Aehlig2018-06-07
| | | | | | | | | | | | | | | | | | | | | | | The option --experimental_distdir has been introduced 4 months ago and was completely unproblematic ever since. Moreover, it is now used productively, both in our own bootstrapping process[1], as well as in external packaging of projects using bazel[2]. So make this option non-experimental. We still keep the old name as an alternative to not break existing uses. Related: #5175. RELNOTES: The --distdir option is no longer experimental. This option allows to specify additional directories to look for files before trying to fetch them from the network. Files from any of the distdirs are only used if a checksum for the file is specified and both, the filename and the checksum, match. [1] Commit 3c9cd82b847f3ece8ec04b2029bd5e8ad0eb7502 [2] https://github.com/gentoo/gentoo/blob/7379cdb578b0c070c846c3fa9f71470e2c5d1320/sci-libs/tensorflow/tensorflow-1.8.0-r1.ebuild#L168 Change-Id: I536238f9bdbad6b4f7222b4f6a1464d70d9f3be3 PiperOrigin-RevId: 199637265
* Fix a few generated docs.Gravatar Sam Rawlins2018-06-07
| | | | | | | | | | | | | | In particular, * fix sentences with no space after the period, like [here]([] * switch backticks to `<code>`, like [here]([] * link `ctx.var` [here]([] * Add periods to the end of paragraphs, like [here]([] * Format a list [here]([] Closes #5337. PiperOrigin-RevId: 199631585
* Fix bug in skyframe-based test-suite expansionGravatar ulfjack2018-06-07
| | | | | | | | | | It was tracking filtered tests and then applying the filter at the next higher level. I also added a bunch of comments - we actually have four implementations of test suite expansion, and they are not consistent. Sorry about that. PiperOrigin-RevId: 199629485
* Remove genrule's dependency on the cpp toolchain.Gravatar jcater2018-06-07
| | | | PiperOrigin-RevId: 199627983
* Make bes_best_effort a no-opGravatar ulfjack2018-06-07
| | | | | | | | | | | | | | | | The current semantics of the flag is to allow BES upload to continue past the nominal end of the build invocation, and possibly overlapping a subsequent build invocation. This conflicts with file uploads, which must read the file before it is removed or modified by the subsequent build invocation. On Linux, we could just open a file handle, but this isn't possible on Windows. We decided to make the flag a no-op for now. Note that the default is already set to false. We may resurrect this option in the future if there's a strong use case for it, possibly with slightly different semantics. PiperOrigin-RevId: 199620392
* C++: Introduces flag to disable automatic expansion of labels in linkopts.Gravatar plf2018-06-07
| | | | | | | LSC is finished. RELNOTES:none PiperOrigin-RevId: 199619978
* Add LabelLateBoundDefault to :coverage_report_generator attributeGravatar dbabkin2018-06-07
| | | | | RELNOTES:none PiperOrigin-RevId: 199619691
* C++: Refactors PyWrapCc to make it easier to migrate to SkylarkGravatar plf2018-06-07
| | | | | RELNOTES:none PiperOrigin-RevId: 199619637
* Allow disabling the simple blob caches via CLI flag overrides.Gravatar John Millikin2018-06-07
| | | | | | | | | | | | | | This fixes a regression from v0.13. When the local disk cache flags were unified into `--disk_cache`, it became impossible to override a default cache location such that the cache became disabled. This prevents canarying of remote execution in the presence of a default bazelrc that enables the disk cache. Fixes #5308 Closes #5338. PiperOrigin-RevId: 199613922
* Add LabelLateBoundDefault to :coverage_support attributeGravatar dbabkin2018-06-07
| | | | | RELNOTES:none PiperOrigin-RevId: 199604462
* Expose C++ action names to SkylarkGravatar hlopko2018-06-07
| | | | | | | | | | | | | | This cl adds Skylark constants allowing users to specify which C++ action they want for the feature configuration Skylark API. This is done by exposing a Skylark file at @bazel_tools//tools/cpp:action_names.bzl. Skylark api to the C++ toolchain doc: https://docs.google.com/document/d/1g91BWJITcYw_X-VxsDC0VgUn5E9g0kRBGoBSpoO41gA/edit#. Progress on #4571. RELNOTES: None. PiperOrigin-RevId: 199596778
* C++: Delete PyCcLinkParamsProvider.Gravatar plf2018-06-07
| | | | | | | No longer needed. RELNOTES:none PiperOrigin-RevId: 199593828
* Rewrite TargetPattern failure reportingGravatar ulfjack2018-06-07
| | | | | | | | | | | | | | Report failures in TargetPatternFunction, rather than in its callers. Since we can't distinguish between keep_going and nokeep_going modes, we otherwise end up double-reporting errors. In the particular case that's covered by the build_event_stream_test.sh, we end up reporting the same target pattern as both skipped and failed. Unfortunately, this means we cannot report whether the target pattern was skipped or failed, so the pattern_skipped event is now unused (if we agree that this is acceptable, I'll remove the corresponding infrastructure). PiperOrigin-RevId: 199593700
* Refactoring: makes the code simpler by deleting Metadata and InputArtifactData.Gravatar shahan2018-06-06
| | | | | | (minor) ActionFS now implements MetadataProvider.getInput PiperOrigin-RevId: 199575194
* Allow for Path and Root resolution when extracting action metadata.Gravatar felly2018-06-06
| | | | | RELNOTES: None PiperOrigin-RevId: 199572597
* Let blaze obfuscate manual main_dex_list according to proguard map.Gravatar Googler2018-06-06
| | | | PiperOrigin-RevId: 199529974
* Remove a pointless nested set expansion.Gravatar Benjamin Peterson2018-06-06
| | | | | | | | | Change-Id: Icdabf559303bfac459e1a88ff44ca95298574361 Closes #5333. Change-Id: Icdabf559303bfac459e1a88ff44ca95298574361 PiperOrigin-RevId: 199527673
* Mark --batch as deprecated in the documentation.Gravatar ccalvarin2018-06-06
| | | | | RELNOTES: None. PiperOrigin-RevId: 199503117
* Build support for enabling cross binary FDO optimization.Gravatar Googler2018-06-06
| | | | | | | Crossbinary FDO optimization is a special form of AutoFDO which uses a synthetic profile to optimize targets without any profile. The synthetic profile will often be used as a default profile and will use .xfdo as suffix. It will be passed though option -fdo_optimize just like Autofdo profile. If .xfdo file is passed through -fdo_optimize in the same command line with other types of profiles, .xfdo file will be neglected. RELNOTES: Build support for enabling cross binary FDO optimization. PiperOrigin-RevId: 199501260
* Remove python3/ prefix to generated .pyc files.Gravatar Googler2018-06-06
| | | | | | | | | That makes: (a) merging PY2 and PY3 .runfiles impossible (which is incorrect anyway) and (b) generated .py source files incompatible with 2to3 (src_version=PY2) - that's OK as we deprecate 2to3. RELNOTES: n/a PiperOrigin-RevId: 199491867
* Add option to enable Docker sandboxing.Gravatar lberki2018-06-06
| | | | | RELNOTES: None. PiperOrigin-RevId: 199467128
* Remove CachingPackageLocator interface from the PackageProvider hierarchyGravatar ulfjack2018-06-06
| | | | | | This simplifies the code quite a bit. PiperOrigin-RevId: 199427943
* MetadataProvider now provides ActionInput lookup by exec path.Gravatar shahan2018-06-05
| | | | | | Adds a helper class, ActionInputMap to do this with minimal wrapping overhead. PiperOrigin-RevId: 199391251