| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
| |
and --nodistinct_host_configuration explicit. This particularly
helps triaging the Bazel tests when --experimental_dynamic_configs
is on.
--
MOS_MIGRATED_REVID=105801590
|
|
|
|
|
|
|
|
|
|
| |
cxx_builtin_include directories which start with "%workspace%/" are taken
to be relative to the build workspace, and not relative to crosstool-top.
RELNOTES[NEW]: cpxx_builtin_include_directory specifications allow more flexibility.
--
MOS_MIGRATED_REVID=105789270
|
|
|
|
|
|
|
|
|
|
|
| |
android_library rule when the android_library is being used as a forwarding rule
(i.e., has no sources).
RELNOTES: When used as a forwarding rule (i.e., has no sources), android_library
will also forward any exported_plugins in its dependencies.
--
MOS_MIGRATED_REVID=105787789
|
|
|
|
|
|
|
| |
RELNOTES: None
--
MOS_MIGRATED_REVID=105787681
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While a normal set is theoretically sufficient, it can cause hard-to-reproduce
problems. In particular, the iteration order of the expansion result depends
on the iteration order of the requested targets. If there are multiple
requests for the same set of targets, but with different orders, the results
would depend on which request was made first. If a downstream function also
inadvertantly depends on the iteration order, it can be hard to debug why it
ended up with a different order than it requested.
Alternatively, we could sort the result before returning it. We generally
expect the key set to be smaller than the result set, so this should be
ever so slightly more efficient.
--
MOS_MIGRATED_REVID=105765514
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks many android targets in the depot.
*** Original change description ***
Trying again with checking for the presence of the "resources" attribute.
Change the resource dependency handling to separate between the transitive and direct resources from libraries.
This slightly increases the complexity of resource propagation. The initial algorithm was to simply merge all transitive ResourceContainers together with any new ResourceContainer and propagate them via the AndroidResourcesProvider. The new algorithm is encapsulated inside a new ResourceDependencies class which...
***
ROLLBACK_OF=105631635
--
MOS_MIGRATED_REVID=105752015
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
release. Note the following peculiarities of the current situation:
- Sandboxed execution still silently falls back to non-sandboxed execution due to LocalGccStrategy explicitly requesting local execution.
- However, builds are still correct due to local execution using hdrs_check.
- hdrs_check, even though it was intended to default to "strict" in Bazel from the start, is still set to "loose" by default, so you might accidentally be using non-declared header files in your cc_* targets. In this case, your builds will break when the default becomes hdrs_check=strict and sandboxing becomes available. It is recommended that you check whether your builds are affected, by specifying --hdrs_check=strict manually and fixing your BUILD files to explicitly list all used includes in the srcs / hdrs attributes of your cc_* targets.
These remaining issues will be fixed in an upcoming change.
This change also adds regression tests for the issue.
--
MOS_MIGRATED_REVID=105747212
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105742091
|
|
|
|
|
|
|
|
| |
This is still not hooked up, but it's now passing all the relevant tests that
apply directly to the LoadingPhaseRunner; there are still a couple of TODOs.
--
MOS_MIGRATED_REVID=105739507
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105734972
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105648425
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the resource dependency handling to separate between the transitive and direct resources from libraries.
This slightly increases the complexity of resource propagation. The initial algorithm was to simply merge all transitive ResourceContainers together with any new ResourceContainer and propagate them via the AndroidResourcesProvider. The new algorithm is encapsulated inside a new ResourceDependencies class which works as follows:
1. Collect resources from the deps into transitive and direct NestedSets
2. If a rule provides a ResourceContainer, merge the transitive and direct into a new transitive set
3. Export the provider
This results having a rule without resources "forward" the merged sets of transitive and direct resources to the next rule.
--
MOS_MIGRATED_REVID=105631635
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes android_resources being dropped on the ground because the
source jar isn't included.
Previously, the java compilation args were used. This includes a bunch
of implicit and generated source, like idl sources. The source jars
include output from resource processing the rule itself, so it wasn't
possible to start including that.
What we want are all explicit sources only. This CL does that.
--
MOS_MIGRATED_REVID=105624870
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105624527
|
|
|
|
|
|
|
| |
Minimize indirection wrt singletons, turns out we had one that was completely unused.
--
MOS_MIGRATED_REVID=105621494
|
|
|
|
|
|
|
| |
For debugging. Simply serializes the proto to a text file.
--
MOS_MIGRATED_REVID=105621279
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks [].
*** Original change description ***
Change the resource dependency handling to separate between the transitive and direct resources from libraries.
This slightly increases the complexity of resource propagation. The initial algorithm was to simply merge all transitive ResourceContainers together with any new ResourceContainer and propagate them via the AndroidResourcesProvider. The new algorithm is encapsulated inside a new ResourceDependencies class which works as follows:
1. Collect resources from the deps into transitive and...
***
--
MOS_MIGRATED_REVID=105598448
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105596479
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most (all?) messages for this exception are complete description of the failure (e.g. "failed to do X", "could not do X"). With the previous wording the user got something like:
ERROR: [...] Writing file for rule '[...]' failedfailed to create file '[...]'
Now:
ERROR: [...] Writing file for rule '[...]' failed (failed to create file '[...]')
--
MOS_MIGRATED_REVID=105591532
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105591091
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105585492
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105552023
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105539869
|
|
|
|
|
|
|
|
|
| |
since root causes are associated with top-level targets and labels, and the filter is for all top-level targets and labels.
I noticed this when a huge --noanalyze build spent most of its time in filtering here. The passed-in "collection" was a list, which meant that we could have sped it up by using a set, but why not just get rid of it all.
--
MOS_MIGRATED_REVID=105536485
|
|
|
|
|
|
|
|
|
| |
former uses the latter). This way we parse BUILD files exactly once.
This is part of a series of changes with the net result being that we open, read, and parse each BUILD file exactly once.
--
MOS_MIGRATED_REVID=105528075
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and direct resources from libraries.
This slightly increases the complexity of resource propagation. The initial algorithm was to simply merge all transitive ResourceContainers together with any new ResourceContainer and propagate them via the AndroidResourcesProvider. The new algorithm is encapsulated inside a new ResourceDependencies class which works as follows:
1. Collect resources from the deps into transitive and direct NestedSets
2. If a rule provides a ResourceContainer, merge the transitive and direct into a new transitive set
3. Export the provider
This results having a rule without resources "forward" the merged sets of transitive and direct resources to the next rule.
--
MOS_MIGRATED_REVID=105515074
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105512492
|
|
|
|
|
|
|
| |
because it breaks some internal tests.
--
MOS_MIGRATED_REVID=105511798
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105511114
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105499267
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105498175
|
|
|
|
|
|
|
| |
Ideally, PrepareDepsOfPatternFunction and maybe even RecursivePkgFunction would also be changed to take a PackageIdentifier instead of RootedPath because the less places we store the set of roots, the better, but I've done enough refactoring in the past weeks to not be thrilled by the idea of doing more.
--
MOS_MIGRATED_REVID=105486561
|
|
|
|
|
|
|
|
|
| |
and mainGroup in xcodeproj.
RELNOTES: Adds --override_workspace_root blaze flag to hand-set workspace_root and mainGroup in xcodeproj.
--
MOS_MIGRATED_REVID=105484952
|
|
|
|
|
|
|
| |
Eliminate side-effect in command_line_srcs and hide the internal class.
--
MOS_MIGRATED_REVID=105480701
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105461876
|
|
|
|
|
|
|
| |
No need for a specific ordering.
--
MOS_MIGRATED_REVID=105438232
|
|
|
|
|
|
|
|
|
|
|
| |
It used to not change the symlink to point to the new one. The failure
modes were different when the old file existed vs not, so there are
tests for both.
--
Change-Id: I6328c56a90254c5da78ccf827d377900bde06e90
Reviewed-on: https://bazel-review.googlesource.com/#/c/2131/
MOS_MIGRATED_REVID=105432042
|
|
|
|
|
|
|
| |
preparation for eventually implementing recursive target patterns for remote repositories.
--
MOS_MIGRATED_REVID=105412566
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change affects only lists, because it is the only mutable type.
The change is also temporary. We will later make the list immutable (when
it comes from a different context) and we will be able to remove the copy.
This fixes a critical bug where values could be mutated from a BUILD file
and affect other BUILD files.
--
MOS_MIGRATED_REVID=105400506
|
|
|
|
|
|
|
|
| |
This is currently not hooked up, and we're passing (potentially) massive
numbers of targets around.
--
MOS_MIGRATED_REVID=105395404
|
|
|
|
|
|
|
| |
No need for this, remove to cut out some cruft/room for accidents.
--
MOS_MIGRATED_REVID=105378202
|
|
|
|
|
|
|
|
|
| |
Uses an AtomicLong to count remaining tasks. Only obtains the
zeroRemainingTasks lock when remaining tasks have gone to zero or
the codepath needs to wait on that condition.
--
MOS_MIGRATED_REVID=105348523
|
|
|
|
|
|
|
|
|
|
| |
Removes unnecessary final keyword on private methods, inlines the
un-overridden protected method getWorkQueue, and restructures internal
constructors to be flatter (i.e. every constructor implementation calls
at most one other constructor).
--
MOS_MIGRATED_REVID=105344413
|
|
|
|
|
|
|
|
| |
Re-adds the missing execution phase statistics which got lost in the
recent ProfileCommand refactoring.
--
MOS_MIGRATED_REVID=105340677
|
|
|
|
|
|
|
| |
Previously, only ThreadPoolExecutor implementations were allowed.
--
MOS_MIGRATED_REVID=105340237
|
|
|
|
|
|
|
|
|
| |
result.
This is a step in the right direction towards the goal of opening and reading each BUILD file exactly once.
--
MOS_MIGRATED_REVID=105338761
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Broke bazel build.
*** Original change description ***
Update iossim for Xcode 7 support.
As of Xcode 7, supportedDeviceTypesByName was replaced by supportedDeviceTypesByAlias.
This is from latest chromium build.
Downstream hash is 9dd179a339c0457f8754069e0774b38f69c258a8.
The latest merge was to upstream ef05b7da00844c0d500c4a7f20d4095dab56e7fe
***
Also includes the following changes:
Size the Lexer tokenization to minimize internal resizing. This value is chosen empirically.
--
Fixes toolchain selection in the generated Android NDK crosstools by making
each target_cpu and compiler field unique.
Note that there are some problems with the clang compilers (e.g. can't find ld), which I'll fix in a subsequent change.
--
Update iossim for Xcode 7 support.
As of Xcode 7, supportedDeviceTypesByName was replaced by supportedDeviceTypesByAlias.
This is from latest chromium build.
Downstream hash is 9dd179a339c0457f8754069e0774b38f69c258a8.
The latest merge was to upstream ef05b7da00844c0d500c4a7f20d4095dab56e7fe
--
MOS_MIGRATED_REVID=105337154
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before:
ERROR: No toolchain found for cpu 'x84'.
After:
ERROR: No toolchain found for cpu 'x84'. Valid cpus are: [
armeabi,
armeabi-v7a,
armeabi-v7a-hard,
armeabi-thumb,
armeabi-v7a-thumb,
armeabi-v7a-hard-thumb,
arm64-v8a,
mips,
mips64,
x86,
x86_64,
].
--
MOS_MIGRATED_REVID=105324190
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
legible by putting each flag combination on its own line.
E.g. from this:
ERROR: No toolchain found for --cpu='foo' --compiler='bar' --glibc='baz'. Valid toolchains are: [ --cpu='armeabi-v7a' --compiler='compiler' --glibc='armeabi-v7a', --cpu='armeabi-v7a' --compiler='compiler' --glibc='armeabi-v7a', --cpu='local' --compiler='compiler' --glibc='local', --cpu='darwin' --compiler='compiler' --glibc='macosx', --cpu='freebsd' --compiler='compiler' --glibc='local', --cpu='k8' --compiler='windows_mingw' --glibc='local', --cpu='k8' --compiler='windows_msys64_mingw64' --glibc='local', --cpu='k8' --compiler='windows_clang' --glibc='local',].
to this:
ERROR: No toolchain found for --cpu='foo' --compiler='bar' --glibc='baz'. Valid toolchains are: [
--cpu='armeabi-v7a' --compiler='compiler' --glibc='armeabi-v7a',
--cpu='armeabi-v7a' --compiler='compiler' --glibc='armeabi-v7a',
--cpu='local' --compiler='compiler' --glibc='local',
--cpu='darwin' --compiler='compiler' --glibc='macosx',
--cpu='freebsd' --compiler='compiler' --glibc='local',
--cpu='k8' --compiler='windows_mingw' --glibc='local',
--cpu='k8' --compiler='windows_msys64_mingw64' --glibc='local',
--cpu='k8' --compiler='windows_clang' --glibc='local',
].
(notice there is a duplicate toolchain)
--
MOS_MIGRATED_REVID=105313547
|
|
|
|
|
|
|
| |
referenced via "//external:android/xyz_v7"
--
MOS_MIGRATED_REVID=105313228
|