| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 202677272
|
|
|
|
|
|
|
|
| |
non-empty set of output files. This would catch a degenerate case when for some
reaon an empty was returned.
RELNOTES: None.
PiperOrigin-RevId: 202672729
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If a SkyFunction read a value (or its absence) from the graph during its
evaluation, that value will be used to compute the event and post
metadata for that evaluation.
This CL modifies the assertion strategy for this code. Previously,
registered deps which were not done would have gone undetected, and
their events/posts skipped.
This CL also makes a few minor changes that make SkyFunctionEnvironment
more consistent:
- Deps not already in previouslyRequestedDepsValues are added to
newlyRequestedDeps regardless of whether evaluation was in
error bubbling or whether the dep was done.
- Previously requested deps of an inflight node are prefetched (by
passing them to SkyFunctionEnvironment's ctor) during error bubbling in
the same way as they are during normal eval or cycle checking.
- Minor signature and documentation adjustments.
RELNOTES: None.
PiperOrigin-RevId: 202672709
|
|
|
|
|
|
|
|
|
|
| |
This is done so that we can check whether the current target can use the C++
Skylark API.
Rolling forward: BlazeInvocationPolicy is not used in host configuration. We simply ignore host configuration and not give an error when we are building there.
RELNOTES:none
PiperOrigin-RevId: 202652552
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[Rolling forward https://github.com/bazelbuild/bazel/commit/c4e128e2c6d8cacaeba034d6a3195796d50f1745]
java_common.compile doesn't generate the output source jar when a source jar is
the only input for the compilation. This is wrong because the source jar can
include APT generated sources. It is also inconsistent with java_library and
leads to inconsistent Skylark rules where a declared output will not always have a
generating action.
This new behavior is guarded by a new flag --incompatible_generate_javacommon_source_jar.
RELNOTES: None.
PiperOrigin-RevId: 202648346
|
|
|
|
| |
PiperOrigin-RevId: 202644128
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks tests: b/110978519
*** Original change description ***
C++: Adds ctx to cc_link_params creation.
This is done so that we can check whether the current target can use the C++
Skylark API.
RELNOTES:none
PiperOrigin-RevId: 202643988
|
|
|
|
|
|
|
| |
test packages.
RELNOTES: None.
PiperOrigin-RevId: 202642995
|
|
|
|
| |
PiperOrigin-RevId: 202642497
|
|
|
|
|
|
|
|
| |
This is done so that we can check whether the current target can use the C++
Skylark API.
RELNOTES:none
PiperOrigin-RevId: 202632582
|
|
|
|
|
|
|
| |
The current logic could fail due to StringIndexOutOfBoundsException because of calling version.substring(0, -1). The system property "java.version" could be a single integer that does not contain dot.
RELNOTES: None
PiperOrigin-RevId: 202578981
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This ensures that if a SkyFunction read a value (or its absence) for a
dep during its evaluation, subsequent requests for that dep's value (or
its absence) provide the same result.
This does not yet necessarily apply to the process of collecting events
and posts from a node's deps, which will be considered in a future
refactoring.
This CL adds SkyFunctionEnvironment#removeUndoneNewlyRequestedDeps
because the prior strategy for removing undone deps for done parents, by
re-requesting the dep's node from the graph and checking its doneness,
could lead to deps being dropped from parents if those deps transitioned
from done to dirty as the parent completes.
Minor cleanup to the bubbleErrorInfo field, which is nullable, and now
documented.
(Note that done->dirty node transitions during evaluation are planned,
but not yet possible.)
RELNOTES: None.
PiperOrigin-RevId: 202577098
|
|
|
|
|
|
|
|
| |
Closes #5307
Closes #5455.
PiperOrigin-RevId: 202567483
|
|
|
|
|
|
|
| |
Skydoc will generate documentation for all rule definitions in the transitive dependencies of the given input file.
RELNOTES: None.
PiperOrigin-RevId: 202553088
|
|
|
|
|
|
|
| |
These fakes won't behave at all like real implementations at this time. In fact, invoking some of their methods (or accessing their fields) may result in an error. This serves, however, as the initial check-in which can be iterated on and improved later.
RELNOTES: None.
PiperOrigin-RevId: 202525168
|
|
|
|
|
| |
RELNOTES: --[no]allow_undefined_configs no longer exists, passing undefined configs is an error.
PiperOrigin-RevId: 202518987
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SkyFunctionEnvironment only cares about directDeps' values, not other
NodeEntry data.
This reduces the space of code which could be sensitive to nodes which
transition from done to dirty during evaluation.
To prevent check-then-act races in the refactored code (and only there;
other code will be fixed in future refactorings), instead of checking
deps' isDone() methods before accessing their value, allow
getValueMaybeWithMetadata to be called when not done, and have it return
null when not done.
(Note that done->dirty node transitions during evaluation are planned,
but not yet possible.)
RELNOTES: None.
PiperOrigin-RevId: 202518781
|
|
|
|
| |
PiperOrigin-RevId: 202514441
|
|
|
|
|
|
|
|
| |
The short-circuiting code was pulled into the !keepGoing conditional
block inadvertently.
RELNOTES: None.
PiperOrigin-RevId: 202505510
|
|
|
|
|
|
| |
and avoid needlessly copying lists.
PiperOrigin-RevId: 202504396
|
|
|
|
|
|
|
| |
This will allow us to reuse the code for the action graph query in a later CL.
RELNOTES: None
PiperOrigin-RevId: 202500176
|
|
|
|
|
|
|
|
|
|
| |
This will be enforced by annotation processor.
This will be followed up, along with turndown of mandatoryPositionals, by
removing the intepreter code which infers the correct number and type of parameters.
RELNOTES: None.
PiperOrigin-RevId: 202499089
|
|
|
|
|
| |
RELNOTES:none:
PiperOrigin-RevId: 202491609
|
|
|
|
|
|
| |
RELNOTES:none
PiperOrigin-RevId: 202483718
|
|
|
|
|
|
|
| |
Closes #5478.
Change-Id: I3ac44605ef16a7c2e6bdc63d26fdf968bef651aa
PiperOrigin-RevId: 202482493
|
|
|
|
|
|
|
|
| |
Make ObjcRuleClasses uses CppRuleClasses.ccToolchainAttribute label resolver.
Mark CppRuleClasses.ccToolchainAttribute with @AutoCodec annotation.
RELNOTES:none
PiperOrigin-RevId: 202479836
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an implementation of the design at
https://docs.google.com/document/d/1g91BWJITcYw_X-VxsDC0VgUn5E9g0kRBGoBSpoO41gA/edit>.
More thorough documentation will be sent in a separate cl. The api was approved
at
https://docs.google.com/document/d/1M8JA7kzZnWpLZ3WEX9rp6k2u_nlwE8smsHYgVTSSJ9k/edit?ts=5b292400#.
Work towards #4571 (only the docs are missing).
RELNOTES: None.
PiperOrigin-RevId: 202464331
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
fix forward
*** Original change description ***
PiperOrigin-RevId: 202441346
|
|
|
|
| |
PiperOrigin-RevId: 202400312
|
|
|
|
| |
PiperOrigin-RevId: 202389874
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 202386363
|
|
|
|
|
|
|
|
|
| |
This is a much cleaner, more elegant approach than previous regex matching.
This still leaves room for unknown-name rule definitions, in case, for example, a user namespaces their rule definition not at the top level.
For example: "foo.bar = rule(...)"
RELNOTES: None.
PiperOrigin-RevId: 202380975
|
|
|
|
|
|
| |
FeatureConfiguration.
PiperOrigin-RevId: 202363333
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 202360925
|
|
|
|
|
|
|
|
|
|
| |
If there are multiple modules with the same name:
- If only one is marked 'documented', that one takes precedence.
- If one is a subclass of the others, the subclass takes precedence.
- Otherwise, an exception is thrown.
RELNOTES: None.
PiperOrigin-RevId: 202359443
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 202325860
|
|
|
|
|
|
| |
unless necessary.
PiperOrigin-RevId: 202317115
|
|
|
|
| |
PiperOrigin-RevId: 202311773
|
|
|
|
|
|
|
|
|
| |
The Skylark constructor of CcCompilationInfo now accepts headers. This may be
the last piece needed to get a working prototype of foreign C++ libraries. Next
step would be open sourcing the sandwich.
RELNOTES:none
PiperOrigin-RevId: 202306252
|
| |
|
| |
|
|
|
|
|
|
|
| |
of DefaultInfo() was used.
RELNOTES: None.
PiperOrigin-RevId: 202192091
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This skydoc rewrite uses an actual skylark interpreter with a faked build API (implementing the actual build API that Bazel uses).
There's a lot left to do here, this is a barebones start.
For example, this does not yet handle:
- load() statements
- non-global build API elements (e.g. apple_common)
- output of any rule information other than attribute names
- markdown output format
RELNOTES: None.
PiperOrigin-RevId: 202187207
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 202167782
|
|
|
|
|
|
|
|
| |
Logger messages aren't printed to the console, they're written to /usr/local/google/tmp, and can be prohibitively large for these debug server logs.
Instead I'm going with your original suggestion in https://github.com/bazelbuild/bazel/commit/b74922932b25a71c626b47ea9a9afb7dbc506cec, and selectively suppressing debug events by wrapping the EventHandler on the way in to SkylarkDebugServer.
PiperOrigin-RevId: 202166571
|
|
|
|
|
|
|
|
|
| |
Consolidate the creation of JavaCompilationArgsProviders, and avoid explicit
handling of the 'direct' and 'recursive' cases in clients. Also add some
higher-level methods to the builder API to support adding dependencies
with dep/export/runtime_dep-like semantics.
PiperOrigin-RevId: 202166383
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 202162804
|
|
|
|
|
|
|
|
|
| |
CppCompileAction.discoverInputsStage2 retrieves values of discovered modules
from ActionExecutionValue.
This addresses a possible a correctness issue.
PiperOrigin-RevId: 202162180
|
|
|
|
| |
PiperOrigin-RevId: 202151257
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 202150316
|