| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks 'blaze query'
*** Original change description ***
Skylark: write labels readably
Write a label as Label("//x:x") instead of merely "//x:x", so it can be read
and evaluated back, as per the Python convention. However, the OutputFormatter
for BUILD files still needs to output "//x:x".
--
MOS_MIGRATED_REVID=97156166
|
|
|
|
|
|
|
| |
XcodeGen.
--
MOS_MIGRATED_REVID=97145288
|
|
|
|
|
|
|
| |
Otherwise this may cause collisions in the final bundle.
--
MOS_MIGRATED_REVID=97132278
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97131151
|
|
|
|
|
|
|
| |
This was only used in error reporting, and the interface of BuildConfiguration could use some more simplicity. The comment on BuildConfiguration.getShortName() was confusing: that field is *not* actually used to compute the output directory name, which took me a few minutes to realize.
--
MOS_MIGRATED_REVID=97128287
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97126283
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97125970
|
|
|
|
|
|
|
| |
"local" spawn strategy.
--
MOS_MIGRATED_REVID=97124055
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97121724
|
|
|
|
|
|
|
|
|
| |
Bazel unconditionally loads all the labels in configurations for now, and we don't want Android stuff to be loaded if the build doesn't have anything to do with Android. The alternative would be to fix this by not loading all configuration fragments, but this is the more expedient solution.
The SDK will be dealt with by binding //external:android/sdk to a dummy SDK unless overridden by an android_sdk_repository rule.
--
MOS_MIGRATED_REVID=97116824
|
|
|
|
|
|
|
|
|
|
|
| |
.checksum() method that is computed from the checksum of the build options. Also remove Fragment.cacheKey() and Fragment.getName().
The reasoning is that within a single build, if two BuildConfigurations share the same BuildOptions, they must be the same because BuildConfiguration can only be a function of BuildOptions, specific targets (which stay the same during a build) and BlazeDirectories (which stay the same during the lifetime of a server). Between different builds if the configurations are recreated, they will always be considered different because Java reference equality (==) is used for comparing BuildConfigurations.
Also remove "Serializable" tags from configuration-related things.
--
MOS_MIGRATED_REVID=97107881
|
|
|
|
|
|
|
| |
Creating the split configurations in Bazel uncovered an incrementality issue: ConfigurationFactory.hostConfigCache kept state between builds untracked by Skyframe, which is not good, and therefore had to be fixed.
--
MOS_MIGRATED_REVID=97106917
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=97022077
|
|
|
|
|
|
|
|
|
| |
Dynamic configuration transitions require access to Skyframe (since they instantiate BuildConfigurations as Skyframe nodes). There are various places in Bazel where static transitions are done with no convenient Skyframe access. This cl shuffles host transitions, in particular, to places that are more amenable.
This change also assumes one host configuration per invocation. While this isn't strictly true (each target configuration can have its own host, and multiple target configurations are possible per build), we don't leverage that functionality in any meaningful way today. So until we have a proper interface for multiple host configurations, let's not block dynamic config progress on it.
--
MOS_MIGRATED_REVID=97008479
|
|
|
|
|
|
|
| |
by reducing the size of the final dwp action.
--
MOS_MIGRATED_REVID=97004508
|
|
|
|
|
|
|
|
|
| |
concurrency abstractions.
Care is taken to maintain the invariant that the glob result returns after all of the work is done, even if there was an exception that cuts the task short. Interruption is an exception to this: In this case, the GlobCache later cancels the task and ensures it is done.
--
MOS_MIGRATED_REVID=97000506
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=96991829
|
|
|
|
|
|
|
| |
This CL makes me so unhappy. As a follow up, I may rename BaseRule and/or RuleBase. Because seriously, you guys, naming.
--
MOS_MIGRATED_REVID=96990894
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=96989486
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=96974643
|
|
|
|
|
|
|
| |
separate calls to skyframeExecutor for each target patterns, all of them are computed in one call.
--
MOS_MIGRATED_REVID=96973513
|
|
|
|
|
|
|
|
|
| |
- Braces can now be escaped ('{{' and '}}')
- In addition to named arguments, both manual ('{0}') and automatic ('{}') positional replacement fields are supported
- An error related to specific regex characters (such as '$') was fixed
--
MOS_MIGRATED_REVID=96971731
|
|
|
|
|
|
|
| |
This feature is tunable through --worker_max_changed_files flag. If unspecified, all builds are considered incremental.
--
MOS_MIGRATED_REVID=96968367
|
|
|
|
|
|
|
| |
Fixes #261.
--
MOS_MIGRATED_REVID=96967085
|
|
|
|
|
|
|
| |
Escapes several of the paths, and gets rid of hardcoding bash -c in several locations.
--
MOS_MIGRATED_REVID=96927479
|
|
|
|
|
|
|
|
|
| |
Removing since we don't appear to need it. Replaced SkyFunctionName.computed
with create to simplify changing everything. Moved all constructors using new
to use create for consistency. Chose create over new since it was less changes.
--
MOS_MIGRATED_REVID=96914199
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Ended up not being necessary; I was able to rephrase things using SettableFuture instead.
*** Original change description ***
Introduce a simple concurrent Multimap-like data structure with reference counting.
--
MOS_MIGRATED_REVID=96884190
|
|
|
|
|
|
|
|
|
|
|
| |
be loaded.
This avoids having to materialize the full universe scope in memory when doing an rdeps query over "//...".
Another option considered was special-casing the string "//..." if it was the first argument to rdeps, but this seemed cleaner.
--
MOS_MIGRATED_REVID=96878999
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor code used for extracting documentation from rule classes into separate class.
Todo after this CL:
* Use RuleDocumentation and RuleDocumentationAttribute directly in .vm templates to further simplify BuildEncyclopediaProcessor code
* Use VTL #include for including common attribute documentation
* Split BE into multiple pages
* Use templating for Skylark Library
--
MOS_MIGRATED_REVID=96865477
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=96835732
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Broke a test
*** Original change description ***
experimental_ios_test: Support data dependencies
This CL makes me so unhappy. As a follow up, I may rename BaseRule and/or RuleBase. Because seriously, you guys, naming.
--
MOS_MIGRATED_REVID=96804486
|
|
|
|
|
|
|
| |
This CL makes me so unhappy. As a follow up, I may rename BaseRule and/or RuleBase. Because seriously, you guys, naming.
--
MOS_MIGRATED_REVID=96795834
|
|
|
|
|
|
|
|
|
|
|
| |
This moves the WORKSPACE-parsing code out of WorkspaceFileFunction.java so
generate_workspace can parse a WORKSPACE into an ExternalPackage without having
to muck with Skyframe.
Addresses issue #89.
--
MOS_MIGRATED_REVID=96777708
|
|
|
|
|
|
|
| |
Add 'args' to the list (for consistency with native rules).
--
MOS_MIGRATED_REVID=96776585
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=96765288
|
|
|
|
|
|
|
| |
-client is now the only default JVM options of JavaBuilder
--
MOS_MIGRATED_REVID=96762330
|
|
|
|
|
|
|
| |
AndroidTools is not passed around anymore. This comes at the cost of having to remember to raise an error in every rule configured target factory, but I think this is preferable to shuttling a variable around.
--
MOS_MIGRATED_REVID=96746874
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=96703011
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=96680754
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=96663796
|
|
|
|
|
|
|
|
| |
Adds them to TargetPatternResolverUtil alongside other useful target
parsing utility functions.
--
MOS_MIGRATED_REVID=96611975
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=96606040
|
|
|
|
|
|
|
| |
characters (such as '.' or '\w') will no longer match other characters.
--
MOS_MIGRATED_REVID=96603729
|
|
|
|
|
|
|
|
|
|
|
|
| |
--objc_enable_binary_stripping are specified:
1. Symbol strippings. A new strip action is registered that uses Darwin tool /usr/bin/strip to remove the symbol table of the linked binary.
2. Dead-code strippings, which uses linker flag "--dead_strip" to remove unreachable code in binary link action.
RELNOTES: Add a flag "objc_enable_binary_stripping" to enable symbol and dead code strippings on linked binaries generated by ObjC rules.
--
MOS_MIGRATED_REVID=96587585
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is important to build packages of bazel-built code, especially
python.
Simple example usage:
def _runfiles_test_impl(ctx):
runfiles_provider = provider(ctx.attr.src, 'analysis.RunfilesProvider')
runfiles = runfiles_provider.default_runfiles.artifacts
commands = []
for f in runfiles:
commands += [
'mkdir -p $(dirname %s/%s)' % (ctx.outputs.outdir.path, f.short_path),
'cp %s %s/%s' % (f.path, ctx.outputs.outdir.path, f.short_path),
]
ctx.action(
outputs = [ ctx.outputs.outdir ],
inputs = list(runfiles),
command = ' && '.join(commands)
)
'''A simple rule which copies all the runfiles from src into outdir.'''
runfiles_buildtest = rule(
implementation = _runfiles_test_impl,
attrs = {
'src': attr.label(allow_files=False, mandatory=True),
'outdir': attr.output(mandatory=True),
},
)
--
Change-Id: I8fbd4c6ea462685142cf199dfe3348bc4436cdcb
Reviewed-on: https://bazel-review.googlesource.com/1530
MOS_MIGRATED_REVID=96576360
|
|
|
|
|
|
|
| |
Fixes #241
--
MOS_MIGRATED_REVID=96573740
|
|
|
|
|
|
|
| |
Also adds tests for it.
--
MOS_MIGRATED_REVID=96572991
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks ios_test targets.
*** Original change description ***
Add two binary size optimizations when --compilation_mode=opt is specified:
1. Symbol strippings. A new strip action is registered that uses Darwin tool /usr/bin/strip to remove the symbol table of the linked binary.
2. Dead-code strippings, which uses linker flag "--dead_strip" to remove unreachable code in binary link action.
RELNOTES: Perform symbol and dead code strippings on linked binaries generated by ObjC rules.
--
MOS_MIGRATED_REVID=96551473
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=96439703
|
|
|
|
|
|
|
| |
No need for it to be otherwise.
--
MOS_MIGRATED_REVID=96437024
|