| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If linkstatic was explicitly set to 0 for a non-test target, we didn't set
CcLibraryHelper to create CcLinkOutputs, but would still try to link those in
instead of the compile output. Instead, pull out a variable that puts this
logic into a single spot.
Also rename the flag to --experimental_link_compile_output_separately, which
IMO makes slightly more sense. Not too important as I don't think we should
keep this flag long-term anyway.
--
PiperOrigin-RevId: 144194903
MOS_MIGRATED_REVID=144194903
|
|
|
|
|
|
|
|
|
|
| |
agent through the $jacocorunner dependency.
They are either both linked in or neither of them is, so there isn't much point in separating them.
--
PiperOrigin-RevId: 144191570
MOS_MIGRATED_REVID=144191570
|
|
|
|
|
|
|
|
|
|
| |
This is part of a series of changes to clean up the test strategies; this
specific change is a Google-internal refactoring. I'm planning to also update
the external test strategies subsequently.
--
PiperOrigin-RevId: 144184752
MOS_MIGRATED_REVID=144184752
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144181101
MOS_MIGRATED_REVID=144181101
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks bazel-docker-tests
http://ci.bazel.io/view/Dashboard/job/bazel-docker-tests/lastCompletedBuild/BAZEL_VERSION=HEAD,PLATFORM_NAME=docker/console
*** Original change description ***
Enable header compilation by default
--
PiperOrigin-RevId: 144176396
MOS_MIGRATED_REVID=144176396
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144127414
MOS_MIGRATED_REVID=144127414
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144108788
MOS_MIGRATED_REVID=144108788
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144107395
MOS_MIGRATED_REVID=144107395
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Still breaks //src/test/shell/bazel:bazel_test_test
http://ci.bazel.io/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/lastCompletedBuild/testReport/(root)/(empty)/test_test_timeout/
--
PiperOrigin-RevId: 144107285
MOS_MIGRATED_REVID=144107285
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks //src/test/shell/bazel:persistent_test_runner_test
http://ci.bazel.io/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/lastBuild/testReport/junit/(root)/(empty)/test_simple_scenario/
*** Original change description ***
Also add the duration as the test process time.
Technically, this code is incorrect, because we're calling into spawn strategy,
which might do any amount of additional waiting (e.g., to acquire local
resources). We should change spawn strategy to return structured information
about the subprocess execution, including the wall time, and use that to set
the test information. But for now, this seems good enough.
Fixes #1748.
--
PiperOrigin-RevId: 144096164
MOS_MIGRATED_REVID=144096164
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The environment is now computed with a mixture of the client environment and
the values specified by the --action_env flag. If a user want to overwrite its
environment for skylark repository, they can do `--action_env FOO=BAR` and
the repository will see FOO as having the value BAR, whichever value is
set in the client environment.
Also propagate it to all repository functions, and deduplicate the way
the client environment is passed to repository functions.
Design doc: https://bazel.build/designs/2016/10/18/repository-invalidation.html [step 1]
RELNOTES[INC]: repository_ctx environment is now affected by --action_env flag (value from the
client environment will be replaced by value given on the command line through --action_env).
--
Change-Id: I131a9695439aa9949d5001f820e2ae450e41332f
Reviewed-on: https://cr.bazel.build/7971
PiperOrigin-RevId: 144091492
MOS_MIGRATED_REVID=144091492
|
|
|
|
|
|
|
|
|
|
|
| |
Since it's already a no-op after the latest release
this should be harmless...
R=ahumesky
--
PiperOrigin-RevId: 144088752
MOS_MIGRATED_REVID=144088752
|
|
|
|
|
|
|
|
|
|
| |
Create the test spawn upfront instead of lazily. In the common case, this
doesn't cost anything, but the worker test strategy doesn't use the spawn
right now.
--
PiperOrigin-RevId: 144086321
MOS_MIGRATED_REVID=144086321
|
|
|
|
|
|
|
|
|
|
| |
licenses.
Also flipped :jvm attribute from HOST to TARGET and set the new flag on it.
--
PiperOrigin-RevId: 144084000
MOS_MIGRATED_REVID=144084000
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Technically, this code is incorrect, because we're calling into spawn strategy,
which might do any amount of additional waiting (e.g., to acquire local
resources). We should change spawn strategy to return structured information
about the subprocess execution, including the wall time, and use that to set
the test information. But for now, this seems good enough.
Fixes #1748.
--
PiperOrigin-RevId: 144082073
MOS_MIGRATED_REVID=144082073
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144074221
MOS_MIGRATED_REVID=144074221
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144072456
MOS_MIGRATED_REVID=144072456
|
|
|
|
|
|
|
|
|
| |
This cl exposes param files that were hard-coded before. This enables more
precise placement on the link command line.
--
PiperOrigin-RevId: 144069927
MOS_MIGRATED_REVID=144069927
|
|
|
|
|
|
|
|
| |
RELNOTES[INC]: Deprecated globals HOST_CFG and DATA_CFG are removed. Use strings "host" and "data" instead.
--
PiperOrigin-RevId: 144069794
MOS_MIGRATED_REVID=144069794
|
|
|
|
|
|
|
|
|
|
| |
This is part of a sequence of changes to update the test strategies; most of
the actual code changes in this specific change is Google-internal, but I'm
planning to update the external test strategies as well.
--
PiperOrigin-RevId: 144064802
MOS_MIGRATED_REVID=144064802
|
|
|
|
|
|
|
|
|
| |
For now, only for aspects, but eventually expand to Attribute's
mandatory providers as well.
--
PiperOrigin-RevId: 144063369
MOS_MIGRATED_REVID=144063369
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. no flag: only the direct reason is given (command execution termination status), and also the instruction to use "--verbose_failures"
2. flag "--verbose_failures": gives failed execution command and the instruction to use "--sandbox_debug --strategy"
3. flag "--verbose_failures --sandbox_debug": gives failed execution command, debugging message from sandboxing, and the instruction to use "--strategy"
Also removes "cd <sandbox_path>" in given failed command, since debugging is only necessary with flag "--verbose_failures --sandbox_debug" and the path is already given in sandboxing debugging message.
Addresses #2174.
Fixes bazel_sandboxing_test.sh and bazel_test_test.sh for the new error message.
--
PiperOrigin-RevId: 144058351
MOS_MIGRATED_REVID=144058351
|
|
|
|
|
|
|
|
| |
No production code should depend on inmemoryfs.
--
PiperOrigin-RevId: 144054981
MOS_MIGRATED_REVID=144054981
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144054816
MOS_MIGRATED_REVID=144054816
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 144010091
MOS_MIGRATED_REVID=144010091
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143991903
MOS_MIGRATED_REVID=143991903
|
|
|
|
|
|
|
|
| |
* Also make constants private since they both have getters now.
--
PiperOrigin-RevId: 143973536
MOS_MIGRATED_REVID=143973536
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143972504
MOS_MIGRATED_REVID=143972504
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
== Before this change ==
Previously, if a and b are sets, then a + b created a new set c whose direct and transitive elements were all those of a, and with b appended as an additional transitive element. If on the other hand b is a list instead of a set, then its contents were appended as additional direct elements of c. In both cases, you can think of c as a copy of a that also knows about b.
This copying of a's elements into c can lead to accumulation when you do it repeatedly, e.g. x += y in a loop. Each union can take O(n) time so you get O(n^2) time overall. Nested set union is supposed to be O(1) time per operation and O(n) time overall.
It also leads to surprising iteration orders. If you do a + b + c + d (left-associative), where each one is a set, then when you do a post-order traversal you get the elements of b, c, d, and a, in that order. This is because b, c, and d each get appended as transitive children of the copies of a.
== After this change ==
If a and b are sets, then a + b returns a new set c with a and b as its two transitive children. If b is a list, then c has a as its only transitive child and b's elements as its only direct elements. This is straightforward, O(1), and avoids the problem with the confusing order.
It is implemented by removing the items/transitiveItems fields and just relying on NestedSetBuilder.
RELNOTES[INC]: (Skylark) Set union is now O(1). As a side-effect, the iteration order of sets produced by union has changed. "print(set([1]) + set([2]) + set([3]))" will now give back the order 1, 2, 3 instead of 2, 3, 1.
--
PiperOrigin-RevId: 143972165
MOS_MIGRATED_REVID=143972165
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes #2311
Closes #2312.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/2312
PiperOrigin-RevId: 143967880
MOS_MIGRATED_REVID=143967880
|
|
|
|
|
|
|
|
| |
The skylark provider is bound as "proto_java" to avoid collisions with the base, which is called "java".
--
PiperOrigin-RevId: 143960605
MOS_MIGRATED_REVID=143960605
|
|
|
|
|
|
|
|
|
|
| |
This feature allows us to expand a flag_group when a build variable is not
available. This is helpful when migrating crosstools in a backward compatible
way (that works with released bazel as well as with bazel at HEAD).
--
PiperOrigin-RevId: 143955333
MOS_MIGRATED_REVID=143955333
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks //src/test/shell/bazel:bazel_sandboxing_test:
http://ci.bazel.io/job/bazel-tests/lastCompletedBuild/BAZEL_VERSION=latest-jdk7,PLATFORM_NAME=linux-x86_64/testReport/(root)/(empty)/test_failing_action_with_ioexception_while_copying_outputs_throws_correct_exception/
*** Original change description ***
Gives 3 levels of sandbox error message under different flags.
1. no flag: only the direct reason is given (command execution termination status), and also the instruction to use "--verbose_failures"
2. flag "--verbose_failures": gives failed execution command and the instruction to use "--sandbox_debug --strategy"
3. flag "--verbose_failures --sandbox_debug": gives failed execution command, debugging message from sandboxing, and the instruction to use "--strategy"
Also removes "cd <sandbox_...
***
ROLLBACK_OF=143937589
--
PiperOrigin-RevId: 143951901
MOS_MIGRATED_REVID=143951901
|
|
|
|
|
|
|
|
|
| |
We were previously jumping through hoops to avoid cyclic dependencies. It's
unclear why the class was here in the first place rather than in lib.actions.
--
PiperOrigin-RevId: 143948959
MOS_MIGRATED_REVID=143948959
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143939410
MOS_MIGRATED_REVID=143939410
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. no flag: only the direct reason is given (command execution termination status), and also the instruction to use "--verbose_failures"
2. flag "--verbose_failures": gives failed execution command and the instruction to use "--sandbox_debug --strategy"
3. flag "--verbose_failures --sandbox_debug": gives failed execution command, debugging message from sandboxing, and the instruction to use "--strategy"
Also removes "cd <sandbox_path>" in given failed command, since debugging is only necessary with flag "--verbose_failures --sandbox_debug" and the path is already given in sandboxing debugging message.
Addresses #2174.
--
PiperOrigin-RevId: 143937589
MOS_MIGRATED_REVID=143937589
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143936734
MOS_MIGRATED_REVID=143936734
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143933349
MOS_MIGRATED_REVID=143933349
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143823562
MOS_MIGRATED_REVID=143823562
|
|
|
|
|
|
|
|
| |
extension registry for the enclosing binary.
--
PiperOrigin-RevId: 143807030
MOS_MIGRATED_REVID=143807030
|
|
|
|
|
|
|
|
| |
The main effect is to cause cc_test rules to build into a self-contained executable rather than relying on external shared libraries. (cc_binary rules do this by default already.)
--
PiperOrigin-RevId: 143806513
MOS_MIGRATED_REVID=143806513
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143792017
MOS_MIGRATED_REVID=143792017
|
|
|
|
|
|
|
|
| |
changes are visibile to all other threads by volatility and we don't read the variable at any intermediate or inconsistent state (simply check against null or a constant). reverseDepsToSignal is also made volatile for subclasses that need volatile reads to it.
--
PiperOrigin-RevId: 143787032
MOS_MIGRATED_REVID=143787032
|
|
|
|
|
|
|
|
| |
outside of rule implementation.
--
PiperOrigin-RevId: 143720112
MOS_MIGRATED_REVID=143720112
|
|
|
|
|
|
|
|
| |
and 3 different binary types.
--
PiperOrigin-RevId: 143718198
MOS_MIGRATED_REVID=143718198
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TESTED=
$ ls android-ndk-r12b/platforms
android-12 android-15 android-18 android-22 android-9
android-13 android-16 android-19 android-23
android-14 android-17 android-21 android-24
RELNOTES: Removed broken api levels 3, 4 and 5 from Android NDK 12.
--
PiperOrigin-RevId: 143710544
MOS_MIGRATED_REVID=143710544
|
|
|
|
|
|
|
|
|
|
|
| |
Since we evaluate the BUILD file despite errors (e.g. parse errors), we
should provide the .bzl dependencies to the BUILD file.
This change removes some confusing/irrelevant error messages.
--
PiperOrigin-RevId: 143696291
MOS_MIGRATED_REVID=143696291
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Tests kept.)
*** Reason for rollback ***
[]
*** Original change description ***
When --experimental_oom_more_eagerly is enabled, tell Bazel to exit with an OutOfMemoryError and have the JVM send Bazel a SIGUSR2 when it detects an OOM. This should help in certain pathological cases when Bazel GC thrashes for some time after an OOM has been detected.
--
PiperOrigin-RevId: 143694970
MOS_MIGRATED_REVID=143694970
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143694257
MOS_MIGRATED_REVID=143694257
|
|
|
|
|
|
|
|
|
|
| |
This are random little nits that aren't dependent on changing the
directory structure, so it makes the (rather large) CL that is
coming cleaner.
--
PiperOrigin-RevId: 143690681
MOS_MIGRATED_REVID=143690681
|