| Commit message (Collapse) | Author | Age |
|
|
|
|
|
| |
inline constructor that did ServerDirectories creation inline: don't pollute production code for tests' convenience.
PiperOrigin-RevId: 168652349
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 168652131
|
|
|
|
|
|
| |
codec. Since PrecomputedValues can contain any value, give them access to an ObjectCodecs instance so we don't have to have a whitelist inside PrecomputedValueCodec.
PiperOrigin-RevId: 168624137
|
|
|
|
| |
PiperOrigin-RevId: 168607439
|
|
|
|
| |
PiperOrigin-RevId: 168583913
|
|
|
|
| |
PiperOrigin-RevId: 168583577
|
|
|
|
| |
PiperOrigin-RevId: 168579567
|
|
|
|
|
|
|
| |
They are just normal javacopts. The only user was Android databinding, so now we just merge databindings javacopts in with the rest of javacopts in AndroidCommon.
RELNOTES: None
PiperOrigin-RevId: 168578013
|
|
|
|
|
|
|
|
| |
categories of toolchains for the purpose of toolchain selection.
Up to now, we've used the native toolchain_type rule for this purpose. That rule depends on a number of configuration fragments that supply build variables - we don't want toolchains to need to depend on those fragments as well. E.g. toolchain_type depends on JvmConfiguration, but we would like toolchains to work with --experimental_disable_jvm.
PiperOrigin-RevId: 168577759
|
|
|
|
|
|
| |
This will be rolled forward with a different API.
PiperOrigin-RevId: 168566666
|
|
|
|
|
|
| |
In the long run it would be good to remove the Path class altogether.
PiperOrigin-RevId: 168560355
|
|
|
|
| |
PiperOrigin-RevId: 168452997
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 168444499
|
|
|
|
|
|
|
|
| |
With dynamic configurations we no longer need a special
class to apply transitions: a simple patch transition
bound to an attribute works just as well.
PiperOrigin-RevId: 168442602
|
|
|
|
|
|
| |
Also pipe keepGoing back into initial configuration creation.
PiperOrigin-RevId: 168412512
|
|
|
|
| |
PiperOrigin-RevId: 168406412
|
|
|
|
|
|
|
| |
These classes are mostly used during the options parsing process itself, and are barely a part of the options parser interface, so they really don't belong in OptionsParser.java. They are also about to change significantly, so taking this opportunity to split them out.
RELNOTES: None.
PiperOrigin-RevId: 168400162
|
|
|
|
|
|
|
|
| |
targets.
This is more in line with what I believe is considered a best practice these days.
PiperOrigin-RevId: 168396725
|
|
|
|
| |
PiperOrigin-RevId: 168389301
|
|
|
|
|
|
|
|
|
|
| |
If testing is requested, but no tests are found, the build is aborted.
Ensure that even in this case the steam of build events is internally
closed (i.e., all announced events are reported, the last event is marked
as such).
Change-Id: I88763ed6ccd7793deedbcb3428df7e8d289efa23
PiperOrigin-RevId: 168364127
|
|
|
|
|
|
| |
Root objects should not expose their absolute paths as they break hermeticity.
PiperOrigin-RevId: 168363549
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduce a new method BuildEventTransport#closeNow() which forcefully
closes the BES upload even if there are still events to upload. This
is executed if the bazel server is being shutdown.
The implementation in the BuildEventServiceTransport works by shutting
down the ExecutorService handling the upload, which in turn will
interrupt the upload thread, which in turn will cancel the streaming RPC.
The BuildEventServiceTransport will wait up to 100ms for that
cancellation to happen.
Also fix a bug where the BES transport would not wait for ACKS.
PiperOrigin-RevId: 168359947
|
|
|
|
| |
PiperOrigin-RevId: 168359681
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
runfiles middleman to the artifacts.
Runfiles.Builder.merge(RunfilesSupport) would add the runfiles
middleman of the RunfilesSupport object being merged into the
artifacts of the nascent Runfiles object. This effectively made the
construction of one runfiles tree depend on that of another.
Instead of putting the runfiles middleman into the runfiles artifacts,
we can put it into the FilesToRunProvider, which should have the same
effect. To facilitate this, RuleConfiguredTargetBuilder gains a
addFilesToRun method. Note that not every caller of
merge(RunfilesSupport) has to be modified because some were already
adding the runfiles middleman to their FilesProvider (e.g.,
AndroidHostServiceFixture), which is a subset of FilesToRunProvider.
This is split out from https://bazel-review.googlesource.com/c/14010
Change-Id: Icfca5262a32619e1e351477f3ff641350b6798dc
PiperOrigin-RevId: 168358030
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a generic retrier implementation (Retrier2) that can be
configured by plugging in a backoff strategy, a function to
decide on retriable errors and a circuit breaker. A concrete
implementation is added via RemoteRetrier that mostly is a
copy of the code of the existing Retrier.
Retrier2 adds support for circuit breaking [1]. It allows the
retrier to reject execution when failure rates are high. The
remote execution code will use this to gently switch between
local and remote execution/caching if the latter experiences
lots of failures.
Retrier2 is also useful when not used with gRPC. We need
retriers for the HTTP caching interface too.
All the code added in this CL is unused, to keep reviews
managable. In a follow up CL, I will switch the code to use
the new Retrier and delete the old retrier.
[1] https://martinfowler.com/bliki/CircuitBreaker.html
PiperOrigin-RevId: 168355597
|
|
|
|
|
|
| |
Closes #3697.
PiperOrigin-RevId: 168353082
|
|
|
|
|
|
|
|
|
| |
This cl removes hardcoded --sysroot flag generation from bazel when constructing
command line for C++ actions. The hardcoded flag is still exposed to Skylark (to
stay backwards compatible).
RELNOTES: None.
PiperOrigin-RevId: 168346711
|
|
|
|
| |
PiperOrigin-RevId: 168345699
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 168312474
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 168300744
|
|
|
|
|
|
|
| |
First commit in series, the second will make the necessary changes to the action.
RELNOTES: None
PiperOrigin-RevId: 168286654
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is that the linker will not produce the expected .params file output
if there are no inputs, and there is no need for this step in that case.
This required adding a method to check if there are any bitcode inputs to
the link either directly or indirectly via a library. This is the same walk done
by createLtoArtifacts once we decide to do an LTO indexing step.
RELNOTES: NONE
PiperOrigin-RevId: 168281516
|
|
|
|
|
|
| |
This whole CL was done using IDE refactoring tools and should be safe.
PiperOrigin-RevId: 168275575
|
|
|
|
|
|
| |
Part of the static config cleanup effort.
PiperOrigin-RevId: 168270713
|
|
|
|
|
|
|
| |
PackageFunction constructors is only used in tests and annotate the missing variable.
RELNOTES: None.
PiperOrigin-RevId: 168265593
|
|
|
|
|
|
|
| |
Now that we have a standard way of referring to an option, remove all of the places that we were referring to them by their name. Since options can have multiple names, this is more clear and provides the additional information needed to understand the option. It also stops the habit of requesting unqualified strings, which was hard to read.
RELNOTES: None.
PiperOrigin-RevId: 168254584
|
|
|
|
|
|
| |
available from BuildViewTestCase#getRuleContext
PiperOrigin-RevId: 168231020
|
|
|
|
|
|
|
|
|
| |
This cl adds flags from --per_file_copts option to 'user_compile_flags' build
variable. This changes the flag order, before they appeared after unfiltered
flags, now they appear before.
RELNOTES: None.
PiperOrigin-RevId: 168221663
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Introduced a UI regression.
See #3534.
*** Original change description ***
Avoid relying on System.out/err going to the terminal
Use an appropriate EventHandler instead.
PiperOrigin-RevId: 168218216
|
|
|
|
|
|
|
| |
getPotentialSplitTransitions() from FragmentOptions.
RELNOTES: None.
PiperOrigin-RevId: 168218102
|
|
|
|
|
|
|
| |
In https://github.com/bazelbuild/bazel/commit/ad42824ae02a1b2edbffe475246984e14af56dd0 the behavior changed, this cl just updates the documentation.
RELNOTES: None.
PiperOrigin-RevId: 168217183
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks BEP parsing in IntelliJ (b/65521927).
*** Original change description ***
bep: encode file paths in URI format
We need to ensure that special characters are encoded according to the
URI specification RFC2396.
Change-Id: Ie93cbe11a70f448d2e7bacd0bba5699ec20cac25
PiperOrigin-RevId: 168195227
|
|
|
|
| |
PiperOrigin-RevId: 168141877
|
|
|
|
|
|
|
|
|
|
|
| |
option name.
UnparsedOptionValueDescription and OptionValueDescription both had redundant information about options, since they tracked options by their names, and not their definition. Remove the redundancy.
For getEffectiveOptions, the old behavior was relying on the fact that all options were given allowmulitple=false, which was wrong, so stop passing in the default value where it would get confused with values that have been created and tracked by the options parser. Instead, passing value=null is the way to indicate that an option is unset.
RELNOTES: None.
PiperOrigin-RevId: 168038067
|
|
|
|
|
|
|
|
|
|
| |
option lists.
Tracking the names together for option identification was useful, but then the same list was being used as the source of options for the parser, which lead to some options being listed twice.
Also complete a few tests that should have already been tested in different orders.
PiperOrigin-RevId: 168024719
|
|
|
|
|
|
| |
Update the callers that only need getMetadata to use the new interface.
PiperOrigin-RevId: 167992239
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
user_compile_flags
Also add magic to a feature named 'unfiltered_compile_flags' so the flags
expanded from it are not subject to nocopt filtering.
This is encore of https://github.com/bazelbuild/bazel/commit/268c0bcbf79f9f3f72d95fa51af0f1b18c5ce29e that was rolled back because it regressed
memory.
RELNOTES: None.
PiperOrigin-RevId: 167989075
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 167986260
|
|
|
|
|
|
|
|
| |
PlatformConfiguration is made a legal configuration fragment for every rule class.
Add a default "dummy" c++ toolchain to prevent resolution errors when legacy toolchain selection logic is used. Add toolchain mocks to java and shell tests.
PiperOrigin-RevId: 167901210
|
|
|
|
|
|
|
|
| |
RELNOTES[INC]:
--incompatible_comprehension_variables_do_not_leak defaults to "true."
Iteration variable becomes inaccessible after a list/dict comprehension.
PiperOrigin-RevId: 167876119
|