| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88927024
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88925875
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88924033
|
|
|
|
|
|
|
| |
shortened.
--
MOS_MIGRATED_REVID=88922152
|
|
|
|
|
|
|
|
|
| |
unit tests and main code have fallen out of sync a few times, so
consolidating the defaults here to make mistakes harder later on.
one could argue this also gives a little better mental locality.
--
MOS_MIGRATED_REVID=88921641
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88917871
|
|
|
|
|
|
|
|
| |
Anyone who needs this kind of functionality in the future can redefine
it through user-defined constraints.
--
MOS_MIGRATED_REVID=88871811
|
|
|
|
|
|
|
| |
in
--
MOS_MIGRATED_REVID=88869446
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves pattern resolving logic from TargetPatternFunction.Resolver to
a top level class. Adds a layer of abstraction to the Resolver
implementation enabling it to be backed by either an Environment or
a Graph, for use in SkyFunction evaluation or on-the-fly evaluation,
respectively. Finally, SkyQueryEnvironment#preloadOrThrow now checks
to see if each target pattern exists in the graph, and any that
don't will be resolved on-the-fly.
--
MOS_MIGRATED_REVID=88861201
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88857682
|
|
|
|
|
|
|
|
|
| |
e.g. def foo(x, y): print(x); print(y)
Bug found when adding the pass statement.
--
MOS_MIGRATED_REVID=88852710
|
|
|
|
|
|
|
|
| |
Have actoolzip abs-ify the partial info plist path because otherwise it picks
seemingly random directories to which to output the info plist files.
--
MOS_MIGRATED_REVID=88851706
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88847172
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88836133
|
|
|
|
|
|
|
|
|
|
| |
Like python, print singleton tuples with a terminating comma before the closing
parenthesis, so you can read them back as tuples.
Also, have toString() call the pretty-printer for Skylark lists and tuples.
--
MOS_MIGRATED_REVID=88831764
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88830705
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88813915
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88789823
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88774665
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88764263
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88758470
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88755217
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88742425
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88739509
|
|
|
|
|
|
|
| |
to do a reverse lookup so that metadata can be more easily retrieved.
--
MOS_MIGRATED_REVID=88733565
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88730682
|
|
|
|
|
|
|
| |
RELNOTES: Allow ios_application in xctest_app attribute.
--
MOS_MIGRATED_REVID=88730548
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88727892
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88726457
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Broke one of our integration tests.
*** Original change description ***
Declare dependencies on discovered inputs before execution instead of after.
As a side effect, we no longer restart ActionExecutionFunction after the action has executed unless the action ran locally (and therefore didn't discover its inputs beforehand). This also means that we no longer need to store an out-of-Skyframe cache for discovered includes except when checking the action cache. Since my suspicion is that the out-of-Skyframe cache will have a minimal performance impact once it is just...
***
--
MOS_MIGRATED_REVID=88724988
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to keep the existing behavior when turning on C++ modules. The problem is that
a #include of a header gets internally translated into an import of the
header's (sub)module. Now, if all headers of a cc_library are in the same
module, this means, a single import of one of them makes the symbols of all of
them accessible. While this isn't inherently problematic, it breaks the
similarity between a modules and non-modules build.
This behavior is hidden behind a feature for now as I have just committed
necessary changes to Clang, which will need to be release to stable, before we
can flip everything.
Also, don't put a header as both normal and private header if it is present in both. (Or don't output two submodules with the new implementation).
--
MOS_MIGRATED_REVID=88723759
|
|
|
|
|
|
|
|
|
| |
Also some cosmetic changes in the BE template: remove strikethrough style when
mouse hovers over text marked as describing something deprecated, to make it
easier to read.
--
MOS_MIGRATED_REVID=88723528
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88721967
|
|
|
|
|
|
|
| |
Also fix a typo (add missing < ).
--
MOS_MIGRATED_REVID=88715707
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88713932
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We want to make it so configured targets can only see the configuration
fragments they have declared, which requires creating a customized
configuration for every configured target.
Therefore, this change moves the directories to a separate object, so
configurations that have the same output directories can share it.
Also change getBinFragment and getGenfilesFragment to call the corresponding
Root.getExecPath() on the fly. However, these are called _very_ often, so at
the same time change Root to cache the exec path.
Instead of keeping a map of all executables, only keep the shell executable,
which is the only value that was actually used anywhere.
Remove the cache key, but keep the short cache key. The cache key was only
used to check for duplicate cache keys in the BuildConfigurationCollection,
which is no longer necessary as we don't use the cache key for anything else
anymore. We should instead check for output directory conflicts, but we can't
do that quite yet (I'm working on it).
Also update the documentation in a couple of places.
--
MOS_MIGRATED_REVID=88712178
|
|
|
|
|
|
|
|
|
| |
root when used with protobuf or XML outputs.
genquery was non-deterministic accross machines / workspace location without that setting.
--
MOS_MIGRATED_REVID=88711033
|
|
|
|
|
|
|
|
|
|
| |
SourceManifestAction.Builder#setTopLevel is the only way the relative
roots was capable of being supplied. Its documentation states "Most
likely, you don't need this". As it is unused removing the extra code
and interpreting as "you don't need this".
--
MOS_MIGRATED_REVID=88574913
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using the new flag works only on ios_application and ios_extension targets,
resulting in their output binaries being "universal" with all given architectures
included.
Internally this is achieved by splitting the "binary" dependency (and its transitive
dependencies) of ios_{application,extension} to be built in one of the architectures
using split transitions. The results are then combined. Since an ios_application may
depend on ios_extension, we transition back to the top-level configuration when
encoutering such a dependency using the newly introduced TOP_LEVEL transition and then
split configurations again.
RELNOTES: --ios_multi_cpus allows building fat ios_applications.
--
MOS_MIGRATED_REVID=88555540
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88547886
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88546692
|
|
|
|
|
|
|
| |
the command line when running an objc_binary or ios_application.
--
MOS_MIGRATED_REVID=88544811
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88535323
|
|
|
|
|
|
|
|
| |
This is important if a base rule definition is available but the specific rule
class wants to override it.
--
MOS_MIGRATED_REVID=88533474
|
|
|
|
|
|
|
|
|
|
|
| |
As a side effect, we no longer restart ActionExecutionFunction after the action has executed unless the action ran locally (and therefore didn't discover its inputs beforehand). This also means that we no longer need to store an out-of-Skyframe cache for discovered includes except when checking the action cache. Since my suspicion is that the out-of-Skyframe cache will have a minimal performance impact once it is just being used for the action cache, I may delete it in a follow-up cl.
After this change, we will overapproximate the set of includes because we depend on all includes, rather than just the ones that the action was found to depend on after execution.
This is a prerequisite for Skyframe-native include scanning in that Skyframe-native include scanning will need to add at least as many Skyframe nodes and edges. If we end up punting on it, then we may want to revert this change. But for now I think it's worth having. I'll run some more numbers to see what the actual performance impact is.
--
MOS_MIGRATED_REVID=88492955
|
|
|
|
|
|
|
| |
Also add tests.
--
MOS_MIGRATED_REVID=88474801
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We define unused artifacts as those that aren't consumed by any
action. This can be because an action produced more outputs than
a dependent action needed, or because it's a top level artifact
and we don't care about its contents, just that it was built
without issue. Actions may prevent outputs from being discarded
by declaring them as mandatory. This is particularly useful for
test outputs. The motivation behind this change is to reduce
storage overhead for things we can do without.
It is worth noting this change doesn't cover all cases. In particular
it has difficulty identifying *_binary artifacts as orphaned. This
is due to the insertion of a virtual runfiles artifact which depends
upon the rule's outputs.
--
MOS_MIGRATED_REVID=88467504
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88449349
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=88444163
|
|
|
|
|
|
|
| |
link system call.
--
MOS_MIGRATED_REVID=88441395
|