| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
to a remote repository.
--
MOS_MIGRATED_REVID=106051348
|
|
|
|
|
|
|
|
| |
Also remove a bunch of custom uses of EventCollector, and use the (already
existing) EventCollectionApparatus instead.
--
MOS_MIGRATED_REVID=106047665
|
|
|
|
|
|
|
| |
--
Change-Id: Ic19a8292e1c57623085daa6ce3cbf280cdf7129e
Reviewed-on: https://bazel-review.googlesource.com/2180
MOS_MIGRATED_REVID=106035838
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=106004898
|
|
|
|
|
|
|
| |
This makes it possible to call these methods with lists from Skylark, which are internally Iterable<>'s but not Collection<>'s.
--
MOS_MIGRATED_REVID=106003065
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We rely on ErrorTransienceValue being different across evaluations by
way of java reference inequality, instead make it a singleton and make
it so that ErrorTransienceValue compares equal to nothing, including itself.
Alternatively we could attach the corresponding Version to ErrorTransienceValue
and use that to force inequality across evaluations. However this gets into
the different possible Version implementations and their varying semantics, so
go with the simplest approach first and see how it works out.
--
MOS_MIGRATED_REVID=106001826
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105999401
|
|
|
|
|
|
|
|
|
| |
order. In general, there's no advantage in Blaze to FIFO, and it means that we effectively do breadth-first graph traversal. When we must hold state for incomplete nodes (as we do with action execution, or more generally, as we do in Skyframe), this increases our memory footprint.
LIFO is not exactly depth-first traversal, since we are multithreaded, but to a first approximation, it looks like a depth-first traversal with "width" the number of threads (at each level of the graph, #(threads) nodes are visited).
--
MOS_MIGRATED_REVID=105995014
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105994907
|
|
|
|
|
|
|
| |
Nothing can extend SkyFunctionName. It's final.
--
MOS_MIGRATED_REVID=105989976
|
|
|
|
|
|
|
| |
For native aspects, AspectClass is a facade for Class<AspectFactory<...>>.
--
MOS_MIGRATED_REVID=105986390
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In SkyQueryEnvironment, the buildTransitiveClosure method ignored the
error messages in successfully evaluated TransitiveTraversalValues,
under the belief that any such error messages are also obtainable by
calling getMissingAndExceptions. This happens to be true right now,
but may not be true in the future.
If, in particular, the TransitiveTraversal skyfunction inlines its
call to the TargetMarker skyfunction, those error messages won't be
available through getMissingAndExceptions.
--
MOS_MIGRATED_REVID=105980430
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, a TransitiveTraversalFunction computed a value that
contained an exception only if the exception resulted from a failure
to load the function's immediate target. If the target had transitive
dependencies on other targets, those other targets would be loaded, but
any errors resulting from loading those targets would not be retained.
SkyQueryEnvironment impromperly used a SkyFrame mechanism (which was
solely intended to ensure equivalent semantics between keep-going and
no-keep-going evaluations) to discover errors in the set of transitive
children of TransitiveTraversal nodes.
In order to transition SkyQueryEnvironment away from that mechanism,
this CL changes TransitiveTraversalFunction to remember the first error
message encountered while loading its target and its transitive
dependencies.
By remembering just the error message as a string, and not the full
exception object, this also helps TransitiveTraversalValue have more
consistent equality semantics for change-pruning.
--
MOS_MIGRATED_REVID=105977182
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105975871
|
|
|
|
|
|
|
|
| |
The cost-benefit isn't there to pay a square cost to roll these up on
the blaze side. Android Studio has to do it on its end instead.
--
MOS_MIGRATED_REVID=105971068
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105969015
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
deduplication of transitive and direct dependencies in the AndroidProcessingAction.
Change the resource dependency handling to separate between the transitive and direct resources from libraries.
This slightly increases the complexity of resource propagation. The initial algorithm was to simply merge all transitive ResourceContainers together with any new ResourceContainer and propagate them via the AndroidResourcesProvider. The new algorithm is encapsulated inside a new ResourceDependencies class which works as follows:
1. Collect resources from the deps into transitive and direct NestedSets
2. If a rule provides a ResourceContainer, merge the transitive and direct into a new transitive set
3. Export the provider
This results having a rule without resources "forward" the merged sets of transitive and direct resources to the next rule.
--
MOS_MIGRATED_REVID=105960655
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105956734
|
|
|
|
|
|
|
| |
REPOSITORY_NAME symbol.
--
MOS_MIGRATED_REVID=105954652
|
|
|
|
|
|
|
|
|
| |
file rather than a ParserInputSource.
This is part of a series of changes with the net result being that we open, read, and parse each BUILD file exactly once.
--
MOS_MIGRATED_REVID=105911557
|
|
|
|
|
|
|
| |
FileStatus#isSpecialFile to help disambiguate between a regular file and a special file, since the file size of a special file cannot be trusted.
--
MOS_MIGRATED_REVID=105903622
|
|
|
|
|
|
|
| |
RuntimeExceptions that were thrown after an InterruptedException was thrown would be swallowed.
--
MOS_MIGRATED_REVID=105902192
|
|
|
|
|
|
|
| |
and fix the bugs that showed up as a result.
--
MOS_MIGRATED_REVID=105896905
|
|
|
|
|
|
|
| |
values).
--
MOS_MIGRATED_REVID=105893837
|
|
|
|
|
|
|
|
| |
Should be a singleton, should never be serialized or deserialized,
but add equals and hash code as well for good measure.
--
MOS_MIGRATED_REVID=105888511
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105878456
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105877617
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105876178
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105875176
|
|
|
|
|
|
|
|
| |
In checkAttrValNonEmpty, also check dict values for emptiness
when the attribute was declared non-empty.
--
MOS_MIGRATED_REVID=105871620
|
|
|
|
|
|
|
|
|
| |
Fixes #518.
RELNOTES: Add support for Windows-created zip files with non-posix permissions.
--
MOS_MIGRATED_REVID=105865785
|
|
|
|
|
|
|
|
| |
Use SkylarkList everywhere rather than either List or GlobList.
Keep a GlobList underneath a MutableList, where applicable.
--
MOS_MIGRATED_REVID=105864035
|
|
|
|
|
|
|
| |
--
Change-Id: Ib82d20394b85433d7b0aae4a71f07ec1af068fa0
Reviewed-on: https://bazel-review.googlesource.com/#/c/2140/
MOS_MIGRATED_REVID=105856861
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of two metasyntactic variables and one random bit of magic which
changes relative paths to be children of crosstool, we now have three
consistent pieces of metasyntax; except that since we can't actually
remove the old syntax, we have either way for the time being.
RELNOTES[NEW]: accept %crosstool_top% in cxx_builtin_include_directory
--
MOS_MIGRATED_REVID=105854779
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105854596
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105851371
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105844221
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105841866
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105841398
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105840775
|
|
|
|
|
|
|
| |
Preparation for running multiple commands in parallel.
--
MOS_MIGRATED_REVID=105840167
|
|
|
|
|
|
|
|
|
| |
hte uniqueifer and size them smaller when we're under the memoization threshold.
A heap dump (with retained garbage) showed many of these sets sitting around, most at under 60% fill ratio.
--
MOS_MIGRATED_REVID=105818028
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Uses tests that don't run on Bazel
*** Original change description ***
Implement aspect(...) Skylark function.
--
MOS_MIGRATED_REVID=105808850
|
|
|
|
|
|
|
|
|
| |
and --nodistinct_host_configuration explicit. This particularly
helps triaging the Bazel tests when --experimental_dynamic_configs
is on.
--
MOS_MIGRATED_REVID=105801590
|
|
|
|
|
|
|
|
|
|
| |
cxx_builtin_include directories which start with "%workspace%/" are taken
to be relative to the build workspace, and not relative to crosstool-top.
RELNOTES[NEW]: cpxx_builtin_include_directory specifications allow more flexibility.
--
MOS_MIGRATED_REVID=105789270
|
|
|
|
|
|
|
|
|
|
|
| |
android_library rule when the android_library is being used as a forwarding rule
(i.e., has no sources).
RELNOTES: When used as a forwarding rule (i.e., has no sources), android_library
will also forward any exported_plugins in its dependencies.
--
MOS_MIGRATED_REVID=105787789
|
|
|
|
|
|
|
| |
RELNOTES: None
--
MOS_MIGRATED_REVID=105787681
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While a normal set is theoretically sufficient, it can cause hard-to-reproduce
problems. In particular, the iteration order of the expansion result depends
on the iteration order of the requested targets. If there are multiple
requests for the same set of targets, but with different orders, the results
would depend on which request was made first. If a downstream function also
inadvertantly depends on the iteration order, it can be hard to debug why it
ended up with a different order than it requested.
Alternatively, we could sort the result before returning it. We generally
expect the key set to be smaller than the result set, so this should be
ever so slightly more efficient.
--
MOS_MIGRATED_REVID=105765514
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks many android targets in the depot.
*** Original change description ***
Trying again with checking for the presence of the "resources" attribute.
Change the resource dependency handling to separate between the transitive and direct resources from libraries.
This slightly increases the complexity of resource propagation. The initial algorithm was to simply merge all transitive ResourceContainers together with any new ResourceContainer and propagate them via the AndroidResourcesProvider. The new algorithm is encapsulated inside a new ResourceDependencies class which...
***
ROLLBACK_OF=105631635
--
MOS_MIGRATED_REVID=105752015
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
release. Note the following peculiarities of the current situation:
- Sandboxed execution still silently falls back to non-sandboxed execution due to LocalGccStrategy explicitly requesting local execution.
- However, builds are still correct due to local execution using hdrs_check.
- hdrs_check, even though it was intended to default to "strict" in Bazel from the start, is still set to "loose" by default, so you might accidentally be using non-declared header files in your cc_* targets. In this case, your builds will break when the default becomes hdrs_check=strict and sandboxing becomes available. It is recommended that you check whether your builds are affected, by specifying --hdrs_check=strict manually and fixing your BUILD files to explicitly list all used includes in the srcs / hdrs attributes of your cc_* targets.
These remaining issues will be fixed in an upcoming change.
This change also adds regression tests for the issue.
--
MOS_MIGRATED_REVID=105747212
|