| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
Ideally, PrepareDepsOfPatternFunction and maybe even RecursivePkgFunction would also be changed to take a PackageIdentifier instead of RootedPath because the less places we store the set of roots, the better, but I've done enough refactoring in the past weeks to not be thrilled by the idea of doing more.
--
MOS_MIGRATED_REVID=105486561
|
|
|
|
|
|
|
|
|
| |
and mainGroup in xcodeproj.
RELNOTES: Adds --override_workspace_root blaze flag to hand-set workspace_root and mainGroup in xcodeproj.
--
MOS_MIGRATED_REVID=105484952
|
|
|
|
|
|
|
| |
Eliminate side-effect in command_line_srcs and hide the internal class.
--
MOS_MIGRATED_REVID=105480701
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105461876
|
|
|
|
|
|
|
| |
No need for a specific ordering.
--
MOS_MIGRATED_REVID=105438232
|
|
|
|
|
|
|
|
|
|
|
| |
It used to not change the symlink to point to the new one. The failure
modes were different when the old file existed vs not, so there are
tests for both.
--
Change-Id: I6328c56a90254c5da78ccf827d377900bde06e90
Reviewed-on: https://bazel-review.googlesource.com/#/c/2131/
MOS_MIGRATED_REVID=105432042
|
|
|
|
|
|
|
| |
preparation for eventually implementing recursive target patterns for remote repositories.
--
MOS_MIGRATED_REVID=105412566
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change affects only lists, because it is the only mutable type.
The change is also temporary. We will later make the list immutable (when
it comes from a different context) and we will be able to remove the copy.
This fixes a critical bug where values could be mutated from a BUILD file
and affect other BUILD files.
--
MOS_MIGRATED_REVID=105400506
|
|
|
|
|
|
|
|
| |
This is currently not hooked up, and we're passing (potentially) massive
numbers of targets around.
--
MOS_MIGRATED_REVID=105395404
|
|
|
|
|
|
|
| |
No need for this, remove to cut out some cruft/room for accidents.
--
MOS_MIGRATED_REVID=105378202
|
|
|
|
|
|
|
|
|
| |
Uses an AtomicLong to count remaining tasks. Only obtains the
zeroRemainingTasks lock when remaining tasks have gone to zero or
the codepath needs to wait on that condition.
--
MOS_MIGRATED_REVID=105348523
|
|
|
|
|
|
|
|
|
|
| |
Removes unnecessary final keyword on private methods, inlines the
un-overridden protected method getWorkQueue, and restructures internal
constructors to be flatter (i.e. every constructor implementation calls
at most one other constructor).
--
MOS_MIGRATED_REVID=105344413
|
|
|
|
|
|
|
|
| |
Re-adds the missing execution phase statistics which got lost in the
recent ProfileCommand refactoring.
--
MOS_MIGRATED_REVID=105340677
|
|
|
|
|
|
|
| |
Previously, only ThreadPoolExecutor implementations were allowed.
--
MOS_MIGRATED_REVID=105340237
|
|
|
|
|
|
|
|
|
| |
result.
This is a step in the right direction towards the goal of opening and reading each BUILD file exactly once.
--
MOS_MIGRATED_REVID=105338761
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Broke bazel build.
*** Original change description ***
Update iossim for Xcode 7 support.
As of Xcode 7, supportedDeviceTypesByName was replaced by supportedDeviceTypesByAlias.
This is from latest chromium build.
Downstream hash is 9dd179a339c0457f8754069e0774b38f69c258a8.
The latest merge was to upstream ef05b7da00844c0d500c4a7f20d4095dab56e7fe
***
Also includes the following changes:
Size the Lexer tokenization to minimize internal resizing. This value is chosen empirically.
--
Fixes toolchain selection in the generated Android NDK crosstools by making
each target_cpu and compiler field unique.
Note that there are some problems with the clang compilers (e.g. can't find ld), which I'll fix in a subsequent change.
--
Update iossim for Xcode 7 support.
As of Xcode 7, supportedDeviceTypesByName was replaced by supportedDeviceTypesByAlias.
This is from latest chromium build.
Downstream hash is 9dd179a339c0457f8754069e0774b38f69c258a8.
The latest merge was to upstream ef05b7da00844c0d500c4a7f20d4095dab56e7fe
--
MOS_MIGRATED_REVID=105337154
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before:
ERROR: No toolchain found for cpu 'x84'.
After:
ERROR: No toolchain found for cpu 'x84'. Valid cpus are: [
armeabi,
armeabi-v7a,
armeabi-v7a-hard,
armeabi-thumb,
armeabi-v7a-thumb,
armeabi-v7a-hard-thumb,
arm64-v8a,
mips,
mips64,
x86,
x86_64,
].
--
MOS_MIGRATED_REVID=105324190
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
legible by putting each flag combination on its own line.
E.g. from this:
ERROR: No toolchain found for --cpu='foo' --compiler='bar' --glibc='baz'. Valid toolchains are: [ --cpu='armeabi-v7a' --compiler='compiler' --glibc='armeabi-v7a', --cpu='armeabi-v7a' --compiler='compiler' --glibc='armeabi-v7a', --cpu='local' --compiler='compiler' --glibc='local', --cpu='darwin' --compiler='compiler' --glibc='macosx', --cpu='freebsd' --compiler='compiler' --glibc='local', --cpu='k8' --compiler='windows_mingw' --glibc='local', --cpu='k8' --compiler='windows_msys64_mingw64' --glibc='local', --cpu='k8' --compiler='windows_clang' --glibc='local',].
to this:
ERROR: No toolchain found for --cpu='foo' --compiler='bar' --glibc='baz'. Valid toolchains are: [
--cpu='armeabi-v7a' --compiler='compiler' --glibc='armeabi-v7a',
--cpu='armeabi-v7a' --compiler='compiler' --glibc='armeabi-v7a',
--cpu='local' --compiler='compiler' --glibc='local',
--cpu='darwin' --compiler='compiler' --glibc='macosx',
--cpu='freebsd' --compiler='compiler' --glibc='local',
--cpu='k8' --compiler='windows_mingw' --glibc='local',
--cpu='k8' --compiler='windows_msys64_mingw64' --glibc='local',
--cpu='k8' --compiler='windows_clang' --glibc='local',
].
(notice there is a duplicate toolchain)
--
MOS_MIGRATED_REVID=105313547
|
|
|
|
|
|
|
| |
referenced via "//external:android/xyz_v7"
--
MOS_MIGRATED_REVID=105313228
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105312426
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105301167
|
|
|
|
|
|
|
|
|
|
| |
I was hitting argument length restrictions when trying to run rules
which take 2 GCC installs and a Clang install as inputs.
--
Change-Id: Iee27bb6fb50fe94bff4b2500bbcfa9381b05d63d
Reviewed-on: https://bazel-review.googlesource.com/#/c/2090
MOS_MIGRATED_REVID=105300670
|
|
|
|
|
|
|
|
|
| |
This works because we resolve the FileValue for every directory found during the traversal, therefore, symlink cycles and symlink structures giving rise to infinite directory trees are handled correctly (that is to say, the same way as they are handled during globbing)
Fixes #274.
--
MOS_MIGRATED_REVID=105290852
|
|
|
|
|
|
|
|
|
| |
error from SkylarkImportResult dep.
This is part of a series of changes with the net result being that we open, read, and parse each BUILD file exactly once.
--
MOS_MIGRATED_REVID=105253634
|
|
|
|
|
|
|
|
|
| |
helper classes do call that method to see if the stream has more data.
This is part of a series of changes with the net result being that we open, read, and parse each BUILD file exactly once.
--
MOS_MIGRATED_REVID=105253425
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Original CL uncovered a depot issue which was fixed in []. I verified it was the only such issue (see []).
*** Original change description ***
Rollback of commit f87a414a6bf50613a2c419e53a96f76154f44ae3.
*** Reason for rollback ***
Rolling back until [] is submitted and we have verified that there are no other breakages
*** Original change description ***
Handle the case of infinite symlink expansion where a path in a symlink chain is a symlink to an ancestor of a path in the chain.
--
MOS_MIGRATED_REVID=105251788
|
|
|
|
|
|
|
| |
Makes it consistent with the rest of the file.
--
MOS_MIGRATED_REVID=105233324
|
|
|
|
|
|
|
| |
not be locked to iOS SDK.
--
MOS_MIGRATED_REVID=105231425
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the cycle values (were supposed to) share a common abstract
base class, however usage was inconsistent. Instead refactor to eliminate
the specialized value classes, remove the abstract class, and share a
common empty placeholder value, which should be useful for future/other
current empty values.
--
MOS_MIGRATED_REVID=105217399
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105214382
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now prints:
//foo:bar (cached) PASSED in 0.1s
instead of:
//foo:bar (1/0 cached) PASSED
Fixes #218.
--
MOS_MIGRATED_REVID=105210302
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105204997
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a flag which allows the user to specify the android compiler.
This commit also disconnects the android compiler from the main
--compiler flag. Changing the --compiler flag won't change the
compiler used by the android rules.
--
Change-Id: I788d3a353a1cc304e1c015b9dd283258e6e172d4
Reviewed-on: https://bazel-review.googlesource.com/2112
MOS_MIGRATED_REVID=105203751
|
|
|
|
|
|
|
| |
This requires changing all "//tools/language:target" implicit dependencies to "@tools//tools/language:target".
--
MOS_MIGRATED_REVID=105193805
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105175791
|
|
|
|
|
|
|
| |
anyway. Also batch retrievals of children when building events.
--
MOS_MIGRATED_REVID=105174435
|
|
|
|
|
|
|
|
| |
This supersedes bin/gen files on Android SDK. The fields are removed
entirely since the proto isn't public yet.
--
MOS_MIGRATED_REVID=105130701
|
|
|
|
|
|
|
| |
error bubbling.
--
MOS_MIGRATED_REVID=105102597
|
|
|
|
|
|
|
|
|
|
|
| |
not all done during invalidation, repeated adding/removing means that we are consolidating more often, negating the benefit of delayed removals. To work around this, delay adds as well until we consolidate and verify the integrity of our data.
Since there is no well-defined point that a consolidation should trigger for a done node, we delay until our pending list is as large as the done list. We can tweak this if necessary for a memory/performance tradeoff.
The alternative to this that I could think of is giving up our strong integrity checks, which I'm not a fan of.
--
MOS_MIGRATED_REVID=105095886
|
|
|
|
|
|
|
|
|
|
| |
We don't have any strong guarantees around the stability of SkyKey#toString(),
which we rely on to canonicalize cycles. We can reasonably expect
PackageIdentifier#toString() to be stable enough though. We also hide away the
cycle detection details from external code in this change.
--
MOS_MIGRATED_REVID=105093095
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rolling back until [] is submitted and we have verified that there are no other breakages
*** Original change description ***
Handle the case of infinite symlink expansion where a path in a symlink chain is a symlink to an ancestor of a path in the chain.
--
MOS_MIGRATED_REVID=105080445
|
|
|
|
|
|
|
| |
If there's a holdup propagating the exception, at least we will see it in the logs.
--
MOS_MIGRATED_REVID=105075242
|
|
|
|
|
|
|
|
|
| |
This is superfluous because when an action is executed, the cwd is always the exec root we always pass exec paths on the command line.
This is necessary because this doesn't work if the proto compiler tool is not in the main repository.
--
MOS_MIGRATED_REVID=105057016
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105054615
|
|
|
|
|
|
|
|
|
| |
present.
This is nice because this removes the last thing Bazel needs to be able to function without a tools/ directory that is not already embedded into the binary.
--
MOS_MIGRATED_REVID=105054134
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105052078
|
|
|
|
|
|
|
|
| |
Add the --combine option to produce a single aggregated statistics output for
multiple profile files. Outputs neither Skylark histograms nor the task chart.
--
MOS_MIGRATED_REVID=105051164
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105050723
|
|
|
|
|
|
|
| |
and implement a "@//" label syntax that always points to the main repository.
--
MOS_MIGRATED_REVID=105041493
|
|
|
|
|
|
|
| |
(determined from xcrun) for applicable actions
--
MOS_MIGRATED_REVID=105000617
|