| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
"blaze test".
RELNOTES: None.
PiperOrigin-RevId: 174386473
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Roll forward again without the changes to expand_location, but with the trimming fix from https://github.com/bazelbuild/bazel/commit/19617360121635a77ffec99b84d825e7d9b260b1.
*** Original change description ***
Automated rollback of commit ca77f608e486bf7aa762565d25bf7b9e30f2268c.
This also rolls back unknown commit.
*** Reason for rollback ***
Affected expand_location Skylark API semantics - it no longer accepts ${abc} or plain dollar signs, but complains.
*** Original change description ***
Extend TemplateExpander to handle $(func param) expansion
Rewrite the Expander to use the new functionality; also rewrite the Skylark
expand_location function to use it.
PiperOrigin-RevId: 174384095
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks alphago targets.
*** Original change description ***
Remove CppConfiguration#getFeatures in favor of
CcToolchainProvider#getFeatures.
PiperOrigin-RevId: 174373331
|
|
|
|
|
|
|
|
|
|
| |
Previously, linkstamp objects would be built without -fPIC. When linked
into a PIE binary, this leads to text relocations, which causes IFUNC
resolution to segfault (the resolution function is called while the
binary is mapped RW).
RELNOTES: None.
PiperOrigin-RevId: 174366114
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 174355404
|
|
|
|
|
|
|
| |
Since the problem or the means to fix it is usually on the user side.
RELNOTES=none
PiperOrigin-RevId: 174348233
|
|
|
|
| |
PiperOrigin-RevId: 174343502
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 174229364
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 174219672
|
|
|
|
| |
PiperOrigin-RevId: 174202685
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 174199997
|
|
|
|
|
|
|
| |
This omits validation for this transition, which will follow in a future change.
RELNOTES: None.
PiperOrigin-RevId: 174183651
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks Blaze nightly
Example failing test: []
*** Original change description ***
Allow android_test to properly inherit resources
RELNOTES: none
PiperOrigin-RevId: 174182803
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 174062560
|
|
|
|
|
|
|
|
|
|
|
| |
In the next review, to handle issues around density filtering, ResourceFilterFactory will return another object that actually handles filtering. To ensure stuff is named properly, rename ResourceFilter to ResourceFilterFactory now so that the new class can be called ResourceFilter.
This is a straightforward automated refactor, followed with some automated reformatting to make linting happy.
I used the name ResourceFilterFactory, rather than the more concise ResourceFilters, as this class actually contains state (both around what filtering should currently do and about what resources were filtered out) and isn't just a helper class.
RELNOTES: none
PiperOrigin-RevId: 174049618
|
|
|
|
|
|
|
|
|
| |
ParallelSkyQueryUtils.RBuildFilesVisitor. Also a minor tweak of the batch size for feeding results to the callback.
Also correctly use the packageSemaphore in SkyQueryEnvironment's non-parallel implementation of rbuildfiles.
RELNOTES: None
PiperOrigin-RevId: 174039067
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LocalResourceContainer.Builder is referenced a bunch of times, but most of
those calls are identical. Replace them with a couple of factory methods. This
lets us make the builder private.
Additionally, LocalResourceContainer called attributeError() on the 'resources'
attribute, even though 'resource_files' is now used most of the time instead.
Now, the error is always given for the correct attribute.
RELNOTES: none
PiperOrigin-RevId: 174038035
|
|
|
|
|
|
| |
#getSolibDirectory to CcToolchainProvider.
PiperOrigin-RevId: 174032021
|
|
|
|
|
| |
RELNOTES:None
PiperOrigin-RevId: 173976330
|
|
|
|
|
|
|
|
| |
Not a totally clean rollback because of the intervening https://github.com/bazelbuild/bazel/commit/b5158a9a677b149e04e844c40a01e9a9dde40783.
*** Reason for rollback ***
PiperOrigin-RevId: 173957187
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 173950304
|
|
|
|
|
|
|
| |
It has been set to all for a bit now. It is not in any teams blazerc/tap configs.
RELNOTES: --incremental_dexing_binary_types has been removed. All builds are supported by incremental dexing (modulo proguard and some blacklisted dx flags).
PiperOrigin-RevId: 173931117
|
|
|
|
|
|
| |
supportsEmbeddedRuntimes, supportsExecOrigin to CcToolchainProvider.
PiperOrigin-RevId: 173928009
|
|
|
|
|
|
|
|
|
| |
RecursivePackageProvider#getPackagesUnderDirectory assumed that the given directory needed to be strictly underneath all directories in the given blacklistedSubdirectories set, yet the callsites were calling this method such that the given directory was not-necessarily-strictly underneath the blacklistedSubdirectories.
N.B. There is no end-to-end bug in EnvironmentBackedRecursivePackageProvider because TargetPatternFunction's usage of TargetPattern#eval is always with blacklistedSubdirectories=ImmutableSet.of(). Also note that the existing fast-path in GraphBackedRecursivePackageProvider is dead code because the Preconditions check would fail first :(
RELNOTES: None
PiperOrigin-RevId: 173924216
|
|
|
|
|
|
|
|
|
|
| |
active, restarting the RPC if required.
- BuildEventServiceTransport sender thread checks the RPC is still active every 1s, failing the RPC if it was ended before we reached the end of the BEP stream.
- "fail_fast" is the default behavior on gRPC (it needs to be disabled using .withWaitForReady).
PiperOrigin-RevId: 173921837
|
|
|
|
|
|
|
|
| |
These classes should not be used by anything since the binary regenerates
updated R classes.
RELNOTES: none
PiperOrigin-RevId: 173906178
|
|
|
|
|
|
|
| |
Keeps the semantics the same.
RELNOTES: None
PiperOrigin-RevId: 173899927
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current implementation copies all inputs into a list and then
iterates over them twice to remove filesets and manifests. We can
do the filtering in one pass instead and avoid the copying to a
list to save memory.
In addition, the Action.getInputs() method often returns inputs
stored in a NestedSet and we want to allow a caller to have
access to it, so that he isn't forced to flatten it. A call can
do that by checking if ActionSpawn.getInputFiles() is an instance
of NestedSetView.
Change-Id: I2fa8904827030c04bf29b14f0f3f942877c317a4
PiperOrigin-RevId: 173881256
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change removes Bazel's dependency on Hazelcast. This will help to reduce
size of the Bazel binary and simplify the usage of remote cache.
However Hazelcast library is still kept in the repository and still being
used by remote_worker. It is useful as a REST server to allow integration
testing with the remote rest cache functionality.
Change-Id: Ia21b970cedaec84bc6c13e839509d838acb5756f
PiperOrigin-RevId: 173880600
|
|
|
|
|
|
|
|
|
|
|
| |
As explained in the javadoc this avoids unnecessary allocations and
preserves underlying Java filesystem information.
This partially addresses #3952.
Closes #3953.
PiperOrigin-RevId: 173877045
|
|
|
|
| |
PiperOrigin-RevId: 173873310
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instances.
Stop storing the canonical list of arguments separately. For the canonicalize-flags command, we want to avoid showing options that either have no values in their own right (such as expansion options and wrapper options) and instances of options that did not make it to the final value. This is work we already do in OptionValueDescription, so we can generate the canonical form from the values tracked there, instead of tracking it separately.
This means the canonical list is more correct where implicit requirements are concerned: implicit requirements are not listed in the canonical form, but now the values they overwrote will be correctly absent as well.
Use this improved list for the effective command line published to the BEP.
RELNOTES: Published command lines should have improved lists of effective options.
PiperOrigin-RevId: 173873154
|
|
|
|
| |
PiperOrigin-RevId: 173731752
|
|
|
|
|
|
| |
We add methods to Path that accept a file system instead of using the associated instance. These will be used during migration away from the methods that use the Path's file system.
PiperOrigin-RevId: 173707291
|
|
|
|
|
|
| |
CcToolchainProvider#getFeatures.
PiperOrigin-RevId: 173702792
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 173691842
|
|
|
|
|
|
| |
This requires a fairly large amount of changes to fundamental objects like BlazeRuntime, Executor, and so on, as well as changing a lot of test code to thread the file system through. I expect future CLs to be much smaller.
PiperOrigin-RevId: 173678144
|
|
|
|
|
|
|
|
| |
This is indeed an helper for the WorkspaceFactory. There is no
state in that class, it is just a namespace for static methods.
Change-Id: I917237639e9e8a366b2b466ce40c45514007209c
PiperOrigin-RevId: 173669872
|
| |
|
|
|
|
|
|
|
| |
This more clearly indicates what this is. Also change some hard-coded uses to
use the constant instead.
PiperOrigin-RevId: 173658659
|
|
|
|
| |
PiperOrigin-RevId: 173618971
|
|
|
|
|
|
|
|
|
| |
CommonCommandOptions.
client_env and default_override stand apart from the other common options. They can be very long, and should only be used by the environment setup. They should ideally not be passed by option at all, but in the RunRequest proto message, but for now, isolate them so that they don't clutter the common command options, which are passed all over the place.
RELNOTES: None.
PiperOrigin-RevId: 173592980
|
|
|
|
|
|
|
|
| |
to blaze to allow us to toggle off enforcement of the one version property
while building java tests.
RELNOTES: n/a
PiperOrigin-RevId: 173578269
|
|
|
|
|
|
| |
assigned to java.util.List, not just ArrayList.
PiperOrigin-RevId: 173577936
|
|
|
|
|
|
|
|
|
| |
instead of android_instrumentation.
GITHUB: #903
RELNOTES: None.
PiperOrigin-RevId: 173572553
|
|
|
|
|
|
|
|
|
|
| |
After the completion of the build, also report useful logs/statistics.
Do so in a separate event, so that the protocol allows reporting build
completion early and purely staticial information later, maybe event after
some computations.
Change-Id: Ibd221546de76fcffcda7819c300187eac45ebd68
PiperOrigin-RevId: 173548733
|
|
|
|
|
|
|
|
|
| |
android_binary now takes an android_binary in the `instruments` attribute. If the attribute is explicitly specified, an AndroidInstrumentationInfo provider is included in the RuleConfiguredTarget, which android_instrumentation_test can use.
Having the provider allows android_instrumentation_test to check and fail if it tries to depend on an android_binary that is not instrumenting anything.
RELNOTES: None.
PiperOrigin-RevId: 173547240
|
|
|
|
|
|
|
|
|
|
|
| |
explicitly
Previously the default semantics were used unconditionally. Allowing non-default semantics is a feature. Requiring semantics to be specified explicitly helps to avoid unintentional divergence from the caller's intended semantics. We recently did the same thing for Skylark's Environment.Builder (https://github.com/bazelbuild/bazel/commit/b368b39f8ba1e8e8a67af50e5ade9127b2b149d7).
Also pass Skylark semantics through Package.Builder.Helper, so that the extra verification done for shell tests uses the same semantics as the build.
RELNOTES: None
PiperOrigin-RevId: 173544885
|
|
|
|
|
|
|
| |
Make variables provider.
RELNOTES: None.
PiperOrigin-RevId: 173527191
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
This has broken rules_docker: https://ci.bazel.io/blue/organizations/jenkins/Global%2Frules_docker/detail/rules_docker/243/pipeline/
*** Original change description ***
Properly escape GitHub repository download URL for git_repository w/ sha256
Addresses #3661
Closes #3770.
PiperOrigin-RevId: 173525982
|