aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build
Commit message (Collapse)AuthorAge
...
* Rollback of commit bd3be73b84001dbdb2f05297f215e8eb5bacf0e1.Gravatar Damien Martin-Guillerez2017-02-22
| | | | | | | | | | | | | | | | *** Reason for rollback *** To deprecate that flag, we need to fix #2539 first. *** Original change description *** Deprecate the legacy_java_test flag, now that nolegacy_java_test has been the default for quite a while now. RELNOTES[INC]: legacy_java_test flag will not have any effect now. -- PiperOrigin-RevId: 148107667 MOS_MIGRATED_REVID=148107667
* Error out when the STL label points to an undefined target when merging STLGravatar Luis Fernando Pino Duque2017-02-22
| | | | | | | | and toolchain contexts. -- PiperOrigin-RevId: 148104218 MOS_MIGRATED_REVID=148104218
* Remove 'allowReturnsNone=true' from the ProtoSourcesProvider methods for ↵Gravatar Googler2017-02-22
| | | | | | | | | | descriptors these fields currently can't return null/None (since the @AutoValue will reject it) and there doesn't seem to be a reason to think that they might in the future so i think this is safe to remove. -- PiperOrigin-RevId: 148099927 MOS_MIGRATED_REVID=148099927
* Augmented assignments don't evaluate lhs multiple timesGravatar Vladimir Moskva2017-02-21
| | | | | | -- PiperOrigin-RevId: 148092963 MOS_MIGRATED_REVID=148092963
* Declare all BuildEvents as Postable Gravatar Klaus Aehlig2017-02-21
| | | | | | | | | | | | ...through the ExtendedEventHandler. The main use case of the extended event handler is to allow posting of BuildEvents. So it is implicit that they are all good to be posted. Declare this. -- Change-Id: I9fcb2f33e57e05c3a05509b1121e44396f28c168 Reviewed-on: https://cr.bazel.build/9011 PiperOrigin-RevId: 148090465 MOS_MIGRATED_REVID=148090465
* Move Classpath.java from src/test/... to src/main/... since it will be used ↵Gravatar Florian Weikert2017-02-21
| | | | | | | | by the documentation generation in the future. -- PiperOrigin-RevId: 148081562 MOS_MIGRATED_REVID=148081562
* Add interface for extended reporting of events Gravatar Klaus Aehlig2017-02-21
| | | | | | | | | | | | Not in all situation, having an EventHandler allows detailed enough reporting on events during the build. Therefore add a new interface that additionally allows posting arbitrary objects on the event bus. -- Change-Id: I6ff3eebcad5f36b52c38d3f7ac20df8af2706821 Reviewed-on: https://cr.bazel.build/8793 PiperOrigin-RevId: 148078891 MOS_MIGRATED_REVID=148078891
* TestResult: make execRoot visible to subclassesGravatar Klaus Aehlig2017-02-21
| | | | | | -- PiperOrigin-RevId: 148075887 MOS_MIGRATED_REVID=148075887
* Fix spelling of millisGravatar Klaus Aehlig2017-02-21
| | | | | | | | -- Change-Id: I9e1483b9e99751b03d332110db023d99c045cb52 Reviewed-on: https://cr.bazel.build/9012 PiperOrigin-RevId: 148069886 MOS_MIGRATED_REVID=148069886
* parseBuildString doesn't crash on files with hash lines.Gravatar Carmi Grushko2017-02-21
| | | | | | -- PiperOrigin-RevId: 148042501 MOS_MIGRATED_REVID=148042501
* Raise error in function calls when star argument is not iterableGravatar Laurent Le Brun2017-02-20
| | | | | | | | This was a bug, f(*4) was silently handled as f(). -- PiperOrigin-RevId: 148017021 MOS_MIGRATED_REVID=148017021
* Rollback of commit 59b01953143562502dc036735c2cd23e5255cb24.Gravatar Laurent Le Brun2017-02-20
| | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks Blaze nightly *** Original change description *** apple_binary extension_safe attribute results in configuration transition on dependencies RELNOTES: apple_binary has a new "extension_safe" attribute to set extension compilation options on dependencies. -- PiperOrigin-RevId: 148009147 MOS_MIGRATED_REVID=148009147
* Rollback of commit 1cb5059396e46d9ff2c317b8a0a046af32b3a1d8.Gravatar Ulf Adams2017-02-20
| | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks TEST_BINARY env setting if --run_under is used. *** Original change description *** Rewrite TestStrategy.getArgs This changes command-line computation for tests: - run the coverage collector before the run_under command - no shell escaping: if all tools just call "$@", then this should work Note that we still wrap the command in a sub-shell to support shell built-ins and PATH lookup if the command does not contain a slash character '/'. A side effect of this change is that the --run_under command now executes in the test's runfiles directory, rather than in the exec root, if... *** -- PiperOrigin-RevId: 148003525 MOS_MIGRATED_REVID=148003525
* Make Python zip extraction work with paths bigger than 256 characters. Gravatar Andreas Bergmeier2017-02-20
| | | | | | | | | | | | | | | | Fixes Windows + Python3. Probably does not work for Python2! @meteorcloudy This is part of the fix. Can you look into porting that to Python2? I have no idea how to properly handle unicode strings in Python2. With that patch, it then later fails in the assert on line 134. Closes #2496. Fixed https://github.com/bazelbuild/bazel/issues/2504 -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/2496 PiperOrigin-RevId: 147975131 MOS_MIGRATED_REVID=147975131
* Update doc wrt set vs depset.Gravatar Laurent Le Brun2017-02-20
| | | | | | -- PiperOrigin-RevId: 147908180 MOS_MIGRATED_REVID=147908180
* Add missing fall through commentGravatar Liam Miller-Cushon2017-02-20
| | | | | | -- PiperOrigin-RevId: 147892584 MOS_MIGRATED_REVID=147892584
* Avoid crashing on proto_libraries when not incrementally dexing lite protos.Gravatar Googler2017-02-20
| | | | | | -- PiperOrigin-RevId: 147876411 MOS_MIGRATED_REVID=147876411
* Tune naming of Android data binding metadata files.Gravatar Greg Estren2017-02-20
| | | | | | | | | | | | | | | | This puts Bazel in line with the paths actually produced by the data binding resource processor. This difference matters when the library name doesn't match the package name (the build fails without this change). I started writing a shell integration test to check this end-to-end. But staging all the data binding support libs and their deps is a mess. Too much so, IMO. -- PiperOrigin-RevId: 147868538 MOS_MIGRATED_REVID=147868538
* Make android_ndk_repository api_level attribute optional.Gravatar Adam Michael2017-02-20
| | | | | | | | | | | | | If not specified, the highest api level in the NDK is used. This is one more step towards the goal of making android_{s,n}dk_repository better for our users in https://github.com/bazelbuild/bazel/issues/2284. RELNOTES: android_ndk_repository api_level attribute is now optional. If not specified, the highest api level in the ndk/platforms directory is used. -- PiperOrigin-RevId: 147868288 MOS_MIGRATED_REVID=147868288
* Rollback of commit 41c2a26eef89167e807cbc9f33487dc66bb757d3.Gravatar Carmi Grushko2017-02-20
| | | | | | | | | | This is not a clean rollback: I had to change CppCompileAction on line 1278 and pass cppSemantics.getIncludeProcessing(). Please flag this if it doesn't make sense :) -- PiperOrigin-RevId: 147868235 MOS_MIGRATED_REVID=147868235
* apple_binary extension_safe attribute results in configuration transition on ↵Gravatar Chris Parsons2017-02-20
| | | | | | | | | | dependencies RELNOTES: apple_binary has a new "extension_safe" attribute to set extension compilation options on dependencies. -- PiperOrigin-RevId: 147864346 MOS_MIGRATED_REVID=147864346
* Deprecate the legacy_java_test flag, now that nolegacy_java_test has been ↵Gravatar Kush Chakraborty2017-02-20
| | | | | | | | | | the default for quite a while now. RELNOTES[INC]: legacy_java_test flag will not have any effect now. -- PiperOrigin-RevId: 147851661 MOS_MIGRATED_REVID=147851661
* Switch J2ObjC to use compile-time jars (interface and header jars) instead ↵Gravatar Rumou Duan2017-02-20
| | | | | | | | of actual class jars. This should improve the action cache hit for J2ObjC translation actions. -- PiperOrigin-RevId: 147836893 MOS_MIGRATED_REVID=147836893
* Progress on Skylarkified java_lite_proto_library.Gravatar Irina Iancu2017-02-20
| | | | | | | | | | * Exposed transitive_runtime_jars from the former black-box JavaProvider. * Added support for aliases. * Returned the runfiles from the Skylark rule of java_lite_proto_library. -- PiperOrigin-RevId: 147834471 MOS_MIGRATED_REVID=147834471
* Rollback of commit 4b73e972d909bcd533f2f9940f95a00b9b73bdde.Gravatar Dmitry Lomov2017-02-17
| | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Broke tests on CI: http://ci.bazel.io/job/bazel-tests/570/ *** Original change description *** Roll forward execroot change RELNOTES[INC]: Previously, an external repository would be symlinked into the execution root at execroot/local_repo/external/remote_repo. This changes it to be at execroot/remote_repo. This may break genrules/Skylark actions that hardcode execution root paths. If this causes breakages for you, ensure that genrules are using $(location :target) to access files and Skylark rules are using http://bazel.io/docs/skylark/lib/File.html's path, dirname, etc. functions. Cust... -- PiperOrigin-RevId: 147833177 MOS_MIGRATED_REVID=147833177
* Fix --run_under to work with labels that describe source or output filesGravatar Ulf Adams2017-02-17
| | | | | | | | | Before this change, running with --run_under=//foo:foo.sh gave an error, if foo.sh is an executable shell script. -- PiperOrigin-RevId: 147831484 MOS_MIGRATED_REVID=147831484
* Rollback of commit 8bae4f4e99594118b7ce651f7779f92e7683cdd0.Gravatar Dmitry Lomov2017-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Reverting this because we need to revert commit 4b73e972d909bcd533f2f9940f95a00b9b73bdde. (See unknown commit). *** Original change description *** CppCompileAction must return false from inputsKnown for .d pruning This is necessary (but not sufficient) for the action cache to work correctly. Consider the following sequence of events: 1. action is executed 2. .d pruning is performed 3. action cache writes entry with post-pruning inputs list 4. action gets regenerated (e.g., due to server restart) 5. the action cache calls inputsKnown(), which returns true 6. action cache checks entry from step 3 against pre-pruning inputs list, which re... *** -- PiperOrigin-RevId: 147831409 MOS_MIGRATED_REVID=147831409
* Make the interface dynamic library builder a regular label instead of a ↵Gravatar Lukacs Berki2017-02-17
| | | | | | | | magic artifact. -- PiperOrigin-RevId: 147830857 MOS_MIGRATED_REVID=147830857
* Move FileAccessException to the vfs packageGravatar Ulf Adams2017-02-17
| | | | | | | | | | | | | | It was previously in unix, but also used from non-unix file systems, which means it's not actually unix-specific. This is in preparation for splitting compilation of the unix and windows file systems into separate libraries. That improves layering and reduces compile times - note that Bazel already injects the vfs into its lower layers, which should only rely on the normal vfs APIs, not on anything platform-specific. -- PiperOrigin-RevId: 147829659 MOS_MIGRATED_REVID=147829659
* Do not sort dict keys when printingGravatar Vladimir Moskva2017-02-17
| | | | | | | | | | Dict keys can in theory belong to different types, it's not allowed anymore to compare such objects by < in Skylark, so the Printer class shouldn't do it either. -- PiperOrigin-RevId: 147827109 MOS_MIGRATED_REVID=147827109
* Remove DynamicModeFlag and thus fix crash caused by passing ↵Gravatar Lukacs Berki2017-02-17
| | | | | | | | --dynamic_mode=auto on the command line. -- PiperOrigin-RevId: 147824992 MOS_MIGRATED_REVID=147824992
* BEP: Also report the xml file in cached test Gravatar Klaus Aehlig2017-02-17
| | | | | | | | | | | | | When the result of a test is reported from cache, report the full list of files. This requires knowing the exec root for, e.g., the xml output file. Therefore, add this path when constructing a cached TestResult. -- Change-Id: Id448eacfe3cfd0d36c25a5344874de4dc57acee9 Reviewed-on: https://cr.bazel.build/8934 PiperOrigin-RevId: 147823951 MOS_MIGRATED_REVID=147823951
* Rewrite TestStrategy.getArgsGravatar Ulf Adams2017-02-17
| | | | | | | | | | | | | | | | | | | This changes command-line computation for tests: - run the coverage collector before the run_under command - no shell escaping: if all tools just call "$@", then this should work Note that we still wrap the command in a sub-shell to support shell built-ins and PATH lookup if the command does not contain a slash character '/'. A side effect of this change is that the --run_under command now executes in the test's runfiles directory, rather than in the exec root, if coverage is enabled at the same time. Inside Google, it's very rare for --run_under to be used in combination with coverage, and it seems likely to be rare externally as well, so I don't think it warrants covering it in the release notes. -- PiperOrigin-RevId: 147815017 MOS_MIGRATED_REVID=147815017
* Fix NPE in NonconfigurableAttributeMapper Gravatar Liangliang He2017-02-17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This PR fixes: https://github.com/bazelbuild/bazel/issues/2036 to provide more error message Explanation why this works: see PR comment thread starting here: https://github.com/bazelbuild/bazel/pull/2531#issuecomment-280573712 without the fix: ``` java.lang.RuntimeException: Unrecoverable error while evaluating node 'CONFIGURED_TARGET:@grpc//:grpc++_config_proto 05cc524e2c4b9309660fb7daa4e35db9 (1333167441 455593757)' (requested by nodes 'CONFIGURED_TARGET:@grpc//:grpc_plugin_support 05cc524e2c4b9309660fb7daa4e35db9 (136418248 455593757)') at com.google.devtools.build.skyframe.ParallelEvaluator$Evaluate.run(ParallelEvaluator.java:429) at com.google.devtools.build.lib.concurrent.AbstractQueueVisitor$WrappedRunnable.run(AbstractQueueVisitor.java:501) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) Caused by: java.lang.NullPointerException at com.google.devtools.build.lib.packages.NonconfigurableAttributeMapper.get(NonconfigurableAttributeMapper.java:45) at com.google.devtools.build.lib.bazel.rules.BazelRuleClassProvider$BazelPrerequisiteValidator.isTestOnlyRule(BazelRuleClassProvider.java:268) at com.google.devtools.build.lib.bazel.rules.BazelRuleClassProvider$BazelPrerequisiteValidator.validateDirectPrerequisiteForTestOnly(BazelRuleClassProvider.java:254) at com.google.devtools.build.lib.bazel.rules.BazelRuleClassProvider$BazelPrerequisiteValidator.validate(BazelRuleClassProvider.java:190) at com.google.devtools.build.lib.analysis.RuleContext$Builder.validateDirectPrerequisite(RuleContext.java:1937) at com.google.devtools.build.lib.analysis.RuleContext$Builder.createTargetMap(RuleContext.java:1610) at com.google.devtools.build.lib.analysis.RuleContext$Builder.build(RuleContext.java:1449) at com.google.devtools.build.lib.analysis.ConfiguredTargetFactory.createRule(ConfiguredTargetFactory.java:241) at com.google.devtools.build.lib.analysis.ConfiguredTargetFactory.createConfiguredTarget(ConfiguredTargetFactory.java:171) at com.google.devtools.build.lib.skyframe.SkyframeBuildView.createConfiguredTarget(SkyframeBuildView.java:491) at com.google.devtools.build.lib.skyframe.ConfiguredTargetFunction.createConfiguredTarget(ConfiguredTargetFunction.java:1024) at com.google.devtools.build.lib.skyframe.ConfiguredTargetFunction.compute(ConfiguredTargetFunction.java:249) at com.google.devtools.build.skyframe.ParallelEvaluator$Evaluate.run(ParallelEvaluator.java:370) ... 4 more java.lang.RuntimeException: Unrecoverable error while evaluating node 'CONFIGURED_TARGET:@grpc//:grpc++_config_proto 05cc524e2c4b9309660fb7daa4e35db9 (1333167441 455593757)' (requested by nodes 'CONFIGURED_TARGET:@grpc//:grpc_plugin_support 05cc524e2c4b9309660fb7daa4e35db9 (136418248 455593757)') at com.google.devtools.build.skyframe.ParallelEvaluator$Evaluate.run(ParallelEvaluator.java:429) at com.google.devtools.build.lib.concurrent.AbstractQueueVisitor$WrappedRunnable.run(AbstractQueueVisitor.java:501) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) Caused by: java.lang.NullPointerException at com.google.devtools.build.lib.packages.NonconfigurableAttributeMapper.get(NonconfigurableAttributeMapper.java:45) at com.google.devtools.build.lib.bazel.rules.BazelRuleClassProvider$BazelPrerequisiteValidator.isTestOnlyRule(BazelRuleClassProvider.java:268) at com.google.devtools.build.lib.bazel.rules.BazelRuleClassProvider$BazelPrerequisiteValidator.validateDirectPrerequisiteForTestOnly(BazelRuleClassProvider.java:254) at com.google.devtools.build.lib.bazel.rules.BazelRuleClassProvider$BazelPrerequisiteValidator.validate(BazelRuleClassProvider.java:190) at com.google.devtools.build.lib.analysis.RuleContext$Builder.validateDirectPrerequisite(RuleContext.java:1937) at com.google.devtools.build.lib.analysis.RuleContext$Builder.createTargetMap(RuleContext.java:1610) at com.google.devtools.build.lib.analysis.RuleContext$Builder.build(RuleContext.java:1449) at com.google.devtools.build.lib.analysis.ConfiguredTargetFactory.createRule(ConfiguredTargetFactory.java:241) at com.google.devtools.build.lib.analysis.ConfiguredTargetFactory.createConfiguredTarget(ConfiguredTargetFactory.java:171) at com.google.devtools.build.lib.skyframe.SkyframeBuildView.createConfiguredTarget(SkyframeBuildView.java:491) at com.google.devtools.build.lib.skyframe.ConfiguredTargetFunction.createConfiguredTarget(ConfiguredTargetFunction.java:1024) at com.google.devtools.build.lib.skyframe.ConfiguredTargetFunction.compute(ConfiguredTargetFunction.java:249) at com.google.devtools.build.skyframe.ParallelEvaluator$Evaluate.run(ParallelEvaluator.java:370) ... 4 more ``` with this fix: ``` java.lang.RuntimeException: Unrecoverable error while evaluating node 'CONFIGURED_TARGET:@grpc//:grpc++_config_proto 26809c5247f58eb7a6314bd0e13655a1 (1551360347 275342100)' (requested by nodes 'CONFIGURED_TARGET:@grpc//:grpc_plugin_support 26809c5247f58eb7a6314bd0e13655a1 (859246773 275342100)') at com.google.devtools.build.skyframe.ParallelEvaluator$Evaluate.run(ParallelEvaluator.java:438) at com.google.devtools.build.lib.concurrent.AbstractQueueVisitor$WrappedRunnable.run(AbstractQueueVisitor.java:501) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) Caused by: java.lang.IllegalArgumentException: No such attribute testonly in rule protobuf_archive at com.google.devtools.build.lib.packages.AbstractAttributeMapper.getIndexWithTypeCheck(AbstractAttributeMapper.java:228) at com.google.devtools.build.lib.packages.AbstractAttributeMapper.get(AbstractAttributeMapper.java:57) at com.google.devtools.build.lib.packages.NonconfigurableAttributeMapper.get(NonconfigurableAttributeMapper.java:45) at com.google.devtools.build.lib.bazel.rules.BazelRuleClassProvider$BazelPrerequisiteValidator.isTestOnlyRule(BazelRuleClassProvider.java:266) at com.google.devtools.build.lib.bazel.rules.BazelRuleClassProvider$BazelPrerequisiteValidator.validateDirectPrerequisiteForTestOnly(BazelRuleClassProvider.java:252) at com.google.devtools.build.lib.bazel.rules.BazelRuleClassProvider$BazelPrerequisiteValidator.validate(BazelRuleClassProvider.java:196) at com.google.devtools.build.lib.analysis.RuleContext$Builder.validateDirectPrerequisite(RuleContext.java:1954) at com.google.devtools.build.lib.analysis.RuleContext$Builder.createTargetMap(RuleContext.java:1626) at com.google.devtools.build.lib.analysis.RuleContext$Builder.build(RuleContext.java:1465) at com.google.devtools.build.lib.analysis.ConfiguredTargetFactory.createRule(ConfiguredTargetFactory.java:245) at com.google.devtools.build.lib.analysis.ConfiguredTargetFactory.createConfiguredTarget(ConfiguredTargetFactory.java:176) at com.google.devtools.build.lib.skyframe.SkyframeBuildView.createConfiguredTarget(SkyframeBuildView.java:491) at com.google.devtools.build.lib.skyframe.ConfiguredTargetFunction.createConfiguredTarget(ConfiguredTargetFunction.java:1094) at com.google.devtools.build.lib.skyframe.ConfiguredTargetFunction.compute(ConfiguredTargetFunction.java:251) at com.google.devtools.build.skyframe.ParallelEvaluator$Evaluate.run(ParallelEvaluator.java:373) ... 4 more java.lang.RuntimeException: Unrecoverable error while evaluating node 'CONFIGURED_TARGET:@grpc//:grpc++_config_proto 26809c5247f58eb7a6314bd0e13655a1 (1551360347 275342100)' (requested by nodes 'CONFIGURED_TARGET:@grpc//:grpc_plugin_support 26809c5247f58eb7a6314bd0e13655a1 (859246773 275342100)') at com.google.devtools.build.skyframe.ParallelEvaluator$Evaluate.run(ParallelEvaluator.java:438) at com.google.devtools.build.lib.concurrent.AbstractQueueVisitor$WrappedRunnable.run(AbstractQueueVisitor.java:501) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) Caused by: java.lang.IllegalArgumentException: No such attribute testonly in rule protobuf_archive at com.google.devtools.build.lib.packages.AbstractAttributeMapper.getIndexWithTypeCheck(AbstractAttributeMapper.java:228) at com.google.devtools.build.lib.packages.AbstractAttributeMapper.get(AbstractAttributeMapper.java:57) at com.google.devtools.build.lib.packages.NonconfigurableAttributeMapper.get(NonconfigurableAttributeMapper.java:45) at com.google.devtools.build.lib.bazel.rules.BazelRuleClassProvider$BazelPrerequisiteValidator.isTestOnlyRule(BazelRuleClassProvider.java:266) at com.google.devtools.build.lib.bazel.rules.BazelRuleClassProvider$BazelPrerequisiteValidator.validateDirectPrerequisiteForTestOnly(BazelRuleClassProvider.java:252) at com.google.devtools.build.lib.bazel.rules.BazelRuleClassProvider$BazelPrerequisiteValidator.validate(BazelRuleClassProvider.java:196) at com.google.devtools.build.lib.analysis.RuleContext$Builder.validateDirectPrerequisite(RuleContext.java:1954) at com.google.devtools.build.lib.analysis.RuleContext$Builder.createTargetMap(RuleContext.java:1626) at com.google.devtools.build.lib.analysis.RuleContext$Builder.build(RuleContext.java:1465) at com.google.devtools.build.lib.analysis.ConfiguredTargetFactory.createRule(ConfiguredTargetFactory.java:245) at com.google.devtools.build.lib.analysis.ConfiguredTargetFactory.createConfiguredTarget(ConfiguredTargetFactory.java:176) at com.google.devtools.build.lib.skyframe.SkyframeBuildView.createConfiguredTarget(SkyframeBuildView.java:491) at com.google.devtools.build.lib.skyframe.ConfiguredTargetFunction.createConfiguredTarget(ConfiguredTargetFunction.java:1094) at com.google.devtools.build.lib.skyframe.ConfiguredTargetFunction.compute(ConfiguredTargetFunction.java:251) at com.google.devtools.build.skyframe.ParallelEvaluator$Evaluate.run(ParallelEvaluator.java:373) ... 4 more ``` Closes #2531. -- Reviewed-on: https://github.com/bazelbuild/bazel/pull/2531 PiperOrigin-RevId: 147814996 MOS_MIGRATED_REVID=147814996
* --proto_compiler points at @com_google_protobuf//:protocGravatar Carmi Grushko2017-02-17
| | | | | | | | This allows proto_library to be used out of the box by adding a repository entry that points to the protobuf distro in one's WORKSPACE file. -- PiperOrigin-RevId: 147808147 MOS_MIGRATED_REVID=147808147
* Rename 'extdir' to 'extclasspath'Gravatar Liam Miller-Cushon2017-02-17
| | | | | | | | | The targets contain the entries in the extdir and are used to construct a classpath, so the label is not actually a directory. -- PiperOrigin-RevId: 147798672 MOS_MIGRATED_REVID=147798672
* Stop building mandatory inputs of CppCompileAction twice.Gravatar Rumou Duan2017-02-17
| | | | | | | | Also Stop copying CcToolchainFeatures.Variables over when making copy of CppCompileActionBuilder. -- PiperOrigin-RevId: 147798008 MOS_MIGRATED_REVID=147798008
* Guard incremental dexing of lite protos in android builds with flagGravatar Googler2017-02-17
| | | | | | -- PiperOrigin-RevId: 147793223 MOS_MIGRATED_REVID=147793223
* Change header thinning feature to use dotd pruning to update action inputs.Gravatar Googler2017-02-17
| | | | | | -- PiperOrigin-RevId: 147788295 MOS_MIGRATED_REVID=147788295
* Make Android data binding work with ↵Gravatar Greg Estren2017-02-17
| | | | | | | | | | | | | | | | | | | | | --experimental_use_parallel_android_resource_processing. Without that flag, data binding already works via hooks in ApplicationManifest and AndroidResourceProcessingAction. The flag replaces AndroidResourceProcessingAction with three smaller processors: AndroidResourceParsingAction, AndroidResourceMergingAction, and AndroidResourceValidatorAction. So this change hooks the same logic into AndroidResourceMergingAction (at the equivalent place where data binding applies in the other pipeline). We could alternatively hook this into AndroidResourceValidatorAction (i.e. anywhere after resource merging completes and before aapt starts). But doing that would block Java compilation on aapt finishing, which the whole point of the flag is to unblock. -- PiperOrigin-RevId: 147770236 MOS_MIGRATED_REVID=147770236
* Remove class member enum CppSource#Type and instead subclass CppSource with ↵Gravatar Rumou Duan2017-02-17
| | | | | | | | | | different implementations, one for each CppSource#Type. Storing CppSource#Type in CppSource directly caused memory regression. -- PiperOrigin-RevId: 147765701 MOS_MIGRATED_REVID=147765701
* Set lipoScannables to an empty list if lipoScannableMap is empty.Gravatar Rumou Duan2017-02-17
| | | | | | -- PiperOrigin-RevId: 147765641 MOS_MIGRATED_REVID=147765641
* Remove support for configuring JDKs with filegroupsGravatar Liam Miller-Cushon2017-02-17
| | | | | | | | RELNOTES: Remove support for configuring JDKs with filegroups; use java_runtime and java_runtime_suite instead -- PiperOrigin-RevId: 147741653 MOS_MIGRATED_REVID=147741653
* [bazel] Added new java_toolchain entry timezoneData support.Gravatar Googler2017-02-17
| | | | | | -- PiperOrigin-RevId: 147741120 MOS_MIGRATED_REVID=147741120
* Make unnecessarily public BinaryOperationExpression methods privateGravatar Michajlo Matijkiw2017-02-17
| | | | | | | | | The reasons for these being public are outdated. Hide them so that no one gets too attached. -- PiperOrigin-RevId: 147739764 MOS_MIGRATED_REVID=147739764
* CppCompileAction must return false from inputsKnown for .d pruningGravatar Ulf Adams2017-02-17
| | | | | | | | | | | | | | | | | | | | | This is necessary (but not sufficient) for the action cache to work correctly. Consider the following sequence of events: 1. action is executed 2. .d pruning is performed 3. action cache writes entry with post-pruning inputs list 4. action gets regenerated (e.g., due to server restart) 5. the action cache calls inputsKnown(), which returns true 6. action cache checks entry from step 3 against pre-pruning inputs list, which results in a cache miss The action cache needs to know that the current list is not the final list, so inputsKnown() in step 5 must return false if .d pruning is enabled. This is a step towards resolving #2490. -- PiperOrigin-RevId: 147738367 MOS_MIGRATED_REVID=147738367
* Refactor AutoProfiler to enable other loggers to work.Gravatar Janak Ramakrishnan2017-02-17
| | | | | | -- PiperOrigin-RevId: 147734029 MOS_MIGRATED_REVID=147734029
* Rollback of commit 8fb311b4dced234b2f799c16c7d08148619f4087.Gravatar Dmitry Lomov2017-02-16
| | | | | | | | | | | | | | | | *** Reason for rollback *** Bisected by dmarting as a root cause of TF breakage: http://ci.bazel.io/job/TensorFlow/672/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/console *** Original change description *** Reinstate idleness checks where the server self-terminates when it's idle and there is either too much memory pressure or the workspace directory is gone. Arguably, it should kill itself when the workspace directory is gone regardless of whether it's idle or not, but let's first get us back to a known good state, then we can think about improvements. -- PiperOrigin-RevId: 147726386 MOS_MIGRATED_REVID=147726386
* Roll forward execroot changeGravatar Kristina Chodorow2017-02-16
| | | | | | | | | | | | | | | | | RELNOTES[INC]: Previously, an external repository would be symlinked into the execution root at execroot/local_repo/external/remote_repo. This changes it to be at execroot/remote_repo. This may break genrules/Skylark actions that hardcode execution root paths. If this causes breakages for you, ensure that genrules are using $(location :target) to access files and Skylark rules are using http://bazel.io/docs/skylark/lib/File.html's path, dirname, etc. functions. Custom crosstools that hardcode external/<repo> paths will have to be updated. Issue #1262. -- PiperOrigin-RevId: 147726370 MOS_MIGRATED_REVID=147726370
* Rollback of commit 686fde1b1aeb4e5d03dca7446cf39cd9f1114d79.Gravatar Dmitry Lomov2017-02-16
| | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks //src/test/shell/bazel:bazel_sandboxing_cpp_test on all platforms: http://ci.bazel.io/job/bazel-tests/567/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/ *** Original change description *** Disable .d input pruning My fix for input discovery is pending some changes by kchodorow, and this is blocking the next release. Temporary workaround for #2490. -- PiperOrigin-RevId: 147725685 MOS_MIGRATED_REVID=147725685
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-08 13:31:31 +0000