aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build
Commit message (Collapse)AuthorAge
...
* Replace calls to NestedSetBuilder#addAll(NestedSet) with addTransitiveGravatar Liam Miller-Cushon2016-07-14
| | | | | -- MOS_MIGRATED_REVID=127334869
* Don't treat empty files specially with respect to mtime/digest.Gravatar Janak Ramakrishnan2016-07-14
| | | | | | | RELNOTES: Bazel no longer regards an empty file as changed if its mtime has changed. -- MOS_MIGRATED_REVID=127328552
* Only include name for UserDefinedFunctionProfilingGravatar Michajlo Matijkiw2016-07-14
| | | | | | | | | | | These are called rather frequently I would imagine, but we don't profile often. Avoid useless object allocation. The SKYLARK_USER_FN qualifier and function name _should_ be enough to identify what's what, though I understand there could be duplicates. If this turns out to be an issue we can add more detail by memoizing location + name, but for now I'm inclined to treat it as YAGNI. -- MOS_MIGRATED_REVID=127328480
* Move more things from TestConstants to AnalysisMock and LoadingMock.Gravatar Ulf Adams2016-07-14
| | | | | | | Also remove other uses of TestConstants. -- MOS_MIGRATED_REVID=127327339
* Re-implement variables in the blaze query language. Instead of using a ↵Gravatar Nathan Harmata2016-07-14
| | | | | | | | | mutable global context of variable bindings, pass around immutable local contexts. The motivation is so we can safely evaluate all blaze query expressions concurrently under the hood. A global context is hostile to this goal. -- MOS_MIGRATED_REVID=127324600
* Use BuiltinFunction name for profilingGravatar Michajlo Matijkiw2016-07-14
| | | | | | | | | BuiltInFunction#call is pretty popular, avoid constructing a new string, or any object for that matter, every time we call it. FWIW the class name probably won't be particularly useful anyway since most built ins are anonymous. -- MOS_MIGRATED_REVID=127318185
* Properly support interaction of pre-grepped source files and LIPO even in theGravatar Googler2016-07-14
| | | | | | | | | presence of interface dependencies. The problem is that pre-grepped source files can be pulled in through CppCompileActions only available via lipoScannables. In this case, we need to make those pre-grepped source files inputs of the action or else we cannot be sure that the corresponding action is actually executed. -- MOS_MIGRATED_REVID=127317557
* Add all available toolchains to the FileProvider of cc_toolchain_suite.Gravatar Lukacs Berki2016-07-14
| | | | | | | This is necessary because we don't have a replacement for saying "this genrule needs the C++ toolchain" and I'd prefer this to do it in a backward-compatible way; burned myself here by trying to be principled, so let's now do the pragmatic thing. -- MOS_MIGRATED_REVID=127317024
* Upgrade to Hazelcast 3.6.Gravatar Dan Fabulich2016-07-14
| | | | | | | | | Fixes issue #1457. -- Change-Id: I913be48c924a48495f4da25a6710971c5c9d20b5 Reviewed-on: https://bazel-review.git.corp.google.com/#/c/3981/ MOS_MIGRATED_REVID=127314440
* Re-enable JDK logs. Fixes issue #1483.Gravatar Dan Fabulich2016-07-14
| | | | | | | -- Change-Id: I1c61b47ac1a6feac889ed8a02136edfd1e72b9e6 Reviewed-on: https://bazel-review.googlesource.com/#/c/3990/ MOS_MIGRATED_REVID=127313910
* Fixes Xcodegen when using --experimental_auto_top_level_union_objc_protos.Gravatar Sergio Campama2016-07-14
| | | | | -- MOS_MIGRATED_REVID=127313628
* Extract CppLinkAction.Builder to its own top level class.Gravatar Cal Peyser2016-07-13
| | | | | -- MOS_MIGRATED_REVID=127221256
* Fix native.existing_rule() when argument is an existing fileGravatar Laurent Le Brun2016-07-13
| | | | | -- MOS_MIGRATED_REVID=127218963
* Use canonical Java 7 javacopts in JavaProtoAspectGravatar Liam Miller-Cushon2016-07-13
| | | | | -- MOS_MIGRATED_REVID=127203325
* Rollback of commit feb1321044e3b7be34f9c1d7dacf9881d99a7327.Gravatar Klaus Aehlig2016-07-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Underlying issue fixed in commit 5b12f6e759c1f3137a7149d3026ff96686d07696 *** Original change description *** Automated [] rollback of commit a3381b6ac136a0cab3ba86020c739fe16b42cee9. *** Reason for rollback *** Broke bazel_rules_test See https://github.com/bazelbuild/bazel/issues/1501. *** Original change description *** Fix default for temporary directories to honor TMPDIR ...and only use the hard-coded "/tmp" as default for the default. Note that is unchanged that blaze.rpcserver.tmpdir still overrides. -- MOS_MIGRATED_REVID=127201018
* Glob arguments 'exclude' and 'exclude_directories' must be namedGravatar Laurent Le Brun2016-07-13
| | | | | | | | | | | Unamed arguments are confusing, e.g. glob(["*.java"], ["testing/*.java"]) The second list is actually excluded. RELNOTES: Glob arguments 'exclude' and 'exclude_directories' must be named -- MOS_MIGRATED_REVID=127190991
* Rollback of commit a3381b6ac136a0cab3ba86020c739fe16b42cee9.Gravatar Kristina Chodorow2016-07-12
| | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Broke bazel_rules_test See https://github.com/bazelbuild/bazel/issues/1501. *** Original change description *** Fix default for temporary directories to honor TMPDIR ...and only use the hard-coded "/tmp" as default for the default. Note that is unchanged that blaze.rpcserver.tmpdir still overrides. -- MOS_MIGRATED_REVID=127179462
* Open-source java_proto_library.Gravatar Carmi Grushko2016-07-12
| | | | | | | RELNOTES: New rule, java_proto_library, to generate Java bindings for protocol-buffers. -- MOS_MIGRATED_REVID=127136894
* In keep-going mode, don't fail-fast on the evaluation of an individual ↵Gravatar Janak Ramakrishnan2016-07-12
| | | | | | | SkyFunction if it throws an exception but still has missing deps. Instead, pretend it didn't throw, and restart it when its known deps are all done, presumably to throw the same exception. This removes a basic source of non-determinism. -- MOS_MIGRATED_REVID=127129202
* Fix internal documentationGravatar Dmitry Lomov2016-07-12
| | | | | -- MOS_MIGRATED_REVID=127126897
* --Gravatar Carmi Grushko2016-07-12
| | | | MOS_MIGRATED_REVID=127108931
* Rephrase Fingerprint in terms of guava HashFunction.Gravatar Eric Fellheimer2016-07-12
| | | | | | | This minimizes API divergence and allows us to make use of performance enhancements in guava, such as https://github.com/google/guava/issues/1197. -- MOS_MIGRATED_REVID=127108107
* RELNOTES: Improve Android split transition handling.Gravatar Googler2016-07-12
| | | | | -- MOS_MIGRATED_REVID=127099896
* --Gravatar Googler2016-07-12
| | | | MOS_MIGRATED_REVID=127091947
* Global cleanup change.Gravatar Googler2016-07-12
| | | | | -- MOS_MIGRATED_REVID=127084529
* Fix default for temporary directories to honor TMPDIRGravatar Klaus Aehlig2016-07-11
| | | | | | | | | | ...and only use the hard-coded "/tmp" as default for the default. Note that is unchanged that blaze.rpcserver.tmpdir still overrides. -- Change-Id: I2ad6b9904b7cde3917968090e85cf2d6c8ad88ab Reviewed-on: https://bazel-review.googlesource.com/#/c/3962 MOS_MIGRATED_REVID=127076270
* Expose ios_simulator_device/version to Skylark.Gravatar Googler2016-07-11
| | | | | | | | These are needed to add `blaze run` support to skylark_ios_application so that they can be passed in as parameters to the ios_runner script. -- MOS_MIGRATED_REVID=126955658
* Use fast-path compiler for android_binary R.classesGravatar Googler2016-07-11
| | | | | | | | | | | | | Hook up the RClassGeneratorAction to blaze code. This is currently only used for android_binary targets to build the final R classes of the binary + all of its libraries. Behind a flag and off by default (flip on later). -- MOS_MIGRATED_REVID=126935165
* Replace QueryableGraph#getBatch with #getBatchWithFieldHints. This allows ↵Gravatar Janak Ramakrishnan2016-07-11
| | | | | | | alternate graph implementations to optimize how they construct node entries. -- MOS_MIGRATED_REVID=126932020
* Refactor QueryableGraph and ThinNodeQueryableGraph to be independent ↵Gravatar Janak Ramakrishnan2016-07-11
| | | | | | | interfaces, in preparation for further changes. -- MOS_MIGRATED_REVID=126924789
* Remove hard-coded android and java7-compatible javacoptsGravatar Liam Miller-Cushon2016-07-11
| | | | | -- MOS_MIGRATED_REVID=126923745
* Fix capturing stdin/stdout on Windows.Gravatar Dmitry Lomov2016-07-11
| | | | | | | | | | | 1. Return EOF for streams representing Windows process pipes. 2. Fix the timing of process.close() 3. Un-synchronized reading of stderr and stdout. -- Change-Id: Iec98f45db9984be2c2b066962801cbd3ca60da3f Reviewed-on: https://bazel-review.googlesource.com/#/c/4000/ MOS_MIGRATED_REVID=126910063
* Add a final event on the event busGravatar Klaus Aehlig2016-07-11
| | | | | | | | | | | | | Add an event to the event bus that is guaranteed to come after the completion of the command. Listeners can use this event to clean up any resources that still need to be cleaned up. As first customer, add the ExperimentalEventHandler so that it is guaranteed not to leak the update thread. -- Change-Id: Ia20bae8a00541aa1338e49f74a7320ac098ab71d Reviewed-on: https://bazel-review.googlesource.com/#/c/4011 MOS_MIGRATED_REVID=126909844
* ExperimentalEventHandler: remove deadlock in update threadGravatar Klaus Aehlig2016-07-08
| | | | | | | | | | | | | | | | | When the progress bar has to be updated, but we cannot do so immediately, e.g., due to rate limiting, we start a thread to do this eventually (the "update thread"). That thread gets stopped if either we realize during an update of the progress bar that it is no longer needed, or if we get informed about the completion of the build. Now, since the update thread does updates of the progress bar (that is its whole purpose) it can get the duty to stop itself. To avoid the deadlock when the thread there blockingly waits for itself to terminate, just skip that termination and let the update thread run till the end of the build. -- Change-Id: Iba08806f5e416f1fa1825969eceaf6cf54c24e6c Reviewed-on: https://bazel-review.googlesource.com/#/c/4010 MOS_MIGRATED_REVID=126906395
* Move the verification of the JVM earlier in the client so that less time ↵Gravatar Lukacs Berki2016-07-08
| | | | | | | | | | | passes between the Ping() and Run() calls and make Ping() and Cancel() calls restart the server timeout interval. This "fixes" a race condition where the client would call Ping(), the server would time out and then the Run() call would fail. Of course, this is not an principled fix because in theory, the timeout can still happen between the two calls, but now there are only simple file system operations and a tiny bit of CPU use between the two so it should be vanishingly unlikely. We use ->Ping() to verify server liveness after we start it up, so in theory, the timeout could strike between those two calls, too... TESTED=By running "bazel --max_timeout_secs=2 info install_base" 100 times in a test and running the test 200 times. This procedure triggered the bug pretty reliably. -- MOS_MIGRATED_REVID=126902519
* Open-source ProtoSupportDataProvider.Gravatar Carmi Grushko2016-07-08
| | | | | -- MOS_MIGRATED_REVID=126850134
* More pieces of RClassGeneratorActionGravatar Googler2016-07-08
| | | | | | | | | | | | Add the rclass_generator.sh, and fill in the boiler-plate for mock tools, etc. Mostly cargo- culting references to resources_processor.sh. Rename earlier pieces to use RClassGenerator prefix instead of AndroidResourceCompilation. -- MOS_MIGRATED_REVID=126831848
* Use serverInit or globalInit where possible.Gravatar Ulf Adams2016-07-08
| | | | | -- MOS_MIGRATED_REVID=126813515
* Rollback of commit 1e37a5375f918376c132fa537e25695f673f41b8.Gravatar Dmitry Lomov2016-07-07
| | | | | | | | | | | | | *** Reason for rollback *** Apparently we now try to open output files for the process twice: once when we are constructing the output streams, and the second time when we tell the process to redirect its outputs. This causes the outputs to be empty on Windows *** Original change description *** Do redirection of stdout / stderr in Java instead of reimplementing it in every process wrapper again. -- MOS_MIGRATED_REVID=126801016
* Add a ServerBuilder, and use that in the module API.Gravatar Ulf Adams2016-07-07
| | | | | | | This change is similar to a previous change that introduced WorkspaceBuilder. -- MOS_MIGRATED_REVID=126799657
* Remove the forced-legacy mode of the JvmConfigurationLoader.Gravatar Ulf Adams2016-07-07
| | | | | -- MOS_MIGRATED_REVID=126797730
* Propagate the system root to every process created in WindowsSubprocessFactory.Gravatar Lukacs Berki2016-07-07
| | | | | | | | | | | This is apparently required by some versions MSVCRT.DLL including the one used in the CL.EXE we happen to be using for testing. This was learned by reading the source code of OpenJDK. Fixes #1480. -- MOS_MIGRATED_REVID=126786461
* Various fixes for gRPC mode:Gravatar Lukacs Berki2016-07-07
| | | | | | | | - Use the abrupt exit protocol to return the correct exit code when the server dies unexpectedly in gRPC mode - Report the command waiting time correctly even if the waiting is done within the server -- MOS_MIGRATED_REVID=126780186
* Refactor BuildingState to save memory.Gravatar Janak Ramakrishnan2016-07-07
| | | | | | | | | Collapse the "evaluating" boolean into the "signaledDeps" int field, since signaledDeps is always 0 if evaluating is false, so we can use the sentinel value -1 to indicate that evaluation has not yet started. This leads to a slightly less tolerant node entry: it must "start evaluating" before you can do things like set its value. Places that wasn't being done have been fixed, at least as far as we have test coverage for. Also, factor the "dirty" parts of BuildingState out into a subclass. It would probably be cleaner to use composition here, but I don't want to pay the price of another object. -- MOS_MIGRATED_REVID=126729331
* Add cc transitive headers to ide-resolve output groupGravatar Googler2016-07-07
| | | | | | | | | | Both source and generated hdrs are included in the output group. Might be cleaner to only include generated headers -- perhaps by adding a new field to CppCompilationContext. This solution seems lighter-weight, however. -- MOS_MIGRATED_REVID=126725901
* --Gravatar Carmi Grushko2016-07-07
| | | | MOS_MIGRATED_REVID=126723341
* Re-use the InMemoryNodeEntry#directDeps field for temporary direct deps.Gravatar Janak Ramakrishnan2016-07-07
| | | | | | | The biggest savings here is that we were not eagerly discarding the InMemoryNodeEntry#directDeps field after an entry was marked dirty, even though we would never read its value again. But rather than just fix that, by getting rid of the field in BuildingState, we can potentially save memory with smaller BuildingState objects as well. -- MOS_MIGRATED_REVID=126709632
* When building ObjectiveC++, pass the flag -std=gnu++11.Gravatar Googler2016-07-07
| | | | | | | | | | | | | | This is a rollback of a rollback, with the change that gnu++11 is used instead of c++11. A [] with this change was run, and the resulting handful of compile errors were addressed. Modified: blaze objc target handling, osx CROSSTOOL and mock osx CROSSTOOL. RELNOTES: When building ObjectiveC++, pass the flag -std=gnu++11. -- MOS_MIGRATED_REVID=126700947
* For Skylark attribute creation, non_empty is deprecated; introduce allow_emptyGravatar Laurent Le Brun2016-07-07
| | | | | | | #1433 -- MOS_MIGRATED_REVID=126693120
* Attr doc: fix typo, add linkGravatar Laurent Le Brun2016-07-07
| | | | | -- MOS_MIGRATED_REVID=126691559