| Commit message (Collapse) | Author | Age |
|
|
|
| |
PiperOrigin-RevId: 178262335
|
|
|
|
| |
PiperOrigin-RevId: 178250626
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary bacause //tools/jdk:current_host_java_runtime is implemented in Skylark, and we don't (and shouldn't) have a way to create MiddlemanProvider from there.
However, we are planning to move to the the java_runtime_alias/java_host_runtime_alias rules as the exclusive representation of the javabase, so we need to be able to make one from Skylark.
Previously, this wasn't a problem, because if the javabase was a filegroup (like //tools/defaults:jdk), the path to the Java binary was taken from the configuration and the middleman from the filegroup, but since we are removing that information from the configuration, we can't do that anymore.
RELNOTES: None.
PiperOrigin-RevId: 178242307
|
|
|
|
|
|
|
|
|
|
| |
Designed here:
https://docs.google.com/document/d/1hK2mWl3TYNL9oJYX_S020TKkXZvBw1aBoYERvTHVyfg/edit
Fix https://github.com/bazelbuild/bazel/issues/3402
Change-Id: I9beff94d8b85ffeb4e46e0959c8f5ed4ef9c6268
PiperOrigin-RevId: 178238408
|
|
|
|
|
|
|
|
|
|
|
|
| |
JavaSkylarkApiProvider will be deprecated soon and replaced by JavaInfo.
Methods exposed:
getCompilationInfoProvider()
getTransitiveExports()
Changed signature of JavaCommon methods to accept JavaInfoBuilder.
RELNOTES:none
PiperOrigin-RevId: 178229835
|
|
|
|
|
|
|
|
| |
Let's not expose middlemen to Skylark if we can help.
RELNOTES[INC]: The ctx.middle_man function is not supported anymore.
PiperOrigin-RevId: 178226393
|
|
|
|
|
|
|
| |
generating another temporary directory name instead of throwing an exception.
RELNOTES: None.
PiperOrigin-RevId: 178190769
|
|
|
|
|
|
|
| |
In particular, provide all of the statistics available from the getrusage() system call.
RELNOTES: None.
PiperOrigin-RevId: 178162687
|
|
|
|
|
|
|
| |
This avoids having to inline a bunch of default values when you only want to change one flag.
RELNOTES: None
PiperOrigin-RevId: 178148057
|
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 178130422
|
|
|
|
| |
PiperOrigin-RevId: 178116776
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This cl replaces entire hardcoded linkstamping command line generation with a
separate action. Instead of generating bash command
to compile linkstamp and prepending it to the standard link command line, this
cl creates a special action that link action depends on.
I kept linkstamp action registration in the CppLinkActionBuilder (and
GoCompilationHelper internally) to keep the cl shorter and change more
localized. I also didn't remove linkstamps and buildInfoHeaderArtifacts from
CppLinkAction to stay compatible with extra actions api. Both issues and
corresponding cleanups will be addressed in separate cls.
RELNOTES: Linkstamping is now a separate and full-blown CppCompileAction, it's
no longer a part of linking command.
PiperOrigin-RevId: 178106899
|
|
|
|
|
|
| |
RELNOTES[NEW]: query: Add option --noproto:flatten_selects to turn off flattening of selector lists in proto output.
PiperOrigin-RevId: 178106289
|
|
|
|
| |
PiperOrigin-RevId: 178105914
|
|
|
|
| |
PiperOrigin-RevId: 178100868
|
|
|
|
|
| |
Change-Id: I3248af31f9f6f3669177015c9f19ecd49165b191
PiperOrigin-RevId: 178096631
|
|
|
|
|
|
| |
rules/repository package.
PiperOrigin-RevId: 178087895
|
|
|
|
|
|
|
|
| |
RELNOTES: The deprecated builtin `set` is no longer allowed even from within
unexecuted code in bzl files. It's temporarily possible to use
--incompatible_disallow_uncalled_set_constructor=false if this change causes
incompatibility issues.
PiperOrigin-RevId: 178087669
|
|
|
|
|
|
|
|
|
| |
Extend the optional meta data that TestResults may
report by a flag indicating that the test was taken
from a remote cache. Also, allow reporting the precise
exit code of the test action.
PiperOrigin-RevId: 178075896
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 178074510
|
|
|
|
|
|
|
|
|
| |
since it is not allowed to have cc_library dependencies.
Fixes #4237
RELNOTES: None.
PiperOrigin-RevId: 178074296
|
|
|
|
|
|
|
|
|
| |
If a rule needs these template variables, it will need to declare a dependency on them in the future by adding @bazel_tools//tools/jdk:current_java_runtime to its toolchains= attribute.
RELNOTES[INC]: In order to access the template variables $(JAVA) and $(JAVABASE), @bazel_tools//tools/jdk:current_java_runtime needs to be added to the toolchains= attribute from now on.
RELNOTES: None.
PiperOrigin-RevId: 178070807
|
|
|
|
|
|
|
| |
ExecutionStatisticsProvider.
RELNOTES: None.
PiperOrigin-RevId: 178056182
|
|
|
|
|
|
|
|
| |
incremental_dexing attribute documentation.
RELNOTES: None.
PiperOrigin-RevId: 178047799
|
|
|
|
|
|
| |
This can occur in genqueries when a referenced package isn't in the scope.
PiperOrigin-RevId: 178038701
|
|
|
|
|
|
|
| |
1: Allow both in the same build (before, just one would trigger)
2: Don't check environment defaults from other groups, since neither
flag asserts any expectations on those groups
PiperOrigin-RevId: 178026699
|
|
|
|
|
|
|
|
| |
This is because I want to add another remote execution related tool, the remote_client, which will use the Remote Execution API to fetch blobs from a remote cache. I will use this tool as part of end-to-end tests for remote execution.
TESTED=remote integration tests, presubmit
RELNOTES: None
PiperOrigin-RevId: 177995895
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 177965330
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 177965009
|
|
|
|
|
|
|
|
|
|
|
| |
JavaSkylarkApiProvider will be deprecated soon and replaced by JavaInfo.
Methods exposed:
getGenJarsProvider()
Made changed in all relevant Java family rules, to build JavaGenJarsProvider provider and assign to JavaInfo
RELNOTES:none
PiperOrigin-RevId: 177950965
|
|
|
|
|
|
|
|
|
| |
This is arguably more correct, since output files don't have any tags, therefore you cannot exclude them by specifying tags to exclude.
Fixes #4012.
RELNOTES: None.
PiperOrigin-RevId: 177950851
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Context: java_import or other custom rules (genrules or Skylark) do not propagate coverage information. Coverage metadata is retrieved from the compilation information and it is passed around through providers as Artifact(s). The problem with the current implementation is that there is no way of retrieving instrumentation metadata from arbitrary jars provided by java_import or other custom rules.
--experimental_java_coverage solves the issue presented above ONLY for the java rules (has no effect for android/[]/etc).
Implementation details:
* For each build jar create a .txt file containing the relative path of each Java file. This file is included in the build jar. It is used for recreating the correct path for each covered file when included in the coverage report.
* java_binary/java_test will set 3 environment variables:
1) JACOCO_METADATA_JAR - in experimental mode will be a txt file containing all the jars considered for collecting coverage (JacocoCoverageRunner filters out the ones that don't have .uninstrumented.class files). In non-experimental mode will be a jar containing all the instrumented class files.
2) JACOCO_MAIN_CLASS - The main class to be called for the current coverage run. Previously this information was embedded in the JACOCO_METADATA_JAR's manifest.
3) JACOCO_JAVA_RUNFILES
RELNOTES: --experimental_java_coverage is available for testing.
PiperOrigin-RevId: 177941471
|
|
|
|
|
| |
RELNOTES: The --remote_rest_cache flag now respects --remote_timeout.
PiperOrigin-RevId: 177926523
|
|
|
|
|
|
|
|
| |
Fixes #3573
Closes #3574.
PiperOrigin-RevId: 177925152
|
|
|
|
|
|
|
| |
Part of #4128.
Change-Id: Id822d3ae6f8daf7c92a75bd8bd28590d4f625845
PiperOrigin-RevId: 177905460
|
|
|
|
|
| |
RELNOTES: The --host_platform and --platform flags are no longer experimental.
PiperOrigin-RevId: 177863761
|
|
|
|
|
|
|
|
|
| |
bundle_loader attribute
Prior to this change, apple_binary relied on bundle_loader targets (which are themselves apple_binary) to propagate an unwrapped ObjcProvider. That is deprecated, is disabled by --noexperimental_objc_provider_from_linked, and will be killed off shortly.
RELNOTES: None.
PiperOrigin-RevId: 177862573
|
|
|
|
|
|
|
|
|
| |
This does not provide any meaningful API to interact with ObjcProtoProvider from a skylark context -- it simply allows ObjcProtoProvider to be passed between skylark API calls as an opaque object.
This helps facilitate exposure of an Apple Linking API to Skylark which will take place in future changes.
RELNOTES: None.
PiperOrigin-RevId: 177844029
|
|
|
|
|
|
|
|
|
|
| |
Basically a refactor of https://github.com/bazelbuild/bazel/pull/2053, which separated the concepts of async and expunge but kept them intertwined at the option level. This was confusing to a number of users. The standard interface is to use one of --expunge, --async, or --expunge_async. --clean_style was more verbose and added no value, so can be removed.
The contents of actuallyClean() could use some ... actual cleaning. This CL just changes the options, removing some of the artificial option-related complexity.
RELNOTES[INC]: --clean_style is no longer an option.
PiperOrigin-RevId: 177843049
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In particular, SymlinkTreeAction no longer needs to accept artifacts
as an input. --experimental_enable_runfiles now immediately reports an
error on Windows.
This mostly unwinds e4974e4cc6aeb437d36b3b36eb20142b7120fb16
("Separate runfiles middlemen into two layers") and
41f4456ac2348bef66739194853a1ddadcbb887e ("Make runfiles tree creation
on Windows depend on the artifacts of the actual runfiles."). See
https://groups.google.com/d/msg/bazel-dev/btOAgxv434g/bDhTOOePAgAJ.
Change-Id: Iac3308669bfc07abfd1c91445922269d8fdc2a26
PiperOrigin-RevId: 177837504
|
|
|
|
|
|
|
|
|
| |
- Replace the existing Retrier with Retrier2.
- Rename Retrier2 to Retrier and remove the old Retrier + RetryException
class.
RELNOTES: None.
PiperOrigin-RevId: 177835070
|
|
|
|
|
|
|
|
| |
Fixes https://github.com/bazelbuild/bazel/issues/4028
Closes #4029.
PiperOrigin-RevId: 177813419
|
|
|
|
|
|
|
| |
Fixes #4056.
Change-Id: Ia7425c2146f15e9293605ee3da53007805e82275
PiperOrigin-RevId: 177813070
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
JavaSkylarkApiProvider will be deprecated soon and replaced by JavaInfo.
Methods exposed:
NestedSet<Artifact> getTransitiveSourceJars()
NestedSet<Artifact> getTransitiveRuntimeDeps()
NestedSet<Artifact> getTransitiveDeps()
Also created helped method to eliminate all duplication code and refactored some methods with is.
RELNOTES:none
PiperOrigin-RevId: 177804645
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The stub template now looks for the python binary relative to the
modules if a relative path was provided. This correctly finds it
inside the runfiles folder both when the py_binary is the output,
and when the py_binary is called by another binary
(ie is data for it).
We also now add the binary and dependencies to the runfiles when it
is used as data so python is accesible.
Change-Id: I3bf6ff17265e72d964614ad66af22933c89f853d
PiperOrigin-RevId: 177803641
|
|
|
|
|
|
|
|
| |
Resolves issue https://github.com/bazelbuild/bazel/issues/4146
Closes #4147.
PiperOrigin-RevId: 177803394
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a roll-forward of https://github.com/bazelbuild/bazel/commit/e8d32b7c922f65539b74357711d5ad6b70934115, which broke some genrules, but without
some cleanup changes which I'm submitting separately, and with a fix for the
bug.
The problem was that I switched from withExecLocations(labels) to
withExecLocations(); the original code was in CommandHelper, and the new
code in GenRuleBase, so this was not obvious.
Also, we didn't have test coverage for this case - note that the specified
labels are _added_ to the default map of labels, rather than replacing the
default map of labels. This only matters if the dependent rule provides a
GenRuleSourcesProvider, which only a single (Google-internal) rule does.
PiperOrigin-RevId: 177802902
|
|
|
|
|
|
|
| |
RELNOTES:
First argument of 'load' must be a label. Path syntax is removed.
(label should start with '//' or ':').
PiperOrigin-RevId: 177802628
|
|
|
|
|
|
|
|
|
|
| |
The same information is accessible as JavaRuntimeInfo.java_executable_exec_path. In order to access that, add an implicit attribute that depends on @bazel_tools//tools/jdk:current_java_runtime, then do
ctx.attr._java_runtime[java_common.JavaRuntimeInfo].java_executable_exec_path .
RELNOTES[INC]: The path to the JVM executable is not accessible anymore as ctx.{fragments,host_fragments}.jvm.java_executable. Use JavaRuntimeInfo.java_executable_exec_path instead.
PiperOrigin-RevId: 177786910
|
|
|
|
|
|
|
| |
RELNOTES: Bazel's default hash function was changed from MD5 to SHA256.
In particular, this affects users of remote caching and execution, as
all hashes will be SHA256 by default.
PiperOrigin-RevId: 177740702
|