| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
to be sure that no one uses it.
--
MOS_MIGRATED_REVID=90693216
|
|
|
|
|
|
|
| |
Some care was taken to make sure that we only log when a file is missing *after* the action is executed, when its failure to be present should force a build failure anyway, in order to avoid a source of memory pressure.
--
MOS_MIGRATED_REVID=90682557
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90649566
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rethrowing cause made sense a while ago, but now the only usages of this
method have a direct handle on the exception they want dealt with and
wrap the input with "new Exception(...)". Instead just pass the exception
along directly.
Also modified the comment in the unexpected case- the class referenced
does not exist anymore, from what I can tell, and thus the comment was
misleading.
--
MOS_MIGRATED_REVID=90623740
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90618694
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90616271
|
|
|
|
|
|
|
|
|
|
|
| |
Relative to the last try, add -B to Linux CROSSTOOL entry, and test
the result on OSX and Linux.
This should fix working with GCC cross compilers installed into
/usr/bin/ next to the host ld.
--
MOS_MIGRATED_REVID=90605463
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90574562
|
|
|
|
|
|
|
| |
better errors.
--
MOS_MIGRATED_REVID=90543663
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90543040
|
|
|
|
|
|
|
|
|
| |
We used to unconditionally add this file, but that doesn't make sense for crosstools that don't have it. Long-term, we need to get the name of this file from the CROSSTOOL file.
I was unable to test this because getting all of an older crosstool's dependencies into a test was too hard. But I manually verified that it works.
--
MOS_MIGRATED_REVID=90533610
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Broke bazel compile.sh build on Linux.
*** Original change description ***
Switch to @AutoValue for RuleDefintion.Metadata now that it is available.
--
MOS_MIGRATED_REVID=90529098
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90516252
|
|
|
|
|
|
|
| |
instead of linear search to find line numbers and paths.
--
MOS_MIGRATED_REVID=90504135
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Use AutoValue in Bazel.
Only FunctionSignature uses AutoValue for now.
* Take advantage of AutoValue's .hashCode() and .equals() methods
to intern function signatures, thus saving space.
In the future, this will allow for better caching of optimizations
for all function calls and struct accesses, base on pairs of
FunctionSignature and CallerSignature or list of names and field name.
--
MOS_MIGRATED_REVID=90482300
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90455131
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90441648
|
|
|
|
|
|
|
|
|
|
|
| |
ActionInputFileCache when given a digest to do a reverse lookup so that metadata can be more easily retrieved.
Discovered inputs are no longer ever put into SingleBuildFileCache, so it is safe to roll this forward now
Because of code changes (meant to ensure the safety of this change), there were conflicts that had to be manually resolved.
--
MOS_MIGRATED_REVID=90425783
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90418160
|
|
|
|
|
|
|
| |
Specifies function return values. Replaces old "builder" terminology. Removes bad advice.
--
MOS_MIGRATED_REVID=90417023
|
|
|
|
|
|
|
| |
functionality is gone.
--
MOS_MIGRATED_REVID=90289916
|
|
|
|
|
|
|
|
|
| |
ExtraAction itself.
This makes ExtraAction simpler to understand (IMO). It's also a prerequisite for some simplifications we're making in core.
--
MOS_MIGRATED_REVID=90288551
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90282858
|
|
|
|
|
|
|
|
|
|
|
| |
(i) Change the semantics of KeyedLocker.AutoUnlocker#close such that it can be called at most once per AutoUnlocker instance.
(ii) Change KeyedLocker.AutoUnlocker#close to throw a IllegalUnlockException (RuntimeException) on error, rather than leave the behavior intentionally underspecified.
(iii) explicitly mention in AutoLocker#lock that a thread can call lock(k) multiple times before unlocking. Combined with (i), this implies that KeyedLocker#lock implementations will want to return fresh AutoUnlocker instances.
These semantics are bit nicer to use anyway, but I also want them because I will soon be introducing KeyedLocker#lockBatch, and it's much easier to specify that given the above.
--
MOS_MIGRATED_REVID=90259645
|
|
|
|
|
|
|
| |
Fixes #91.
--
MOS_MIGRATED_REVID=90185784
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks bazel for /usr/bin/gcc. It needs -B to find ld, because we don't supply a $PATH.
*** Original change description ***
Remove unnecessary -B flag from linker command line.
This should fix working with GCC cross compilers installed into
/usr/bin/ next to the host ld.
--
MOS_MIGRATED_REVID=90173200
|
|
|
|
|
|
|
|
| |
This should fix working with GCC cross compilers installed into
/usr/bin/ next to the host ld.
--
MOS_MIGRATED_REVID=90167821
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90157406
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90157149
|
|
|
|
|
|
|
| |
Use ctx.var dict instead.
--
MOS_MIGRATED_REVID=90155461
|
|
|
|
|
|
|
| |
HashMultimap provides no guarantee on the iteration order.
--
MOS_MIGRATED_REVID=90153110
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90151316
|
|
|
|
|
|
|
|
| |
Reduce the number of error message after a parse error.
Recover only when we have confidence we are in good state.
--
MOS_MIGRATED_REVID=90147322
|
|
|
|
|
|
|
| |
the fact that a valid Target exists, and instead request it directly from its Package.
--
MOS_MIGRATED_REVID=90107670
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90103351
|
|
|
|
|
|
|
| |
See https://github.com/google/bazel/issues/88.
--
MOS_MIGRATED_REVID=90089965
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90081310
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added "-Tests$" to the default instrumentation_filter, this is the typical pattern for Objective C.
All sources are included in ObjcCommon.SOURCE.
Sources from targets which match the current instrumentation_filter are included in ObjcCommon.INSTRUMENTED_SOURCE.
GCNOs are added to ObjcCommon.GCNO iff the source they originate from is included in from a target which matches the instrumentation_filter.
RELNOTES: --instrumentation_filter now works with Objective C coverage.
--
MOS_MIGRATED_REVID=90076465
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90075856
|
|
|
|
|
|
|
|
| |
This class is poorly documented and the API is not well thought. We cannot
remove it now (because it is used) though.
--
MOS_MIGRATED_REVID=90070889
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90061800
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90061261
|
|
|
|
|
|
|
|
|
| |
Careful, this is a breaking change.
To get the Label value as before, use ctx.attr.<labelattr>.label.
The goal is to remove ctx.targets and simplify access to label attributes.
--
MOS_MIGRATED_REVID=90056829
|
|
|
|
|
|
|
|
|
|
|
|
| |
The goal of this change is to provide a means for disallowing
files outside of declared, known locations in order to better
enforce the hermeticy and in turn reproducability of builds.
Previously when encountering these files (typically via external
symlinks) we would add a dependency on build_id, now we can
optionally fail the build.
--
MOS_MIGRATED_REVID=90015665
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=90004683
|
|
|
|
|
|
|
|
|
|
| |
By popular demand from other implementers, reorder BuiltinFunction arguments
so that mandatory named-only arguments come befor optional named-only arguments
rather than after. This will make Skylark internals slightly clearer and less
surprising, at the cost of eschewing a tiny optimization.
--
MOS_MIGRATED_REVID=89978554
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89977206
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89973895
|
|
|
|
|
|
|
| |
RELNOTES: Always define OS_IOS in iOS builds.
--
MOS_MIGRATED_REVID=89969990
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89964638
|