aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build
Commit message (Collapse)AuthorAge
* Make a copy of the list when passing the value from Skylark to BUILD.Gravatar Laurent Le Brun2015-10-14
| | | | | | | | | | | | This change affects only lists, because it is the only mutable type. The change is also temporary. We will later make the list immutable (when it comes from a different context) and we will be able to remove the copy. This fixes a critical bug where values could be mutated from a BUILD file and affect other BUILD files. -- MOS_MIGRATED_REVID=105400506
* Reimplement target pattern parsing in Skyframe.Gravatar Ulf Adams2015-10-14
| | | | | | | | This is currently not hooked up, and we're passing (potentially) massive numbers of targets around. -- MOS_MIGRATED_REVID=105395404
* Make package not Java serializableGravatar Michajlo Matijkiw2015-10-14
| | | | | | | No need for this, remove to cut out some cruft/room for accidents. -- MOS_MIGRATED_REVID=105378202
* Mostly lockless updates of remainingTasks counterGravatar Mark Schaller2015-10-14
| | | | | | | | | Uses an AtomicLong to count remaining tasks. Only obtains the zeroRemainingTasks lock when remaining tasks have gone to zero or the codepath needs to wait on that condition. -- MOS_MIGRATED_REVID=105348523
* Minor tidying of AbstractQueueVisitorGravatar Mark Schaller2015-10-13
| | | | | | | | | | Removes unnecessary final keyword on private methods, inlines the un-overridden protected method getWorkQueue, and restructures internal constructors to be flatter (i.e. every constructor implementation calls at most one other constructor). -- MOS_MIGRATED_REVID=105344413
* Add HTML profiler execution phase statisticsGravatar Klaas Boesche2015-10-13
| | | | | | | | Re-adds the missing execution phase statistics which got lost in the recent ProfileCommand refactoring. -- MOS_MIGRATED_REVID=105340677
* Allow other ExecutorService implementations in AbstractQueueVisitorGravatar Mark Schaller2015-10-13
| | | | | | | Previously, only ThreadPoolExecutor implementations were allowed. -- MOS_MIGRATED_REVID=105340237
* Only open and read the BUILD file when we don't have a cached preprocessing ↵Gravatar Nathan Harmata2015-10-13
| | | | | | | | | result. This is a step in the right direction towards the goal of opening and reading each BUILD file exactly once. -- MOS_MIGRATED_REVID=105338761
* Rollback of unknown previous commit.Gravatar Googler2015-10-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Broke bazel build. *** Original change description *** Update iossim for Xcode 7 support. As of Xcode 7, supportedDeviceTypesByName was replaced by supportedDeviceTypesByAlias. This is from latest chromium build. Downstream hash is 9dd179a339c0457f8754069e0774b38f69c258a8. The latest merge was to upstream ef05b7da00844c0d500c4a7f20d4095dab56e7fe *** Also includes the following changes: Size the Lexer tokenization to minimize internal resizing. This value is chosen empirically. -- Fixes toolchain selection in the generated Android NDK crosstools by making each target_cpu and compiler field unique. Note that there are some problems with the clang compilers (e.g. can't find ld), which I'll fix in a subsequent change. -- Update iossim for Xcode 7 support. As of Xcode 7, supportedDeviceTypesByName was replaced by supportedDeviceTypesByAlias. This is from latest chromium build. Downstream hash is 9dd179a339c0457f8754069e0774b38f69c258a8. The latest merge was to upstream ef05b7da00844c0d500c4a7f20d4095dab56e7fe -- MOS_MIGRATED_REVID=105337154
* Improves the error message for invalid cpu (--cpu or --fat_apk_cpu).Gravatar Alex Humesky2015-10-13
| | | | | | | | | | | | | | | | | | | | | | | | | Before: ERROR: No toolchain found for cpu 'x84'. After: ERROR: No toolchain found for cpu 'x84'. Valid cpus are: [ armeabi, armeabi-v7a, armeabi-v7a-hard, armeabi-thumb, armeabi-v7a-thumb, armeabi-v7a-hard-thumb, arm64-v8a, mips, mips64, x86, x86_64, ]. -- MOS_MIGRATED_REVID=105324190
* Makes the error message for invalid or duplicate crosstool toolchains more ↵Gravatar Alex Humesky2015-10-13
| | | | | | | | | | | | | | | | | | | | | | | | | | legible by putting each flag combination on its own line. E.g. from this: ERROR: No toolchain found for --cpu='foo' --compiler='bar' --glibc='baz'. Valid toolchains are: [ --cpu='armeabi-v7a' --compiler='compiler' --glibc='armeabi-v7a', --cpu='armeabi-v7a' --compiler='compiler' --glibc='armeabi-v7a', --cpu='local' --compiler='compiler' --glibc='local', --cpu='darwin' --compiler='compiler' --glibc='macosx', --cpu='freebsd' --compiler='compiler' --glibc='local', --cpu='k8' --compiler='windows_mingw' --glibc='local', --cpu='k8' --compiler='windows_msys64_mingw64' --glibc='local', --cpu='k8' --compiler='windows_clang' --glibc='local',]. to this: ERROR: No toolchain found for --cpu='foo' --compiler='bar' --glibc='baz'. Valid toolchains are: [ --cpu='armeabi-v7a' --compiler='compiler' --glibc='armeabi-v7a', --cpu='armeabi-v7a' --compiler='compiler' --glibc='armeabi-v7a', --cpu='local' --compiler='compiler' --glibc='local', --cpu='darwin' --compiler='compiler' --glibc='macosx', --cpu='freebsd' --compiler='compiler' --glibc='local', --cpu='k8' --compiler='windows_mingw' --glibc='local', --cpu='k8' --compiler='windows_msys64_mingw64' --glibc='local', --cpu='k8' --compiler='windows_clang' --glibc='local', ]. (notice there is a duplicate toolchain) -- MOS_MIGRATED_REVID=105313547
* Add the remainder of support_v7 to android_sdk_repository that can beGravatar Todd Jeffreys2015-10-13
| | | | | | | referenced via "//external:android/xyz_v7" -- MOS_MIGRATED_REVID=105313228
* Delete unused method in AbstractQueueVisitor.Gravatar Janak Ramakrishnan2015-10-13
| | | | | -- MOS_MIGRATED_REVID=105312426
* Split off 2 BUILD files.Gravatar Han-Wen Nienhuys2015-10-13
| | | | | -- MOS_MIGRATED_REVID=105301167
* Make the sandbox handle an arbitrary number of argumentsGravatar Brian Silverman2015-10-13
| | | | | | | | | | I was hitting argument length restrictions when trying to run rules which take 2 GCC installs and a Clang install as inputs. -- Change-Id: Iee27bb6fb50fe94bff4b2500bbcfa9381b05d63d Reviewed-on: https://bazel-review.googlesource.com/#/c/2090 MOS_MIGRATED_REVID=105300670
* Make the /... recursive package target wildcard traverse symlinks.Gravatar Lukacs Berki2015-10-13
| | | | | | | | | This works because we resolve the FileValue for every directory found during the traversal, therefore, symlink cycles and symlink structures giving rise to infinite directory trees are handled correctly (that is to say, the same way as they are handled during globbing) Fixes #274. -- MOS_MIGRATED_REVID=105290852
* Fix PackageFunction#loadPackage preprocessing result cache memory leak on ↵Gravatar Nathan Harmata2015-10-13
| | | | | | | | | error from SkylarkImportResult dep. This is part of a series of changes with the net result being that we open, read, and parse each BUILD file exactly once. -- MOS_MIGRATED_REVID=105253634
* Enable Blaze profiling for the VFS_READ on InputStream#read(), since some ↵Gravatar Nathan Harmata2015-10-13
| | | | | | | | | helper classes do call that method to see if the stream has more data. This is part of a series of changes with the net result being that we open, read, and parse each BUILD file exactly once. -- MOS_MIGRATED_REVID=105253425
* Automated [] rollback of [] + merge with []Gravatar Nathan Harmata2015-10-13
| | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Original CL uncovered a depot issue which was fixed in []. I verified it was the only such issue (see []). *** Original change description *** Rollback of commit f87a414a6bf50613a2c419e53a96f76154f44ae3. *** Reason for rollback *** Rolling back until [] is submitted and we have verified that there are no other breakages *** Original change description *** Handle the case of infinite symlink expansion where a path in a symlink chain is a symlink to an ancestor of a path in the chain. -- MOS_MIGRATED_REVID=105251788
* Make SkyFunctions.SKYLARK_IMPORT_CYLCE publicGravatar Michajlo Matijkiw2015-10-13
| | | | | | | Makes it consistent with the rest of the file. -- MOS_MIGRATED_REVID=105233324
* Rename IOS_SDK_VERSION_OVERRIDE to APPLE_SDK_VERSION_OVERRIDE, as it need ↵Gravatar Chris Parsons2015-10-13
| | | | | | | not be locked to iOS SDK. -- MOS_MIGRATED_REVID=105231425
* Refactor cycle related skyvalues to use shared empty valueGravatar Michajlo Matijkiw2015-10-13
| | | | | | | | | | | Previously the cycle values (were supposed to) share a common abstract base class, however usage was inconsistent. Instead refactor to eliminate the specialized value classes, remove the abstract class, and share a common empty placeholder value, which should be useful for future/other current empty values. -- MOS_MIGRATED_REVID=105217399
* Description redacted.Gravatar Googler2015-10-13
| | | | | -- MOS_MIGRATED_REVID=105214382
* Add timing info for tests and correct caching vs. run ratioGravatar Kristina Chodorow2015-10-13
| | | | | | | | | | | | | | | Now prints: //foo:bar (cached) PASSED in 0.1s instead of: //foo:bar (1/0 cached) PASSED Fixes #218. -- MOS_MIGRATED_REVID=105210302
* LTO: Don't choke on cc_library without srcs.Gravatar Han-Wen Nienhuys2015-10-12
| | | | | -- MOS_MIGRATED_REVID=105204997
* Added android_compiler flag.Gravatar Austin Schuh2015-10-12
| | | | | | | | | | | | Added a flag which allows the user to specify the android compiler. This commit also disconnects the android compiler from the main --compiler flag. Changing the --compiler flag won't change the compiler used by the android rules. -- Change-Id: I788d3a353a1cc304e1c015b9dd283258e6e172d4 Reviewed-on: https://bazel-review.googlesource.com/2112 MOS_MIGRATED_REVID=105203751
* Make Bazel use tools that are embedded in its binary.Gravatar Lukacs Berki2015-10-12
| | | | | | | This requires changing all "//tools/language:target" implicit dependencies to "@tools//tools/language:target". -- MOS_MIGRATED_REVID=105193805
* Show documentation for --objc_generate_debug_symbolsGravatar Peter Schmitt2015-10-12
| | | | | -- MOS_MIGRATED_REVID=105175791
* Don't iterate over children when building events if events won't be stored ↵Gravatar Janak Ramakrishnan2015-10-12
| | | | | | | anyway. Also batch retrievals of children when building events. -- MOS_MIGRATED_REVID=105174435
* Add isSource to Android aspect ArtifactLocation.Gravatar Googler2015-10-12
| | | | | | | | This supersedes bin/gen files on Android SDK. The fields are removed entirely since the proto isn't public yet. -- MOS_MIGRATED_REVID=105130701
* Clear interrupt bit before processing any error thrown by SkyFunction during ↵Gravatar Janak Ramakrishnan2015-10-12
| | | | | | | error bubbling. -- MOS_MIGRATED_REVID=105102597
* Delay additions as well as removals of reverse deps. Now that removals are ↵Gravatar Janak Ramakrishnan2015-10-12
| | | | | | | | | | | not all done during invalidation, repeated adding/removing means that we are consolidating more often, negating the benefit of delayed removals. To work around this, delay adds as well until we consolidate and verify the integrity of our data. Since there is no well-defined point that a consolidation should trigger for a done node, we delay until our pending list is as large as the done list. We can tweak this if necessary for a memory/performance tradeoff. The alternative to this that I could think of is giving up our strong integrity checks, which I'm not a fan of. -- MOS_MIGRATED_REVID=105095886
* Track skylark import cycles in terms of PackageIdentifiersGravatar Michajlo Matijkiw2015-10-12
| | | | | | | | | | We don't have any strong guarantees around the stability of SkyKey#toString(), which we rely on to canonicalize cycles. We can reasonably expect PackageIdentifier#toString() to be stable enough though. We also hide away the cycle detection details from external code in this change. -- MOS_MIGRATED_REVID=105093095
* Rollback of commit 0f1b041c23e7cc3a2af4bb47a6cd1f3a331b5a4f.Gravatar Shreya Bhattarai2015-10-12
| | | | | | | | | | | | | *** Reason for rollback *** Rolling back until [] is submitted and we have verified that there are no other breakages *** Original change description *** Handle the case of infinite symlink expansion where a path in a symlink chain is a symlink to an ancestor of a path in the chain. -- MOS_MIGRATED_REVID=105080445
* Log immediately when AbstractQueueVisitor encounters a critical error.Gravatar Eric Fellheimer2015-10-12
| | | | | | | If there's a holdup propagating the exception, at least we will see it in the logs. -- MOS_MIGRATED_REVID=105075242
* Do not change cwd when building J2ObjC protos.Gravatar Lukacs Berki2015-10-09
| | | | | | | | | This is superfluous because when an action is executed, the cwd is always the exec root we always pass exec paths on the command line. This is necessary because this doesn't work if the proto compiler tool is not in the main repository. -- MOS_MIGRATED_REVID=105057016
* Rename protobuf targets to xxx_proto.Gravatar Han-Wen Nienhuys2015-10-09
| | | | | -- MOS_MIGRATED_REVID=105054615
* Make it possible to load the tools/defaults package without a BUILD file ↵Gravatar Lukacs Berki2015-10-09
| | | | | | | | | present. This is nice because this removes the last thing Bazel needs to be able to function without a tools/ directory that is not already embedded into the binary. -- MOS_MIGRATED_REVID=105054134
* Add support for filesets in LinuxSandboxedStrategy.Gravatar Philipp Wollermann2015-10-09
| | | | | -- MOS_MIGRATED_REVID=105052078
* Add combine option for multiple profile file statsGravatar Klaas Boesche2015-10-09
| | | | | | | | Add the --combine option to produce a single aggregated statistics output for multiple profile files. Outputs neither Skylark histograms nor the task chart. -- MOS_MIGRATED_REVID=105051164
* Description redacted.Gravatar Nathan Harmata2015-10-09
| | | | | -- MOS_MIGRATED_REVID=105050723
* Make RedirectChaser follow redirects through external repositories correctly ↵Gravatar Lukacs Berki2015-10-09
| | | | | | | and implement a "@//" label syntax that always points to the main repository. -- MOS_MIGRATED_REVID=105041493
* For standalone spawn strategy (local execution), bootstrap ios SDKROOT ↵Gravatar Chris Parsons2015-10-09
| | | | | | | (determined from xcrun) for applicable actions -- MOS_MIGRATED_REVID=105000617
* Replace LoadingCache<String, Label> with Interner<Label> in order to save ↵Gravatar Miguel Alcon Pinto2015-10-09
| | | | | | | memory. -- MOS_MIGRATED_REVID=104998704
* Visibility tweaksGravatar Michajlo Matijkiw2015-10-09
| | | | | -- MOS_MIGRATED_REVID=104989776
* Be more specific about InMemoryNodeEntry.getGroupedDirectDepsGravatar Mark Schaller2015-10-09
| | | | | -- MOS_MIGRATED_REVID=104983790
* Remove useless explicit 'stat' call on the BUILD file in directories ↵Gravatar Nathan Harmata2015-10-09
| | | | | | | encountered during legacy globbing (note that we end up doing this stat anyway in the 'locator.getBuildFileForPackage' call). The old motivation for this is obsolete; we have incremental correctness from Skyframe. -- MOS_MIGRATED_REVID=104982764
* Add the ability to filter out attributes when doing queries.Gravatar Miguel Alcon Pinto2015-10-09
| | | | | -- MOS_MIGRATED_REVID=104979750
* Remove dead code.Gravatar Nathan Harmata2015-10-09
| | | | | -- MOS_MIGRATED_REVID=104979604
* Add executable option to http_fileGravatar Kristina Chodorow2015-10-09
| | | | | | | | | | | | | This also simplifies the decompressor code a bit and actually adds lib/bazel/repository tests to a test rule. Fixes #497. RELNOTES[NEW]: http_file can specify "executable" to make the downloaded file runnable. -- MOS_MIGRATED_REVID=104975488