| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
| |
Skyframe globbing. This adds a log(n) factor to uses of globs, but getting globs to be returned in a reasonable order that can be emulated by legacy globbing is hard and bug-prone right now, and we must sort anyway if we are merging legacy and Skyframe globs.
Note that this log(n) factor is already present on clean builds with legacy globbing. If we end up seeing performance issues on incremental loading, we can investigate making GlobFunction efficiently return elements in sorted order. (We would still need to sort if merging legacy and Skyframe globs, but that should be a relatively rare occurrence, and can be dealt with by a more efficient merge sort if necessary.)
--
MOS_MIGRATED_REVID=127752554
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127747661
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127735980
|
|
|
|
|
|
|
| |
Fixes #1125.
--
MOS_MIGRATED_REVID=127719941
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Let's launch open-source java_proto_library with strict-deps checking turned on by default.
*** Original change description ***
Unveil Bazel's proto_library and java_proto_library.
--
MOS_MIGRATED_REVID=127716437
|
|
|
|
|
|
|
| |
Instead have callers get it via package.
--
MOS_MIGRATED_REVID=127715494
|
|
|
|
|
|
|
| |
In theory, now we can cancel Ping() and Cancel() RPCs, too, but since we don't tell their UUID anyone, we are fine.
--
MOS_MIGRATED_REVID=127703598
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127701838
|
|
|
|
|
|
|
| |
unlike System#currentTimeMillis().
--
MOS_MIGRATED_REVID=127697254
|
|
|
|
|
|
|
| |
Isn't strictly necessary, remove it before anyone decides they want to use it.
--
MOS_MIGRATED_REVID=127585617
|
|
|
|
|
|
|
|
|
| |
rather than a PRECOMPUTED value.
Having a stale TopLevelArtifactContext leads to invalidation of all the top level target nodes, causing time wasted due to a lot of cache hits for a null build.
--
MOS_MIGRATED_REVID=127585059
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change:
Any given cc_library can only contribute one library with a given name to
targets which depend on it. If an input library has the same name as the
cc_library which it is an input to, the decision of which to use is based
on the link mode. e.g.,
cc_library(
name = "foo",
srcs = ["foo.c", "libfoo.so"],
)
will only contribute libfoo.a (a static library containing foo.o) in static mode,
while it will only contribute libfoo.so (the precompiled shared library) in dynamic
mode.
This change alters cc_library's behavior in this case:
* If libfoo.a would be empty (i.e., there are no linkable sources), then
this is allowed. The libfoo.so from srcs is simply passed through. (Previously,
the empty libfoo.a would be forwarded.)
* Otherwise, this is an error.
In the case where there are multiple libraries in the srcs with the same
library identifier (lib[name].[a|so|lo]), cc_library will still choose one
based on the link mode. This behavior has not changed.
Similarly, cc_library will still choose one of its own outputs based on the
link mode. That behavior has not changed either.
RELNOTES[INC]: It is now an error to include a precompiled library (.a, .lo, .so)
in a cc_library which would generate a library with the same name
(e.g., libfoo.so in cc_library foo) if that library also contains other linkable
sources.
--
MOS_MIGRATED_REVID=127569615
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127543896
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127538990
|
|
|
|
|
|
|
| |
--
Change-Id: I3255a14a60b7ae7749c49d5a885d92f4f19ec84f
Reviewed-on: https://bazel-review.git.corp.google.com/#/c/3980/
MOS_MIGRATED_REVID=127537367
|
|
|
|
|
|
|
|
|
| |
-XX:TieredStopAtLevel=1 instead of -client, as the latter is ignored on 64-bit JVMs since at least JDK 6.
The new flags have been shown to cut down CPU time by 50% due to reduced time spent in JIT and improving overall run time for short running actions, some times also cutting them in half.
--
MOS_MIGRATED_REVID=127536578
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127531480
|
|
|
|
|
|
|
| |
are already compiled into a proto runtime.
--
MOS_MIGRATED_REVID=127489419
|
|
|
|
|
|
|
| |
What we really are doing here is formatting.
--
MOS_MIGRATED_REVID=127481183
|
|
|
|
|
|
|
|
|
| |
Turns out that our existing test coverage was insufficient for catching this (I
misread the tests during development of unknown commit and thus incorrectly
thought we had test coverage for this).
--
MOS_MIGRATED_REVID=127461716
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127458867
|
|
|
|
|
|
|
|
|
|
| |
The new packaging rules need these in order to access resources included in
objc_library dependencies of an application.
RELNOTES:
--
MOS_MIGRATED_REVID=127445152
|
|
|
|
|
|
|
|
| |
select() as "nonconfigurable", polish up general configurable
attributes docs.
--
MOS_MIGRATED_REVID=127440164
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127435666
|
|
|
|
|
|
|
|
|
|
|
| |
related to tests.
This allows for better caching and also makes it easy to run tests in a different directory than the global execroot.
The paths are rewritten to absolute paths in test-setup.sh, because Test Encyclopedia says that we pass absolute paths to tests in these variables.
--
MOS_MIGRATED_REVID=127432675
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127425448
|
|
|
|
|
|
|
|
|
| |
and commit 6388680b44893c2b3ccddd73f6c4abb693a18cd4 now that the incompatibilities have been resolved.
RELNOTES[INC]: The host_platform and target_platform entries are not written to the master log anymore.
--
MOS_MIGRATED_REVID=127417109
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Broke Android targets with native code when cpu is explicitly set.
*** Original change description ***
RELNOTES: Improve Android split transition handling.
--
MOS_MIGRATED_REVID=127377943
|
|
|
|
|
|
|
| |
The classpaths get split during flag parsing, so joining them is unnecessary.
--
MOS_MIGRATED_REVID=127377219
|
|
|
|
|
|
|
|
|
|
| |
Saves some needless garbage generation. We expect TestSize#getTestSize(String)
to always pass in a lowercase value, which we promptly change to uppercase for
the enum lookup. Instead memoize the lowercase -> TestSize mapping to avoid
this call.
--
MOS_MIGRATED_REVID=127362499
|
|
|
|
|
|
|
|
|
|
|
| |
and use it to work around an analysis performance regression caused by header
compilation. SpawnAction expands the full argument list and compares the length
to --min_param_file_size when deciding whether to use a params file, and header
compilation actions often have very long JoinExecPathsArg fragemnts that are
expensive to expand.
--
MOS_MIGRATED_REVID=127354241
|
|
|
|
|
|
|
|
|
|
|
| |
ThinLTO isn't fully supported for host builds, in order to handle this add
support for enabling either a 'host' or 'target' feature in the configuration.
The thin_lto feature will require the new 'target' configuration.
Companion crosstool change: unknown commit.
--
MOS_MIGRATED_REVID=127350506
|
|
|
|
|
|
|
| |
This is equivalent to the deprecation of NestedSetBuilder#addAll(NestedSet).
--
MOS_MIGRATED_REVID=127336417
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127334955
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127334869
|
|
|
|
|
|
|
| |
RELNOTES: Bazel no longer regards an empty file as changed if its mtime has changed.
--
MOS_MIGRATED_REVID=127328552
|
|
|
|
|
|
|
|
|
|
|
| |
These are called rather frequently I would imagine, but we don't profile often. Avoid
useless object allocation. The SKYLARK_USER_FN qualifier and function name _should_
be enough to identify what's what, though I understand there could be duplicates. If
this turns out to be an issue we can add more detail by memoizing location + name,
but for now I'm inclined to treat it as YAGNI.
--
MOS_MIGRATED_REVID=127328480
|
|
|
|
|
|
|
| |
Also remove other uses of TestConstants.
--
MOS_MIGRATED_REVID=127327339
|
|
|
|
|
|
|
|
|
| |
mutable global context of variable bindings, pass around immutable local contexts.
The motivation is so we can safely evaluate all blaze query expressions concurrently under the hood. A global context is hostile to this goal.
--
MOS_MIGRATED_REVID=127324600
|
|
|
|
|
|
|
|
|
| |
BuiltInFunction#call is pretty popular, avoid constructing a new string, or any
object for that matter, every time we call it. FWIW the class name probably
won't be particularly useful anyway since most built ins are anonymous.
--
MOS_MIGRATED_REVID=127318185
|
|
|
|
|
|
|
|
|
| |
presence of interface dependencies.
The problem is that pre-grepped source files can be pulled in through CppCompileActions only available via lipoScannables. In this case, we need to make those pre-grepped source files inputs of the action or else we cannot be sure that the corresponding action is actually executed.
--
MOS_MIGRATED_REVID=127317557
|
|
|
|
|
|
|
| |
This is necessary because we don't have a replacement for saying "this genrule needs the C++ toolchain" and I'd prefer this to do it in a backward-compatible way; burned myself here by trying to be principled, so let's now do the pragmatic thing.
--
MOS_MIGRATED_REVID=127317024
|
|
|
|
|
|
|
|
|
| |
Fixes issue #1457.
--
Change-Id: I913be48c924a48495f4da25a6710971c5c9d20b5
Reviewed-on: https://bazel-review.git.corp.google.com/#/c/3981/
MOS_MIGRATED_REVID=127314440
|
|
|
|
|
|
|
| |
--
Change-Id: I1c61b47ac1a6feac889ed8a02136edfd1e72b9e6
Reviewed-on: https://bazel-review.googlesource.com/#/c/3990/
MOS_MIGRATED_REVID=127313910
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127313628
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127221256
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127218963
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127203325
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Underlying issue fixed in commit 5b12f6e759c1f3137a7149d3026ff96686d07696
*** Original change description ***
Automated [] rollback of commit a3381b6ac136a0cab3ba86020c739fe16b42cee9.
*** Reason for rollback ***
Broke bazel_rules_test
See https://github.com/bazelbuild/bazel/issues/1501.
*** Original change description ***
Fix default for temporary directories to honor TMPDIR
...and only use the hard-coded "/tmp" as default for the default.
Note that is unchanged that blaze.rpcserver.tmpdir still overrides.
--
MOS_MIGRATED_REVID=127201018
|
|
|
|
|
|
|
|
|
|
|
| |
Unamed arguments are confusing, e.g.
glob(["*.java"], ["testing/*.java"])
The second list is actually excluded.
RELNOTES: Glob arguments 'exclude' and 'exclude_directories' must be named
--
MOS_MIGRATED_REVID=127190991
|