| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
|
| |
This simplifies a future change that introduces new variance to
ValueVisitor's use of AbstractQueueVisitor.
--
MOS_MIGRATED_REVID=106846210
|
|
|
|
|
|
|
|
|
|
| |
Changes the AbstractQueueVisitor strategy for varying its response to
unhandled exceptions from inheritance to composition. This will help
with a forthcoming switch from inheritance to delegation for
ValueVisitor's use of AbstractQueueVisitor.
--
MOS_MIGRATED_REVID=106730708
|
|
|
|
|
|
|
|
|
|
|
|
| |
This interface (mostly) encapsulates what the ValueVisitor expects
from the AbstractQueueVisitor class it currently inherits from. This
makes it easier for a future CL to change ValueVisitor's strategy of
code reuse from inheritance to composition.
RELNOTES:
--
MOS_MIGRATED_REVID=106728863
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=106493557
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=106323413
|
|
|
|
|
|
|
| |
reference to the original map. This made us to keep a reference to the whole node but we are only interested on the rdeps.
--
MOS_MIGRATED_REVID=106098938
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=106004898
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We rely on ErrorTransienceValue being different across evaluations by
way of java reference inequality, instead make it a singleton and make
it so that ErrorTransienceValue compares equal to nothing, including itself.
Alternatively we could attach the corresponding Version to ErrorTransienceValue
and use that to force inequality across evaluations. However this gets into
the different possible Version implementations and their varying semantics, so
go with the simplest approach first and see how it works out.
--
MOS_MIGRATED_REVID=106001826
|
|
|
|
|
|
|
| |
Nothing can extend SkyFunctionName. It's final.
--
MOS_MIGRATED_REVID=105989976
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In SkyQueryEnvironment, the buildTransitiveClosure method ignored the
error messages in successfully evaluated TransitiveTraversalValues,
under the belief that any such error messages are also obtainable by
calling getMissingAndExceptions. This happens to be true right now,
but may not be true in the future.
If, in particular, the TransitiveTraversal skyfunction inlines its
call to the TargetMarker skyfunction, those error messages won't be
available through getMissingAndExceptions.
--
MOS_MIGRATED_REVID=105980430
|
|
|
|
|
|
|
| |
RuntimeExceptions that were thrown after an InterruptedException was thrown would be swallowed.
--
MOS_MIGRATED_REVID=105902192
|
|
|
|
|
|
|
| |
values).
--
MOS_MIGRATED_REVID=105893837
|
|
|
|
|
|
|
|
| |
Should be a singleton, should never be serialized or deserialized,
but add equals and hash code as well for good measure.
--
MOS_MIGRATED_REVID=105888511
|
|
|
|
|
|
|
| |
RELNOTES: None
--
MOS_MIGRATED_REVID=105787681
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105539869
|
|
|
|
|
|
|
| |
Previously, only ThreadPoolExecutor implementations were allowed.
--
MOS_MIGRATED_REVID=105340237
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the cycle values (were supposed to) share a common abstract
base class, however usage was inconsistent. Instead refactor to eliminate
the specialized value classes, remove the abstract class, and share a
common empty placeholder value, which should be useful for future/other
current empty values.
--
MOS_MIGRATED_REVID=105217399
|
|
|
|
|
|
|
| |
anyway. Also batch retrievals of children when building events.
--
MOS_MIGRATED_REVID=105174435
|
|
|
|
|
|
|
| |
error bubbling.
--
MOS_MIGRATED_REVID=105102597
|
|
|
|
|
|
|
|
|
|
|
| |
not all done during invalidation, repeated adding/removing means that we are consolidating more often, negating the benefit of delayed removals. To work around this, delay adds as well until we consolidate and verify the integrity of our data.
Since there is no well-defined point that a consolidation should trigger for a done node, we delay until our pending list is as large as the done list. We can tweak this if necessary for a memory/performance tradeoff.
The alternative to this that I could think of is giving up our strong integrity checks, which I'm not a fan of.
--
MOS_MIGRATED_REVID=105095886
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=104983790
|
|
|
|
|
|
|
|
|
|
| |
For use in alternate graph implementations.
Also adds some user-friendly methods to StringValue, a SkyValue
implementation used in tests.
--
MOS_MIGRATED_REVID=104899226
|
|
|
|
|
|
|
| |
RELNOTES:
--
MOS_MIGRATED_REVID=104674937
|
|
|
|
|
|
|
| |
EvaluableGraph#createIfAbsentBatch.
--
MOS_MIGRATED_REVID=104534858
|
|
|
|
|
|
|
| |
deps.
--
MOS_MIGRATED_REVID=104531377
|
|
|
|
|
|
|
| |
RELNOTES:
--
MOS_MIGRATED_REVID=104341630
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=104316416
|
|
|
|
|
|
|
| |
RELNOTES:
--
MOS_MIGRATED_REVID=104262323
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=104250152
|
|
|
|
|
|
|
|
| |
Also change the semantics to create a new one on every call; inject the offset
where we were previously relying on hidden state in the SkyframeExecutor.
--
MOS_MIGRATED_REVID=104188580
|
|
|
|
|
|
|
| |
The value getting checked was the same as the value it was compared to.
--
MOS_MIGRATED_REVID=104144544
|
|
|
|
|
|
|
|
|
|
|
|
| |
Single constructor allows us to enforce/document high-level constraints
in a single place. Move previous constructors to static methods which do
their custom transformations but ultimately funnel their final calculated
fields through the common constructor.
Also added some tests to demonstrate expected behavior of static methods.
--
MOS_MIGRATED_REVID=104142909
|
|
|
|
|
|
|
|
|
|
|
| |
The headers were modified with
`find . -type f -exec 'sed' '-Ei' 's|Copyright 201([45]) Google|Copyright 201\1 The Bazel Authors|' '{}' ';'`
And manual edit for not Google owned copyright. Because of the nature of ijar, I did not modified the header of file owned by Alan Donovan.
The list of authors were extracted from the git log. It is missing older Google contributors that can be added on-demand.
--
MOS_MIGRATED_REVID=103938715
|
|
|
|
|
|
|
| |
both an "error" and "success" state.
--
MOS_MIGRATED_REVID=103897656
|
|
|
|
|
|
|
| |
message if a previously known direct dep isn't done.
--
MOS_MIGRATED_REVID=103880990
|
|
|
|
|
|
|
| |
reifying them in the Skyframe graph.
--
MOS_MIGRATED_REVID=103758591
|
|
|
|
|
|
|
| |
avoid mutating the deps of nodes that are still going to be deps after evaluation is finished.
--
MOS_MIGRATED_REVID=103659429
|
|
|
|
|
|
|
| |
RELNOTES:
--
MOS_MIGRATED_REVID=103606693
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
internally. This should be a semantics-preserving change for users. In a subsequent CL, I'll change the Skylark syntax to allow load statements to use labels as well as paths, with the goal of eventually deprecating the latter.
Also:
- Removed the hack for handling relative loads in the prelude file.
- Refactored some redundant functionality in PackageFunction and SkylarkImportLookupFunction for handling loads.
- Removed the ability to put the BUILD file for the package containing a Skylark file under a different package root than the Skylark file itself. This functionality isn't currently used and is inconsistent with Blaze's handling of the package path elsewhere.
- Added BUILD files to a number of tests that load Skylark files; this is consistent with the requirement that all Skylark files need to be part of some package.
- Changed the constants used to set the location of the prelude file from paths to labels.
--
MOS_MIGRATED_REVID=103567562
|
|
|
|
|
|
|
| |
since ErrorInfo doesn't override equality, there's no issue with preserving equality for now.
--
MOS_MIGRATED_REVID=103414237
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103387106
|
|
|
|
|
|
|
| |
we do in ParallelEvaluator.
--
MOS_MIGRATED_REVID=103031770
|
|
|
|
|
|
|
| |
all the packages referenced by subinclude files should be in the graph. But this is not the case when the package is in error (The package is in the graph but as an error value, not as a package value). This produced the crash seen in [1] for a simple query like rbuildfiles(broken/BUILD).
--
MOS_MIGRATED_REVID=102869135
|
|
|
|
|
|
|
| |
I'll never get the last half hour of my life back, but at least nobody else will suffer.
--
MOS_MIGRATED_REVID=102863680
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=102835622
|
|
|
|
|
|
|
| |
Now that we don't clean the graph during catastrophes, we should be crashing hard in these cases.
--
MOS_MIGRATED_REVID=102785226
|
|
|
|
|
|
|
|
|
| |
to interrupt evaluation in constant time.
Some ParallelEvaluator tests that implicitly relied on cleaning happening before the next evaluation were moved into MemoizingEvaluatorTest as a result.
--
MOS_MIGRATED_REVID=102696653
|
|
|
|
|
|
|
| |
SkyFunction#compute calls.
--
MOS_MIGRATED_REVID=102268773
|
|
|
|
|
|
|
|
|
| |
not the iterator has more elements is a perfectly good signal.
Also put the reference hash code into the string representation for use in debugging.
--
MOS_MIGRATED_REVID=102264568
|
|
|
|
|
|
|
|
|
|
|
| |
This CL introduces a ThinNodeEntry, which is a NodeEntry without the
means of accessing its value. The InvalidatingNodeVisitor does not
need to access nodes' values while doing its work, so it is provided
with a ThinNodeQueryableGraph, capable of producing only
ThinNodeEntries.
--
MOS_MIGRATED_REVID=102088111
|