| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This introduces a single SkyFunction that has the desired side effect
of loading matching targets and their transitive dependencies in the
graph.
It replaces the two calls to buildDriver.evaluate that made sure the
graph loaded the necessary values before query evaluation with just one
call.
--
MOS_MIGRATED_REVID=89864338
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89740455
|
|
|
|
|
|
|
| |
and fail hard in other cases.
--
MOS_MIGRATED_REVID=89720528
|
|
|
|
|
|
|
|
|
|
|
| |
for them can be retrieved with other inputs, avoiding a restart.
This also allows us to delete the UndeclaredInputsHandler, since we eagerly cache metadata before entering any ActionCacheChecker methods.
This should also allow us to split FileAndMetadataCache into two separate classes, as well as asserting that SingleBuildFileCache only sees non-artifact ActionInputs. To be done in follow-ups.
--
MOS_MIGRATED_REVID=89718712
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89713328
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89704303
|
|
|
|
|
|
|
|
|
| |
for allowing it to be restarted in case of missing deps.
Note that this means that action-cache writing is no longer part of the ACTION_COMPLETE profiling unit.
--
MOS_MIGRATED_REVID=89702039
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89697088
|
|
|
|
|
|
|
| |
In particular: add a BazelPythonSemantics implementation and the respective RuleConfiguredTarget factories, rule class definitions and hook them up with BazelRuleClassProvider. Add implicit dependencies (2to3 is just a stub script for now that always fails) and a tiny exampe.
--
MOS_MIGRATED_REVID=89691827
|
|
|
|
|
|
|
| |
This change moves the workspace rules and adjusts BUILD files as necessary.
--
MOS_MIGRATED_REVID=89689632
|
|
|
|
|
|
|
|
|
|
|
|
| |
PackageDeserializer: handle null-value attributes (single-value attributes with
no value setting) without crashing.
Without this change, attributes with computed defaults can crash on serialization
because RawAttributeMapper.isNotNull isn't smart enough to check *indirect*
configurable attributes that the computed attribute depends on.
--
MOS_MIGRATED_REVID=89599145
|
|
|
|
|
|
|
| |
Introduces a restriction that prohibits using both simulator and device architectures for ios_multi_cpus in the same build.
--
MOS_MIGRATED_REVID=89597247
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89592165
|
|
|
|
|
|
|
| |
This bug, and all of them like it, will be fixed in an upcoming cl that makes sure all input metadata is obtained through Skyframe. But I think we should have this fix now.
--
MOS_MIGRATED_REVID=89540265
|
|
|
|
|
|
|
|
|
|
| |
Here we additionally identify artifacts as orphaned if they are only
inputs to middleman actions whose outputs are unused. The middleman
actions are still part of the action graph, but we tolerate their
inputs being orphaned.
--
MOS_MIGRATED_REVID=89512745
|
|
|
|
|
|
|
| |
chains.
--
MOS_MIGRATED_REVID=89511018
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89483786
|
|
|
|
|
|
|
| |
these two versions of query consistent we need to add additional edges to the target that contains aspects, instead of adding it to the target that was in direct deps of the original one.
--
MOS_MIGRATED_REVID=89483301
|
|
|
|
|
|
|
| |
of null values).
--
MOS_MIGRATED_REVID=89443545
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89443026
|
|
|
|
|
|
|
| |
requested.
--
MOS_MIGRATED_REVID=89436511
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
serialization logic.
Among other things, this fixes an out-of-sync bug where
ProtoOutputFormatter's version knew how to handle configurable
attributes while PackageSerializer's version crashed.
The merged logic preserves ProtoOutputFormatter's semantics:
configurable attributes work, but their values are merged together
into a flattened list, so the original select structure can't be
reproduced later.
--
MOS_MIGRATED_REVID=89435116
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89433520
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89411484
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change moves the resource compilation actions from each declaring target
to the bundle in which they're stored. This bundle is (mostly, see below) the
only thing that cares about the compiled resources. As a result, we avoid
compiling each resource many times when in a multi-architecture context.
Note that as a result of this change rules other than ios_test do no longer
add the compiled datamodels and storyboards to files to build. There (should?)
be no need for them anyhow. Also, Xcode targets will now no longer contain the
transitive closure of datamodels, only their own.
Note that in the case where the input resource is produced by a genrule the
resource compilation still happens for each architecture but we ignore the
results for all but one of the architectures to avoid bundling conflicts.
There are also some more validation checks and nicer error messages for users
when they specify illegal strings resources.
--
MOS_MIGRATED_REVID=89404405
|
|
|
|
|
|
|
|
|
| |
This syntax is broken under Eclipse.
For some reason this syntax is valid from BuildJar
but it is not compatible with Eclipse Java 8.
--
MOS_MIGRATED_REVID=89397040
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89392921
|
|
|
|
|
|
|
|
|
| |
when the default is specified (and not just filesToBuild).
This is necessary so that rules that explicitly add artifacts to OutputGrovider.DEFAULT have those artifacts built when they are mentioned on the command line.
--
MOS_MIGRATED_REVID=89387243
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89386727
|
|
|
|
|
|
|
|
|
|
|
| |
This change makes them consistent with global variables.
e.g.
def foo(len): return len + 1 # now allowed
Redefinition is still forbidden.
--
MOS_MIGRATED_REVID=89383535
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89348225
|
|
|
|
|
|
|
| |
native module.
--
MOS_MIGRATED_REVID=89309511
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89307831
|
|
|
|
|
|
|
| |
RELNOTES: Python 3 keywords are added to the lexer. They cannot be used as identifiers.
--
MOS_MIGRATED_REVID=89301541
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change means that tests no longer need to specify the patterns
they use themselves, unless the test involves excluding some pattern.
Also fixes a bug in GraphBackedRecursivePackageProvider revealed by
the test changes where it behaved differently from
EnvironmentBackedRecursivePackageProvider when looking up packages
with errors.
--
MOS_MIGRATED_REVID=89297008
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89296560
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89296523
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89294740
|
|
|
|
|
|
|
|
| |
- SkylarkNativeModule is added to handle to native module.
- Glob function is migrated to be a SkylarkFunction. Note that other functions in the native module are more difficult to migrate since they are not static.
--
MOS_MIGRATED_REVID=89292579
|
|
|
|
|
|
|
|
|
| |
java_binary was a prefix of the exec path of the associated ijar, which may cause problems.
This was discovered using my "bindir == genfilesdir == outputdir" experiment.
--
MOS_MIGRATED_REVID=89285440
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89285345
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89279534
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89152485
|
|
|
|
|
|
|
|
|
|
|
|
| |
We generate a nested bundle for each architecture specified in ios_multi_cpus
which would cause any artifacts generated by these rules (such as info plists
or compiled resource files) to clash in the final application bundle (where
the bundle directory only exists once). For now just pick one architecture at
random to store the bundle in - unfortunately we still generate the bundle for
all architectures.
--
MOS_MIGRATED_REVID=89152199
|
|
|
|
|
|
|
| |
necessarily used (it's not used when SkyQuery isn't used, e.g. when --noorder_results isn't specified).
--
MOS_MIGRATED_REVID=89150192
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89149156
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89148288
|
|
|
|
|
|
|
|
|
|
| |
As we are releasing the tools somewhat independently of the rules these utility
dependencies make life a lot harder. I'm sad about losing some of the enum
type-safety but being able to treat the code independently is more than worth
it.
--
MOS_MIGRATED_REVID=89137624
|
|
|
|
|
|
|
|
|
| |
name without any extra work in Xcodegen. Use this label to determ
ine the *correct* built library.
--
MOS_MIGRATED_REVID=89135635
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=89134834
|