aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib
Commit message (Collapse)AuthorAge
* Move the BuildView over from BlazeRuntime to CommandEnvironment.Gravatar Ulf Adams2015-09-28
| | | | | | | | | It doesn't contain any state anymore, so creating a new instance per command is safe. On the other hand, it would be just as safe to merge the remaining code into SkyframeBuildView, which we might do in the future. -- MOS_MIGRATED_REVID=104010694
* Move the remaining state from BuildView to SkyframeBuildView.Gravatar Ulf Adams2015-09-28
| | | | | -- MOS_MIGRATED_REVID=104009600
* Remove BuildView.skyframeCacheWasInvalidated.Gravatar Ulf Adams2015-09-28
| | | | | | | | | | | | It was mainly used for testing during the transition phase to Skyframe. The only reason I can see to keep it would be to have test coverage that changing the configuration drops the configured targets. However, do we even want that? I tried to find out whether it's safe to remove that check (the corresponding comment is outdated), but couldn't find where (if anywhere) we're doing garbage collection of old configured targets. -- MOS_MIGRATED_REVID=104009210
* Remove BuildView.binTools, which was only used for tests.Gravatar Ulf Adams2015-09-28
| | | | | -- MOS_MIGRATED_REVID=104008237
* Give a nice error message on double included files in objc rules.Gravatar Peter Schmitt2015-09-28
| | | | | -- MOS_MIGRATED_REVID=103986912
* Inject an event handler into the getErrorFreeVisitedPackages call.Gravatar Ulf Adams2015-09-28
| | | | | | | This means we no longer need an event handler on the object itself. -- MOS_MIGRATED_REVID=103982299
* Refactor the LoadingPhaseRunner: create a new TransitivePackageLoader per run.Gravatar Ulf Adams2015-09-28
| | | | | | | | | | | | | | The only implementation of TransitivePackageLoader at this point is in SkyframeLabelVisitor, which by itself does not keep any state; it relies on Skyframe to do all the caching. Creating a new one per run should ensure that we don't accidentally keep state there, and also reduces memory consumption (a little), because it can now be garbage collected after the loading phase. As a side effect, we no longer need to create an instance if we're using the simplified loading phase. -- MOS_MIGRATED_REVID=103979794
* Clean up Aspect checks in query tests.Gravatar Eric Fellheimer2015-09-28
| | | | | -- MOS_MIGRATED_REVID=103977080
* Remove unnecessary env.valuesMissing() call.Gravatar Nathan Harmata2015-09-28
| | | | | -- MOS_MIGRATED_REVID=103975426
* Make explicit that the SkyframeTransitivePackageLoader needs an EventHandler.Gravatar Ulf Adams2015-09-28
| | | | | -- MOS_MIGRATED_REVID=103975222
* Use the same method as LoadedPackageProvider.Bridge to look up targets.Gravatar Ulf Adams2015-09-28
| | | | | | | | | | This unfortunately requires injecting an EventHandler into the getTargetForLabel call, which is not super nice. On the other hand, it's not clear how this can be much better - looking up targets in the cycle reporter doesn't lend itself to prettiness. -- MOS_MIGRATED_REVID=103965373
* Inject an EventHandler rather than using the one on SkyframeExecutor.Gravatar Ulf Adams2015-09-28
| | | | | | | In preparation for removing SkyframeExecutor.errorEventListener. -- MOS_MIGRATED_REVID=103960561
* Fix attribute's rule nameGravatar Kristina Chodorow2015-09-28
| | | | | | | Gah. -- MOS_MIGRATED_REVID=103959841
* Expose proto sources in the Skylark providerGravatar Laurent Le Brun2015-09-28
| | | | | -- MOS_MIGRATED_REVID=103947930
* Move BuildView.getActionGraph to SkyframeExecutor.Gravatar Ulf Adams2015-09-28
| | | | | | | | This is another case of uninterruptible evaluation, which directly accesses SkyframeExecutor.errorEventListener. -- MOS_MIGRATED_REVID=103946310
* Resolve labels in linkopts against either 'deps' or 'srcs'Gravatar Googler2015-09-28
| | | | | | | RELNOTES[NEW]: labels in "linkopts" may match any label in either "deps" or "srcs" to be considered valid. -- MOS_MIGRATED_REVID=103945104
* Disable include scanning for assembler-without-preprocessor source.Gravatar Googler2015-09-28
| | | | | | | | The scanner only looks for C preprocessor directives, but most assemblers allow '.include' assembly directives, and those aren't found by the scanner. So skip the include scanner for assembly files that don't want C preprocessing, because correctly declared inclusions are to be preferred anyway. -- MOS_MIGRATED_REVID=103944189
* Find the test setup script based on its basename and not its precise exec path.Gravatar Lukacs Berki2015-09-28
| | | | | | | This is necessary so that the existence of a script //tools/test:test-setup.sh is not hardcoded into Bazel, which is in turn necessary so that the Bazel tools (//tools/...) are not required to be in the main repository. -- MOS_MIGRATED_REVID=103943618
* Split the PackageManager type hierarchy; no longer inherit LoadedPackageProv.Gravatar Ulf Adams2015-09-28
| | | | | | | | | | | | | This limits the exposure of LoadedPackageProvider, such that there will be no regressions in the use of getLoadedTarget. Unfortunately, fully removing LoadedPackageProvider is more work than I'm willing to take on right now, and this is the cleanest intermediate solution I could come up with. This unblocks my other work (removing SkyframeExecutor.errorEventHandler). Someone else will have to shave this yak. -- MOS_MIGRATED_REVID=103943375
* Also ship the linker for LTO backend actions.Gravatar Han-Wen Nienhuys2015-09-28
| | | | | -- MOS_MIGRATED_REVID=103942611
* Make rules construction more flexible.Gravatar Miguel Alcon Pinto2015-09-28
| | | | | -- MOS_MIGRATED_REVID=103942367
* Rationalize copyright headersGravatar Damien Martin-Guillerez2015-09-25
| | | | | | | | | | | The headers were modified with `find . -type f -exec 'sed' '-Ei' 's|Copyright 201([45]) Google|Copyright 201\1 The Bazel Authors|' '{}' ';'` And manual edit for not Google owned copyright. Because of the nature of ijar, I did not modified the header of file owned by Alan Donovan. The list of authors were extracted from the git log. It is missing older Google contributors that can be added on-demand. -- MOS_MIGRATED_REVID=103938715
* Use Label.parseAbsolute() to determine whether command line options that can ↵Gravatar Lukacs Berki2015-09-25
| | | | | | | | | take absolute paths and labels are labels. This makes them work with labels not in the main repository (i.e. @repo//pkg:target). The alternative would have been to simply add .startsWith("@"), but why try to parse labels in a lame and limited way if we can do the right thing. -- MOS_MIGRATED_REVID=103934380
* Improved error reporting in RuleContext:Gravatar Florian Weikert2015-09-25
| | | | | | | | - Unified duplicate code from RuleContext and RuleContext.Builder in a new class, RuleContext.ErrorReporter - Added the BUILD file location to error/warning messages if the offending rule was created by a macro -- MOS_MIGRATED_REVID=103934375
* Do not hardcode the path to genrule-setup.sh in the implementation of genrule.Gravatar Lukacs Berki2015-09-25
| | | | | | | I don't know why it was implemented like that in the first place. -- MOS_MIGRATED_REVID=103934038
* Implemented copy constructor for Skylark dictionaries: new_dict = dict(old_dict)Gravatar Florian Weikert2015-09-25
| | | | | -- MOS_MIGRATED_REVID=103932279
* Skylark rules can no longer overwrite built-in attributes.Gravatar Florian Weikert2015-09-25
| | | | | -- MOS_MIGRATED_REVID=103931317
* Tweak the installation order of split APKs so that there is less logcat spam ↵Gravatar Lukacs Berki2015-09-25
| | | | | | | during "mobile install --split_apks". -- MOS_MIGRATED_REVID=103927507
* Removed new_file_suffix().Gravatar Florian Weikert2015-09-25
| | | | | -- MOS_MIGRATED_REVID=103926575
* Add a serialization proxy to RepositoryName instead of PackageIdentifier so ↵Gravatar Lukacs Berki2015-09-25
| | | | | | | | | that naked RepositoryName objects can also be serialized properly. Also store the initial offset a target pattern was parsed with. -- MOS_MIGRATED_REVID=103921930
* Change Attribute.skipConstraintsCheck() (and similar methods)Gravatar Greg Estren2015-09-25
| | | | | | | | | | | | | to Attribute.skipPrereqValidatorCheck. This is to disambiguate the concept of "constraints" and keep the word consciously focused on Bazel's *new* constraint system. The changed methods refer to checks done by PrerequisiteValidator, which is basically an adhoc version of the "old" system (e.g. checking visibility) -- MOS_MIGRATED_REVID=103872412
* Make sure runtime shuts down on exception in uncaught exception handlerGravatar Michajlo Matijkiw2015-09-25
| | | | | | | RELNOTES: -- MOS_MIGRATED_REVID=103869828
* Remove another use of errorEventHandler.Gravatar Ulf Adams2015-09-25
| | | | | -- MOS_MIGRATED_REVID=103850879
* Disable generateSubModules, since it causes issues with private headers.Gravatar Googler2015-09-25
| | | | | -- MOS_MIGRATED_REVID=103847305
* Use byte[] and Input/OutputStream directly for HTTP downloads.Gravatar Han-Wen Nienhuys2015-09-25
| | | | | | | | | | | | | nio.channels.ReadableByteChannel is unbuffered, so this causes HTTP downloads to read and write in 1 byte increments. To boot, InputStream#read and OutputStream#write are simpler. Fixes #478. -- Change-Id: Ic4854e03f5d48e47fb8cc58bbbdc459b831b16f3 Reviewed-on: https://bazel-review.googlesource.com/#/c/2040 MOS_MIGRATED_REVID=103844552
* Remove the experimental check-deps implementation.Gravatar Ulf Adams2015-09-24
| | | | | -- MOS_MIGRATED_REVID=103839895
* Remove more uses of errorEventHandler (previously of Reporter).Gravatar Ulf Adams2015-09-24
| | | | | | | Removes mutable global state. -- MOS_MIGRATED_REVID=103837106
* Rollback of commit 402d112bc25449f1e690bbbace600bbcda834d24.Gravatar Googler2015-09-24
| | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Rollforward with fix *** Original change description *** Automated [] rollback of []. *** Reason for rollback *** Breaks tests. *** Original change description *** Remove gen jar implicit output. This allows us to only create a jar for libraries that use annotation processing. It also increases our flexibility by reducing the visibility of these gen jars to an undocumented output group. -- MOS_MIGRATED_REVID=103833283
* Remove all direct uses of SkyframeExecutor.reporter.Gravatar Ulf Adams2015-09-24
| | | | | | | | | Instead, pass an appropriate EventHandler instance in. This is in preparation for creating a per-command EventHandler, in preparation for allowing multiple commands to run in parallel. This is removal of shared global state. -- MOS_MIGRATED_REVID=103828963
* Add a main_dex_proguard_specs attribute to android_binary that lets users ↵Gravatar Lukacs Berki2015-09-24
| | | | | | | | | | | specify which classes should go into the main dex. This mode uses Proguard to determine the dependencies of these classes, which means that no error-prone manual listing required like in multidex="manual" mode. RELNOTES: android_binary now has a main_dex_proguard_specs attribute to specify which classes should be in the main dex. -- MOS_MIGRATED_REVID=103824119
* Make intra-package wildcards work for remote repositories and clean up ↵Gravatar Lukacs Berki2015-09-24
| | | | | | | | | target pattern parsing just a tiny little bit. This wounds #389 dealing 4d6 fire damage (recursive wildcards, e.g. /... and friends still don't work) -- MOS_MIGRATED_REVID=103822319
* Rollback of commit 53330510c6ea5cd6257b9981b44e52d15a9e01aa.Gravatar Googler2015-09-24
| | | | | | | | | | | | | | | | | *** Reason for rollback *** Breaks tests. *** Original change description *** Remove gen jar implicit output. This allows us to only create a jar for libraries that use annotation processing. It also increases our flexibility by reducing the visibility of these gen jars to an undocumented output group. -- MOS_MIGRATED_REVID=103800137
* Make TargetFormatter available for tests.Gravatar Janak Ramakrishnan2015-09-24
| | | | | -- MOS_MIGRATED_REVID=103798663
* Improve performance of Sky query.Gravatar Miguel Alcon Pinto2015-09-24
| | | | | -- MOS_MIGRATED_REVID=103793399
* Propagates cc_library linkopts attribute to dependent objc_libraries.Gravatar Googler2015-09-24
| | | | | -- MOS_MIGRATED_REVID=103792157
* Remove gen jar implicit output.Gravatar Googler2015-09-24
| | | | | | | | | This allows us to only create a jar for libraries that use annotation processing. It also increases our flexibility by reducing the visibility of these gen jars to an undocumented output group. -- MOS_MIGRATED_REVID=103789186
* Fix attribute capitalizationGravatar Kristina Chodorow2015-09-24
| | | | | -- MOS_MIGRATED_REVID=103785076
* Merge BazelIosTest and ExperimentalIosTest, deleting the former.Gravatar Chris Parsons2015-09-24
| | | | | -- MOS_MIGRATED_REVID=103781890
* Remove both of equals/hashCode from classes in lib/packages where either ↵Gravatar Nathan Harmata2015-09-24
| | | | | | | | | only one of them was implemented (potentially incorrectly) or the class really intends to have reference equality. RELNOTES: -- MOS_MIGRATED_REVID=103778746
* Better syncing of Google vs. external constraint enforcement.Gravatar Greg Estren2015-09-24
| | | | | -- MOS_MIGRATED_REVID=103768073