| Commit message (Collapse) | Author | Age |
|
|
|
|
|
| |
--
PiperOrigin-RevId: 141904124
MOS_MIGRATED_REVID=141904124
|
|
|
|
|
|
|
|
|
|
|
| |
The actual issue is with the code that calls this method by way
of reflection. This is a temporary work around to fix #2232.
RELNOTES: An IE bug was fixed in repository_ctx.download_and_extract
--
PiperOrigin-RevId: 141899395
MOS_MIGRATED_REVID=141899395
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 141896569
MOS_MIGRATED_REVID=141896569
|
|
|
|
|
|
|
|
|
|
| |
Fixes https://github.com/bazelbuild/bazel/issues/564.
RELNOTES: aar_import rule is now documented.
--
PiperOrigin-RevId: 141843994
MOS_MIGRATED_REVID=141843994
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 141817345
MOS_MIGRATED_REVID=141817345
|
|
|
|
|
|
|
|
| |
execution cache.
--
PiperOrigin-RevId: 141807596
MOS_MIGRATED_REVID=141807596
|
|
|
|
|
|
|
|
| |
Helps debugging.
--
PiperOrigin-RevId: 141802189
MOS_MIGRATED_REVID=141802189
|
|
|
|
|
|
|
|
| |
Previously, at least one critical provider was not propagated (CppCompilationContext) which resulted in cc_library's being unable to find the generated headers.
--
PiperOrigin-RevId: 141800408
MOS_MIGRATED_REVID=141800408
|
|
|
|
|
|
|
|
| |
This method coerces any collection to a Skylark tuple, analogous to list() or set().
--
PiperOrigin-RevId: 141779268
MOS_MIGRATED_REVID=141779268
|
|
|
|
|
|
|
|
| |
API. This enables creating a TestEnvironmentProvider from Skylark.
--
PiperOrigin-RevId: 141775285
MOS_MIGRATED_REVID=141775285
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turns out that ForkJoinTask#adapt(Callable) returns a ForkJoinTask whose Future#get on error throws a ExecutionException wrapping a RuntimeException wrapping the thrown checked exception from the callable. This is documented behavior [1] that I incorrectly didn't know about.
The additional level of wrapping meant that the catch-block of the parallel implementation of BinaryOperatorExpression wasn't rethrowing the InterruptedException/QueryException that the parallel task threw.
The subtly in this bug is that the query expression being evaluated needs to be of the form "e1 + e2", where evaluation of "e1" throws a QueryException even in keepGoing mode (note that most of the query errors actually go through AbstractBlazeQueryEnvironment#reportBuildFileError). The test I wrote picks on LetExpression's evaluation-time (rather than e.g. parsing time) validation of the variable name.
[1] https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ForkJoinTask.html#adapt(java.util.concurrent.Callable)
--
PiperOrigin-RevId: 141772584
MOS_MIGRATED_REVID=141772584
|
|
|
|
|
|
|
|
|
|
|
|
| |
loading external repositories.
Fixes #2198.
--
Change-Id: Ife0232f8e4652a90bc3b7dceec6e67312a142879
Reviewed-on: https://cr.bazel.build/7691
PiperOrigin-RevId: 141771126
MOS_MIGRATED_REVID=141771126
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 141769552
MOS_MIGRATED_REVID=141769552
|
|
|
|
|
|
|
|
| |
the same srcs as they are.
--
PiperOrigin-RevId: 141604925
MOS_MIGRATED_REVID=141604925
|
|
|
|
|
|
|
|
|
|
| |
Instead they mount the individual files. Currently, non-empty tree artifacts result in ERR_DIRECTORY_NOT_EMPTY because we attempt to mount both the directory and the files inside it.
Fixes https://github.com/bazelbuild/bazel/issues/1745.
--
PiperOrigin-RevId: 141599030
MOS_MIGRATED_REVID=141599030
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 141594768
MOS_MIGRATED_REVID=141594768
|
|
|
|
|
|
|
|
|
|
| |
That is, if an Aspect registered an action that an extra-action is shadowing, its name will be used when creating the extra-action's ID and name.
Without this change, it's impossible to analyze extra-actions when there's more than one aspected rule that acts on the same rule (e.g., java_proto_library and java_lite_proto_library on the same proto_library).
--
PiperOrigin-RevId: 141587608
MOS_MIGRATED_REVID=141587608
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 141561079
MOS_MIGRATED_REVID=141561079
|
|
|
|
|
|
|
|
|
|
|
| |
This confused me every time I looked it up. Thought that was working through some magic shell alias tricks until I found the files on my hard drive.
Closes #2203.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/2203
PiperOrigin-RevId: 141556677
MOS_MIGRATED_REVID=141556677
|
|
|
|
|
|
|
|
| |
individual --whole_archive/--no_whole_archive blocks.
--
PiperOrigin-RevId: 141555295
MOS_MIGRATED_REVID=141555295
|
|
|
|
|
|
|
|
| |
It wrongly stated that this only affects the timeout, however it actually affects the resources required for a test to run.
--
PiperOrigin-RevId: 141546278
MOS_MIGRATED_REVID=141546278
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 141535067
MOS_MIGRATED_REVID=141535067
|
|
|
|
|
|
|
|
|
|
| |
attribute
This prevents duplicate symbol errors for objects that would otherwise be linked both in the application binary and a dylib the binary is linked against.
--
PiperOrigin-RevId: 141478238
MOS_MIGRATED_REVID=141478238
|
|
|
|
|
|
|
|
|
|
|
|
| |
At this point this does nothing more than re-run the exact same test without having to re-start the test runner.
In future iterations the aim is to be able to re-run tests with modified code, without having to re-start the test runner.
To test out the WorkerTestStrategy simply use --test_strategy=experimental_worker for a test with bazel.
--
PiperOrigin-RevId: 141465929
MOS_MIGRATED_REVID=141465929
|
|
|
|
|
|
|
|
|
|
| |
When running ProGuard in multiple phases, Bazel was picking up an
erroneous 0-byte seeds artifact. ProGuard only generates a seeds
artifact during NORMAL and INITIAL runtypes.
--
PiperOrigin-RevId: 141463120
MOS_MIGRATED_REVID=141463120
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 141455148
MOS_MIGRATED_REVID=141455148
|
|
|
|
|
|
|
|
| |
This should save on heap space for actions with long strings.
--
PiperOrigin-RevId: 141440705
MOS_MIGRATED_REVID=141440705
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
An asynchronous clean without a complete purge and daemon shutdown is
particularly useful when the daemon takes an inordinate amount of time
to read output files for md5sums. Incurs a garbage collector invocation
after cache cleanup in the interest of correct usage reporting.
Closes #2053.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/2053
PiperOrigin-RevId: 141437418
MOS_MIGRATED_REVID=141437418
|
|
|
|
|
|
|
|
|
| |
This hardcodes usage of proto-toolchains, which triggers strict-proto-deps.
Since strict-proto-deps relies on a proto-compiler feature which doesn't exist yet, I've also changed the default of --strict_proto_deps to 'default', which won't trigger the check unless specifically requested.
--
PiperOrigin-RevId: 141347426
MOS_MIGRATED_REVID=141347426
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Under --experimental_objc_library, breaks objc_library targets with empty sources.
*** Original change description ***
Better error message for experimental_objc_library targets built with a
crosstool that does not support objc.
--
PiperOrigin-RevId: 141344598
MOS_MIGRATED_REVID=141344598
|
|
|
|
|
|
|
|
|
| |
Make the distinction between transitive and direct inputs clearer,
and decouple command line construction from the use of params files.
--
PiperOrigin-RevId: 141341256
MOS_MIGRATED_REVID=141341256
|
|
|
|
|
|
|
|
|
|
| |
Null generating rules shouldn't actually happen. That's its own bug that
needs its own attention. This change is just a workaround to prevent
NullPointerExceptions when the bug hits.
--
PiperOrigin-RevId: 141329624
MOS_MIGRATED_REVID=141329624
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Roll forward after fixing tests. Changes from rolled-back CL:
Native aspect now determines 'isExternal' identically to skylark aspect.
RepositoryName.isMain was unreliable (at least in testing environment),
because unknown repos (occurring due to some race condition) are flagged
as being in the 'default' repo, distinct from the 'main' repo.
We now bypass RepositoryName entirely, and use the same label string
heuristic as used in the Skylark aspect.
--
PiperOrigin-RevId: 141314075
MOS_MIGRATED_REVID=141314075
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also:
- Make ConfiguredTargetFunction.getDynamicConfigurations more readable.
- Add a bit more testing coverage for configured dep resolution.
This is a roll forward of commit 7505d94c19727e3100ac5e16a960bff2cb324f23. The original changed failed for two
reasons:
1) Windows-only: "ppc" wasn't recognized as a valid cpu:
https://github.com/bazelbuild/bazel/issues/2191
2) Bazel requires android_binary's "manifest" attribute to be "AndroidManifest.xml":
https://www.google.com/url?sa=D&q=http%3A%2F%2Fci.bazel.io%2Fjob%2Fbazel-tests%2FBAZEL_VERSION%3DHEAD%2CPLATFORM_NAME%3Dubuntu_15.10-x86_64%2FlastCompletedBuild%2FtestReport%2F
This version uses "armeabi-v7a" instead of "ppc" and "AndroidManifest.xml"
in the splitDeps test.
--
PiperOrigin-RevId: 141313454
MOS_MIGRATED_REVID=141313454
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 141307853
MOS_MIGRATED_REVID=141307853
|
|
|
|
|
|
|
|
| |
Doesn't add much on top of the Iterable version in the current state of things, and it is too easy to confuse with addString.
--
PiperOrigin-RevId: 141300940
MOS_MIGRATED_REVID=141300940
|
|
|
|
|
|
|
|
| |
(series 4/4 of open-sourcing coverage command for java test)
--
PiperOrigin-RevId: 141292977
MOS_MIGRATED_REVID=141292977
|
|
|
|
|
|
|
|
|
|
|
|
| |
CppConfiguration's constructor was computing whether to strip binaries
twice: once to fill the stripBinaries member and once to fill a local variable
that shadowed the member. Doing only the former suffices.
--
Change-Id: I20f61e71572da79e0ec315b01c04b13f4fb14960
Reviewed-on: https://cr.bazel.build/6390
PiperOrigin-RevId: 141285267
MOS_MIGRATED_REVID=141285267
|
|
|
|
|
|
|
|
|
|
| |
These targets no longer exist because the JARs they referenced are no longer shipped in the Android SDK.
RELNOTES: Android SDK external bindings for support libraries, e.g. //external:android/appcompat_v4, are removed because the support library JARs that they referenced no longer ship with the Android SDK.
--
PiperOrigin-RevId: 141263303
MOS_MIGRATED_REVID=141263303
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Still fails bazel-tests
See http://ci.bazel.io/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=ubuntu_15.10-x86_64/lastCompletedBuild/testReport/ for instance
*** Original change description ***
Provide deterministic order for split configured deps (roll forward)
Also:
- Make ConfiguredTargetFunction.getDynamicConfigurations more readable.
- Add a bit more testing coverage for configured dep resolution.
This is a roll forward of commit 7505d94c19727e3100ac5e16a960bff2cb324f23. The original changed failed on
Windows because "ppc" wasn't recognized as a valid cpu:
https://github.com/bazelbuild/bazel/issues/2191
This version uses "armeabi-v7a" instead.
--
PiperOrigin-RevId: 141212457
MOS_MIGRATED_REVID=141212457
|
|
|
|
|
|
|
|
|
|
| |
framework directories."
This is a rollforward of the first attempt, which broke swift rules.
--
PiperOrigin-RevId: 141210876
MOS_MIGRATED_REVID=141210876
|
|
|
|
|
|
|
|
| |
to reach the dependent proto_library rules, whose sources will be used to generate J2ObjC protos.
--
PiperOrigin-RevId: 141187718
MOS_MIGRATED_REVID=141187718
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change:
- renames windows_error_handling.* to
windows_util.*
- moves most stuff except for the JNI method
implementations into the new windows_util
namespace
- implements a jstring to wchar string converter
- uses GetFileAttributesW in
windows_file_operations.cc
See https://github.com/bazelbuild/bazel/issues/2181
--
PiperOrigin-RevId: 141187291
MOS_MIGRATED_REVID=141187291
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also:
- Make ConfiguredTargetFunction.getDynamicConfigurations more readable.
- Add a bit more testing coverage for configured dep resolution.
This is a roll forward of commit 7505d94c19727e3100ac5e16a960bff2cb324f23. The original changed failed on
Windows because "ppc" wasn't recognized as a valid cpu:
https://github.com/bazelbuild/bazel/issues/2191
This version uses "armeabi-v7a" instead.
--
PiperOrigin-RevId: 141185293
MOS_MIGRATED_REVID=141185293
|
|
|
|
|
|
|
|
|
|
|
|
| |
A followup change will remove the apksigner jar that is bundled with Bazel.
RELNOTES: Bazel Android builds use the apksigner tool from the Android SDK
build-tools. Bazel Android builds now require build-tools version 24.0.3 or
later.
--
PiperOrigin-RevId: 141181612
MOS_MIGRATED_REVID=141181612
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 141178325
MOS_MIGRATED_REVID=141178325
|
|
|
|
|
|
|
|
|
|
| |
Also a drive-by improvement on some related error messages.
RELNOTES[INC]: Only targets with public visibility can be bound to something in //external: .
--
PiperOrigin-RevId: 141178039
MOS_MIGRATED_REVID=141178039
|
|
|
|
|
|
|
|
| |
When a persistent worker returns a WorkResponse that cannot be parsed by protobuf, it probably means that the worker has encountered an error and mistakenly printed a stack trace or error message to stdout. For users who want to know why their compiler crashes and for developers of tools that support the worker mode, it is extremely helpful to actually see these error messages, so let's print them.
--
PiperOrigin-RevId: 141176835
MOS_MIGRATED_REVID=141176835
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
This change make AndroidStudioInfoAspectTest#testAndroidLibrary flaky
bazel test --nocache_test_results --runs_per_test 10 //src/test/java/com/google/devtools/build/lib:ideinfo_test
gives 2 to 3 failures out of 10 run.
Fixes #2192
*** Original change description ***
Pass isExternal field to blaze ide info proto
Roll forward after fixing tests. The intellij aspect tests now
correctly retains the required toolchain targets in the WORKSPACE file.
--
PiperOrigin-RevId: 141174688
MOS_MIGRATED_REVID=141174688
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Newly added test fail on Windows platform
Fixes https://github.com/bazelbuild/bazel/issues/2191
*** Original change description ***
Provide deterministic order for split configured deps.
Also:
- Make ConfiguredTargetFunction.getDynamicConfigurations more readable.
- Add a bit more testing coverage for configured dep resolution.
--
PiperOrigin-RevId: 141167110
MOS_MIGRATED_REVID=141167110
|