| Commit message (Collapse) | Author | Age |
|
|
|
| |
MOS_MIGRATED_REVID=108278075
|
|
|
|
|
|
|
| |
dynamic config / configurable attributes change.
--
MOS_MIGRATED_REVID=108274420
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Specifically, given:
config_setting(
name = 'foo',
values = {'copts': '-DABC'})
this requires a dependency on the Cpp configuration fragment.
config_setting rules are unique in that this dependency comes
from string representations of option names.
--
MOS_MIGRATED_REVID=108268831
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108258054
|
|
|
|
|
|
|
|
|
|
|
| |
If --output_groups is specified without a + or a - sign, it removes the
default output groups used for artifact selection from targets.
* Use output_groups=+<group_name> to add an output group,
* Use output_groups=-<group_name> to remove an output group.
--
MOS_MIGRATED_REVID=108247894
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108243881
|
|
|
|
|
|
|
| |
of recording VFS_ stats we try to catalog the access base on the path type.
--
MOS_MIGRATED_REVID=108238357
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the feature-based flags for links of native code for Android
were coming from the standard TARGET toolchain, which is wrong. This
went unnoticed because Bazel's CROSSTOOL (and mine until recently) don't
add any flags that way in either, which means getting the flags either
way results in none.
--
Change-Id: I74cd18ff56e3aea7ca61fabe62cb2246100ee59a
Reviewed-on: https://bazel-review.googlesource.com/#/c/2322
MOS_MIGRATED_REVID=108234274
|
|
|
|
|
|
|
| |
for the purpose of change pruning.
--
MOS_MIGRATED_REVID=108203369
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108182745
|
|
|
|
|
|
|
|
|
| |
neverlink attribute.
RELNOTES: Resources defined locally on an android_library rule will respect the neverlink attribute.
--
MOS_MIGRATED_REVID=108178381
|
|
|
|
|
|
|
|
|
| |
This boolean matches bazel's semantics on whether a R.java class should
be generated. Android Studio generates its own in-memory class, but we
need to know *whether* we should generate one.
--
MOS_MIGRATED_REVID=108175802
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as its input.
e.g. given input {"attr": [':a', ':b']}
the trimmed version also keeps ':a' in front of ':b'.
This preserves the expected invariant that prerequisites are
navigatable in BUILD declaration order.
--
MOS_MIGRATED_REVID=108170921
|
|
|
|
|
|
|
|
|
| |
(accidentally) the implicit requirement that the deriving class override FileSystem#stat.
Even though this wasn't a problem in practice in the Bazel codebase (since all of our transitive subclasses had custom 'stat' implementation), it's good hygiene to have things correct (e.g. if we added a new subclass).
--
MOS_MIGRATED_REVID=108158039
|
|
|
|
|
|
|
| |
make sure that we don't store duplicate elements within a given group (although that is currently taken care of by the callers).
--
MOS_MIGRATED_REVID=108155105
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108154410
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108154189
|
|
|
|
|
|
|
| |
pretty simple: It aggregates up to 10k elements and then it notifies the parent.
--
MOS_MIGRATED_REVID=108144202
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108142409
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108142169
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows using compilers downloaded in *_repository rules without
ugly hacks like symlinks to bazel-out/../../external.
I manually tested all of the %prefix%s which this refactors the
implementations of.
--
Change-Id: Ie9931dfbed646b8b5c9cd7fba5e6df5cf0baa1f2
Reviewed-on: https://bazel-review.googlesource.com/#/c/2200
MOS_MIGRATED_REVID=108139097
|
|
|
|
|
|
|
|
|
|
|
|
| |
options. If a rule (such as a filegroup) doesn't
have C++ options in its transitive closure, then
buildOptions.get(CppOptions.class) returns null
and crashes.
So add a check to just fast-return for these cases.
--
MOS_MIGRATED_REVID=108079561
|
|
|
|
|
|
|
| |
as a quote separated list and DensitySpecificResourceFilter missing some densities.
--
MOS_MIGRATED_REVID=108077692
|
|
|
|
|
|
|
|
|
| |
label-based loading machinery) when the containing file is in a subdirectory of a package.
Also, while we're in the neighborhood: correct two nearby tests of relative loads that were passing for the wrong reasons.
--
MOS_MIGRATED_REVID=108072189
|
|
|
|
|
|
|
|
|
|
|
| |
in ConfiguredTargetFunction.trimConfigurations to preserve
key insertion order.
This ensures that RuleContext.getPrerequisites returns an
attribute's deps in the same order they were declared.
--
MOS_MIGRATED_REVID=108063142
|
|
|
|
|
|
|
| |
This makes query output independent of the insertion order of the dictionary.
--
MOS_MIGRATED_REVID=108061190
|
|
|
|
|
|
|
|
|
|
| |
Also introduces DottedVersion, a way to parse, represent and most of all compare
Apple's version identifiers.
RELNOTES: iOS apps and extensions now have launch_storyboard
--
MOS_MIGRATED_REVID=108060328
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108057030
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108056940
|
|
|
|
|
|
|
|
|
| |
attribute of the same name.
RELNOTES: Remove obsolete --objc_per_proto_includes flag.
--
MOS_MIGRATED_REVID=108056207
|
|
|
|
|
|
|
| |
FileSystemValueChecker when checking for dirty actions.
--
MOS_MIGRATED_REVID=108046467
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
include Skylark-declared requirements (which use names instead of fragment
class, e.g. "cpp" vs. CppConfiguration.class).
Also add "cpp" to Skylark java_* definitions, since java_* rules are
used to trigger LipoDataTransitions and thus expected to have a
CppConfiguration fragment.
Test coverage: skylark.BindTest with --experimental_dynamic_configs=1.
(and other Skylark tests).
--
MOS_MIGRATED_REVID=108041244
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108026192
|
|
|
|
|
|
|
| |
A prerequisite is to pass RuleContext to ConfiguredAspect, so we can read from it the registered actions when we build() the aspect.
--
MOS_MIGRATED_REVID=107997593
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107989708
|
|
|
|
|
|
|
| |
NestedSet, to reduce waste when copying aggregating it.
--
MOS_MIGRATED_REVID=107988653
|
|
|
|
|
|
|
| |
JavaToolchainProvider.
--
MOS_MIGRATED_REVID=107982866
|
|
|
|
|
|
|
| |
Become a bit more restrictive to keep our exception cases tight.
--
MOS_MIGRATED_REVID=107953779
|
|
|
|
|
|
|
| |
Motivation: "toString" doesn't describe what representation it returns, and can be called implicitly on string-conversion. Users are then forced to read the javadoc to figure out what they get.
--
MOS_MIGRATED_REVID=107946973
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107942588
|
|
|
|
|
|
|
|
|
| |
through to the JVM instead of (almost certainly incorrectly) splitting the options along spaces.
This allows us to pass non-quote-delimited strings to the JVM, which is necessary for things like -XX:OnOutOfMemoryError="kill -3 %p" (normally bash strips those quotes, but they're not stripped when passed via --host_jvm_args).
--
MOS_MIGRATED_REVID=107820087
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107812527
|
|
|
|
|
|
|
| |
load a Skylark file not contained in a package.
--
MOS_MIGRATED_REVID=107811126
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107808413
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107806099
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107805824
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107800790
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
configurations contain regardless of whether their rules explicitly
require it.
This is used to ensure all rules have BazelConfiguration. That
fragment supplies the path to the shell, which powers
BuildConfiguration.getShExecutable(), which powers any rule that
generates a SpawnAction.
Since SpawnActions are such a ubiquitous pattern we only want to
accelerate going forward, there's no point not to make this
automatically available to every rule.
--
MOS_MIGRATED_REVID=107786879
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks the Jenkins continuous builds. The error message is a mysterious Skyframe one and it only raised if the Android NDK/SDK is set in the WORKSPACE file:
java.lang.IllegalStateException: ANDROID_NDK_REPOSITORY:@androidndk -> GroupedListHelper{groupedList=[FILE:[/usr/local/google/home/lberki/.cache/bazel/_bazel_lberki/97aa07230f44a76bcaa14338f20a8e2e/external/androidndk/ndk/RELEASE.TXT]/[]], elements=[FILE:...], size=24}, reverseDepsToSignal=ReverseDeps{reverseDeps=REPOSITORY:@androidndk, singleReverseDep=true, dataToConsolidate=null}, lastBuildDirectDeps=null, dirtyDirectDepIterator=null}}
at com.google.common.base.Preconditions.checkState(Preconditions.java:197)
at com.google.devtools.build.skyframe.ParallelEvaluator$Evaluate.run(ParallelEvaluator.java:994)
at com.google.devtools.build.lib.concurrent.AbstractQueueVisitor$2.run(AbstractQueueVisitor.java:496)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
*** Original change description ***
Preserve repositories' rooted paths
This was taking the "right" rooted path, converting it to a path, and then
making the rooted path [/path/to/external/repo/BUILD]/[] (where it should
have been [/path/to/external/repo]/[BUILD]).
--
MOS_MIGRATED_REVID=107768560
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
internally. The load location for a Skylark Aspect is specified via a PathFragment, for consistency with current non-Aspect Skylark loads.
This should be a semantics-preserving change for users. In a subsequent CL, I'll change the Skylark syntax to allow load statements to use labels as well as paths, with the goal of eventually deprecating the latter.
Also:
- Removed the hack for handling relative loads in the prelude file.
- Refactored some redundant functionality in PackageFunction and SkylarkImportLookupFunction for handling loads.
- Removed the ability to put the BUILD file for the package containing a Skylark file under a different package root than the Skylark file itself. This functionality isn't currently used and is inconsistent with Blaze's handling of the package path elsewhere.
- Added BUILD files to a number of tests that load Skylark files; this is consistent with the requirement that all Skylark files need to be part of some package.
- Changed the constants used to set the location of the prelude file from paths to labels.
--
MOS_MIGRATED_REVID=107741568
|