| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
Very large server instances can take >10 seconds for GC, and if they are hit at an inopportune moment, they may get killed needlessly.
RELNOTES: None.
PiperOrigin-RevId: 169905185
|
|
|
|
|
|
|
| |
Some of the arguments are not used or are always passed blank.
RELNOTES: None.
PiperOrigin-RevId: 169899161
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Relanding
https://github.com/bazelbuild/bazel/commit/17214ac78ffaec369d5d5bafe62a39730473cfaa
with fixes to 'repository_ctx.download()' and
'repository_ctx.download_and_extract()'.
I reviewed other usages of @ParamType annotation - I do not think there
are more issues.
Fixes #3714.
Change-Id: I17087ef3fc2d28ab99224740a2164675a49847d3
PiperOrigin-RevId: 169896223
|
|
|
|
|
|
|
| |
All callers passed true, so there's no need to have the boolean there.
RELNOTES: None.
PiperOrigin-RevId: 169888322
|
|
|
|
|
|
|
|
| |
In https://github.com/bazelbuild/bazel/commit/b7a9ecd08c958e9513ea234b470a0f86e89e1acd I introduced a bug when linkstamping outputs would no longer be
stored in $TEST_TMPDIR. This cl fixes that.
RELNOTES: None.
PiperOrigin-RevId: 169882831
|
|
|
|
| |
PiperOrigin-RevId: 169874059
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 169792510
|
|
|
|
|
|
|
|
|
|
|
| |
In Skylark.java, fix line numbers to start at 1 instead of 2.
In Eval.java, go through maybeTransformException for consistency with expressions, even though no statement nodes use this feature.
In EvalExceptionWithStackTrace, fix style violation (non-consecutive overloads) and add TODO explaining an open issue.
RELNOTES: None
PiperOrigin-RevId: 169769928
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 169753517
|
|
|
|
|
|
| |
that were public because of skylark compilation.
PiperOrigin-RevId: 169739373
|
|
|
|
|
|
|
|
| |
remove all "precomputed values for analysis" from SkyframeExecutor. We use SkyframeExecutor#injectExtraPrecomputedValues these days.
This simplifies logic around when to inject precomputed values, and makes the graph more consistent.
PiperOrigin-RevId: 169733304
|
|
|
|
| |
PiperOrigin-RevId: 169728184
|
|
|
|
|
|
|
| |
nested.
RELNOTES: None
PiperOrigin-RevId: 169723791
|
|
|
|
| |
PiperOrigin-RevId: 169723724
|
|
|
|
|
|
|
|
| |
injected directly, which makes sense, because it's immutable over the lifetime of the server.
Step 3.
PiperOrigin-RevId: 169717587
|
|
|
|
|
|
| |
regarding the integrity of the structure to various operations.
PiperOrigin-RevId: 169715233
|
|
|
|
|
|
|
|
| |
of depending on a precomputed value. BlazeDirectories don't change over the lifetime of the Blaze server, and certainly not over the lifetime of a SkyframeExecutor instance, which already had a reference to them.
Step 2.
PiperOrigin-RevId: 169711443
|
|
|
|
|
|
|
|
| |
depending on a precomputed value. BlazeDirectories don't change over the lifetime of the Blaze server, and certainly not over the lifetime of a SkyframeExecutor instance, which already had a reference to them.
The goal is getting rid of the precomputed value entirely, but since this change necessitated a fair number of testing changes, I'm mailing this out as a first step.
PiperOrigin-RevId: 169705474
|
|
|
|
|
|
|
|
|
|
| |
"AndroidManifest.xml".
aapt requires the manifest to be named "AndroidManifest.xml" (unknown commit)
This allows users to provide manifests with custom names.
RELNOTES: Android rules no longer restrict the manifest file to be named "AndroidManifest.xml".
PiperOrigin-RevId: 169695062
|
|
|
|
|
|
|
| |
and apple_static_library no longer propagate ObjcProvider.
RELNOTES: None.
PiperOrigin-RevId: 169690934
|
|
|
|
|
|
|
|
|
| |
Before, linkstamping compile actions were hardcoded in bazel and assumed
gcc/clang and bash. This cl removes gcc/clang assumptions by using feature
configuration.
RELNOTES: None.
PiperOrigin-RevId: 169685949
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Rolled back commit enforces stricter parameter checks. Will fix and roll forward
This creates several failures on the nightly build of Bazel:
ERROR: /home/ci/workspace/Global/rules_closure-node=linux-x86_64/closure/protobuf/test/BUILD:23:1: no such package '@com_google_protobuf_protoc//': Cannot convert parameter 'url' to type string or sequence of strings, in method download_and_extract(List, string, string, string, string) of 'repository_ctx' and referenced by '//closure/protobuf/test:example_proto_gen'.
ERROR: Analysis of target '//closure/protobuf/test:example_lib' failed; build aborted: no such package '@com_google_protobuf_protoc//': Cannot convert parameter 'url' to type string or sequence of strings, in method download_and_extract(List, string, string, string, string) of 'repository_ctx'.
*** Original change description ***
Check parameter types for methods when multiple types are allowed.
Fixes #3714
RELNOTES: None.
PiperOrigin-RevId: 169669802
|
|
|
|
|
|
|
| |
build.lib.actions.SpawnActionContext can import SpawnResult without creating a cyclic dependency.
RELNOTES: None.
PiperOrigin-RevId: 169642267
|
|
|
|
| |
PiperOrigin-RevId: 169631693
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 169582778
|
|
|
|
|
|
| |
multiple constraint_values from the same constraint_setting (re: #350)
PiperOrigin-RevId: 169577576
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
executions and tests with multiple attempts. Previously, non-cached test execution would incorrectly only include test.log and test.xml.
Implement this by unifying test output list building in a static TestResult method.
For additional output files in multi-attempt tests, we follow the existing convention:
Existing example: test.xml => test_attempts/attempt_N.xml
New example (all new outputs done similarly): test.outputs/outputs.zip => test_attempts/attempt_N.outputs/outputs.zip
RELNOTES: All test output files included for cached, uncached, and multiple attempt tests.
PiperOrigin-RevId: 169556608
|
|
|
|
|
|
|
|
|
| |
Options that expand to other options are expansion options and the options they expand to have values that were expansions. This can be a bit confusing. Removes the isExpansion() call that is somewhat ambiguous, and forces option users to explicitly check the option definition for this information.
Also provide a parallel boolean function for implicit requirements, so that we stop querying for the length of the implicit requirement all over the place.
RELNOTES: None.
PiperOrigin-RevId: 169461566
|
|
|
|
|
|
| |
This is on the way to making select() work with constraint_values re: #305.
PiperOrigin-RevId: 169454982
|
|
|
|
|
|
| |
Part of the effort to simplify ConfiguredTargetFunction.
PiperOrigin-RevId: 169453435
|
|
|
|
|
|
|
|
| |
configsetting rule class. This is a step in the process of integrating platforms with selects and works towards fixing #350.
Also allow the host platform to be empty/nullable to support clients without access to its default settings.
PiperOrigin-RevId: 169436155
|
|
|
|
|
|
|
|
| |
There's no need for it in the core configuration options, as it's used
exclusively by Python rules.
RELNOTES: None.
PiperOrigin-RevId: 169435643
|
|
|
|
|
|
| |
RELNOTES: remove unused --host_incremental_dexing flag
PiperOrigin-RevId: 169433775
|
|
|
|
|
|
|
|
|
| |
See API Revisions design doc: https://docs.google.com/document/d/12c3oAPgedckLpue2yj0xGgJTEOyUm4mXWWBJ157J-8I/edit#heading=h.llz6ymkp07b1
The BuildInfo is now sent via RequestMetadata.
TESTED=we never used this field
PiperOrigin-RevId: 169432884
|
|
|
|
| |
PiperOrigin-RevId: 169428146
|
|
|
|
| |
PiperOrigin-RevId: 169418286
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, every Android-related top-level target will use the feature
flag whitelist, regardless of whether it has any feature flags.
This change makes it so that these targets only load the whitelist if
they need it.
In the process, it moves the value of the whitelist from the attribute
definition method to outside of it. Because it's a builder, this is only
a minor change to each callsite.
RELNOTES: None.
PiperOrigin-RevId: 169405621
|
|
|
|
|
|
|
| |
This change misses the corner case of builds which are entirely 32-bit (as opposed to mixed 32&64 bit) due to no legitimate place to report the error of such a build; execution will fail for such builds at the action level.
RELNOTES: None.
PiperOrigin-RevId: 169397354
|
|
|
|
|
|
| |
TESTED=unit tests
RELNOTES: none
PiperOrigin-RevId: 169395919
|
|
|
|
|
|
| |
is not present.
PiperOrigin-RevId: 169387061
|
|
|
|
|
|
|
|
| |
Replaces 'buildAndRegisterSpawnAction' now that
ActionConstructionContext does not leak underlying rule.
RELNOTES: None.
PiperOrigin-RevId: 169385509
|
|
|
|
|
|
|
|
|
| |
Now that we have dedicated sysroot variable, it is not necessary to have it in
unfiltered_compile_flags (actually, it's bad to have it here because it assumes
--sysroot= flag, and that doesn't work cross-platform).
RELNOTES: None.
PiperOrigin-RevId: 169384693
|
|
|
|
|
|
| |
Fixes #3714
RELNOTES: None.
PiperOrigin-RevId: 169382686
|
|
|
|
|
|
|
|
| |
Static libraries: cc_archive -> archive
Dynamic libraries: cc_dynamic_library -> dynamic_library
RELNOTES: None
PiperOrigin-RevId: 169374373
|
|
|
|
|
|
|
| |
This option does not in fact set a static $LANG envvar.
Change-Id: I9fbc477194aa1a8723069bb89069be6fafb8df35
PiperOrigin-RevId: 169364740
|
|
|
|
|
|
| |
This would have prevented a large breakage.
PiperOrigin-RevId: 169364731
|
|
|
|
|
|
|
|
|
|
|
| |
When copy_dynamic_libraries_to_binary is enabled, we copy the shared
libraries required by the binary to the binary's directory.
Bazel will throw errors if there are confilct actions generating the
same artifacts.
Change-Id: I09a5a599ca0ec7a67efd49d5aa89481450fa4e90
PiperOrigin-RevId: 169364498
|
|
|
|
|
|
|
|
| |
Also clarify the interfaces *TransitionResolver* - which determines what
transition to apply to an input configuration and *ConfigurationResolver*
- which determines the output configuration from that transition.
PiperOrigin-RevId: 169311986
|
|
|
|
|
|
|
| |
Fixes #3586.
RELNOTES: None.
PiperOrigin-RevId: 169303481
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 169258065
|