| Commit message (Collapse) | Author | Age |
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143939410
MOS_MIGRATED_REVID=143939410
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143380643
MOS_MIGRATED_REVID=143380643
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 142686266
MOS_MIGRATED_REVID=142686266
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thread all updates through a CodedOutputStream. This has the benefit of
potentially hashing less data, as many int values can be represented more
compactly, and reducing the churn of hashing strings (generally), since
CodedOutputStream is already heavily optimized for this. While the buffer
size is a little generous, it winds up paying off.
--
PiperOrigin-RevId: 142151062
MOS_MIGRATED_REVID=142151062
|
|
|
|
|
|
|
|
|
|
| |
Async threads are divorced from the server's error-reporting mechanism. In the event
of a server shutdown originating in an async-thread, write the exit code to a file that
can be read by the client.
--
PiperOrigin-RevId: 141920284
MOS_MIGRATED_REVID=141920284
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 141307853
MOS_MIGRATED_REVID=141307853
|
|
|
|
|
|
|
|
| |
Doesn't add much on top of the Iterable version in the current state of things, and it is too easy to confuse with addString.
--
PiperOrigin-RevId: 141300940
MOS_MIGRATED_REVID=141300940
|
|
|
|
|
|
|
|
|
| |
This allows us to reset and reuse the underlying digest implementation, which
guava's HashFunction doesn't allow. We do take the clone-if-possible page out
of guava's book.
--
MOS_MIGRATED_REVID=140624836
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change improves upon 4c67807964e37cfd55bbcda4c6374fcc480bcecc.
- A urls attribute has been added to the native workspace rules, with
the exception of maven_jar and git_repository. The Skylark repository
API also supports multiple URLs now.
- The earlier mirrors in the list are preferred. Failover will happen
automatically in parallel.
- The first 32kB of data is checked before choosing a mirror in order
to evade captive portals.
- If one's Internet goes down or a download times out, then the
download will resume automatically where it left off, provided the
server supports RFC7233 for that particular file. Please note that
GitHub does not support this for archive snapshots. Files should
always be mirrored to a CDN, e.g. GCS, because they support this.
- A semaphore is now used on downloads so only 8 can happen at once.
Fixes #1814
Fixes #2131
Fixes #2008
Fixes #1968
Fixes #1717
Fixes #943
Wont fix #1194
Fixes tensorflow/tensorflow#5933
Fixes tensorflow/tensorflow#5924
Fixes tensorflow/tensorflow#5924
Fixes tensorflow/tensorflow#5432
See #1607
See #821
See tensorflow/tensorflow#5080
See tensorflow/tensorflow#5029
See tensorflow/tensorflow#4583
See tensorflow/tensorflow#4058
RELNOTES: A urls attribute has been added to repository rules to support multiple mirror URLs for reliably downloading files.
--
MOS_MIGRATED_REVID=140495736
|
|
|
|
|
|
|
| |
by introducing TargetPattern#parEval, which allows TargetPatterns' evaluations to explicitly have parallel implementations (no need to secretly use a FJP).
--
MOS_MIGRATED_REVID=139101922
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=138039276
|
|
|
|
|
|
|
|
| |
These new log statements help in understanding what files trigger the
TimestampGranularityMonitor's wait logic and when the wait is performed.
--
MOS_MIGRATED_REVID=137868235
|
|
|
|
|
|
|
|
|
|
| |
Not storing it bare both breaks equality comparison for GroupedList and
uses more space.
--
Change-Id: Iaf4f88908ecf4293cfc31dbd896f46e1da3b4184
Reviewed-on: https://bazel-review.googlesource.com/#/c/6850/
MOS_MIGRATED_REVID=137099785
|
|
|
|
|
|
|
| |
Instead, deduplicate when the helper is actually added to a GroupedList.
--
MOS_MIGRATED_REVID=136145321
|
|
|
|
|
|
|
|
|
|
|
| |
We have added support for Linux s390x platform in Bazel.
Closes #1891.
--
Reviewed-on: https://github.com/bazelbuild/bazel/pull/1891
MOS_MIGRATED_REVID=135777047
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
[] hasn't released unknown commit yet.
We need to keep the old behavior until then.
*** Original change description ***
Stop consulting the environment for "originating user" information.
--
MOS_MIGRATED_REVID=135441115
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=135422529
|
|
|
|
|
|
|
|
|
| |
(which results in single-character gRPC messages).
Fixes #1861.
--
MOS_MIGRATED_REVID=134775680
|
|
|
|
|
|
|
|
| |
It's possible that there are multiple outstanding interrupts. When this
happens avoid interleaving their stack traces.
--
MOS_MIGRATED_REVID=134477540
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=132570504
|
|
|
|
|
|
|
| |
+ binds tighter than shift operators so this code was essentially doing (i+i)/2 when it was really trying to do i + (i/2).
--
MOS_MIGRATED_REVID=131709276
|
|
|
|
|
|
|
|
|
|
|
| |
InetAddress.getLocalHost().getHostName() can take seconds to complete as it
performs reverse DNS lookup. Prior to this cl hostname lookup was performed on
every build, noticeably slowing down null builds especially. This cl caches
computed hostname so null builds are faster for the lifetime of the server.
--
Reviewed-on: https://bazel-review.googlesource.com/#/c/5432/
MOS_MIGRATED_REVID=130441617
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OrderedSetMultimap. This maintains insertion order while eliminating duplicates.
Certain rules, in particular, otherwise break this invariant:
https://github.com/bazelbuild/bazel/blo[]e3e28274cca5b87f48abe33884edb84016dd3/src/main/java/com/google/devtools/build/lib/skyframe/ConfiguredTargetFunction.java#L403
There's no reason (to my knowledge) to need multiple instances of the same <Attribute, Dependency> pair.
More context from Google code review:
(Michael Staib):
> There are many things which pass around a dependentNodeMap or help construct one or modify one. We want an interface which has the right guarantees.
> ListMultimap is not the right interface because it has no guarantee of unique elements, which we want - we don't want the problem that this CL ran into, and there's no reason (that we know of, to be confirmed) that anyone would want multiple identical Dependencies.
> SetMultimap is not the right interface because it has no guarantee of deterministic iteration order or efficient iteration, which we want - dependency order sometimes matters (e.g., Java classpath or C++ link order).
> We agreed that the best way to get what we want is to define our own interface with its own simultaneous uniqueness and iterability guarantees. Unspoken in the discussion was why we wouldn't just use LinkedHashMultimap as the thing we pass around. IMO the reason for that is that we don't care that it be a LinkedHashMultimap specifically; if tomorrow Guava comes out with a faster cooler map that has deterministic and efficient iteration and guarantees element uniqueness, we want it.
> In this case we're going to make the "interface" be a (final?) class: OrderedSetMultimap, an extension of ForwardingSetMultimap which delegates to LinkedHashMultimap, an implementation which does support both of those guarantees.
> I had mentioned in the conversation that none of the Multimap implementations make guarantees about key iteration order, but this is not true - LinkedHashMultimap preserves key insertion order. We should perhaps declare this as part of the OrderedSetMultimap contract as well.
--
MOS_MIGRATED_REVID=130037643
|
|
|
|
|
|
|
| |
Removes a noticeable hotspot from LabelValidator.validateTargetName().
--
MOS_MIGRATED_REVID=128359980
|
|
|
|
|
|
|
|
|
|
| |
The naive algorithm was O(n*m) where n = number of precompiled libraries and
m = number of libraries linked during this rule. Ugly!
This one provides hopefully much more reasonable performance.
--
MOS_MIGRATED_REVID=128206057
|
|
|
|
|
|
|
| |
This minimizes API divergence and allows us to make use of performance enhancements in guava, such as https://github.com/google/guava/issues/1197.
--
MOS_MIGRATED_REVID=127108107
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Apparently we now try to open output files for the process twice: once when we are constructing the output streams, and the second time when we tell the process to redirect its outputs. This causes the outputs to be empty on Windows
*** Original change description ***
Do redirection of stdout / stderr in Java instead of reimplementing it in every process wrapper again.
--
MOS_MIGRATED_REVID=126801016
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=126566280
|
|
|
|
|
|
|
|
|
| |
that's what it does.
In particular, it affects Windows.
--
MOS_MIGRATED_REVID=126293339
|
|
|
|
|
|
|
| |
every process wrapper again.
--
MOS_MIGRATED_REVID=126279021
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=126177747
|
|
|
|
|
|
|
| |
they actually return a Path and not a File.
--
MOS_MIGRATED_REVID=126102820
|
|
|
|
|
|
|
|
|
| |
This is the first actual use of Windows JNI!
Also a cleanup of ProcessUtils. Injecting a mock implementation was never used.
--
MOS_MIGRATED_REVID=126068832
|
|
|
|
|
|
|
|
|
|
|
| |
- change options to print --foo=value
- allow option to specify what "value" should be
- update the documentation for the startup options
- add some indentation to the descriptions
- add some spacing between flag texts
--
MOS_MIGRATED_REVID=125960618
|
|
|
|
|
|
|
|
|
| |
...so that it can be used by the main code base.
--
Change-Id: Ibf59d74ab1b0cca9bd9406bb76ee6e71189653bf
Reviewed-on: https://bazel-review.googlesource.com/#/c/3903
MOS_MIGRATED_REVID=125950656
|
|
|
|
|
|
|
| |
This is to simplify the contract of BuildConfiguration.Fragment, thus making it simpler to create BuildConfigurations without unnecessary fragments and eventually create configuration fragments from Skylark.
--
MOS_MIGRATED_REVID=125137625
|
|
|
|
|
|
|
|
|
| |
CompactPersistentActionCache didn't work because it trys to rename a file to an existing file which JavaIoFileSystem doesn't support. Solution is deleting the file before renaming.
--
Change-Id: I8d476cd2835c8cddbeed8f556361e0e35d1a2bd4
Reviewed-on: https://bazel-review.googlesource.com/#/c/3802
MOS_MIGRATED_REVID=124828957
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=124744073
|
|
|
|
|
|
|
| |
It works for both labels on the command-line and labels in BUILD files.
--
MOS_MIGRATED_REVID=123967347
|
|
|
|
|
|
|
| |
This will be used later to detect typos and provide suggestions.
--
MOS_MIGRATED_REVID=123761611
|
|
|
|
|
|
|
|
|
| |
BlazeRuntime#getProductName() or a reference to TestConstants.PRODUCT_NAME for tests.
This CL prepares the codebase in order to delete the constant.
--
MOS_MIGRATED_REVID=122993568
|
|
|
|
|
|
|
|
|
|
| |
- mark the addDependencies method as @VisibleForTesting, and don't round-trip
through PathFragment
- use Path.getRelative(String) instead of Path.getRelative(PathFragment), which
may do additional optimizations
--
MOS_MIGRATED_REVID=122720947
|
|
|
|
|
|
|
| |
conversion is unnecessary and wasteful. In the remaining cases, the set conversion can be explicit.
--
MOS_MIGRATED_REVID=122294939
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
This is breaking ~1,000 tests in the latest Blaze nightly:
[]
Per sheriff policy, we need to either roll back or provide a quick fix tonight.
*** Original change description ***
Optimize hotspot in DependencySet.process().
--
MOS_MIGRATED_REVID=122220429
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=122050015
|
|
|
|
|
|
|
|
| |
Since file path is case-insensitive on Windows, we need to support this.
Also fixed .d file inclusions check in CppCompileAction.java on Windows
--
MOS_MIGRATED_REVID=121823250
|
|
|
|
|
|
|
| |
allowing for future work that may want to access a particular group in the GroupedList without advancing the iterator.
--
MOS_MIGRATED_REVID=120933039
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=120325869
|
|
|
|
|
|
|
|
| |
Consists of adding @Immutable annotations, adding final modifiers, and changing
the types of fields to immutable types.
--
MOS_MIGRATED_REVID=120221067
|
|
|
|
|
|
|
|
|
|
| |
...by only starting the new line, if needed and not already if the last
usable character of the line is written.
--
Change-Id: I86519389fe64fe74ba9045be07483ce5f55d5e9a
Reviewed-on: https://bazel-review.googlesource.com/#/c/3384
MOS_MIGRATED_REVID=119949042
|