| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
| |
The code has been untouched and unused for over a year (it's very likely
broken) and we have other priorities for now.
--
PiperOrigin-RevId: 145087310
MOS_MIGRATED_REVID=145087310
|
|
|
|
|
|
|
|
| |
In case of conflict, show the location of the original rule.
--
PiperOrigin-RevId: 143541281
MOS_MIGRATED_REVID=143541281
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143380643
MOS_MIGRATED_REVID=143380643
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143373605
MOS_MIGRATED_REVID=143373605
|
|
|
|
|
|
| |
--
PiperOrigin-RevId: 143204724
MOS_MIGRATED_REVID=143204724
|
|
|
|
|
|
|
|
|
| |
RELNOTES: Skylark dicts internally don't rely on keys order anymore and accept
any hashable values (i.e. structs with immutable values) as keys. Iteration order of dictionaries is no longer specified.
--
PiperOrigin-RevId: 141055080
MOS_MIGRATED_REVID=141055080
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
--
MOS_MIGRATED_REVID=140687884
|
|
|
|
|
|
|
|
| |
RELNOTES: Skylark dicts internally don't rely on keys order anymore and accept
any hashable values (i.e. structs with immutable values) as keys. Iteration order of dictionaries is no longer specified.
--
MOS_MIGRATED_REVID=140591710
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=140121290
|
|
|
|
|
|
|
|
| |
RELNOTES: Skylark dicts internally don't rely on keys order anymore and accept
any hashable values (i.e. structs with immutable values) as keys.
--
MOS_MIGRATED_REVID=139914704
|
|
|
|
|
|
|
|
|
| |
If `f` is an object with an attribute `x` which is callable, it's valid now to
call `f.x()` directly (caused a "no function called x" error before because .x
is a attribute, not a method).
--
MOS_MIGRATED_REVID=137698425
|
|
|
|
|
|
|
| |
function calls.
--
MOS_MIGRATED_REVID=137303042
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Fixed underlying broken CL that was depended on
*** Original change description ***
Automated [] rollback of commit e025939e71b179ae0f6bd09ef3af474f49b853a2.
*** Reason for rollback ***
Depends on commit 9c25afe750a937b2152c21a93effc8b9ba82c27b, which needs to be rolled back.
*** Original change description ***
Add API for individual actions
This exposes action inputs, outputs, argv, content, and substitutions (if applicable).
--
MOS_MIGRATED_REVID=135821603
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=135816105
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Depends on commit 9c25afe750a937b2152c21a93effc8b9ba82c27b, which needs to be rolled back.
*** Original change description ***
Add API for individual actions
This exposes action inputs, outputs, argv, content, and substitutions (if applicable).
--
MOS_MIGRATED_REVID=135783964
|
|
|
|
|
|
|
| |
This exposes action inputs, outputs, argv, content, and substitutions (if applicable).
--
MOS_MIGRATED_REVID=135226123
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=135144084
|
|
|
|
|
|
|
|
| |
Crash was triggered by overriding a @SkylarkCallable without repeating the
annotation in the subclass's method.
--
MOS_MIGRATED_REVID=134797463
|
|
|
|
|
|
|
| |
The new provider gathers actions generated by any Skylark-based RuleConfiguredTarget, so long as the rule definition has _skylark_test=True set. For the moment this flag is under the user's control, but the intention is that it will be set by a test runner.
--
MOS_MIGRATED_REVID=134687396
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of a SkylarkCallable.
CL already reviewed in commit 5972bee6ebfa53cf165befab9fa7962e19d5f620.
Rolled back due to casting error in Java 1.7. This is fixed now:
https://github.com/bazelbuild/bazel/issues/1832
Old:
matchingMethod =
new Pair<>(
method, argumentListConversionResult.getArguments());
New:
matchingMethod =
new Pair<MethodDescriptor, List<Object>>(
method, argumentListConversionResult.getArguments());
--
MOS_MIGRATED_REVID=134503884
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Break Bazel bootstrap on JDK7
*** Original change description ***
Skylark: Give more detailed errors when parsing the arguments
of a SkylarkCallable.
--
MOS_MIGRATED_REVID=134309621
|
|
|
|
|
|
|
| |
of a SkylarkCallable.
--
MOS_MIGRATED_REVID=134266707
|
|
|
|
|
|
|
|
|
|
| |
Currently, you will get an error for nearly all types since None is not
contained in any type but NoneType and Object.
Instead, use the same approach as SkylarkSignatureProcessor does currently.
--
MOS_MIGRATED_REVID=133821662
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously an error might look like:
Type PackagingCommon has no function directory(Label labelstring pathint mode).
Now, it shows up correctly as:
Type PackagingCommon has no function directory(Label label, string path, int mode).
--
MOS_MIGRATED_REVID=133285688
|
|
|
|
|
|
|
| |
function calls.
--
MOS_MIGRATED_REVID=133259901
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130665520
|
|
|
|
|
|
|
|
|
| |
method cannot be found when called from Skylark.
PAIR=laurentlb
--
MOS_MIGRATED_REVID=130636387
|
|
|
|
|
|
|
|
|
|
| |
This just add the support on the Skylark side, the documentation generator
still needs to be updated.
--
Change-Id: Ic26547cdb8d2c5c01839a4014c10f1b9b209b92b
Reviewed-on: https://bazel-review.googlesource.com/#/c/4247/
MOS_MIGRATED_REVID=129328278
|
|
|
|
|
|
|
|
|
|
|
| |
I believe the original intention of this error check was to always fail if kwargs were present (while Skylark doesn't support kwargs, at least). However, the current code will most likely fail at findJavaMethod because only the args (i.e. not the kwargs) are used to find a matching method.
This issue has already been encountered on the bazel-discuss group (g/bazel-discuss/hHyf2txlS70).
With the proposed modification, I believe any kwargs provided to Skylark methods will cause the kwarg-specific error.
--
MOS_MIGRATED_REVID=121345719
|
|
|
|
|
|
|
| |
Add some functions to Build, allow method calls.
--
MOS_MIGRATED_REVID=110835163
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Skylark into their own package. This allows, e.g., classes in the syntax package to access classes in the cmdline package without creating circular dependencies.
While we're here:
- Removed a couple of unused BUILD deps flagged in [].
- Updated SkylarkRuleImplementationFunctionsTest to remove non-ASCII characters and
clarify the intent of the test.
--
MOS_MIGRATED_REVID=110360763
|
|
|
|
|
|
|
| |
Mostly reuses the interpreters argument checking and helper functions.
--
MOS_MIGRATED_REVID=107395974
|
|
|
|
|
|
|
|
| |
Use SkylarkList everywhere rather than either List or GlobList.
Keep a GlobList underneath a MutableList, where applicable.
--
MOS_MIGRATED_REVID=105864035
|
|
|
|
|
|
|
| |
no).
--
MOS_MIGRATED_REVID=104655508
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Some rules write the toString representation of lists of files to disk and then read it back again. This breaks that.
--
MOS_MIGRATED_REVID=104524336
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=104197461
|
|
|
|
|
|
|
|
|
|
|
| |
The headers were modified with
`find . -type f -exec 'sed' '-Ei' 's|Copyright 201([45]) Google|Copyright 201\1 The Bazel Authors|' '{}' ';'`
And manual edit for not Google owned copyright. Because of the nature of ijar, I did not modified the header of file owned by Alan Donovan.
The list of authors were extracted from the git log. It is missing older Google contributors that can be added on-demand.
--
MOS_MIGRATED_REVID=103938715
|
|
|
|
|
|
|
|
| |
Make SkylarkList no longer read-only to match Python and the BUILD language.
Instead, subject it to a Mutability object inherited from the Environment.
--
MOS_MIGRATED_REVID=103332973
|
|
|
|
|
|
|
|
|
|
|
| |
Clarify the criterion for being a valid Skylark value;
stop claiming immutability is "the" criterion when Skylark now has mutable values;
stop relying on a reflection with a magic list (this also fixes the SkylarkShell build).
Clarify the criterion for determining immutable types when making a SkylarkNestedSet.
Clarify and use the criterion for being a valid Skylark dict key.
--
MOS_MIGRATED_REVID=103313934
|
|
|
|
|
|
|
|
|
| |
- Moved registration mechanism from BaseFunction into ASTNode / Statement / Expression
- Added more details about statements/expressions to the output trace (including if's)
- Fixed wrong locations
--
MOS_MIGRATED_REVID=102841164
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make Environment-s freezable: Introduce a class Mutability
as a revokable capability to mutate objects in an Environment.
For now, only Environment-s carry this capability.
Make sure that every Mutability is revoked in the same function that create...
This reinstates a change that previously rolled-back because it broke the
serializability of SkylarkLookupValue. Bad news: serializing it succeeds for the
wrong reason, because a SkylarkEnvironment was stored as a result (now an
Environment.Extension) that was Serializable but inherited its bindings from an Environment (now an Environment.BaseExtension) which wasn't Serializable.
Apparently, Java doesn't try to serialize the bindings then (or at least doesn't
error out when it fails), because these bindings map variable names to pretty
arbitrary objects, and a lot of those we find in practice aren't Serializable.
Thus the current code passes the same tests as the previous code, but obviously
the serialization is just as ineffective as it used to be.
--
MOS_MIGRATED_REVID=102776694
|
|
|
|
|
|
|
|
| |
Old message was e.g.
"No matching method found for $index(int) in set"
--
MOS_MIGRATED_REVID=102685114
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks serialization of SkyValues.
--
MOS_MIGRATED_REVID=102457225
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make Environment-s freezable: Introduce a class Mutability
as a revokable capability to mutate objects in an Environment.
For now, only Environment-s carry this capability.
Make sure that every Mutability is revoked in the same function that creates it,
so no Environment is left open for modification after being created and exported;
exceptions for tests, the shell and initialization contexts.
Unify Environment, SkylarkEnvironment and EvaluationContext into Environment.
Have a notion of Frame for the bindings + parent + mutability.
Replace the updateAndPropagate mechanism by a dynamicFrame.
Simplify ValidationEnvironment, that is now always deduced from the Environment.
--
MOS_MIGRATED_REVID=102363438
|
|
|
|
|
|
|
| |
attributes: generator_{function, name, location}
--
MOS_MIGRATED_REVID=102139196
|
|
|
|
|
|
|
|
| |
Move away global constants and global namespaces out of Environment
and into a new file Runtime.
--
MOS_MIGRATED_REVID=101940218
|
|
|
|
|
|
|
|
| |
Allow a call to a struct's field when it's a function.
Check whether a java method exists before issuing KwArg error.
--
MOS_MIGRATED_REVID=101937143
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101798931
|
|
|
|
|
|
|
| |
attributes: generator_{function, name, location}
--
MOS_MIGRATED_REVID=101774632
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=101572295
|