aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skyframe
Commit message (Collapse)AuthorAge
...
* Quiet error-checking by implementing hash code for object that already had ↵Gravatar Janak Ramakrishnan2015-05-22
| | | | | | | hash code implementation from super class. -- MOS_MIGRATED_REVID=94297315
* Allow @repo//foo:bar targets in BUILD filesGravatar Kristina Chodorow2015-05-22
| | | | | | | | This allows you to use @repo//... syntax outside of the WORKSPACE file, which makes it easier to use external dependencies. -- MOS_MIGRATED_REVID=94275085
* Add a hidden flag which allows us to set the size of the legacy globbing ↵Gravatar Eric Fellheimer2015-05-22
| | | | | | | thread pool. -- MOS_MIGRATED_REVID=94236393
* Move target pattern parsing to key construction timeGravatar Mark Schaller2015-05-21
| | | | | | | | | | | | So that a subsequent commit can take advantage of semantic information known only after target patterns have been parsed, this commit moves parsing from pattern evaluation time to pattern key construction time. This leads toward more efficient processing of target patterns in target pattern sequence evaluation. -- MOS_MIGRATED_REVID=94025646
* Teach skyframe about excluded directories, pathsGravatar Mark Schaller2015-05-21
| | | | | | | | | | | | RecursivePkgFunction now expects both a rooted path to load packages beneath and a set of paths to exclude. This also augments existing machinery to deliver this set of paths to exclude. This leads toward more efficient processing of target patterns in target pattern sequence evaluation. -- MOS_MIGRATED_REVID=94020331
* Rename skyframe's TargetPattern to TargetPatternKeyGravatar Mark Schaller2015-05-21
| | | | | | | | There were two TargetPattern types, one in cmdline and one in skyframe. This made things more confusing than they needed to be. -- MOS_MIGRATED_REVID=94005358
* Fix WORKSPACE file existence hermeticityGravatar Kristina Chodorow2015-05-18
| | | | | -- MOS_MIGRATED_REVID=93901785
* Deleted little-used PackageLoadedEvent.Gravatar Eric Fellheimer2015-05-18
| | | | | -- MOS_MIGRATED_REVID=93881974
* Add some basic logging around DiffAwarenessGravatar Michajlo Matijkiw2015-05-18
| | | | | | | | Some simple logging to tell us what strategy we are using and how many files we detect as modified. Useful for debugging slow (or fast) builds. -- MOS_MIGRATED_REVID=93745644
* Allow globs to be used outside of the skyframe package.Gravatar Janak Ramakrishnan2015-05-15
| | | | | -- MOS_MIGRATED_REVID=93647914
* Add a SingleCycleReporter for analysis phase cycles, which can (only) occur ↵Gravatar Nathan Harmata2015-05-15
| | | | | | | | | due to configurations. RELNOTES: -- MOS_MIGRATED_REVID=93543318
* We are trying to merge same copies of the aspect, when target is declared in ↵Gravatar Marian Lobur2015-05-15
| | | | | | | different attributes, to which we have attached aspect. -- MOS_MIGRATED_REVID=93412457
* Clean up some overly permissive permissions in FileStateValue.Gravatar Janak Ramakrishnan2015-05-07
| | | | | -- MOS_MIGRATED_REVID=92944321
* Track BUILD file changes on new_ repositoriesGravatar Kristina Chodorow2015-05-07
| | | | | | | | I noticed, while writing http://bazel.io/docs/cpp.html#including-external-libraries-an-example, that the BUILD file didn't get reparsed when it changed. This fixes that. -- MOS_MIGRATED_REVID=92921670
* Add fetch commandGravatar Kristina Chodorow2015-04-28
| | | | | | | | | | | | | | This command takes a one or more targets and fetches any external repository prerequisites that will be needed to build them. Example usage: bazel fetch //foo:bar If //foo:bar depends on, say, a maven_jar, it'll be downloaded. -- MOS_MIGRATED_REVID=92279626
* Clean up analysis error reporting a bit:Gravatar Janak Ramakrishnan2015-04-28
| | | | | | | | | 1. Make --analysis_warnings_as_errors a no-op. 2. Stop doing a sanity check that we didn't succeed in analysis even with errors emitted. 3. As a result, emit an error about shared actions to the proper listener. -- MOS_MIGRATED_REVID=92262247
* Fix SkyframeExecutor to not assume only one node for the configuration(s).Gravatar Ulf Adams2015-04-27
| | | | | | | | | | | | | As far as I can tell, the dependency on the BuildConfigurationCollection node is not required anymore. The BuildConfiguration is part of the SkyKey, and it uses object identity. This shouldn't affect garbage collection due to the explicit BuildView.dropConfiguredTargets. If we change that in the future, we will have to be (even more) careful. -- MOS_MIGRATED_REVID=92134490
* Simplify the createConfiguration method in SkyframeExecutor.Gravatar Ulf Adams2015-04-23
| | | | | | | | | Instead of passing BuildConfigurationKey instances around, just pass in the little data we actually need. This allows removing the BuildConfigurationKey class. -- MOS_MIGRATED_REVID=91865340
* Simplify AnalysisEnvironment creation.Gravatar Ulf Adams2015-04-23
| | | | | | | | | | | | | | Instead of computing flags based on the configuration in two places, we pass in the configuration and let the common code figure it out. Also change it so each CT only depends on the build info collection for its specific configuration. This should be safe, as the API doesn't allow passing a configuration in - it instead takes ruleContext.getConfiguration, which should be consistent with the dependency declarations in SkyframeBuildView in all cases. -- MOS_MIGRATED_REVID=91819844
* Similar to TargetMarkerValue, have TargetPatternValue *not* embed Targets.Gravatar Nathan Harmata2015-04-23
| | | | | | | []TESTED: See -- MOS_MIGRATED_REVID=91816612
* Remove old Skylark Function hierarchyGravatar Francois-Rene Rideau2015-04-23
| | | | | | | Last step in refactoring of Skylark builtin functions. -- MOS_MIGRATED_REVID=91796746
* Add the option to match by regexp in RecursiveFilesystemTraversal.Gravatar Janak Ramakrishnan2015-04-21
| | | | | -- MOS_MIGRATED_REVID=91642690
* Add a clear() method to FileOutErr.Gravatar Eric Fellheimer2015-04-21
| | | | | -- MOS_MIGRATED_REVID=91605508
* Pass in the test environment using ↵Gravatar Lukacs Berki2015-04-20
| | | | | | | | | | | BuildConfiguration.Options.testEnvironment instead of special-casing it in a large number of classes. The variables in the client environment are read in BlazeRuntime#beforeCommand() now. Note that this entails a slight loss of caching: before, "--test_env=a=A,b=B" and "--test_env=b=B,a=A" were equivalent, now they are not, since instead of comparing Map<String, String>, List<Map.Entry<String,String>> instances are compared. -- MOS_MIGRATED_REVID=91570828
* More skylark function cleanupsGravatar Francois-Rene Rideau2015-04-17
| | | | | -- MOS_MIGRATED_REVID=91407816
* Remove the full client environment from BuildConfiguration in favor of ↵Gravatar Lukacs Berki2015-04-17
| | | | | | | computing the test environment as early as possible, and passing that along. -- MOS_MIGRATED_REVID=91388451
* Tweak the default Skyframe thread count during testing. Since test cases are ↵Gravatar Eric Fellheimer2015-04-16
| | | | | | | typically small, the current default is too high. -- MOS_MIGRATED_REVID=91225981
* Belated cleanup of MetadataHandler#discardMetadata. Since we have per-action ↵Gravatar Janak Ramakrishnan2015-04-14
| | | | | | | metadata handlers, we can just unconditionally discard all output metadata with this call. -- MOS_MIGRATED_REVID=91008004
* Delete debugging code used to diagnose bug when shared actions raced to execute.Gravatar Janak Ramakrishnan2015-04-14
| | | | | -- MOS_MIGRATED_REVID=91007686
* Fix race when two shared actions don't know about each other until after ↵Gravatar Janak Ramakrishnan2015-04-14
| | | | | | | | | they have started executing in SkyframeActionExecutor. We were updating the action cache for both actions in this case, but one of the actions' metadata handler was not updated during execution, and thus it had no metadata for outputs. -- MOS_MIGRATED_REVID=90993813
* Don't take into account symlinks when computing intrabuild file ↵Gravatar Miguel Alcon Pinto2015-04-13
| | | | | | | modifications. While there could be bogus targets that modify symlinks, Bazel has output symlinks that point to source code. -- MOS_MIGRATED_REVID=90827597
* Clear dirty output tree counters so that the next build does not get the old ↵Gravatar Miguel Alcon Pinto2015-04-10
| | | | | | | counters. -- MOS_MIGRATED_REVID=90749273
* Add more debugging to help track down crash.Gravatar Janak Ramakrishnan2015-04-09
| | | | | | | Note that we probably want to change the discardMetadata signature to no longer take an argument, since we have per-action metadata handling. However, I'd like to know that that's the source of the crash, if it is, which is why I'm not removing the argument right now. -- MOS_MIGRATED_REVID=90712991
* Add debug logging to help find mysterious crash experienced by users.Gravatar Janak Ramakrishnan2015-04-09
| | | | | | | Some care was taken to make sure that we only log when a file is missing *after* the action is executed, when its failure to be present should force a build failure anyway, in order to avoid a source of memory pressure. -- MOS_MIGRATED_REVID=90682557
* Remove stale comment.Gravatar Nathan Harmata2015-04-08
| | | | | -- MOS_MIGRATED_REVID=90574562
* Mostly-automated roll-forward to return ActionInput objects from the ↵Gravatar Janak Ramakrishnan2015-04-06
| | | | | | | | | | | ActionInputFileCache when given a digest to do a reverse lookup so that metadata can be more easily retrieved. Discovered inputs are no longer ever put into SingleBuildFileCache, so it is safe to roll this forward now Because of code changes (meant to ensure the safety of this change), there were conflicts that had to be manually resolved. -- MOS_MIGRATED_REVID=90425783
* Split FileAndMetadataCache into two classes, since most of the shared ↵Gravatar Janak Ramakrishnan2015-04-06
| | | | | | | functionality is gone. -- MOS_MIGRATED_REVID=90289916
* Remove direct store of Target from NoSuchTargetException. Instead, just note ↵Gravatar Eric Fellheimer2015-04-02
| | | | | | | the fact that a valid Target exists, and instead request it directly from its Package. -- MOS_MIGRATED_REVID=90107670
* Clean up an unnecessary field in NoSuchTargetException.Gravatar Eric Fellheimer2015-04-02
| | | | | -- MOS_MIGRATED_REVID=90081310
* optionally error on files outside of known rootsGravatar Michajlo Matijkiw2015-04-01
| | | | | | | | | | | | The goal of this change is to provide a means for disallowing files outside of declared, known locations in order to better enforce the hermeticy and in turn reproducability of builds. Previously when encountering these files (typically via external symlinks) we would add a dependency on build_id, now we can optionally fail the build. -- MOS_MIGRATED_REVID=90015665
* Add PrepareDepsOfPatternsFunction, use before queryGravatar Mark Schaller2015-03-31
| | | | | | | | | | | | | This introduces a single SkyFunction that has the desired side effect of loading matching targets and their transitive dependencies in the graph. It replaces the two calls to buildDriver.evaluate that made sure the graph loaded the necessary values before query evaluation with just one call. -- MOS_MIGRATED_REVID=89864338
* Catch action conflicts in the same target during configured target analysis, ↵Gravatar Janak Ramakrishnan2015-03-30
| | | | | | | and fail hard in other cases. -- MOS_MIGRATED_REVID=89720528
* Resolve inputs that were stored in action cache ahead of time so metadata ↵Gravatar Janak Ramakrishnan2015-03-30
| | | | | | | | | | | for them can be retrieved with other inputs, avoiding a restart. This also allows us to delete the UndeclaredInputsHandler, since we eagerly cache metadata before entering any ActionCacheChecker methods. This should also allow us to split FileAndMetadataCache into two separate classes, as well as asserting that SingleBuildFileCache only sees non-artifact ActionInputs. To be done in follow-ups. -- MOS_MIGRATED_REVID=89718712
* Fix WORKSPACE file lookup to look at all package pathsGravatar Kristina Chodorow2015-03-30
| | | | | -- MOS_MIGRATED_REVID=89713328
* remove unused method/vars/doc in ConfiguredTargetFunctionGravatar Michajlo Matijkiw2015-03-30
| | | | | -- MOS_MIGRATED_REVID=89704303
* Move action-cache updating to inside ActionExecutionFunction, in preparation ↵Gravatar Janak Ramakrishnan2015-03-30
| | | | | | | | | for allowing it to be restarted in case of missing deps. Note that this means that action-cache writing is no longer part of the ACTION_COMPLETE profiling unit. -- MOS_MIGRATED_REVID=89702039
* Fix bug where inputs are updated from action cache but not tracked in Skyframe.Gravatar Janak Ramakrishnan2015-03-26
| | | | | | | This bug, and all of them like it, will be fixed in an upcoming cl that makes sure all input metadata is obtained through Skyframe. But I think we should have this fix now. -- MOS_MIGRATED_REVID=89540265
* Add functionality to discard orphaned binaries and middlemen.Gravatar Michajlo Matijkiw2015-03-25
| | | | | | | | | | Here we additionally identify artifacts as orphaned if they are only inputs to middleman actions whose outputs are unused. The middleman actions are still part of the action graph, but we tolerate their inputs being orphaned. -- MOS_MIGRATED_REVID=89512745
* Proper support for the external immutable directory mechanism for symlink ↵Gravatar Nathan Harmata2015-03-25
| | | | | | | chains. -- MOS_MIGRATED_REVID=89511018
* Add support of aspects to the skyframe implementation of query. To keep ↵Gravatar Marian Lobur2015-03-25
| | | | | | | these two versions of query consistent we need to add additional edges to the target that contains aspects, instead of adding it to the target that was in direct deps of the original one. -- MOS_MIGRATED_REVID=89483301
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-07 01:05:00 +0000