| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
them with getConfiguredTargetAndTarget() so we can get rid of
ConfiguredTarget.getTarget() callers. This should be a test only change.
PiperOrigin-RevId: 184877255
|
|
|
|
| |
PiperOrigin-RevId: 184784669
|
|
|
|
| |
PiperOrigin-RevId: 184720361
|
|
|
|
| |
PiperOrigin-RevId: 184710375
|
|
|
|
|
|
|
|
|
| |
execution platforms.
Part of #4442.
Change-Id: I6678d57f4aaadcb19032bf58820606242ba66a25
PiperOrigin-RevId: 184707708
|
|
|
|
|
|
| |
Looks like this got missed.
PiperOrigin-RevId: 184701334
|
|
|
|
|
|
| |
field type information.
PiperOrigin-RevId: 184695891
|
|
|
|
|
|
| |
runtime check on the type of the iterable, performing custom serialization for a NestedSet.
PiperOrigin-RevId: 184686288
|
|
|
|
|
|
|
| |
Part of #4442.
Change-Id: I21baffe59431ccd3d76754596ec2a605dbbe4354
PiperOrigin-RevId: 184678470
|
|
|
|
|
|
| |
InjectingObjectCodec.
PiperOrigin-RevId: 184566571
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
native skyframe implementation was actually quite incorrect in this case: It was adding a skyframe dependency on a FileValue for the output file. Without a transitive dependency on the source files and actions that determine the output file's state, this could never work (and explains why the incremental build would fail). Instead, we now depend on the Artifact corresponding to the output file instead.
This change updates the business logic RecursiveFilesystemTraversalFunction. This approach keeps the business logic of Fileset filesystem traversal centralized in RFTF.
To avoid making weird recursive Skyframe nodes in the output tree, we inline Skyframe dependencies and do direct filesystem operations over the output tree.
There are now three states we can be in when looking up a file:
1. Source file: As before, make a skyframe dep on the corresponding file
2. Top-level file of an output tree: Make a dep on the corresponding Artifact
3. Recursive file under an output directory: Do direct filesystem operations. It doesn't make sense to make Skyframe nodes corresponding to these files. In the future, I think we should consider failing fast on this case.
RELNOTES: None
PiperOrigin-RevId: 184556044
|
|
|
|
|
|
|
|
| |
essentially promote OwnedArtifact to ArtifactSkyKey and rename it to ArtifactSkyKey. The king is dead...
Also add some other execution-phase codecs.
PiperOrigin-RevId: 184552706
|
|
|
|
|
|
| |
SpecialArtifact.
PiperOrigin-RevId: 184539696
|
|
|
|
|
|
|
|
| |
We're now using ctime to detect file changes, so the timestamp granularity monitor should as well.
Unfortunately, we currently get nanosecond ctime from Linux, but then only return millis from FileStatus, so this doesn't change the accuracy of the monitor at all.
PiperOrigin-RevId: 184536539
|
|
|
|
|
|
|
|
| |
to do.
Also change AspectDescriptor #isEmpty() semantics because they seemed like a bug to me.
PiperOrigin-RevId: 184319840
|
|
|
|
|
|
|
|
| |
has a CODEC member. AutoCodec cannot yet support other type parameters for
NestedSet, like NestedSet<List<Foo>>. This will have to wait for AutoCodec
Runtime.
PiperOrigin-RevId: 184294808
|
|
|
|
|
|
|
|
|
| |
Bazel completely swallowed errors in some cases, e.g., if the pattern is
invalid like bazel build foo//bar:baz.
Note that it previously silently ignored empty targets if --experimental_skyframe_target_pattern_evaluator was passed, and now fails (which is consistent with legacy behavior). This is an intentional change, but may break users who are using the experimental flag and are passing empty strings to Bazel.
PiperOrigin-RevId: 184282856
|
|
|
|
| |
PiperOrigin-RevId: 184211212
|
|
|
|
| |
PiperOrigin-RevId: 184177838
|
|
|
|
|
|
|
| |
ConfiguredTargetAndTarget instead of a ConfiguredTarget.
This is to assist in deprecating ConfiguredTarget.getTarget().
PiperOrigin-RevId: 184043491
|
|
|
|
| |
PiperOrigin-RevId: 184040834
|
|
|
|
| |
PiperOrigin-RevId: 184032456
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
This CL is breaking src/test/shell/bazel/srcs_test
https://ci.bazel.build/blue/organizations/jenkins/bazel-tests/detail/bazel-tests/1884/tests
Fix https://github.com/bazelbuild/bazel/issues/4548
*** Original change description ***
Verbatim, initial checkin of Kryo files for @AutoCodec Runtime.
PiperOrigin-RevId: 183977098
|
|
|
|
| |
PiperOrigin-RevId: 183904648
|
|
|
|
|
|
| |
null in AbstractPackageLoader and tests).
PiperOrigin-RevId: 183896826
|
|
|
|
|
|
| |
Scan takes 1-2s.
PiperOrigin-RevId: 183881368
|
|
|
|
|
|
|
| |
Part of #4442.
Change-Id: I44f52d4200f50af0281735fbba326dce5960e950
PiperOrigin-RevId: 183874104
|
|
|
|
| |
PiperOrigin-RevId: 183859414
|
|
|
|
|
|
|
|
|
| |
It is not compatible with multiple execution platforms.
Part of #4442.
Change-Id: I683beaae1624130352a6f02bae3f4dfff263ea00
PiperOrigin-RevId: 183855561
|
|
|
|
|
|
|
| |
Part of #4442.
Change-Id: Ia9c4403817d9c1e6497212712f96dbf6618138e9
PiperOrigin-RevId: 183855255
|
|
|
|
|
|
|
|
| |
If two SkyValue objects are equal, then Skyframe caches and returns the old one, instead of the new one. That's a problem for the detection of file changes, which uses the FileContentsProxy, which wasn't part of the equals check before this change.
Progress on #3360.
PiperOrigin-RevId: 183834897
|
|
|
|
| |
PiperOrigin-RevId: 183826311
|
|
|
|
| |
PiperOrigin-RevId: 183731563
|
|
|
|
|
|
|
|
|
|
|
| |
This removes the need for ConfigurationTransitionProxy.DATA by providing a
way for the C++ rule defs to directly inject the transition for all rules
to use.
Skylark attributes work differently, so they'll be addressed in another
change.
PiperOrigin-RevId: 183721293
|
|
|
|
|
|
| |
Generalizes @AutoCodec.Constructor to @AutoCodec.Instantiator.
PiperOrigin-RevId: 183702768
|
|
|
|
|
|
| |
BuildConfiguration.
PiperOrigin-RevId: 183667795
|
|
|
|
|
|
| |
that took ConfiguredTargetKey.
PiperOrigin-RevId: 183519981
|
|
|
|
|
|
|
|
| |
Uses type and object equality to determine references. This results in a canonical serialized representation.
ObjectCodecTester and SerializerTester now log some timing information.
PiperOrigin-RevId: 183403658
|
|
|
|
|
|
| |
SkyKey and perform the lookup in AspectFunction, in parallel with the lookup for the base configured target introduced in unknown commit.
PiperOrigin-RevId: 183399436
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
...as completion of the respective top-level targets. In this way,
a failure is associated to its root cause, even if the cause is at
analysis phase; in particular, visibility errors are correctly
associated.
For the time beeing, we associate visibility root causes only with
labels; it is planned to change that to the more accurate configured
labels in a follow-up change.
Change-Id: I04121a7cd2099fc65171eae0719fd77b98aef09b
PiperOrigin-RevId: 183359798
|
|
|
|
|
|
| |
This should bring Serializers to parity with AutoCodec Marshallers.
PiperOrigin-RevId: 183330231
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds some logging to test helpers for size of serialized data.
Jan 25, 2018 7:16:25 AM com.google.devtools.build.lib.skyframe.serialization.testutils.SerializerTester testSerializeDeserialize
INFO: total serialized bytes = 70
Jan 25, 2018 7:16:25 AM com.google.devtools.build.lib.skyframe.serialization.testutils.ObjectCodecTester testSerializeDeserialize
INFO: total serialized bytes = 208
Kryo output is significantly smaller.
PiperOrigin-RevId: 183300353
|
|
|
|
| |
PiperOrigin-RevId: 183248133
|
|
|
|
|
|
| |
ConfiguredTargetAndTarget.getTarget().
PiperOrigin-RevId: 183241259
|
|
|
|
|
|
| |
Allows ObjectCodec to be registered as a Kryo Serializer.
PiperOrigin-RevId: 183149177
|
|
|
|
|
|
|
|
| |
TestConfigFragment.
Thanks to shahan@ for the TestConfigFragment code.
PiperOrigin-RevId: 183127152
|
|
|
|
|
|
| |
from package.
PiperOrigin-RevId: 183121812
|
|
|
|
|
|
|
|
| |
https://github.com/bazelbuild/bazel/commit/3863b536bcab8de2000f342c85c31c7ea91cccbe, we don't want to have to serialize/deserialize a BuildConfiguration in a SkyKey.
Cutting the edge to the aspect configuration will come in a follow-up.
PiperOrigin-RevId: 183117915
|
|
|
|
|
|
|
|
| |
BuildConfiguration: BuildConfigurations are too heavy to be in SkyKeys.
This adds an extra dependency for BuildInfoCollectionValues, but there are not many in the graph, and the dep request is now batched, which is better than before.
PiperOrigin-RevId: 183106788
|
|
|
|
| |
PiperOrigin-RevId: 183102476
|