| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
| |
- Label parsing can be simplified
- lib.syntax is only contains the code for Skylark and is reasonably independent from the problem domain of building things
This change is mostly only changes to imports declarations. The rest is reversing the dependency between :cmdline and :syntax and moving a tiny amount of code between Printer and FilesetEntry and the addition of SkylarkPrintableValue that I couldn't be bothered to separate out into its own change.
--
MOS_MIGRATED_REVID=103527877
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=102497981
|
|
|
|
|
|
|
|
|
|
|
|
| |
So that a subsequent commit can take advantage of semantic information
known only after target patterns have been parsed, this commit moves
parsing from pattern evaluation time to pattern key construction time.
This leads toward more efficient processing of target patterns in
target pattern sequence evaluation.
--
MOS_MIGRATED_REVID=94025646
|
|
|
|
|
|
|
|
| |
There were two TargetPattern types, one in cmdline and one in skyframe.
This made things more confusing than they needed to be.
--
MOS_MIGRATED_REVID=94005358
|
|
|
|
|
|
|
| |
[]TESTED: See
--
MOS_MIGRATED_REVID=91816612
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moves pattern resolving logic from TargetPatternFunction.Resolver to
a top level class. Adds a layer of abstraction to the Resolver
implementation enabling it to be backed by either an Environment or
a Graph, for use in SkyFunction evaluation or on-the-fly evaluation,
respectively. Finally, SkyQueryEnvironment#preloadOrThrow now checks
to see if each target pattern exists in the graph, and any that
don't will be resolved on-the-fly.
--
MOS_MIGRATED_REVID=88861201
|
|
|
|
|
|
|
|
|
|
|
|
| |
The package resolver calls getValueOrThrow in its getPackage method.
This call can throw an exception, and a year ago, the exception could
be multiple different subtypes of NoSuchThingException. Subsequently,
we made it so that only NoSuchPackageException could be thrown, but
the exception type specified in this call site remained the more
general supertype.
--
MOS_MIGRATED_REVID=88154358
|
|
--
MOE_MIGRATED_REVID=85702957
|