| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
|
|
|
|
|
| |
1. Make --analysis_warnings_as_errors a no-op.
2. Stop doing a sanity check that we didn't succeed in analysis even with errors emitted.
3. As a result, emit an error about shared actions to the proper listener.
--
MOS_MIGRATED_REVID=92262247
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
As far as I can tell, the dependency on the BuildConfigurationCollection node
is not required anymore. The BuildConfiguration is part of the SkyKey, and it
uses object identity.
This shouldn't affect garbage collection due to the explicit
BuildView.dropConfiguredTargets. If we change that in the future, we will have
to be (even more) careful.
--
MOS_MIGRATED_REVID=92134490
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of computing flags based on the configuration in two places, we pass
in the configuration and let the common code figure it out.
Also change it so each CT only depends on the build info collection for its
specific configuration. This should be safe, as the API doesn't allow passing
a configuration in - it instead takes ruleContext.getConfiguration, which
should be consistent with the dependency declarations in SkyframeBuildView in
all cases.
--
MOS_MIGRATED_REVID=91819844
|
| |
|
|
|
|
|
| |
and fail hard in other cases.
--
MOS_MIGRATED_REVID=89720528
|
| |
|
|
|
|
|
|
|
| |
This allows the pending action counter to be decremented correctly when in --keep_going mode.
As part of this, there's a small refactor in ParallelEvaluator that also fixes a potential bug, that nodes in error were signaling their parents with the graph version as opposed to their actual version. Because errors never compare equal (ErrorInfo doesn't override equality), this isn't an issue in practice. But it could be in the future.
--
MOS_MIGRATED_REVID=88395500
|
|
|
--
MOE_MIGRATED_REVID=85702957
|
Janak Ramakrishnan
Ulf Adams
Han-Wen Nienhuys