aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/skyframe/LocalDiffAwareness.java
Commit message (Collapse)AuthorAge
* Make --watchfs a common command option.Gravatar Ulf Adams2016-10-14
| | | | | | | | | | | | | | | | | | | | | | | | | Adding an options parameter to DiffAwareness#getCurrentView seems like the simplest way to achieve that. Alternatives considered: 1. Making the diff awareness modules stateful. However, I did not want to do so as I've also been working on improving the module API to reduce state, or at least to have a proper lifecycle management for any necessary state. 2. Making the watchFs flag a constructor parameter. However, that would also invalidate any implementations that don't use the flag (of which we have several). 3. Only passing in a single boolean flag instead of an options class provider; however, this is a more principled, futureproof API, which allows other modules / awareness implementations to use their own options. RELNOTES: --watchfs is now a command option; the startup option of the same name is deprecated. I.e., use bazel build --watchfs, not blaze --watchfs build. -- MOS_MIGRATED_REVID=136154395
* Rollback of commit 2891ec527eed27d0c6460d66f51cb66a43373b6a.Gravatar Damien Martin-Guillerez2016-10-14
| | | | | | | | | | | | | | | | | | | | | | | | | | *** Reason for rollback *** Causes our integration tests on Darwin to time out *** Original change description *** Make --watchfs a common command option. Adding an options parameter to DiffAwareness#getCurrentView seems like the simplest way to achieve that. Alternatives considered: 1. Making the diff awareness modules stateful. However, I did not want to do so as I've also been working on improving the module API to reduce state, or at least to have a proper lifecycle management for any necessary state. 2. Making the watchFs flag a constructor parameter. However, that would also invalidate any implement... *** -- MOS_MIGRATED_REVID=136070807
* Make --watchfs a common command option.Gravatar Ulf Adams2016-10-13
| | | | | | | | | | | | | | | | | | | | | | | | | Adding an options parameter to DiffAwareness#getCurrentView seems like the simplest way to achieve that. Alternatives considered: 1. Making the diff awareness modules stateful. However, I did not want to do so as I've also been working on improving the module API to reduce state, or at least to have a proper lifecycle management for any necessary state. 2. Making the watchFs flag a constructor parameter. However, that would also invalidate any implementations that don't use the flag (of which we have several). 3. Only passing in a single boolean flag instead of an options class provider; however, this is a more principled, futureproof API, which allows other modules / awareness implementations to use their own options. RELNOTES: --watchfs is now a command option; the startup option of the same name is deprecated. I.e., use bazel build --watchfs, not blaze --watchfs build. -- MOS_MIGRATED_REVID=136026835
* Introduce FsEventsDiffAwareness for OS X.Gravatar Damien Martin-Guillerez2016-06-02
| | | | | | | | | | | | | | | | | Use FsEvents API (https://developer.apple.com/library/mac/documentation/Darwin/Reference/FSEvents_Ref) to watch the file system. This change also refactor the LocalDiffAwareness to extract the WatchService specific part. It now select the FsEventsDiffAwareness on OSX and the WatchServiceDiffAwareness on Linux. RELNOTES[NEW]: On OSX, --watchfs now uses FsEvents to be notified of changes from the filesystem (previously, this flag had no effect on OS X). Fixes #1074. -- Change-Id: I927951468e4543a399e0e0ad0f1dd23d38ce15a0 Reviewed-on: https://bazel-review.googlesource.com/3420 MOS_MIGRATED_REVID=123854017
* Use Bazel Preconditions variant which avoids varargs array creationGravatar Mark Schaller2015-12-10
| | | | | | | Reduces garbage. -- MOS_MIGRATED_REVID=109914243
* Disable --watchfs on OSX in preparation for enabling it by default.Gravatar Ulf Adams2015-10-28
| | | | | | | | There's no timeline right now, but it's unusable on OSX and Oracle has no plans of fixing it. -- MOS_MIGRATED_REVID=106486015
* Rationalize copyright headersGravatar Damien Martin-Guillerez2015-09-25
| | | | | | | | | | | The headers were modified with `find . -type f -exec 'sed' '-Ei' 's|Copyright 201([45]) Google|Copyright 201\1 The Bazel Authors|' '{}' ';'` And manual edit for not Google owned copyright. Because of the nature of ijar, I did not modified the header of file owned by Alan Donovan. The list of authors were extracted from the git log. It is missing older Google contributors that can be added on-demand. -- MOS_MIGRATED_REVID=103938715
* Remove the WATCHFS_BLACKLIST from Constants.java.Gravatar Ulf Adams2015-08-28
| | | | | | | Instead, inject the list from the corresponding module. -- MOS_MIGRATED_REVID=101769355
* Log information about the baseline and new View passed to DiffAwarness#getDiff.Gravatar Nathan Harmata2015-07-17
| | | | | -- MOS_MIGRATED_REVID=98382658
* Unregister previously registered directories when they are deleted. This is ↵Gravatar Nathan Harmata2015-06-05
| | | | | | | important because the directory's inode could be reused for another directory in the future, and we would get WatchEvents for that new directory which would be problematic if we hadn't noted it yet. -- MOS_MIGRATED_REVID=95214882
* Add some basic logging around DiffAwarenessGravatar Michajlo Matijkiw2015-05-18
| | | | | | | | Some simple logging to tell us what strategy we are using and how many files we detect as modified. Useful for debugging slow (or fast) builds. -- MOS_MIGRATED_REVID=93745644
* Some cleanup changes.Gravatar Ulf Adams2015-03-05
| | | | | -- MOS_MIGRATED_REVID=87821306
* Update from Google.Gravatar Han-Wen Nienhuys2015-02-25
-- MOE_MIGRATED_REVID=85702957
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-05 11:37:52 +0000