| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
--
Change-Id: I1b8acc9dbd73ede3952a51f3f67b32e1b7e536a2
Reviewed-on: https://bazel-review.googlesource.com/#/c/3900
MOS_MIGRATED_REVID=125957281
|
|
|
|
|
|
|
|
|
|
| |
Make the experimental UI honor the --progress_in_terminal_title options which
requests that the terminal title be set to a description of the current progress.
--
Change-Id: I8ebded9ebb7e9f821344165fca6b5f6b9b254c68
Reviewed-on: https://bazel-review.googlesource.com/#/c/3904
MOS_MIGRATED_REVID=125953773
|
|
|
|
|
|
|
|
|
|
| |
...to save a bit of horizontal space in the scroll-back buffer.
The color-coding already gives enough navigation hints.
--
Change-Id: Id0e5decc6bd495a99ec839c096700406d8d1bab9
Reviewed-on: https://bazel-review.googlesource.com/#/c/3902
MOS_MIGRATED_REVID=125943242
|
|
|
|
|
|
|
|
|
|
|
|
| |
The experimental UI shows the oldest still running actions as well
as the total number of running actions. However, just presenting
them as "X actions" is confusing for some users; so be more explicit
and mention them as "X actions running".
--
Change-Id: I26b8450690dc8b233271596d3c85e9c0924f7333
Reviewed-on: https://bazel-review.googlesource.com/#/c/3901
MOS_MIGRATED_REVID=125941605
|
|
|
|
|
|
|
|
|
| |
At the end of the build (or when realizing that there will be no build phase),
the experimental UI drops into full streaming mode. When doing so, do not forget
to flush all buffered incomplete lines for stdout and stderr.
--
MOS_MIGRATED_REVID=125770854
|
|
|
|
|
|
|
| |
Bazel is using the right value.
--
MOS_MIGRATED_REVID=125764994
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Whenever the UI has to write a line to the progress buffer, it removes
the progress bar, write the line and re-adds the progress bar. Of course,
the re-added progress bar is the one that represents the up-to-date state
at the time of it being re-added. Therefore, this also is a refresh of the
progress bar. So update the time stamp tracking the last refresh. In this
way rate-limits on refreshes are honored more correctly; also, requirements
of the progress bar having to be refreshed after a certain point in time
that have been fulfilled by that implicit refresh are recognized as such,
keeping the output less flickering.
--
Change-Id: I44bcd85a149cb88fcde126119100a6e1ff1ba45d
Reviewed-on: https://bazel-review.googlesource.com/#/c/3873
MOS_MIGRATED_REVID=125664608
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At the end of the analysis phase, show the amount of work done during
this phase (e.g., number of packages loaded) in a way similar to the
last progress message shown for loading. In this way, users will over
time learn the number of packages their project depends on; thus the
progress shown during loading will become more meaningful to them.
--
Change-Id: If56fab5704c419be988e55f0c1705b3732c11369
Reviewed-on: https://bazel-review.googlesource.com/#/c/3872
MOS_MIGRATED_REVID=125656896
|
|
|
|
|
|
|
|
| |
Also update HelpCommand to output the configuration options in the hmtl
output.
--
MOS_MIGRATED_REVID=125570665
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125562946
|
|
|
|
|
|
|
|
|
|
|
| |
Several modules now explicitly add common command options. Of the remaining
ones, most add options to the build command, except one, which adds options
to query. They now all use the canonical implementation.
Also updated the documentation to clarify what this method actually does.
--
MOS_MIGRATED_REVID=125560058
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125554274
|
|
|
|
|
|
|
| |
An upcoming change will pipe this to an actual page.
--
MOS_MIGRATED_REVID=125545220
|
|
|
|
|
|
|
|
| |
Behavior of getLowerCase/getUpperCase is locale-specific, and can be rather
surprising. We should _always_ pass a locale explicitly.
--
MOS_MIGRATED_REVID=125450790
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=125436393
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the experimental UI always shows the 3 oldest, still running actions.
While this seems a reasonable default, some users requested to be able to change
the number of actions shown. Hence replace the hard-coded value by a flag.
While there, also fix an off-by-one error in deciding when to put the ellipsis
symbol.
--
Change-Id: I037d208360fa1d3f100c99ab1ab1f5fc140138ac
Reviewed-on: https://bazel-review.googlesource.com/#/c/3811
MOS_MIGRATED_REVID=125427168
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To keep the noise of messages in the scroll-back buffer low, limit
which test summaries are shown there.
- If a test fails to build, the error message about the build failure
is already in the scroll-back buffer---and more useful to the user
anyway.
- If a test is not run (either because the user interrupted the build,
or because of a build error), then either the user is aware of it
anyway or the information about the build failure is present and
more useful. Also, this is only detected at the end of the build,
were a summary of the tests is shown; hence avoid duplication here.
- If a test has status failed and there is precisely one failure log,
then the summary does not provide any useful information compared
to the individual FAIL message in the scrollback buffer.
While there, also show the precise status of the summary.
--
Change-Id: I13665db24f956c8d8b651dc38859649085b8bbcf
Reviewed-on: https://bazel-review.googlesource.com/#/c/3830
MOS_MIGRATED_REVID=125339810
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Very often, when an action completes, a new one is started directly
afterwards. With this in mind, delay the refresh after the completion
of an action as long as acceptable by the refresh rate limiting. If
indeed an action starts within that time, we have replaced a double refresh
of the progress bar by a single one, thus make it appear less flickering.
--
Change-Id: I0e9143d6bba9929265ad2b6a3699486a1d5b3b2b
Reviewed-on: https://bazel-review.googlesource.com/#/c/3823
MOS_MIGRATED_REVID=125165516
|
|
|
|
|
|
|
|
|
|
| |
In the experimental UI, for the running actions also report their strategy.
This will give a more complete picture of what Bazel is currently doing.
--
Change-Id: I9553c952ed494e0db225b2a1ae5e8eba00f68617
Reviewed-on: https://bazel-review.googlesource.com/#/c/3820
MOS_MIGRATED_REVID=125162808
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, another 5 java_test targets of Bazel passed on Windows:
//src/test/java/com/google/devtools/...
build/lib/bazel/repository/downloader:DownloaderTests
build/lib:graph_test
build/lib:java-rules-tests
build/lib:profiler-tests
build/lib:windows_test
Already passing targets are:
//src/test/java/com/google/devtools/...
build/android/ziputils:ziputils-tests
build/lib:BazelDocumentationTests
build/lib:objc-rules-tests
build/skyframe:skyframe_base_test
common/options:options_test
--
Change-Id: Ibb63f29615b84d6df44289c902f6d85ab6569d61
Reviewed-on: https://bazel-review.googlesource.com/#/c/3821
MOS_MIGRATED_REVID=125084737
|
|
|
|
|
|
|
| |
potentially-relevant options from the creation of the callback.
--
MOS_MIGRATED_REVID=124981132
|
|
|
|
|
|
|
|
|
|
|
|
| |
While there is little value in using the experimental UI if no
progress output is desired, we still want the experimental UI to
serve as a drop-in replacement for the old one, including the
ability to not show any progress.
--
Change-Id: I54c67a6f432541611da8b4ab7e7f88bb85926391
Reviewed-on: https://bazel-review.googlesource.com/#/c/3803
MOS_MIGRATED_REVID=124833575
|
|
|
|
|
|
|
|
|
| |
CompactPersistentActionCache didn't work because it trys to rename a file to an existing file which JavaIoFileSystem doesn't support. Solution is deleting the file before renaming.
--
Change-Id: I8d476cd2835c8cddbeed8f556361e0e35d1a2bd4
Reviewed-on: https://bazel-review.googlesource.com/#/c/3802
MOS_MIGRATED_REVID=124828957
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=124487512
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a user is running a test with lots of runs (e.g., to debug flakyness),
it is useful to immediately see individual failures and not wait for the
summary of tests. Therefore, report failure events just like errors in the
scrollback buffer.
--
Change-Id: If32d1201f59cec75d99d18a50fc881c3596c3081
Reviewed-on: https://bazel-review.googlesource.com/#/c/3770
MOS_MIGRATED_REVID=124437705
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Java's Arrays.copyOfRange expects as "to" argument the index of the
first character not to be copied. As indices start with 0, the first
index outside the array is, in fact, the length itself (and not one
more than the length).
This off-by-one error so far never caused any problems, as Arrays.copyOfRange
is guaranteed to accept arbitrary large "to" values and helpfully
pads with 0-bytes. As 0-bytes are not shown on most terminals, the
output still looked correct. However, that off-by-one error did mess
up the output for users of the --experimental_show_artifacts flag.
--
Change-Id: I135ff720740db5c224a47668fc7513cbb7110f9f
Reviewed-on: https://bazel-review.googlesource.com/#/c/3771
MOS_MIGRATED_REVID=124332337
|
|
|
|
|
|
|
| |
after the Package is fully loaded.
--
MOS_MIGRATED_REVID=124260910
|
|
|
|
|
|
|
| |
super-constructor records timestamps and gc stats under the covers, so that data will be inaccurate.
--
MOS_MIGRATED_REVID=123909692
|
|
|
|
|
|
|
|
|
|
|
| |
The experimental UI also keeps track, in the progress bar, of the last test
that completed. When using curses, use colors to indicate whether the test
passed or not.
--
Change-Id: Iaa01a773c3bbf534692ed21dd420596cb63e2585
Reviewed-on: https://bazel-review.googlesource.com/#/c/3752
MOS_MIGRATED_REVID=123871492
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=123723401
|
|
|
|
|
|
|
|
|
|
|
| |
(finally) delete Constants.java.
For bazel the file Constants.java is the only source of
src/main/java/com/google/devtools/build/lib:common and since it was exporting
guava then many dependencies needed to be fixed.
--
MOS_MIGRATED_REVID=123648270
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To give a better understanding of which packages are on the critical
path during loading and analysis, provide information in the same way
as during execution: show the earliest started, but not yet completed
package. As not all packages looked at during the analysis phase are
reported to the progress receiver, use a custom class to aggregate those
data.
--
Change-Id: I03c25efdecb4124e1bc06fce8be9175dc56b5500
Reviewed-on: https://bazel-review.googlesource.com/#/c/3700
MOS_MIGRATED_REVID=123408689
|
|
|
|
|
|
|
| |
creating fresh Package instances. Also make a few Package methods public.
--
MOS_MIGRATED_REVID=123247246
|
|
|
|
|
|
|
|
|
|
|
| |
When reporting about actions that are still running, groups those belonging
to the same test. In this way, more useful information can be presented in the
progress bar, instead of wasting a whole line for a single shard.
--
Change-Id: Id1f5a0595767906d6a75f6533be54f3c262ddd67
Reviewed-on: https://bazel-review.googlesource.com/#/c/3646
MOS_MIGRATED_REVID=123097744
|
|
|
|
|
|
|
| |
path after we OOM, in an attempt to make that path complete more quickly and successfully.
--
MOS_MIGRATED_REVID=123040502
|
|
|
|
|
|
|
|
|
| |
pessimistically OOMing when GC thrashing. The first seems to make us hang on OOM, which is kind of the opposite of what we want.
These flags are now even more terribly named than they used to be, but a rename can wait until we actually know what we want.
--
MOS_MIGRATED_REVID=123036704
|
|
|
|
|
|
|
|
|
| |
BlazeRuntime#getProductName() or a reference to TestConstants.PRODUCT_NAME for tests.
This CL prepares the codebase in order to delete the constant.
--
MOS_MIGRATED_REVID=122993568
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a progress message has to be shortened, as it does not fit in a
line in the progress bar, add a new first attempt: if the message the
path implicit to the label, only shorten that path within the message
(if that gets short enough, leaving a reasonable part of the path);
usually, the additional information is more useful than having a longer
part of the path present.
While there, also fix incorrect length computation in a different case
of message shortening.
--
Change-Id: Ied80e03cace1b249fc0f4e11bce41f2b4207b6ad
Reviewed-on: https://bazel-review.googlesource.com/#/c/3670
MOS_MIGRATED_REVID=122818198
|
|
|
|
|
|
|
| |
ConfiguredTarget.
--
MOS_MIGRATED_REVID=122729392
|
|
|
|
|
|
|
|
|
|
|
| |
After the initial loading phase, further packages are loaded during
analysis. Show in the experimental UI the total number of packages
loaded during analysis phase to indicate at least some progress.
--
Change-Id: I345c6f806591e70e4397fc3e3365718dde95d7d2
Reviewed-on: https://bazel-review.googlesource.com/#/c/3645
MOS_MIGRATED_REVID=122728719
|
|
|
|
|
|
|
| |
Fixes #1290.
--
MOS_MIGRATED_REVID=122726071
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If tests are run with --test_output=streamed, output has to be passed through
before the end of the (overall) build. In this situation, enforcing a line-end
to redraw the status bar messes up the output that is streamed through. Therefore,
buffer stdout/stderr to full lines and pass them through without extra newlines
added.
--
Change-Id: I52d5dfbd1cb30a6ce2d7d2fd34658a606abcc277
Reviewed-on: https://bazel-review.googlesource.com/#/c/3620
MOS_MIGRATED_REVID=122248012
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rollback of commit cda4b4eae0c495a8f90f2a70a8db46e34062ee26.
*** Reason for rollback ***
Roll-forward with fixes (see ExternalPackageBuilder).
*** Original change description ***
Automated [] rollback of commit 178a3dfda8bf72abf22758597a90a4afb8eed181.
*** Reason for rollback ***
Broke ci.bazel.io.
See #1234.
*** Original change description ***
Allow modules to inject a custom AttributeContainer.
--
MOS_MIGRATED_REVID=122100417
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=121996611
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=121960458
|
|
|
|
|
|
|
|
|
| |
message.
This fixes the output "Executed 1 out of 1 tests".
--
MOS_MIGRATED_REVID=121949576
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the progress bar of the experimental state tracker, when
reporting that precisely one target is being analyzed, show
that target. While there, also consistently switch to American
spelling.
--
Change-Id: Ib9027145aed69e757a7caf7076abdeb1c5ebeb30
Reviewed-on: https://bazel-review.googlesource.com/#/c/3583
MOS_MIGRATED_REVID=121833343
|
|
|
|
|
|
|
|
|
| |
...use Constants.PRODUCT_NAME instead. Fixes #1244.
--
Change-Id: Icdf07c5e0cdadc0e459708f13dae78f70b5ef026
Reviewed-on: https://bazel-review.googlesource.com/#/c/3580
MOS_MIGRATED_REVID=121819053
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Broke ci.bazel.io.
See #1234.
*** Original change description ***
Allow modules to inject a custom AttributeContainer.
--
MOS_MIGRATED_REVID=121658474
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=121497233
|