| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
| |
another command.
This is kind of lame (better would be to guarantee that once a command is accepted, it will run), but better than just crashing.
--
MOS_MIGRATED_REVID=129606325
|
|
|
|
|
|
|
| |
exception that caused the crash is an OOM. Too many systems wrap Errors in other exceptions, for instance https://github.com/google/guava/blob/master/guava-gwt/src-super/com/google/common/cache/super/com/google/common/cache/LocalCache.java#L267
--
MOS_MIGRATED_REVID=127845350
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add an event to the event bus that is guaranteed to come after the
completion of the command. Listeners can use this event to clean up
any resources that still need to be cleaned up. As first customer, add
the ExperimentalEventHandler so that it is guaranteed not to leak the
update thread.
--
Change-Id: Ia20bae8a00541aa1338e49f74a7320ac098ab71d
Reviewed-on: https://bazel-review.googlesource.com/#/c/4011
MOS_MIGRATED_REVID=126909844
|
|
|
|
|
|
|
| |
This change is similar to a previous change that introduced WorkspaceBuilder.
--
MOS_MIGRATED_REVID=126799657
|
|
|
|
|
|
|
|
| |
- Use the abrupt exit protocol to return the correct exit code when the server dies unexpectedly in gRPC mode
- Report the command waiting time correctly even if the waiting is done within the server
--
MOS_MIGRATED_REVID=126780186
|
|
|
|
|
|
|
|
|
| |
BlazeRuntime#getProductName() or a reference to TestConstants.PRODUCT_NAME for tests.
This CL prepares the codebase in order to delete the constant.
--
MOS_MIGRATED_REVID=122993568
|
|
|
|
|
|
|
|
|
| |
This saves the cost of (1) collecting all Options classes and (2) getting all their @Option annotations. Note that there is no savings on reflection costs, since that's already memoized internally by OptionsParser.
This saves ~250us per Blaze invocation.
--
MOS_MIGRATED_REVID=121153156
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2009!).
If a "blaze clean --expunge" was run concurrently with another command (that was waiting for the lock), it's possible that the clean command deletes the lock file, the new server starts up, then the JVM shutdown hooks delete the PID files from the *new* server.
There is still a slight possibility of a race condition if the lock is deleted then IOException occurs which prevents the BlazeShutdownException from being raised, but I'd rather not introduce another channel from command implementations to RPCServer to close that loophole.
This issue was triggered by commit 5a78166ee4edbd295f5d5fdb94785025285e764b, after which the PID files for the new server are written a bit more early, thus increasing the time window in which the race condition can happen.
--
MOS_MIGRATED_REVID=120805163
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The client provides information about whether the terminal is a tty, and
which width the output should be formatted for. Passing this information
as explicit command-line arguments has the disadvantage that it overrides
any setting in configuration files. While usually there is no one-size-fits-all
value for terminal width, it doesn't make sense either to have an option
where the user cannot set a default. Fix this by providing the client options
as least imported rc-source.
This is a roll-forward of commit 044adedc70de040475443e52eb1a3c692159790e
--
MOS_MIGRATED_REVID=120338148
|
|
|
|
|
|
|
| |
when in gRPC mode.
--
MOS_MIGRATED_REVID=120233121
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a less specific option specification in a rc file could override a more specific option specification when there's a non-trivial Command hierarchy. A concrete example would be a "build --foo=1" line overriding a "test --foo=2" line for a "test" invocation.
See the added test for more details.
Also fix some typos in BlazeCommandDispatcherRcoptionsTest.java.
Note that commit dc0fbb42ab22ab8f3205b0884069e1ffe03677c9 was rolled back in commit 417dad0f1e0d0ed4ccd5f8e52b49eb79937da49d which also incidentally rolled back commit 4f0fbe1b09333806cce76b75214e98c7684766e0. So this change is effectively a roll-forward of both of those, plus the bug fix, plus the typo fixes, and plus a documentation update.
--
MOS_MIGRATED_REVID=119276218
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Changed the semantics of local .blazerc handling, requiring a Blaze release rollback ([]).
*** Original change description ***
Make specific options win over common ones
When specifying which command names to parse options for, given the
command annotation, ensure that "common" comes first, so that it can
be overridden by more specific options.
--
MOS_MIGRATED_REVID=119227260
|
|
|
|
|
|
|
|
|
|
| |
In this way, the ExperimentalStateTracker has access to all the information needed
to provide information about the run-time of currently running actions.
--
Change-Id: I0f4e48f39e9ebe63555e4bb1d70df2a6dbb65430
Reviewed-on: https://bazel-review.googlesource.com/#/c/3204
MOS_MIGRATED_REVID=118929758
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=118605600
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=118568284
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=118563271
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=118561661
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As explained in commit 37f3e9ee, after completion of the build, there
is no need any more to update the progress bar. Instead, its last line,
if any, can just float into the scroll-back buffer. From then on, STDOUT
and STDERR events are just passed through. Do so as well for any late
INFO, WARNING, or ERROR events. This will allow avoiding pointless
messages in commands like 'bazel clean' (the patch removing those messages
will also provide an appropriate integration test).
Unfortunately, to make this work properly, we must ensure that both
event handlers get informed about the fact that we have a no-build
command. To do this, we register the event handler with the intended
IO stream on the event bus, as well as a passively observing variant of the
event handler that has direct acces to the full output stream.
--
Change-Id: I148dc0065b6343e4a2a225b2d4fa615b4f720ff5
Reviewed-on: https://bazel-review.googlesource.com/#/c/3124
MOS_MIGRATED_REVID=118444275
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=117939121
|
|
|
|
|
|
|
|
|
|
|
|
| |
If bazel is invoked with --color=no, two event handlers are in use
simultaneously, using different output streams. For the event bus,
register the one that is aware of ansi control characters, as this
is the one that will also pass through stdout/stderr events.
--
Change-Id: I83f1164b9057cebf9345c315f42c8d54a88d3888
Reviewed-on: https://bazel-review.googlesource.com/#/c/3121
MOS_MIGRATED_REVID=117922780
|
|
|
|
|
|
|
|
| |
This is one of the last pieces of state in BlazeRuntime that isn't safe to
share across command invocations.
--
MOS_MIGRATED_REVID=117910631
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The client provides information about whether the terminal is a tty, and
which width the output should be formatted for. Passing this information
as explicit command-line arguments has the disadvantage that it overrides
any setting in configuration files. While usually there is no one-size-fits-all
value for terminal width, it doesn't make sense either to have an option
where the user cannot set a default. Fix this by providing the client options
as least imported rc-source.
--
Change-Id: Iad9eddbb3ff1777f4b423053e21aeac9fd7c466f
Reviewed-on: https://bazel-review.googlesource.com/#/c/3092
MOS_MIGRATED_REVID=117833645
|
|
|
|
|
|
|
|
|
|
|
| |
When specifying which command names to parse options for, given the
command annotation, ensure that "common" comes first, so that it can
be overridden by more specific options.
--
Change-Id: I20cd90c098e993580c32297d1e36c8a6c939873a
Reviewed-on: https://bazel-review.googlesource.com/#/c/3091
MOS_MIGRATED_REVID=117821257
|
|
|
|
|
|
|
| |
Remove the constant.
--
MOS_MIGRATED_REVID=115555161
|
|
|
|
|
|
|
| |
--
Change-Id: I68f9f8c897c65b6d51bd21262e25ad6a93ee794f
Reviewed-on: https://bazel-review.googlesource.com/#/c/3011
MOS_MIGRATED_REVID=115454025
|
|
|
|
|
|
|
|
|
|
|
| |
By enabling this option (default is off), a new, still experimental
UI will be used. As it is developped from scratch, this commit simply
implements a UI that does not produce any output at all.
--
Change-Id: I895c0e0744c008212efc7bdfca1457f7907c9b64
Reviewed-on: https://bazel-review.googlesource.com/#/c/3009/
MOS_MIGRATED_REVID=115441032
|
|
|
|
|
|
|
| |
execroot of another workspace.
--
MOS_MIGRATED_REVID=109885272
|
|
|
|
|
|
|
|
|
| |
$OUTPUT_BASE/execroot/<workspace name> instead of $OUTPUT_BASE/<workspace name>.
This makes it possible to run Bazel in directories whose name clashes with one of the pre-existing files in the output base. Note that this option is turned off by default for now.
--
MOS_MIGRATED_REVID=109791053
|
|
|
|
|
|
|
|
| |
This only affects tests that previously set a Reporter on the BlazeRuntime;
the production code is already using the per-command Reporter in all cases.
--
MOS_MIGRATED_REVID=106820846
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105840775
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105499267
|
|
|
|
|
|
|
|
|
|
| |
The loadingPhaseRunner is stateless, and moving it prevents accidentally
adding state to it. The TargetPatternEvaluator is not stateless, but is
currently retained by the SkyframePackageManager, so we still keep that state
across invocations (see follow-up CL).
--
MOS_MIGRATED_REVID=104187659
|
|
|
|
|
|
|
| |
--invocation_policy startup flag and allows an application invoking Bazel to set or override flag values (whether from the command line or a bazelrc).
--
MOS_MIGRATED_REVID=104160290
|
|
|
|
|
|
|
|
|
|
|
| |
The headers were modified with
`find . -type f -exec 'sed' '-Ei' 's|Copyright 201([45]) Google|Copyright 201\1 The Bazel Authors|' '{}' ';'`
And manual edit for not Google owned copyright. Because of the nature of ijar, I did not modified the header of file owned by Alan Donovan.
The list of authors were extracted from the git log. It is missing older Google contributors that can be added on-demand.
--
MOS_MIGRATED_REVID=103938715
|
|
|
|
|
|
|
|
|
|
| |
This change makes it so commands are no longer both stored in the BlazeRuntime
and in the BlazeCommandDispatcher. Instead, they are only stored in
BlazeRuntime and usually passed there during construction. We have some tests
where this is tricky, so I'm keeping the old code path for now.
--
MOS_MIGRATED_REVID=103364581
|
|
|
|
|
|
|
|
| |
They are usually on the same line, so doing this in separate changes can cause
merge conflicts.
--
MOS_MIGRATED_REVID=103362797
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103276489
|
|
|
|
|
|
|
|
| |
The main piece is the blaze module environment, which is only valid during
command execution. Also configuration creation and precompleteCommand.
--
MOS_MIGRATED_REVID=103186467
|
|
|
|
|
|
|
|
|
| |
I wanted to merge it into beforeCommand, but the reporter isn't set up yet
when we call beforeCommand. Hopefully we can refactor the code to merge it
in the future.
--
MOS_MIGRATED_REVID=103179268
|
|
|
|
|
|
|
|
| |
The very long term plan is to make BlazeRuntime immutable, so that we can
run multiple commands in the same server.
--
MOS_MIGRATED_REVID=103080946
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=100814605
|
|
|
|
|
|
|
|
| |
1. We are adding handler and removing it after that.
2. There is no modules that calls .handle method of reporter in beforeCommand.
--
MOS_MIGRATED_REVID=100478454
|
|
|
|
|
|
|
|
|
| |
color when the build fails.
Includes fix for problems causing the original slowdown to blaze query
--
MOS_MIGRATED_REVID=99755414
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Query performance regression.
--
MOS_MIGRATED_REVID=99560234
|
|
|
|
|
|
|
| |
color when the build fails.
--
MOS_MIGRATED_REVID=98736813
|
|
|
|
|
|
|
|
| |
$ bazel blah
Command 'blah' not found. Try 'bazel help'.
--
MOS_MIGRATED_REVID=95089307
|
|
|
|
|
|
|
| |
Further improvements on #167.
--
MOS_MIGRATED_REVID=92459390
|
|
|
|
|
|
|
|
|
|
|
| |
BuildConfiguration.Options.testEnvironment instead of special-casing it in a large number of classes.
The variables in the client environment are read in BlazeRuntime#beforeCommand() now.
Note that this entails a slight loss of caching: before, "--test_env=a=A,b=B" and "--test_env=b=B,a=A" were equivalent, now they are not, since instead of comparing Map<String, String>, List<Map.Entry<String,String>> instances are compared.
--
MOS_MIGRATED_REVID=91570828
|
|
--
MOE_MIGRATED_REVID=85702957
|