| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
given application as there are cases where you want both.
--
MOS_MIGRATED_REVID=116998425
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=116990273
|
|
|
|
|
|
|
|
|
|
| |
srcs instead of throwing an error.
Implicit exporting of the deps of an android_library rule that doesn't have srcs
is deprecated and will soon be removed.
--
MOS_MIGRATED_REVID=116988446
|
|
|
|
|
|
|
| |
It has been made obsolete by java_toolchain.jvm_flags.
--
MOS_MIGRATED_REVID=116884961
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Skylark rule context object has a runfiles method. This adds two
optional parameters to that method, "symlinks" and "root_symlinks",
that expose functionality from the underlying Runfiles java class.
With this functionality, one can construct links in the runfiles tree
where the source and destination of the link have different names
and/or relative directories. This might be useful for things like
AppEngine rules where a file in a subdirectory of the source tree
needs to appear in the root directory of the runfiles tree.
If either new parameter is used, the runfiles is subject to stricter
validity checking. This checking propagates to other runfiles that
depend on it.
RELNOTES: Added "root_symlinks" and "symlinks" parameters to Skylark
runfiles() method.
--
MOS_MIGRATED_REVID=116879064
|
|
|
|
|
|
|
| |
Simplify automatic entries creation.
--
MOS_MIGRATED_REVID=116866524
|
|
|
|
|
|
|
| |
-all_load does not work like whole-archive in the Apple linker. It affects *all* arguments, before and after it. Therefore, a single always_link dependency in a cc_binary on Apple platforms turns *everything* into always_link.
--
MOS_MIGRATED_REVID=116674199
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=116595467
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=116593165
|
|
|
|
|
|
|
|
|
| |
and specify --experimental_android_resource_shrinking on the command line.
RELNOTES: Specifying --experimental_android_resource_shrinking on the command line will enable a resource shrinking pass on android_binary targets that already use Proguard.
--
MOS_MIGRATED_REVID=116572863
|
|
|
|
|
|
|
| |
Will need to release before we can remove resources from objcbinary rules.
--
MOS_MIGRATED_REVID=116571890
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=116549753
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=116511350
|
|
|
|
|
|
|
| |
that it can depend on Skylark rule.
--
MOS_MIGRATED_REVID=116385078
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=116272974
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Broke depot: []
*** Original change description ***
Skylark aspects should always output to bin directory.
--
MOS_MIGRATED_REVID=116264598
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=116255991
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using mandatoryProvidersList to validate python rules' dependency.
Added a SkylarkProvider named 'py' which is a SkylarkClassObject in Java and a
struct in Skylark. Native python rule and Skylark python rule should have this provider
so that they can depend on each other.
RELNOTES[NEW]: Native python rule can depend on skylark rule as long as skylark
rule provides 'py' provider.
--
MOS_MIGRATED_REVID=116241504
|
|
|
|
|
|
|
| |
are created, as opposed to when they are requested from the ParallelEvaluator. That delay can lead to large memory spikes and churn.
--
MOS_MIGRATED_REVID=116224565
|
|
|
|
|
|
|
|
|
|
|
|
| |
The production JvmConfigurationLoader never invents Jvm labels, and this
is only used for the sanity check that all implicit labels can be derived
from explicit labels. Unfortunately, our tests often use the
MockJvmFactory, which happily invents Jvm labels.
This is a step towards making the sanity check run unconditionally.
--
MOS_MIGRATED_REVID=116125095
|
|
|
|
|
|
|
| |
cpp, java, jvm) to the documentation.
--
MOS_MIGRATED_REVID=116092594
|
|
|
|
|
|
|
|
|
| |
that labels and label_lists are actually of type Target, and adding more cross linking to various documentation to make it easier to peruse.
Tested all of the links to make sure they work.
--
MOS_MIGRATED_REVID=116076080
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=116020389
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=116017697
|
|
|
|
|
|
|
|
| |
If we don't do that, the host configuration still uses the default
value, despite the invocation policy we apply internally.
--
MOS_MIGRATED_REVID=115986998
|
|
|
|
|
|
|
|
| |
Migrates --java_langtools, --javabuilder_top, --singlejar_top, --genclass_top,
and --ijar_top to java_toolchain.{javac,javabuilder,singlejar,genclass,ijar}
--
MOS_MIGRATED_REVID=115949619
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115921810
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115920640
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115912069
|
|
|
|
|
|
|
|
|
|
| |
This change adds a to_json method on Skylark structs, paralleling the
existing to_proto built-in.
RELNOTES[NEW]: Adds a to_json method to Skylark structs, providing conversion to JSON format.
--
MOS_MIGRATED_REVID=115873229
|
|
|
|
|
|
|
|
|
|
|
| |
the same artifact.
This fix is that we pick the random executable. Filed #987 for a better
fix (the current behavior just crashes the build randomly and the real
fix is involved).
--
MOS_MIGRATED_REVID=115835198
|
|
|
|
|
|
|
| |
RELNOTES:
--
MOS_MIGRATED_REVID=115804885
|
|
|
|
|
|
|
|
|
|
| |
- Remove unneeded abstract override AbstractAction#getResourceConsumption()
- Remove comments justifying returning ResourceSet.ZERO from getResourceConsumption() - instead document it once on the base method.
- Replace ResourceSet.create(0, 0, 0) with ResourceSet.ZERO.
- Make sure no one ever returns null from getResourceConsumption() and then simplify the code in SkyframeActionExecutor to not check for it.
--
MOS_MIGRATED_REVID=115739250
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes very little sense, because we only do this when compiling
them within a rule. The preprocessed files are not shipped to other rules,
meaning we treat things differently depending on the dependency
structure. And, worst of all, this can lead to a bug in the aidl compiler,
which causes the preprocessed definition to take precedence over the input
file, which causes certain modifiers to be stripped away.
Also, Gradle doesn't do it, and that's proof enough that this is no longer
the way to go, if ever it was.
Unfortunately, this causes a problem: the preprocessing had an effect, in
that all preprocessed types are available without the use of imports. This
means that .aidl files which were previously legal before this change may
now be broken, if they relied on this behavior. But, those .aidl files are
actually not legal according to the .aidl specification. Unfortunate, but
the right thing to do.
This CL also updates the idl documentation. Which, let's face it, could
probably have used some improvement.
RELNOTES[INC]: .aidl files correctly require import statements for types
defined in the same package and the same android_library.
--
MOS_MIGRATED_REVID=115718918
|
|
|
|
|
|
|
| |
willExecuteRemotely(). Remove unused parameter "mnemonic".
--
MOS_MIGRATED_REVID=115666410
|
|
|
|
|
|
|
|
|
| |
instead of special-casing it.
This removes the need to deserialize artifacts in FdoSupport, which in turn removes the need to support artifact deserialization at all, which makes our lives simpler and Thoreauvian programming is good.
--
MOS_MIGRATED_REVID=115660698
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115659763
|
|
|
|
|
|
|
| |
directly to newDeterministicWriter.
--
MOS_MIGRATED_REVID=115626619
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115581742
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115577068
|
|
|
|
|
|
|
| |
Remove the constant.
--
MOS_MIGRATED_REVID=115555161
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=115550466
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A Skylark remote repository should be invalidated only when
the WORKSPACE file change, or one of its dependency or the Skylark
file change.
This change include two fixes:
- The path of the RepositoryDirectoryValue was incorrect when
the directory root is a symlink and the repository is not local
(and not refetching). This was never triggered before because
the only rule that were symlinking their root were the local
one.
- Directories were unitialized for the SkylarkRepositoryFunction
(was forgotten as part of a refactor when introducing it).
--
MOS_MIGRATED_REVID=115547540
|
|
|
|
|
|
|
|
|
| |
Also implement handling of exports in Skylark aspects and enable
remaining tests (except PackageManifest and deprecated non-hermetic
stuff).
--
MOS_MIGRATED_REVID=115496333
|
|
|
|
|
|
|
|
| |
Also expose functionality to calculate resource source directory from
Android resource artifact.
--
MOS_MIGRATED_REVID=115492705
|
|
|
|
|
|
|
|
| |
Once this is released we can phase out --javac_bootclasspath and
--javac_extdir.
--
MOS_MIGRATED_REVID=115478455
|
|
|
|
|
|
|
|
|
|
|
|
| |
resources.
In Java code, it is a shared logic in
LocalResourceContainer.definesAndroidResources (that method has a fair
number of usages). This CL exposes that information on
AndroidIdeInfoProvider and futher on AndroidSkylarkInforProvider.
--
MOS_MIGRATED_REVID=115453472
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Any -target and -source options specified in javacopts are currently ignored
as they are overwritten with the hard-coded default -target 7 -source 7.
This seems more reasonable to me - there are valid use cases for doing so,
and if someone wants to shoot themselves in the foot, there are already plenty
of other ways of doing so.
A small step towards #844.
--
MOS_MIGRATED_REVID=115449058
|
|
|
|
|
|
|
| |
Make more tests pass for Skylark IDE info aspect implementation.
--
MOS_MIGRATED_REVID=115448483
|
|
|
|
|
|
|
| |
After JavaCommon is initialized once, all further calls throw an exception.
--
MOS_MIGRATED_REVID=115442886
|