| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
| |
classpath is
non-empty but there are no annotation processors to run.
PiperOrigin-RevId: 206244327
|
|
|
|
|
|
| |
https://github.com/bazelbuild/bazel/commit/9b29a1bd7bbe37500b28a6508cb82ca1943c75b5
PiperOrigin-RevId: 206182289
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is accomplished by:
- Setting the APPLE_CROSSTOOL configuration distinguisher in AppleCrosstoolTransition
- Doing nothing in AppleCrosstoolTransition in case we are already in an Apple configuration so that funky use cases like a binary having a dependency on a swift_library both directly and through an objc_library work
- Adding the "apl-" prefix to the output directory name in APPLE_CROSSTOOL configurations
Plus a few minor cleanups:
- Removed some unused methods
- Nopped out --enable_apple_crosstool_transition if the new flag is set
- Nopped out --target_uses_apple_crosstool if the new flag is set
These latter reduce the possible space of Apple configurations, thus making the code a bit more comprehensible.
RELNOTES: None.
PiperOrigin-RevId: 206157413
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 206156886
|
|
|
|
|
|
|
|
| |
This is in preparation for deleting CcLinkParamsStore. All remaining calls
to the setCcLinkparamsStore method of the CcLinkingInfo builder have been removed.
RELNOTES:none
PiperOrigin-RevId: 206128439
|
|
|
|
|
|
|
|
|
|
| |
This is in preparation for deleting CcLinkParamsStore. Not all calls to
setCcLinkparamsStore have been removed in this CL.
Roll forward with bzl change in separate CL (unknown commit) and giving a proper error in Skylark instead of a crash when CcLinkingInfo is not built correctly.
RELNOTES:none
PiperOrigin-RevId: 206122870
|
|
|
|
|
|
|
|
|
| |
This allows loading data inputs to annotation processors and Error Prone plugins.
Previously the only supported way to do this was using Java resources, but in
the case of per-package configuration that ties any changes to the resources
to JavaBuilder's release process.
PiperOrigin-RevId: 206106802
|
|
|
|
| |
PiperOrigin-RevId: 206102499
|
|
|
|
|
| |
RELNOTES: Removed the gen_jars output group
PiperOrigin-RevId: 206092599
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Crash (see linked bug).
PiperOrigin-RevId: 206060905
|
|
|
|
|
| |
RELNOTES: none.
PiperOrigin-RevId: 206035881
|
|
|
|
|
| |
RELNOTES: none.
PiperOrigin-RevId: 206035420
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add an option to provide a file with a resolved value, that will be
used to verify that the repositories mentioned in this file produce
a correct directory tree.
RELNOTES: newly added options --experimental_repository_hash_file and
--experimental_verify_repository_rules allow to verify for repositories
the directory generated against pre-recorded hashes. See documentation
for those options.
Work towards #5660.
Change-Id: I2d8becb188d0fa51e890fb8f6139f321cca14b7b
PiperOrigin-RevId: 206016792
|
|
|
|
|
|
|
|
| |
This is in preparation for deleting CcLinkParamsStore. Not all calls to
setCcLinkparamsStore have been removed in this CL.
RELNOTES:none
PiperOrigin-RevId: 205998687
|
|
|
|
|
|
|
|
|
| |
There were convoluted cases with multiple JavaInfo created from Skylark that
didn't have the JavaStrictCompilationArgsProvider. If these were to be merged
and later forwarded with exports we would miss them as dependencies.
RELNOTES: None
PiperOrigin-RevId: 205980933
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
3 providers had AbstractCcLinkParamsStore as a class field, now they wrap
CcLinkingInfo instead.
This is being rolled forward, first try caused a NullPointerException in
go_wrap_cc rules that had the attribute use_default_import set to False.
GoWrapCcConfiguredTargetTest now has a go_wrap_cc rule that has this attribute
set to false and fails with the previous version of this CL.
RELNOTES:none
PiperOrigin-RevId: 205959266
|
|
|
|
|
|
|
|
|
| |
the declared directories. Especially when doing validation during input
discovery, the discovery's over-approximation can lead to isDeclaredIn walking
the full path to the root without finding a declared include directory.
RELNOTES: None.
PiperOrigin-RevId: 205958078
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Crash with NullPointerException
*** Original change description ***
C++: Remove AbstractCcLinkParamsStore from providers.
3 providers had AbstractCcLinkParamsStore as a class field, now they wrap
CcLinkingInfo instead.
RELNOTES:none
PiperOrigin-RevId: 205885939
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Fixed duplicate derived inputs bug. Test is in diffbase.
RELNOTES[INC]: If the same artifact is generated by two distinct but identical actions, and a downstream action has both those actions' outputs in its inputs, the artifact will now appear twice in the downstream action's inputs. If this causes problems in Skylark actions, you can use the uniquify=True argument in Args.add_args.
PiperOrigin-RevId: 205863806
|
|
|
|
|
|
|
|
| |
RELNOTES: java_common.compile creates the native headers jar accesible via JavaInfo.outputs.native_headers.
Closes #5662.
PiperOrigin-RevId: 205832180
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 205825362
|
|
|
|
|
|
|
|
| |
3 providers had AbstractCcLinkParamsStore as a class field, now they wrap
CcLinkingInfo instead.
RELNOTES:none
PiperOrigin-RevId: 205821081
|
|
|
|
|
|
|
| |
treat java_proto_library.
RELNOTES: None
PiperOrigin-RevId: 205812269
|
|
|
|
| |
PiperOrigin-RevId: 205729963
|
|
|
|
|
|
|
|
|
| |
generate_interface_library is available
This way users of the Skylark API don't see this feature expanded.
RELNOTES: None.
PiperOrigin-RevId: 205704719
|
|
|
|
|
|
|
| |
For now, implicitly convert "warn" to "loose".
RELNOTES: None.
PiperOrigin-RevId: 205652060
|
|
|
|
|
|
|
|
|
| |
disabling relying on CROSSTOOL file in order to select the cc_toolchain label
CROSSTOOL file should not have any influence over selection of the cc_toolchain label. Ultimately the information that CROSSTOOL offers will be rerouted through an attribute of cc_toolchain.
RELNOTES: None.
PiperOrigin-RevId: 205651369
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 205646506
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 205635805
|
|
|
|
|
|
|
|
| |
Providers that were wrapping CcLinkParamsStore now wrap CcLinkingInfo instead.
CcLinkParamsStore will be deleted in a future CL.
RELNOTES:none
PiperOrigin-RevId: 205629924
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
makes it possible to disable .d file scanning when input discovery is used
without allowing the usage of undeclared headers.
The way this is implemented relies on having a sand-boxed or remote execution
environment and simply removes undeclared files from discovered inputs. As a
result, the compiler cannot see them and can diagnose missing headers.
The input discovery itself cannot (usually) diagnose undeclared headers as it
is often implemented to be an over-approximation. It needs to find all used
headers, but it is allowed to find more. Diagnosing these additional headers
would not be useful.
RELNOTES: None.
PiperOrigin-RevId: 205628312
|
|
|
|
|
|
|
| |
for this upgrade.
RELNOTES=None.
PiperOrigin-RevId: 205437116
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Update the Flutter rules AndroidSdkInfo provider to FlutterAndroidSdkInfo. AndroidSdkInfo should be unique in the repo now.
*** Original change description ***
Automated rollback of commit 4d10250291a813302de64151be3b22d57e94749d.
*** Reason for rollback ***
AndroidSdkInfo is already being used by the Flutter rules.
*** Original change description ***
Expose AndroidSdkProvider to Skylark (as AndroidSdkInfo).
RELNOTES: None.
PiperOrigin-RevId: 205431461
|
|
|
|
|
|
|
|
| |
are enabled before setting the corresponding build variables for the
crosstool. Such a conditional is unnecessary.
RELNOTES: None.
PiperOrigin-RevId: 205397072
|
|
|
|
|
|
| |
This is in preparation for open sourcing our include scanning implementation.
PiperOrigin-RevId: 205386312
|
|
|
|
|
|
|
| |
RELNOTES[INC]:Labels in C++ rules' linkopts attribute are not expanded anymore
unless they are wrapped, e.g: $(location //foo:bar)
PiperOrigin-RevId: 205385711
|
|
|
|
|
|
| |
One tiny step after the other.
PiperOrigin-RevId: 205378056
|
|
|
|
|
|
|
|
| |
Feature configuration and toolchain are now mandatory arguments. Rule context
is no longer a positional argument.
RELNOTES:none
PiperOrigin-RevId: 205367825
|
|
|
|
|
|
| |
generation action, track all the sources that will be generated by the proto generator.
PiperOrigin-RevId: 205309842
|
|
|
|
|
|
|
| |
Working towards #4570.
RELNOTES:none
PiperOrigin-RevId: 205274676
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous behavior was to put flags coming from Bazel option --linkopt into
legacy_link_flags. They should be in user_link_flags instead (together with
flags coming from linkopts rule attribute). This cl introduces
--experimental_linkopts_in_user_link_flags option that flips the behavior.
There is another incompatible change. Previously cc_common.create_link_variables() included flags from --linkopt, with the flag flipped it doesn't anymore. I believe
--linkopt flags shouldn't be there by default because:
* We don't tie the API with the specifics of C++ rules/options, enabling theoretical use with other languages (objc)
* Users are free to use ctx.fragments.cpp to access C++ options and add them explicitly (https://github.com/bazelbuild/bazel/issues/5602)
* New behavior maintains the symmetry with --copt and user_compile_flags
RELNOTES: None.
PiperOrigin-RevId: 205274272
|
|
|
|
|
|
|
| |
type.
RELNOTES: None.
PiperOrigin-RevId: 205237848
|
|
|
|
| |
PiperOrigin-RevId: 205236169
|
|
|
|
|
|
|
| |
Also add an execution requirement that allows disabling reporting to the CLI;
this will be used in a future change.
PiperOrigin-RevId: 205216096
|
|
|
|
|
|
|
|
|
| |
being executed if the action requires input discovery. Input discovery might
actually change the action's command line, which in turn can become part of the
file being written.
RELNOTES: None.
PiperOrigin-RevId: 205207109
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
AndroidSdkInfo is already being used by the Flutter rules.
*** Original change description ***
Expose AndroidSdkProvider to Skylark (as AndroidSdkInfo).
RELNOTES: None.
PiperOrigin-RevId: 205142459
|
|
|
|
|
| |
RELNOTES: Fixed compatibility with aar_import when using aapt2. AAPT2 is now supported for Android app builds without resource shrinking. To use it, pass the `--android_aapt=aapt2` flag or define android_binary.aapt_version=aapt2.
PiperOrigin-RevId: 205136160
|
|
|
|
|
| |
RELNOTES: none.
PiperOrigin-RevId: 205100703
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 205060182
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The C++ Skylark API is protected by a flag and whitelist. The flag's value
should be true by default for non-Bazel. This is set with an invocation policy. In
Bazel the default value is false. When this was checked in I couldn't find a
way to use the default value in the host configuration, so when checking the
flag we ignored the value for these cases.
In this CL we copy the target config value to the host config.
RELNOTES:none
PiperOrigin-RevId: 205059612
|