| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
| |
Moved the last remaining logic to its corresponding support class
(XcodeSupport).
--
MOS_MIGRATED_REVID=93462899
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the ObjcBundleLibrary#create() function creates a
BundleSupport object with the default "iphone" target family.
An ObjcBundleLibrary is a descendant of a Bundle, which has
a "families" attribute, so the information is available.
Currently, ObjcBundleLibrary will unconditionally use "iphone"
as the target device family.
This commit updates ObjcBundleLibrary to use the "families"
attribute. It does this by making BundleSupport
control the "families" attribute, and then provide access
to it for the other classes that use it, like
ObjcBundleLibrary. The other classes are changed to
get their target device family information from their
BundleSupport objects.
--
Change-Id: I4a5be2849315dabfe7f2975c006a2092a56027af
Reviewed-on: https://bazel-review.googlesource.com/#/c/1260/3
MOS_MIGRATED_REVID=93456579
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93454041
|
|
|
|
|
|
|
| |
tools/objc/BUILD.
--
MOS_MIGRATED_REVID=93447039
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When an ios_application is built, Bazel now collects the .breakpad files for
each architecture and tweaks the first line of each file to reflect the name of
the app, instead of the name of the binary:
MODULE mac arm64 5A70922132B738E194DDBC456F90F43F0 PrenotCalculatorBinary_bin
becomes
MODULE mac arm64 5A70922132B738E194DDBC456F90F43F0 PrenotCalculator
Bazel also correctly renames the files to end with their architecture, so that
the crash server can use them:
armv7/.../PrenotCalculatorBinary.breakpad
becomes
PrenotCalculator_armv7.breakpad
--
MOS_MIGRATED_REVID=93419816
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93416921
|
|
|
|
|
|
|
|
|
|
|
| |
TestStrategy#getLocalRunfilesDirectory(...) was using manifest names
to infer if the runfiles symlinks were created by comparing the name
of manifests. This is a bit confusing and adds unnecessary reliance
on manifests which we'd like to reduce. Instead get whether or not
we created the symlinks from the boolean that determines it.
--
MOS_MIGRATED_REVID=93414150
|
|
|
|
|
|
|
| |
XCode project files. Bazel-generated XCode projects contain all necessary header search paths to resolve header imports. Header map is not needed.
--
MOS_MIGRATED_REVID=93329329
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93308663
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93170106
|
|
|
|
|
|
|
| |
--
Change-Id: I523f31cf2179521847f644c426235bdf76e9d497
Reviewed-on: https://bazel-review.googlesource.com/#/c/1262/
MOS_MIGRATED_REVID=93146490
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93066384
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93051778
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93025992
|
|
|
|
|
|
|
|
|
|
|
|
| |
The command used to compile storyboards for iOS targets was
leaving off the --target-device options, which would result
in an empty compiled storyboard. This commit updates the
command constructed so that it does pass those options and
builds non-empty storyboards.
--
Change-Id: Ief6aed6f61099fa19ec7846d2321b40f8fce1ab2
MOS_MIGRATED_REVID=93016471
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=93014182
|
|
|
|
|
|
|
|
| |
getPackageFragment() only returns the relative path within a repository,
getPathFragment() is needed to return the external path.
--
MOS_MIGRATED_REVID=92941601
|
|
|
|
|
|
|
| |
It's undocumented, but it can be used for experimentation.
--
MOS_MIGRATED_REVID=92928896
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92920724
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92843582
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the "families" attribute is defined on the ReleaseBundlingRule.
Due to the relationships between the iOS rule classes, this leaves some
rules that need to know the device family they are building for without
that knowledge. Specifically, objc_bundle_library() can build storyboards
outside of any app or extension, and thus needs to know the target device
families to use during compilation. For reference, this was discussed at
https://groups.google.com/d/msg/bazel-discuss/c-2nwFiqhWo/puESbFNGAYMJ
This commit moves the "families" attribute from ReleaseBundlingRule to
BundlingRule to accomplish this.
--
Change-Id: Ia0d146e85f1c2cdb13bd74aef4a57de1ad537e0f
MOS_MIGRATED_REVID=92725861
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92725547
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92474815
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92472728
|
|
|
|
|
|
|
|
|
| |
the extra action.
This meant that the action was potentially being mutated on two threads, which was bad.
--
MOS_MIGRATED_REVID=92469122
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92407038
|
|
|
|
|
|
|
|
|
| |
plist file.
RELNOTES: Set the bundle id on plist files referenced by XCode application target.
--
MOS_MIGRATED_REVID=92378112
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92366919
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92364017
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92267704
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is required because Apple does not accept extensions whose plist
has a minimum OS value lower than 8.0, or whose code is compiled at less
than 8.0, even if it is included in an application that is compiled for,
and marked compatible with, a lower OS version.
Note that I didn't make this an attribute for now as there are no use
cases for setting the value to anything but 8.0. If we ever need to
make this user-configurable, a value can easily be set.
Second submission attempt with small additional logic to distinguish xcode
projects across configurations.
--
MOS_MIGRATED_REVID=92267493
|
|
|
|
|
|
|
|
| |
1. Race condition where extra action updates action's inputs while action is updating its own inputs.
2. Action was being updated with all inputs, including the extra action's ones, on a cache hit.
--
MOS_MIGRATED_REVID=92264706
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=92264639
|
|
|
|
|
|
|
| |
bundle id override.
--
MOS_MIGRATED_REVID=92262226
|
|
|
|
|
|
|
| |
companion Xcode library target.
--
MOS_MIGRATED_REVID=92198656
|
|
|
|
|
|
|
|
| |
getPackageFragment() only returns the relative path within a repository,
getPathFragment() is needed to return the external path.
--
MOS_MIGRATED_REVID=92196789
|
|
|
|
|
|
|
| |
Also fixes some grammar and indentation.
--
MOS_MIGRATED_REVID=91979763
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=91881146
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is required because Apple does not accept extensions whose plist
has a minimum OS value lower than 8.0, or whose code is compiled at less
than 8.0, even if it is included in an application that is compiled for,
and marked compatible with, a lower OS version.
Note that I didn't make this an attribute for now as there are no use
cases for setting the value to anything but 8.0. If we ever need to
make this user-configurable, a value can easily be set.
--
MOS_MIGRATED_REVID=91831415
|
|
|
|
|
|
|
| |
[]TESTED: See
--
MOS_MIGRATED_REVID=91816612
|
|
|
|
|
|
|
|
| |
This simplifies the callers and we get better consistency - the getBuildInfo
must use matching AnalysisEnvironment and RuleContext objects.
--
MOS_MIGRATED_REVID=91815339
|
|
|
|
|
|
|
| |
Last step in refactoring of Skylark builtin functions.
--
MOS_MIGRATED_REVID=91796746
|
|
|
|
|
|
|
|
| |
Replace the uses of AbstractFunction, MixedModeFunction,
SkylarkFunction and SimpleSkylarkFunction by BuiltinFunction.
--
MOS_MIGRATED_REVID=91763158
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=91713784
|
|
|
|
|
|
|
| |
Fixes #138.
--
MOS_MIGRATED_REVID=91708374
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=91617486
|
|
|
|
|
|
|
| |
Also simplifies command line construction and removes redundant linker arguments.
--
MOS_MIGRATED_REVID=91613561
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=91603959
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=91578316
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=91407816
|