| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
| |
The only case this exception is thrown is when there is
a bug in Bazel and we should surface the whole stacktrace.
See #3664
PiperOrigin-RevId: 167492638
|
|
|
|
| |
PiperOrigin-RevId: 167480127
|
|
|
|
| |
PiperOrigin-RevId: 167477112
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Broke several tests in nightly.
[]
*** Original change description ***
Rollforward #2 of "AppleBinary and AppleStaticLibrary no longer propagate unwrapped ObjcProvider", after changes made to apple bazel rules to be compatible.
RELNOTES: None.
PiperOrigin-RevId: 167312716
|
|
|
|
|
|
|
|
|
|
|
| |
class.
TESTED=Dumped the actions graph for AndroidBinary before and after the change
and compared to make sure the same actions are registered, and also manually
invoked mobile-install.
RELNOTES: None.
PiperOrigin-RevId: 167311030
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bazel now creates all SpawnActions in
AndroidBinary, AndroidCommon, and DexArchiveAspect
such that they use the default shell environment.
The benefit of this is that these actions will
have a well-controlled, minimal environment, and
most importantly they'll have valid TMP and TEMP
environment variables, which is necessary for temp
file creaion on Windows.
I created this commit for the same reason as
https://github.com/bazelbuild/bazel/commit/0abf5fa2d64c76def5a8fa0f960b73ce0566af4d
See https://github.com/bazelbuild/bazel/issues/3659
Change-Id: Ice42ea6424af8984d3c382ab01727e04cbd0c1b4
PiperOrigin-RevId: 167285724
|
|
|
|
|
|
|
| |
Instead of passing all the runtime jars in the environment variable, we now write them all to a file and store the file path in the env variable, jacoco runner reading the jars from there. Changes on Jacoco runner side are here: https://github.com/bazelbuild/bazel/commit/05418b33dd87d63e2653e594d462b2aedb0e22e5
RELNOTES: A new Java coverage implementation is available. Makes possible coverage for Skylark JVM rules.
PiperOrigin-RevId: 167248966
|
|
|
|
|
|
|
|
| |
This will be used to create thin skylark rules to allow for select() on provider values, with xcode_config_alias's XcodeProperties to be the first.
This is demonstrated in XcodeConfigTest.
RELNOTES: None.
PiperOrigin-RevId: 167204266
|
|
|
|
|
|
|
|
| |
This feature is opening up beyond just ConfigFeatureFlags, and so should not
be restricted.
RELNOTES: None.
PiperOrigin-RevId: 167195959
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks rules_go CI
*** Original change description ***
Bazel c++ rules depend on a c++ toolchain.
PiperOrigin-RevId: 167191667
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 167164919
|
|
|
|
| |
PiperOrigin-RevId: 167154793
|
|
|
|
| |
PiperOrigin-RevId: 167147239
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 167143657
|
|
|
|
|
|
|
| |
Add _'s in proto.transitivedescriptorsets
RELNOTES: none
PiperOrigin-RevId: 167139522
|
|
|
|
|
|
|
|
|
|
| |
- Move ProfilerInfo into a subpackage (it's not necessary for profiling, just for analyzing a profile).
- Make some fields in Profiler public for ProfileInfo.
- Mark Profiler as ThreadSafe; there's no cyclic dependency here.
This is based on ulfjack's microbazel patch series: https://github.com/ulfjack/bazel/commit/44553fcac0fc876784d8f48c2e577d8c999712de
PiperOrigin-RevId: 167121952
|
|
|
|
|
| |
RELNOTES: `JavaInfo` is a preferred alias to `java_common.provider`.
PiperOrigin-RevId: 167116971
|
|
|
|
|
|
|
| |
unwrapped ObjcProvider", after changes made to apple bazel rules to be compatible.
RELNOTES: None.
PiperOrigin-RevId: 167061765
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After this CL, if the feature_flags attribute of android_test or
android_binary is not set, no transition takes place when entering that
rule. This means that if it is depended upon by another test or binary, it
will use the enclosing test or binary's flags.
This permits users of feature flags to depend on non-users of feature flags.
The opposite is still not permitted. If a dep sets feature flags, then the
target depending on it must have the exact same feature flags set.
This way, all targets used in an android_test are built the same way, but
it's possible to interoperate with targets which are agnostic to feature
flags.
Note that "not set" is different from "set to the empty dictionary"; the
former reuses the definitions set higher up in the build graph, while the
latter clears all feature flag values and resets them to their defaults.
RELNOTES: None.
PiperOrigin-RevId: 167035122
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 167031992
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 167028314
|
|
|
|
|
|
|
| |
also, AppleConfiguration no longer throws NPE with invalid cpu.
RELNOTES: None.
PiperOrigin-RevId: 167013760
|
|
|
|
|
|
|
|
| |
The code in scheduleLtoBackendAction was attempting to construct the Artifact for a .dwo file when Fission is enabled by getting the related artifact via the ruleContext. This doesn't work for nativedeps files which have a shared _nativedeps/-relative library path, instead of being under the package directory.
Instead, compute the .dwo path the same way we do the ThinLTO imports and index file outputs, using the linkArtifactFactory.
PiperOrigin-RevId: 167002233
|
|
|
|
|
|
|
|
| |
with the new android_binary parameter "proguard_apply_dictionary".
RELNOTES[NEW]: android_binary now supports proguard_apply_dictionary to specify a custom dictionary to use for choosing names to obfuscate classes and members to.
PiperOrigin-RevId: 167000875
|
|
|
|
| |
PiperOrigin-RevId: 166966182
|
|
|
|
|
|
| |
that is accessible to the c++ rules.
PiperOrigin-RevId: 166934390
|
|
|
|
|
|
|
| |
it turns out these keys are still used by objc_framework, so cannot be removed.
RELNOTES: None.
PiperOrigin-RevId: 166895085
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, when filtering in analysis, density information was not passed to
execution to avoid wasting time on re-filtering. However, that density
information was also used to add information to the manifest. Add an additional
flag to save density information to the manifest without triggering resource
filtering in execution, and use it when filtering in analysis.
RELNOTES: None
PiperOrigin-RevId: 166891827
|
|
|
|
| |
PiperOrigin-RevId: 166889783
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 166889164
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 166888780
|
|
|
|
|
|
|
|
|
| |
Previously it had too many essentially identical accessors. This trims it down a bit and adjusts the call sites.
This cl changes the command line passed to tests slightly - now they can possibly contain linkstamping command prepended to actual linker invocation.
RELNOTES: None.
PiperOrigin-RevId: 166888575
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 166874734
|
|
|
|
|
|
|
|
|
| |
https://github.com/bazelbuild/bazel/commit/0071b396776be4d146fd271499716dd5dea6f7e9: Enable parameter files for manifest merger actions.
NEW: Using shell quoted param files and unescape arguments in ParamsFilePreProcessor to avoid miss-processing --manifestValues arguments containing whitespace.
RELNOTES: None.
PiperOrigin-RevId: 166858411
|
|
|
|
|
|
|
|
| |
PlatformConfiguration is made a legal configuration fragment for every rule class.
Add a default "dummy" c++ toolchain to prevent resolution errors when legacy toolchain selection logic is used. Add toolchain mocks to java and shell tests.
PiperOrigin-RevId: 166854893
|
|
|
|
|
|
|
|
|
| |
While we don't generate .dwp files for shared libraries, the link still expects the object files to contain split debug info.
Enhanced tests to ensure the cc_library LTO backend actions always have the expected outputs/build variable, regardless of linking static or not.
RELNOTES: NONE
PiperOrigin-RevId: 166853630
|
|
|
|
| |
PiperOrigin-RevId: 166849610
|
|
|
|
|
|
|
|
|
| |
To do this, add a new tool that is used instead of zipper to get the resources out of the AAR. This tool creates res/values/empty.xml if there are no resources in the AAR.
Also, some general cleaning of the code.
RELNOTES: None
PiperOrigin-RevId: 166768607
|
|
|
|
|
| |
RELNOTES: none
PiperOrigin-RevId: 166764640
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 166756809
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks //src/test/shell/bazel:bazel_bootstrap_distfile_test:
INFO: You can skip this first step by providing a path to the bazel binary as second argument:
INFO: ./compile.sh compile /path/to/bazel
🍃 Building Bazel from scratch......
🍃 Building Bazel with Bazel.
.WARNING: /tmp/bazel_cHivhPBc/out/external/bazel_tools/WORKSPACE:1: Workspace name in /tmp/bazel_cHivhPBc/out/external/bazel_tools/WORKSPACE (@io_bazel) does not match the name given in the repository's definition (@bazel_tools); this will cause a build error in future versions.
ERROR: in target '//external:cc_toolchain': error loading package '@local_config_cc//': Extension file not found. Unable to load file '@local_config_cc//:dummy_toolchain.bzl': file doesn't exist or isn't a file.
INFO: Elapsed time: 3.343s
ERROR: Could not build Bazel
Found by git bisect.
*** Original change description ***
Add a new toolchain type for c++. In order to do this, PlatformConfiguration is made a legal configuration fragment for every rule class.
Add a default "dummy" c++ toolchain to prevent resolution errors when legacy toolchain selection logic is used. Add toolchain mocks to java and shell tests.
PiperOrigin-RevId: 166750885
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 166745722
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 166735889
|
|
|
|
|
|
|
| |
states that "This and *values* cannot both be empty" with the word *values* hyperlinking to define_values. Assuming typo(?) and changing to "This and *define_values* cannot both be empty."
RELNOTES: None.
PiperOrigin-RevId: 166723373
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change forces use of CustomCommandLine.Builder, which has a richer interface for constructing memory-efficient command lines. It will also permit surveying the code base for inefficient patterns using an IDE.
This change was done by hand and split using Rosie to assist with rollbacks in case of bugs. Reviewers, please pay particular attention to:
* Each all to addInputArgument/addOutputArgument should come with a corresponding matching pair to SpawnAction.Builder#addInput and CustomCommandLine.Builder#addExecPath (eg.).
* The commandLine must be set on the SpawnAction using SpawnAction.Builder#setCommandLine.
Note that most calls to addPrefixed("arg=", val) should be more idiomatically expressed as add("arg", val), but this involves changing tests and making sure that the command line tools can accept the format.
PiperOrigin-RevId: 166723076
|
|
|
|
| |
PiperOrigin-RevId: 166722992
|
|
|
|
|
|
|
| |
removal of the C++ toolchain identifier from the output path.
RELNOTES: None.
PiperOrigin-RevId: 166705005
|
|
|
|
|
|
|
|
| |
PlatformConfiguration is made a legal configuration fragment for every rule class.
Add a default "dummy" c++ toolchain to prevent resolution errors when legacy toolchain selection logic is used. Add toolchain mocks to java and shell tests.
PiperOrigin-RevId: 166509298
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will encourage new users to avoid it, and would have helped me. At
the start, I cargo-culted other projects that use bind() heavily without
knowing why.
Related: #1952
Closes #3608.
PiperOrigin-RevId: 166464352
|
|
|
|
|
|
|
| |
if --javabase= is an absolute path and thus there is no java_runtime rule to forward them from.
RELNOTES: None.
PiperOrigin-RevId: 166459625
|