| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
Change-Id: I3248af31f9f6f3669177015c9f19ecd49165b191
PiperOrigin-RevId: 178096631
|
|
|
|
|
|
|
|
|
| |
bundle_loader attribute
Prior to this change, apple_binary relied on bundle_loader targets (which are themselves apple_binary) to propagate an unwrapped ObjcProvider. That is deprecated, is disabled by --noexperimental_objc_provider_from_linked, and will be killed off shortly.
RELNOTES: None.
PiperOrigin-RevId: 177862573
|
|
|
|
|
|
|
|
|
| |
This does not provide any meaningful API to interact with ObjcProtoProvider from a skylark context -- it simply allows ObjcProtoProvider to be passed between skylark API calls as an opaque object.
This helps facilitate exposure of an Apple Linking API to Skylark which will take place in future changes.
RELNOTES: None.
PiperOrigin-RevId: 177844029
|
|
|
|
| |
PiperOrigin-RevId: 177452571
|
|
|
|
|
|
|
|
|
| |
Infer those values from STATIC_FRAMEWORK_FILE.
This correctly dedupes static frameworks between an app and its dylibs.
RELNOTES: None.
PiperOrigin-RevId: 177214770
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 177165649
|
|
|
|
|
| |
RELNOTES:
PiperOrigin-RevId: 176844836
|
|
|
|
|
|
|
|
|
| |
uses of attribute-name string literals from MultiArchBinarySupport
This cleanup is a step in the right direction for exposing the apple linking API to Skylark -- supports must avoid calling ruleContext.getPrerequisites with attribute-name string literals; providers and TransitiveInfoCollections should come as inputs to the API.
RELNOTES: None.
PiperOrigin-RevId: 176525071
|
|
|
|
|
|
|
| |
incorrectly using multi-arch iOS
RELNOTES: None.
PiperOrigin-RevId: 175579695
|
|
|
|
| |
PiperOrigin-RevId: 175531318
|
|
|
|
| |
PiperOrigin-RevId: 175218074
|
|
|
|
|
|
|
| |
This feature is experimental, and thus left mostly undocumented.
RELNOTES: None.
PiperOrigin-RevId: 175187791
|
|
|
|
|
|
|
|
| |
Blaze had its own class to avoid GC from varargs array creation for the precondition happy path. Guava now (mostly) implements these, making it unnecessary to maintain our own.
This change was almost entirely automated by search-and-replace. A few BUILD files needed fixing up since I removed an export of preconditions from lib:util, which was all done by add_deps. There was one incorrect usage of Preconditions that was caught by error prone (which checks Guava's version of Preconditions) that I had to change manually.
PiperOrigin-RevId: 175033526
|
|
|
|
|
|
| |
CcToolchainProvider#getFeatures.
PiperOrigin-RevId: 174492427
|
|
|
|
| |
PiperOrigin-RevId: 174481563
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks alphago targets.
*** Original change description ***
Remove CppConfiguration#getFeatures in favor of
CcToolchainProvider#getFeatures.
PiperOrigin-RevId: 174373331
|
|
|
|
|
|
|
| |
This omits validation for this transition, which will follow in a future change.
RELNOTES: None.
PiperOrigin-RevId: 174183651
|
|
|
|
|
|
| |
CcToolchainProvider#getFeatures.
PiperOrigin-RevId: 173702792
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks ~2k ios targets, see b/68179560
*** Original change description ***
Move hard-coded compilation-mode-specific flags in ObjcConfiguration.
PiperOrigin-RevId: 173239463
|
|
|
|
| |
PiperOrigin-RevId: 172932367
|
|
|
|
|
|
|
| |
(possibly empty) set of SpawnResults created during execution of the Action.
RELNOTES: None.
PiperOrigin-RevId: 172529328
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 172394552
|
|
|
|
|
|
|
|
|
| |
opposed to only through ctx.fragments.apple)
Progress towards #3424.
RELNOTES: None.
PiperOrigin-RevId: 172299240
|
|
|
|
| |
PiperOrigin-RevId: 172199420
|
|
|
|
|
|
| |
direct files into the deps attribute, only proto_library and objc_proto_library targets are allowed.
PiperOrigin-RevId: 172107133
|
|
|
|
|
|
|
| |
Configurable"
RELNOTES: None.
PiperOrigin-RevId: 171751391
|
|
|
|
|
|
|
| |
Previously the java rules returned some providers twice: once as regular providers and once wrapped in JavaInfo (e.g. JavaCompilationArgsProvider). This is unnecessary, inefficient and error prone. JavaInfo should be the only way of returning these providers.
RELNOTES: None.
PiperOrigin-RevId: 171663550
|
|
|
|
|
|
|
| |
Progress towards #3424.
RELNOTES: None.
PiperOrigin-RevId: 171648540
|
|
|
|
|
|
|
| |
Rename it to TemplateExpander and start rewriting the documentation to refer
to template variables.
PiperOrigin-RevId: 171648255
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 171113424
|
|
|
|
| |
PiperOrigin-RevId: 171017483
|
|
|
|
| |
PiperOrigin-RevId: 171013687
|
|
|
|
|
| |
RELNOTES: None.
PiperOrigin-RevId: 170722989
|
|
|
|
|
|
| |
Progress on #2475.
PiperOrigin-RevId: 170473111
|
|
|
|
|
|
|
|
|
| |
Currently CppLinkActionBuilder is not using CppSemantics, but it will when
we use full CppCompileAction for linkstamp compiles. This cl is a preparation
for that.
RELNOTES: None.
PiperOrigin-RevId: 170467826
|
|
|
|
|
|
|
| |
apple_static_library.
RELNOTES: apple_binary and apple_static_library no longer support compilation attributes such as 'srcs'. If this breaks any existing targets, you may migrate all such attributes to a new objc_library target and depend on that objc_library target via the 'deps' attribute of apple_binary or apple_static_library.
PiperOrigin-RevId: 170373794
|
|
|
|
|
|
| |
LIPO. Remove the check that requires a context collector to be present.
PiperOrigin-RevId: 170341259
|
|
|
|
|
|
|
| |
Some of the setters didn't return the builder, this cl fixes that.
RELNOTES: None.
PiperOrigin-RevId: 170313892
|
|
|
|
|
|
|
| |
and apple_static_library no longer propagate ObjcProvider.
RELNOTES: None.
PiperOrigin-RevId: 169690934
|
|
|
|
| |
PiperOrigin-RevId: 169428146
|
|
|
|
|
|
|
| |
This change misses the corner case of builds which are entirely 32-bit (as opposed to mixed 32&64 bit) due to no legitimate place to report the error of such a build; execution will fail for such builds at the action level.
RELNOTES: None.
PiperOrigin-RevId: 169397354
|
|
|
|
|
|
| |
causes the cc_toolchain dependency of cc targets to be selected using the platforms/toolchains constraint solving system.
PiperOrigin-RevId: 169250621
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, there is no way to enforce that LateBoundDefaults only access
the fragments that they declare. This means that LateBoundDefaults can
fail to declare fragments at all, or declare the wrong ones, and still
have no troubles.
But when trimming, these fragments must be declared, because otherwise
they will not necessarily be available.
This change refactors LateBoundDefault to declare a single fragment type,
not a set. All existing LateBoundDefaults use sets with a single element
or no elements at all for their set of fragment classes, so this does not
limit anything being done currently.
To account for LateBoundDefaults which do not use configuration at all,
typically those which only want to access the configured attribute map,
it is possible for Void to be the fragment class which is requested.
To account for LateBoundDefaults which need to access methods of the
BuildConfiguration instance itself, it is possible for BuildConfiguration
to be the fragment class which is requested; however, this is unsafe, so
it is only a temporary state until a way to do this without also giving
access to all of the fragments can be added.
Drive-by refactoring: LateBoundDefaults' values are now typed. All actual
production LateBoundDefaults were Label or List<Label> typed, through the
LateBoundLabel and LateBoundLabelList subclasses. These subclasses have
been removed, and LateBoundDefault has two type parameters, one for the
type of its input, and one for the type of its output.
RELNOTES: None.
PiperOrigin-RevId: 169242278
|
|
|
|
|
|
| |
This is a trivial change with a large file footprint.
PiperOrigin-RevId: 169169864
|
|
|
|
|
|
|
| |
Exempt RuleConfiguredTarget in this change because that's liable to touch
a billion files.
PiperOrigin-RevId: 168929827
|
|
|
|
|
|
| |
the c++ toolchain type through an implicit attribute.
PiperOrigin-RevId: 168864540
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Breaks clang_tidy.
*** Original change description ***
Introduce -c source_file -o output_file build variables
Prior to this cl CompileCommandLine would (almost) unconditionally emit -c and
-o flags. This cl removes this logic and relies on crosstool to emit these
flags. This is another small step towards platform independent C++ rules.
Memory use is not affected, since the build variables used by this cl are already
exposed, this cl just forces crosstools to use it.
RELNOTES: None.
PiperOrigin-RevId: 168834576
|
|
|
|
| |
PiperOrigin-RevId: 168802886
|
|
|
|
|
|
| |
This is necessary for the upcoming Skylark implementation of param files.
PiperOrigin-RevId: 168744486
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prior to this cl CompileCommandLine would (almost) unconditionally emit -c and
-o flags. This cl removes this logic and relies on crosstool to emit these
flags. This is another small step towards platform independent C++ rules.
Memory use is not affected, since the build variables used by this cl are already
exposed, this cl just forces crosstools to use it.
RELNOTES: None.
PiperOrigin-RevId: 168671507
|