| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
| |
configuration
RELNOTES: None.
PiperOrigin-RevId: 157017608
|
|
|
|
| |
PiperOrigin-RevId: 154860105
|
|
|
|
|
|
|
|
|
| |
This functionality is never used, have never been exposed to Skylark
and is a continuous pain to maintain and test.
--
PiperOrigin-RevId: 145079832
MOS_MIGRATED_REVID=145079832
|
|
|
|
|
|
|
|
| |
Also clean up the setting of aspect name in ConfiguredAspect and
AspectDefintion - it is now obtained from the AspectClass.
--
MOS_MIGRATED_REVID=140357052
|
|
|
|
|
|
|
|
|
|
|
|
| |
by class.
TransitiveInfoProviderMap enforces that the provider implements the interface it's keyed by
and provides accessors the reduce the amount of casting. This in general reduces boilerplate throughout wherever TransitiveInfoProviders are mapped by their class.
Also add shorthand for adding a provider where it only implements TransitiveInfoProvider once, reducing the redundant specification of the TransitiveInfoProvider class. Infer the class as the exclusive direct implementor of TransitiveInfoProvider to account for special cases like AutoValue and LicenseProvider.
--
MOS_MIGRATED_REVID=133386336
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=130406840
|
|
|
|
|
|
|
| |
much smaller. This adds more granularity and helps prevent excessive compilation by minimizing the number of inputs for each action.
--
MOS_MIGRATED_REVID=130359288
|
|
|
|
|
|
|
| |
ObjcProtoProvider and ObjcProtoAspect.
--
MOS_MIGRATED_REVID=129997369
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
Prevent [] from burning up
*** Original change description ***
Make the proto bundling behavior the default when using the new library.
--
MOS_MIGRATED_REVID=128226570
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=127747661
|
|
|
|
|
|
|
| |
attribute would fail requesting its deps, and crash. Also checks whether the portable_proto_filters attribute was explicitly specified.
--
MOS_MIGRATED_REVID=123218724
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NativeAspectClass.
This a large refactoring of the aspects, currently we have the following:
- AspectClasses: The interface AspectClass is a implemented by either
SkylarkAspectClass or NativeAspectClass<NativeAspectFactory>.
They are wrappers for the AspectFactories and they hold the information about
the Class<> of the factory.
- AspectFactories (FooAspect.java): Represented by the interfaces
ConfiguredAspectFactory and NativeAspectFactory, also by
the interface ConfiguredNativeAspectFactory which is the union of the two
aforementioned interfaces.
All aspects implement ConfiguredNativeAspectFactory except Skylark aspects
which implement only ConfiguredAspectFactory.
After this CL the distinction between NativeAspectFactories and NativeAspectClasses
dissappear, namely aspect that extends NativeAspectClass is considered native
and if it implements ConfiguredAspectFactory it is configured.
Therefore the interfaces NativeAspectFactory and ConfiguredNativeAspectFactory
both disappear.
With this refactoring the aspectFactoryMap in the ConfiguredRuleClassProvider
changes its type from (String -> Class<? extends NativeAspectClass>)
to (String -> NativeAspectClass) which means it is now able to have an instance
of the aspect instead of its Class only.
By doing this, it is now possible to pass parameters when creating an
aspect in the ConfiguredRuleClassProvider.
--
MOS_MIGRATED_REVID=120819647
|
|
with an ObjcProtoAspect which propagates the proto provider through the dependency chain.
--
MOS_MIGRATED_REVID=120747710
|