| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Skylark into their own package. This allows, e.g., classes in the syntax package to access classes in the cmdline package without creating circular dependencies.
While we're here:
- Removed a couple of unused BUILD deps flagged in [].
- Updated SkylarkRuleImplementationFunctionsTest to remove non-ASCII characters and
clarify the intent of the test.
--
MOS_MIGRATED_REVID=110360763
|
|
|
|
|
|
|
|
|
| |
- If we have a class object available, we can use .cast(Object)
- Only store the required options objects in CppConfigurationParameters
rather than keeping the entire BuildOptions
--
MOS_MIGRATED_REVID=109981236
|
|
|
|
|
|
|
| |
Reduces garbage.
--
MOS_MIGRATED_REVID=109914243
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108985661
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the feature-based flags for links of native code for Android
were coming from the standard TARGET toolchain, which is wrong. This
went unnoticed because Bazel's CROSSTOOL (and mine until recently) don't
add any flags that way in either, which means getting the flags either
way results in none.
--
Change-Id: I74cd18ff56e3aea7ca61fabe62cb2246100ee59a
Reviewed-on: https://bazel-review.googlesource.com/#/c/2322
MOS_MIGRATED_REVID=108234274
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=108182745
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows using compilers downloaded in *_repository rules without
ugly hacks like symlinks to bazel-out/../../external.
I manually tested all of the %prefix%s which this refactors the
implementations of.
--
Change-Id: Ie9931dfbed646b8b5c9cd7fba5e6df5cf0baa1f2
Reviewed-on: https://bazel-review.googlesource.com/#/c/2200
MOS_MIGRATED_REVID=108139097
|
|
|
|
|
|
|
|
|
|
|
|
| |
options. If a rule (such as a filegroup) doesn't
have C++ options in its transitive closure, then
buildOptions.get(CppOptions.class) returns null
and crashes.
So add a check to just fast-return for these cases.
--
MOS_MIGRATED_REVID=108079561
|
|
|
|
|
|
|
| |
is guaranteed not to be a package. Instead, start with its parent. This will be faster and take less memory.
--
MOS_MIGRATED_REVID=107725767
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107719461
|
|
|
|
|
|
|
|
|
| |
in CcLibraryHelper.
Also add a check for null configurations.
--
MOS_MIGRATED_REVID=107709170
|
|
|
|
|
|
|
|
|
| |
Fixes #445, based on https://github.com/bazelbuild/bazel/compare/master...ulfjack:cpp-include-path.
RELNOTES: C++ libraries no longer need includes = ["."] (or similar copts) to include paths relative to a remote repository's root.
--
MOS_MIGRATED_REVID=107593486
|
|
|
|
|
|
|
| |
This makes all tool dependencies be under @bazel_tools again (and not //tools)
--
MOS_MIGRATED_REVID=107482585
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL permits a cc_binary to have a set of dependencies that are all
gathered together when the cc_binary is linked, producing a set of
LibraryToLink objects to link into the cc_binary. Each such
dependency will an instance of a class that extends BuildLibraryToLink
to a CcLinkParams. All instances of the same class will be gathered
together. At link time the BuildLibraryToLink method buildLibraries
will be called to build the LibraryToLink objects.
--
MOS_MIGRATED_REVID=107242331
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=107048547
|
|
|
|
|
|
|
| |
Fixes #538.
--
MOS_MIGRATED_REVID=106674650
|
|
|
|
|
|
|
| |
RELNOTES: Bazel does strict validation of include files now to ensure correct incremental builds. If you see compilation errors when building C++ code, please make sure that you explicitly declare all header files in the srcs or hdrs attribute of your cc_* targets and that your cc_* targets have correct "deps" on cc_library's that they use.
--
MOS_MIGRATED_REVID=106410969
|
|
|
|
|
|
|
|
|
| |
LocalGccStrategy / LocalLinkStrategy with SpawnGccStrategy / SpawnLinkStrategy.
RELNOTES: C++ compile actions run in a sandbox now on systems that support sandboxed execution.
--
MOS_MIGRATED_REVID=106299043
|
|
|
|
|
|
|
| |
validating includes and updating action inputs is clearly separated and easier to understand now.
--
MOS_MIGRATED_REVID=106298050
|
|
|
|
|
|
|
| |
This makes it possible to call these methods with lists from Skylark, which are internally Iterable<>'s but not Collection<>'s.
--
MOS_MIGRATED_REVID=106003065
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of two metasyntactic variables and one random bit of magic which
changes relative paths to be children of crosstool, we now have three
consistent pieces of metasyntax; except that since we can't actually
remove the old syntax, we have either way for the time being.
RELNOTES[NEW]: accept %crosstool_top% in cxx_builtin_include_directory
--
MOS_MIGRATED_REVID=105854779
|
|
|
|
|
|
|
|
|
|
| |
cxx_builtin_include directories which start with "%workspace%/" are taken
to be relative to the build workspace, and not relative to crosstool-top.
RELNOTES[NEW]: cpxx_builtin_include_directory specifications allow more flexibility.
--
MOS_MIGRATED_REVID=105789270
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105624527
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before:
ERROR: No toolchain found for cpu 'x84'.
After:
ERROR: No toolchain found for cpu 'x84'. Valid cpus are: [
armeabi,
armeabi-v7a,
armeabi-v7a-hard,
armeabi-thumb,
armeabi-v7a-thumb,
armeabi-v7a-hard-thumb,
arm64-v8a,
mips,
mips64,
x86,
x86_64,
].
--
MOS_MIGRATED_REVID=105324190
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
legible by putting each flag combination on its own line.
E.g. from this:
ERROR: No toolchain found for --cpu='foo' --compiler='bar' --glibc='baz'. Valid toolchains are: [ --cpu='armeabi-v7a' --compiler='compiler' --glibc='armeabi-v7a', --cpu='armeabi-v7a' --compiler='compiler' --glibc='armeabi-v7a', --cpu='local' --compiler='compiler' --glibc='local', --cpu='darwin' --compiler='compiler' --glibc='macosx', --cpu='freebsd' --compiler='compiler' --glibc='local', --cpu='k8' --compiler='windows_mingw' --glibc='local', --cpu='k8' --compiler='windows_msys64_mingw64' --glibc='local', --cpu='k8' --compiler='windows_clang' --glibc='local',].
to this:
ERROR: No toolchain found for --cpu='foo' --compiler='bar' --glibc='baz'. Valid toolchains are: [
--cpu='armeabi-v7a' --compiler='compiler' --glibc='armeabi-v7a',
--cpu='armeabi-v7a' --compiler='compiler' --glibc='armeabi-v7a',
--cpu='local' --compiler='compiler' --glibc='local',
--cpu='darwin' --compiler='compiler' --glibc='macosx',
--cpu='freebsd' --compiler='compiler' --glibc='local',
--cpu='k8' --compiler='windows_mingw' --glibc='local',
--cpu='k8' --compiler='windows_msys64_mingw64' --glibc='local',
--cpu='k8' --compiler='windows_clang' --glibc='local',
].
(notice there is a duplicate toolchain)
--
MOS_MIGRATED_REVID=105313547
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=105204997
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=104862806
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=104845397
|
|
|
|
|
|
|
|
|
|
| |
step.
This should make ThinLTO work with .o files that are not generated by
compiling C++ in a cc_library()
--
MOS_MIGRATED_REVID=104764111
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, module maps contain both "use <module>" entries that specify which
modules the current module map depends on, and "extern module" entries that
provide paths where to load the dependent module maps from.
This change adds a feature "module_map_without_extern_module", which instructs
blaze to not write the "extern module" entries into the module map. Instead,
the crosstool needs to add -fmodule-file flags for each dependent module file
where needed for the compile via the new build variable
"dependent_module_map_files".
Note that the feature is phrased negatively ("_without_") in order to simplify
the roll-out of this feature: as long as crosstools do not specify any
features, they still want the old behavior.
We cannot make the feature positive and add it to the legacy configuration, as
we currently cannot remove features that have already been set in the crosstool
file.
--
MOS_MIGRATED_REVID=104757413
|
|
|
|
|
|
|
|
|
|
|
| |
tools repository.
This is a no-op refactoring CL. The actual switch will be made once everything passes with the new setup.
As a side cleanup, change the awkward realAndroidSdk() / realAndroidCrosstoolTop() mechanism to a converter.
--
MOS_MIGRATED_REVID=104649067
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=104529103
|
|
|
|
|
|
|
| |
RELNOTES[NEW]: labels in "linkopts" may match any label in either "deps" or "srcs" to be considered valid.
--
MOS_MIGRATED_REVID=103945104
|
|
|
|
|
|
|
|
| |
The scanner only looks for C preprocessor directives, but most assemblers allow '.include' assembly directives, and those aren't found by the scanner.
So skip the include scanner for assembly files that don't want C preprocessing, because correctly declared inclusions are to be preferred anyway.
--
MOS_MIGRATED_REVID=103944189
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103942611
|
|
|
|
|
|
|
|
|
|
|
| |
The headers were modified with
`find . -type f -exec 'sed' '-Ei' 's|Copyright 201([45]) Google|Copyright 201\1 The Bazel Authors|' '{}' ';'`
And manual edit for not Google owned copyright. Because of the nature of ijar, I did not modified the header of file owned by Alan Donovan.
The list of authors were extracted from the git log. It is missing older Google contributors that can be added on-demand.
--
MOS_MIGRATED_REVID=103938715
|
|
|
|
|
|
|
|
|
|
| |
- Label parsing can be simplified
- lib.syntax is only contains the code for Skylark and is reasonably independent from the problem domain of building things
This change is mostly only changes to imports declarations. The rest is reversing the dependency between :cmdline and :syntax and moving a tiny amount of code between Printer and FilesetEntry and the addition of SkylarkPrintableValue that I couldn't be bothered to separate out into its own change.
--
MOS_MIGRATED_REVID=103527877
|
|
|
|
|
|
|
| |
Without this, the FDO features enabled under --fdo* blaze options are not removed when BUILD files contain "features = ['-fdo_instrument', '-fdo_optimize']".
--
MOS_MIGRATED_REVID=103431508
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103384782
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=103374106
|
|
|
|
|
|
|
|
|
|
|
| |
Adding the accepted file extensions was a minor issue.
The bulk of this change was to weaken the assertion
that all cxx compiler actions produce a '.d' file.
RELNOTES[NEW]: a cc_binary rule may list '.s' and '.asm' files in the srcs
--
MOS_MIGRATED_REVID=103196242
|
|
|
|
|
|
|
|
|
| |
syntax that means "refer to the main repository".
There isn't an overarching plan for what we are going to do with the cmdline package, which seems to be separated from the .syntax one in all sorts of awkward ways.
--
MOS_MIGRATED_REVID=103088960
|
|
|
|
|
|
|
| |
BaseFunction.
--
MOS_MIGRATED_REVID=102988766
|
|
|
|
|
|
|
| |
*** Reason for rollback ***
--
MOS_MIGRATED_REVID=102590114
|
|
|
|
|
|
|
|
|
|
|
| |
Adding the accepted file extensions was a minor issue.
The bulk of this change was to weaken the assertion
that all cxx compiler actions produce a '.d' file.
RELNOTES[NEW]: a cc_binary rule may list '.s' and '.asm' files in the srcs
--
MOS_MIGRATED_REVID=102346882
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=102332437
|
|
|
|
|
| |
--
MOS_MIGRATED_REVID=102239051
|
|
|
|
|
|
|
| |
Fixes some of #407.
--
MOS_MIGRATED_REVID=102148776
|
|
|
|
|
|
|
|
|
|
| |
The baseline artifacts are part of the instrumented files provider now, and
are strongly tied to the collect_code_coverage flag. It seems to be simpler
to collect them explicitly in the BuildView (which already collects them for
post-processing), than to rely on the output group selection.
--
MOS_MIGRATED_REVID=101926341
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're currently doing too much work for baseline coverage - every rule creates
an action for its entire transitive closure; these actions are added to the
output group for baseline coverage, but not transitively accumulated.
It would be better for every rule to create an action for local baseline
coverage, and to aggregate the baseline coverage artifacts down the dependency
tree.
By merging the code paths, the InstrumentedFilesCollector can perform the
aggregation, because it can distinguish local and transitive files; I'm
planning to implement that in a subsequent change.
--
MOS_MIGRATED_REVID=101914334
|