| Commit message (Collapse) | Author | Age |
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 192681579
|
|
|
|
|
|
|
|
|
| |
The was that the presence of invalid dependency edges would incorrectly cause 'allrdeps' to not visit targets. Concrete example: if --nohost_deps was set and T1 depended on T via a host edge and T2 depended on T via a non-host edge then 'allrdeps(T)' might incorrectly not contain T2.
Along with fixing the bug, refactor ParallelVisitor's deduping logic: instead of deduping visitations inside #getVisitResult, dedupe them before adding them to #processingQueue. This should be a strict, small, performance win, especially for trivial visitations (e.g. RBuildFilesVisitor).
RELNOTES: None
PiperOrigin-RevId: 192327607
|
|
|
|
|
|
|
|
|
| |
ParallelSkyQueryUtils.RBuildFilesVisitor. Also a minor tweak of the batch size for feeding results to the callback.
Also correctly use the packageSemaphore in SkyQueryEnvironment's non-parallel implementation of rbuildfiles.
RELNOTES: None
PiperOrigin-RevId: 174039067
|
|
|
|
|
| |
RELNOTES: None
PiperOrigin-RevId: 167335614
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
query errors
When a Query evaluation is interrupted, we expect ParallelVisitor worker
threads to be interrupted. The RuntimeInterruptedException thrown by
ParallelVisitor.Task#run does not represent an error.
Likewise, QueryExceptions do not represent bugs and shouldn't be logged
by ParallelVisitor either.
RELNOTES: None.
PiperOrigin-RevId: 163219663
|
|
|
|
|
|
|
| |
With a few manual fixes for readability.
RELNOTES: None.
PiperOrigin-RevId: 160582556
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interrupted eagerly
The original code swallows the InterruptedException, sets the interrupt bit and
stops new tasks from being submitted. However it does not actively send an
interrupt signal to all running and pending tasks already in the pool. It is
partly due to the misleading syntax of awaitTermination, which actually quitely
waits for all tasks to exit even if interruptWorkers is set to true. Both
errors are fixed in this change.
RELNOTES: None
PiperOrigin-RevId: 157762029
|
|
computing TransitiveTraversalValues.
RELNOTES: None
PiperOrigin-RevId: 156138657
|