| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
|
|
|
|
| |
Add static methods to return target kinds of InputFile and OutFile, as well as
suffix of target kind of Rule.
RELNOTES: None
PiperOrigin-RevId: 154866926
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
targets.
These two functions don't use a Uniquifier internally so if the same bzl file foo.bzl is loaded multiple ways in 'e' in 'loadfiles(e)' then 'f' in 'f(loadfiles(e))' will observe foo.bzl multiple times.
This isn't observable in practice (i.e. I cannot write a black-box query test that would fail without this CL) because:
(1) BlazeQueryEnvironment#eval(QueryExpression, VariableContext<Target>, Callback<Target>) uses an intermediate aggregating callback and thus doesn't use the streaming query evaluation model. This means that the internal deduping in BlazeQueryEnvironment#getBuildFiles is sufficient.
(2) SkyQueryEnvironment uses an outer BatchStreamedCallback which internally uses a Uniquifier.
Still, this CL is useful for SkyQuery because without we're doing wasted work (e.g. in my example above, 'f' will wastefully do duplicate work with the .bzl files from the inner loadfiles(e)) because the deduping happens on the final query result, not on the intermediate result from 'buildfiles'/'loadfiles'.
For 'buildfiles', there's an additional wart with (1) above because FakeSubincludeTarget doesn't override Object#equals/hashCode.
--
PiperOrigin-RevId: 147656183
MOS_MIGRATED_REVID=147656183
|
| |
|
|
|
|
|
| |
Reduces garbage.
--
MOS_MIGRATED_REVID=109914243
|
| |
|
|
|
|
|
|
|
|
| |
(following PackageGroup's precedent).
Also cleanup: generalize the pattern by which we determine
non-configurable target types.
--
MOS_MIGRATED_REVID=104125803
|
| |
|
|
|
|
|
|
|
|
|
| |
The headers were modified with
`find . -type f -exec 'sed' '-Ei' 's|Copyright 201([45]) Google|Copyright 201\1 The Bazel Authors|' '{}' ';'`
And manual edit for not Google owned copyright. Because of the nature of ijar, I did not modified the header of file owned by Alan Donovan.
The list of authors were extracted from the git log. It is missing older Google contributors that can be added on-demand.
--
MOS_MIGRATED_REVID=103938715
|
| |
|
|
|
|
|
|
|
|
| |
- Label parsing can be simplified
- lib.syntax is only contains the code for Skylark and is reasonably independent from the problem domain of building things
This change is mostly only changes to imports declarations. The rest is reversing the dependency between :cmdline and :syntax and moving a tiny amount of code between Printer and FilesetEntry and the addition of SkylarkPrintableValue that I couldn't be bothered to separate out into its own change.
--
MOS_MIGRATED_REVID=103527877
|
| |
|
|
|
|
|
|
|
|
|
|
| |
While evaluating the transitive closure of the universe, if the
universe contains the buildfiles of a package with a subinclude, the
RdepsFunction would ask a FakeSubincludeTarget for its package.
Prior to this change, this would result in a crash. Now,
FakeSubincludeTargets remember the package they belong to.
--
MOS_MIGRATED_REVID=95212925
|
|
|
--
MOE_MIGRATED_REVID=85702957
|
Googler
Nathan Harmata
Mark Schaller
Greg Estren
Damien Martin-Guillerez
Lukacs Berki
Han-Wen Nienhuys