aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/main/java/com/google/devtools/build/lib/packages/RawAttributeMapper.java
Commit message (Collapse)AuthorAge
* Stop "no generating action" exceptions for configurableGravatar Greg Estren2015-06-19
| | | | | | | | | | | | | | | | | | | cc_library "srcs". The underlying problem is that Bazel determines whether or not to generate a .so by the contents of "srcs", but this happens in the loading phase before configurations are known. So, when "srcs" is configurable, it conservatively assumes a .so needs to be generated. In cc_library analysis, when the final values for "srcs" is properly bound, the .so may not actually be needed after all. This cl fixes the discrepancy by registering a FailAction for the .so under those circumstances - we don't actually need the .so anywhere but we still have to ensure it's registered with an owning action. -- MOS_MIGRATED_REVID=96405079
* Minimize calls to AggregatingAttributeMapper.visitAttribute. Attributes withGravatar Greg Estren2015-04-15
| | | | | | | | | multiple selects run the risk of exponential value growth, so we shouldn't request a full iteration of possible values unless that's really what the caller needs. -- MOS_MIGRATED_REVID=91118257
* Configurable attributes: support embeddable selects. With thisGravatar Greg Estren2015-04-14
| | | | | | | | | | | | | | | | change, the following syntax: deps = [':always'] + select({':a': [':adep'], ':b': [':bdep']}) or deps = select({':a': [':adep'], ':b': [':bdep']}) + select({':c': [':cdep'], ':d': [':ddep']}) works. -- MOS_MIGRATED_REVID=91016337
* PackageSerializer: include attributes with null values.Gravatar Greg Estren2015-03-26
| | | | | | | | | | | | PackageDeserializer: handle null-value attributes (single-value attributes with no value setting) without crashing. Without this change, attributes with computed defaults can crash on serialization because RawAttributeMapper.isNotNull isn't smart enough to check *indirect* configurable attributes that the computed attribute depends on. -- MOS_MIGRATED_REVID=89599145
* Merge PackageSerializer's and ProtoOutputFormatter's duplicatedGravatar Greg Estren2015-03-25
| | | | | | | | | | | | | | | | serialization logic. Among other things, this fixes an out-of-sync bug where ProtoOutputFormatter's version knew how to handle configurable attributes while PackageSerializer's version crashed. The merged logic preserves ProtoOutputFormatter's semantics: configurable attributes work, but their values are merged together into a flattened list, so the original select structure can't be reproduced later. -- MOS_MIGRATED_REVID=89435116
* Removed a <?> generic in a instanceof.Gravatar Damien Martin-Guillerez2015-03-24
| | | | | | | | | This syntax is broken under Eclipse. For some reason this syntax is valid from BuildJar but it is not compatible with Eclipse Java 8. -- MOS_MIGRATED_REVID=89397040
* Description redacted.Gravatar Greg Estren2015-03-23
| | | | | -- MOS_MIGRATED_REVID=89134834
* Update from Google.Gravatar Han-Wen Nienhuys2015-02-25
-- MOE_MIGRATED_REVID=85702957