| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
|
|
|
| |
This is part of splitting up the build-base library into separate libraries for
analysis, exec, and rules.
PiperOrigin-RevId: 164835678
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to also registers extra-actions.
ExtraActionArtifactsProvider was using a set of ExtraArtifactSet, whose key was derived from the label of the owner of the extra-action.
Since actions registered by Aspects have the same label as those registered by the base rule, the former ones would disappear from the set.
An alternative to this CL would be to use an ArtifactOwner instead of a label as the key of the ExtraArtifactSet, but
1. BuildView only has access to ConfiguredTarget's, which lack the information to manipulate ArtifactOwner's; and
2. I don't see what ExtraArtifactSet gains us. In particular, ExtraArtifactSet.getLabel() is not used by anything outside of ExtraArtifactSet.
The only disadvantage of this CL is that filtering (--experimental_extra_action_filter) can be slower if targets register a massive number of actions.
Before this CL, we would match a single label per rule, while after this CL we match a single label per action.
--
MOS_MIGRATED_REVID=139591862
|
| |
|
|
|
|
|
| |
Except in action execution logic (ActionExecutionFunction, SkyframeActionExecutor, etc.), switch Action interface references to either ActionAnalysisMetadata if possible or ActionExecutionMetadata.
--
MOS_MIGRATED_REVID=120723431
|
| |
|
|
|
| |
--
MOS_MIGRATED_REVID=119203499
|
| |
|
|
|
| |
--
MOS_MIGRATED_REVID=112709717
|
| |
|
|
|
| |
--
MOS_MIGRATED_REVID=108592613
|
| |
|
|
|
|
|
| |
NestedSet, to reduce waste when copying aggregating it.
--
MOS_MIGRATED_REVID=107988653
|
| |
|
|
|
|
|
| |
is required by rules but not aspects.
--
MOS_MIGRATED_REVID=107689641
|
|
|
class, in preparation for calling it from Aspects.
--
MOS_MIGRATED_REVID=107587682
|
ulfjack
Carmi Grushko
Rumou Duan
Janak Ramakrishnan