| Commit message (Collapse) | Author | Age |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
features.
Features on the rule level modify features that are enabled at the package
level. Note that this behavior is different from how the current command line /
package level interaction is, but we probably want to change the command line
behavior.
Alternative implementations considered:
a) using package-level features as default value for the rule attribute; this
would make it hard for future transitions; adding a completely new feature
to a package should not require updating all rules that have overrides
b) putting all positive features and all negative features from command-line,
package, and rule attribute into a positive and negative set, and subtract
the negative from the positive set; this is how the command-line features
worked previously, but it makes it impossible to enable a features that
is disabled at the package level just for one rule.
RELNOTES: Add 'features' attribute on the rule level.
--
MOS_MIGRATED_REVID=92448449
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reflection, and saves ~15% of initialization time in []RuleClassProvider.create().
Before change:
Over 14 samples,
average = 976
median = 969.9
After change:
Over 14 samples,
average = 811.5
median = 813.9
--
MOS_MIGRATED_REVID=89036261
|
| |
|
|
|
|
|
|
| |
Anyone who needs this kind of functionality in the future can redefine
it through user-defined constraints.
--
MOS_MIGRATED_REVID=88871811
|
|
|
--
MOE_MIGRATED_REVID=85702957
|
Manuel Klimek
Googler
Greg Estren
Han-Wen Nienhuys